From: ying chen <yc1082463@gmail.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm/vmscan: when the swappiness is set to 0, memory swapping should be prohibited during the global reclaim process
Date: Thu, 27 Feb 2025 22:34:51 +0800 [thread overview]
Message-ID: <CAN2Y7hxDdATNfb=R5J1as3pqA1RsP8c8LubC4QxojK5cJS9Q9w@mail.gmail.com> (raw)
When we use zram as swap disks, global reclaim may cause the memory in some
cgroups with memory.swappiness set to 0 to be swapped into zram. This memory
won't be swapped back immediately after the free memory increases. Instead,
it will continue to occupy the zram space, which may result in no available
zram space for the cgroups with swapping enabled. Therefore, I think that
when the vm.swappiness is set to 0, global reclaim should also refrain
from memory swapping, just like these cgroups.
Signed-off-by: yc1082463 <yc1082463@gmail.com>
---
mm/vmscan.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c767d71c43d7..bdbb0fc03412 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2426,14 +2426,7 @@ static void get_scan_count(struct lruvec
*lruvec, struct scan_control *sc,
goto out;
}
- /*
- * Global reclaim will swap to prevent OOM even with no
- * swappiness, but memcg users want to use this knob to
- * disable swapping for individual groups completely when
- * using the memory controller's swap limit feature would be
- * too expensive.
- */
- if (cgroup_reclaim(sc) && !swappiness) {
+ if (!swappiness) {
scan_balance = SCAN_FILE;
goto out;
}
--
2.34.1
next reply other threads:[~2025-02-27 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:34 ying chen [this message]
2025-02-27 15:54 ` Joshua Hahn
2025-02-27 16:19 ` Johannes Weiner
2025-02-28 3:18 ` ying chen
2025-02-28 3:21 ` Yafang Shao
2025-02-28 3:16 ` ying chen
2025-02-27 19:12 ` Shakeel Butt
2025-02-28 2:48 ` ying chen
2025-03-03 12:07 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2025-02-27 7:51 ying chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN2Y7hxDdATNfb=R5J1as3pqA1RsP8c8LubC4QxojK5cJS9Q9w@mail.gmail.com' \
--to=yc1082463@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox