From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD1ED3ABC2 for ; Mon, 11 Nov 2024 15:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 495976B0089; Mon, 11 Nov 2024 10:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 445A76B008A; Mon, 11 Nov 2024 10:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30D936B008C; Mon, 11 Nov 2024 10:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 112AA6B0089 for ; Mon, 11 Nov 2024 10:58:48 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B63E4A19B5 for ; Mon, 11 Nov 2024 15:58:47 +0000 (UTC) X-FDA: 82774271916.29.1D64FFB Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf10.hostedemail.com (Postfix) with ESMTP id BE5F6C000F for ; Mon, 11 Nov 2024 15:58:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="c1qC0mC/"; spf=pass (imf10.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731340638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dl9j2ZhDxQQ2YzSVFeZKFe/F9Df3fYpRcMcBflMuxFU=; b=kgce4EFh+CSw9V0uFJyjxfEjQBQRHXf6iZhMa8LcihWXQy0SD9VvplkjXB3DMfXbAVoE0i 2IWyr5XuKZaNsqTymxkvx1VeMywp0KJ9vqO0LSOdFIUjLVhqLevSoY17ym6v8SXhMauwt5 sM6xH76MRdtC5hLRCzdE6bCc0D3OLBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731340638; a=rsa-sha256; cv=none; b=iqV+1Bu/jXkZPHBOWCBaRTvsbE8FiKtbC1FRa3aTugbNxR0c0lfFbnE7kXWZff2z7OV4fe uKjQ0nY5dBKEoeUku7V+V0mnZ+dTxzevDeTtUt1KRn3QmjUktuSAXgpJsqHM2UU3o9lU88 R7ltHHRl6nii5rzwLyLDJhbhO17m06o= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="c1qC0mC/"; spf=pass (imf10.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a99f1fd20c4so718261466b.0 for ; Mon, 11 Nov 2024 07:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731340724; x=1731945524; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dl9j2ZhDxQQ2YzSVFeZKFe/F9Df3fYpRcMcBflMuxFU=; b=c1qC0mC/XCiAEBlMAIB84+2iziVBGsvx+KHjXUmXDZlsXyItJHiA1XhEXNGiWG4ibl VAarwv0Mp/ShTtM9QC0I3qAlF4fD7Zc6p84+Wwi6Io6VsHdSaIsPLArDDpd1bEuYX1p2 bnT3qHzt4Zkvw020LLmhv0x3GcIu1GgjkJQlEoU6rVGf/I+CbowrkbTUeauqTQhrQZpd GVe1aJNWNLqSeHAY7yMZbWGl4o3ON+bvXXZaOoP0f+ZvPEBR2Gc+X0WPS2Z693abmKcO Z9Q4jYciwiMh8Ytc85GoHWH9uxbK+tbXFTGIY2ojKAApeA3wVivAfLtOYYzEbgelHq5f UeHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731340724; x=1731945524; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dl9j2ZhDxQQ2YzSVFeZKFe/F9Df3fYpRcMcBflMuxFU=; b=K3L/DjIvdw9xwXF5V8zjeqmFZfkLDF1Yj+mV+3Baurs6vgAy1wLCJWPOZJt3DCSfQv rBcG141agiROBDprHLBbNiN8EAIRvz/LZZcYTmxnaipXNDY6TT/NdX5sqw5KzdiSl+yz h2zUOJeLYSREqYWcZT7qA1P7jkhJMb6+cICxAOPIdm96ZTBpKkHXg/RPc1sNWNukVGeH 5GoBqkW0mAf9zPU8Mjt2uixL2zhuYSNPyWApxmUCbUcautWsizUuFftbSVIdR6sydmVI QJh7Xqsk40rf4jI2d0+81UnyQbBGzEN5MOSxm30TrMADlMlT+F0ZfiyUkFio03BGr7vs ACMQ== X-Forwarded-Encrypted: i=1; AJvYcCXOsvVdioSjZ28NuTjRHS4Y9/f+iOwv7Zh2Wv4Bkp+e5+as2hFSZAzi70eNovx3EfgmJnW7OYc4mw==@kvack.org X-Gm-Message-State: AOJu0Yx8DytSPViO4ih0goGUHkUBShZUzD5qi8wd/58tKsAuTtgTapl/ FfaRps/54xt2FW2nzS+GK12FldOURC5VE6YKiRjnw+WJ5PHhMPRUgsHlY4zhKYtu64MbbnuFf03 qUiePoCG/GGozTko74+TQ10Mwy6I= X-Google-Smtp-Source: AGHT+IFVWWt4lX8khmDtVZ2kVgUASNxC6iDiSfAVTyuaUSBaXtk0CtGDqWPITCIxLKL9+nMWHqxJWPrBH1EgnkwxP4s= X-Received: by 2002:a17:907:84a:b0:a99:f887:ec1d with SMTP id a640c23a62f3a-a9ef001b40emr1312010466b.49.1731340723945; Mon, 11 Nov 2024 07:58:43 -0800 (PST) MIME-Version: 1.0 References: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> <72688d81-24db-70ba-e260-bd5c74066d27@google.com> In-Reply-To: <72688d81-24db-70ba-e260-bd5c74066d27@google.com> From: Joshua Hahn Date: Mon, 11 Nov 2024 10:58:32 -0500 Message-ID: Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg To: David Rientjes Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, chris@chrisdown.name, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Stat-Signature: nfdwhgt81sdyowr6itc8diyh96wnzza7 X-Rspamd-Queue-Id: BE5F6C000F X-Rspam-User: X-HE-Tag: 1731340707-197810 X-HE-Meta: U2FsdGVkX18TvdyDC69RoNBH0SKDTj33zsMq7DtjJHAHY5yYsw/6RcmDiIjF/YZmp4vbEhesHFEqtPOQzJj4nQjwxFK2/iCMfI8IhQwcBXoKJ3qyZVbKgmBFuPJoAY8uzSN/ZjAEEk6GoicDgNolF/N2wAes1re3l9iL8eBMzD6WXBCWpMlIUjm3za/2alBJdfM+os98UGO4Dg83pkg1673ppD6W+/Dd6S6/COSETQ2lefXfQN7t4QTXCzDoAU1IhbV2te25zVhtbGQG3VAc6kFPij6aHCKmAmx4c3plj/bWgtO/JoLFWX62sI8aE9bBKY6zIl2HxikofYv4XFIlTftj5jpt8checWnobXHnygqOxjsCJZjH0FOUJ8Ln1yqNMZWdrUbrAc3EnNN+wBcuy/6COTj1P1uiAgwu6Yl+qExkdhASkS5YfWWU0fBzcV6hLwyS4cAZ+V/jBk2AiYalIuXr5BsFtdDzrpsF3U+EChV03zZDJy7+2ASej0Y55QY6Sy6yyTQiv3SZozxa0JSLydTxbvEDg/AErapsM/YNQ13waoby/+TsRTYWlnyfkodG1xKew1kpMFBwcCOOgFnsANHT4krQcqj4SIkJylMJXrUooumGKrCx1wcg+BcUT0cWbSWD+oZbR/YgYHEo5Q5xD8o8Wng3USE41fmnvF7KC+b0EeL5FCS6EUJ9sonlwin382OtGYjdtYN6A8RhMZF4qYVlhu48mZUigfhzYNE5elNwI9vfVtB/uQiLsg+Ilxg/CTepArk3akZyU/wFRdQTVmKrW6naoJ8HjonDGfvBTF8PNxgKhXdm3XnCQCvefExNRXbVTZuG3HtPUl6QUHTTA9+GZIg5Cl0q4kLcZRkYc3HPi32k8xmiGK6/+8pE6HxmHtDrGW7XQJ1ixNuKIt+QFA7a5sNy0QDf+u/uitCcDp0j/8wRLyua1Jv7BxU/kHFBIB5R0FqQ192jnU0rziG 4rxeY/iK V6Bp8LYydfBjU/nEfC3YBQtdNpEB/GYItEAXXr+vMdNg1w/0tBAF5MxVC4bAjqhvKhN6F1af5EtsR2O3MNGMTD+aU+qlg3yQrW8zKPNhBERi34d2rDgePqHKc6qo2ajMRoNgw5Qf7uEzKigoV7m8sr6VDjh6rMki7T151xy4w3WYESibbROgwEfilPk9W0aUcWszQraPoeOCZdz9+zDIAv80pkYmv12q0ohYnFxEjgpY0WZIvbDp9mRayp4cjve/JHegrZE5w7R27j0YV/AWn8Bqzjq5tVgijgb7kc0AYhb5m5vkPZCEzd21gdSOXjJaMdqPsx4DG8eocj7pZCXIvkCRfI/s0+akoFnOrMM3DpcN8zGwoAVD028dRXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 9, 2024 at 9:19=E2=80=AFPM David Rientjes = wrote: > > On Fri, 1 Nov 2024, Joshua Hahn wrote: > > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/ad= min-guide/cgroup-v2.rst > > index 69af2173555f..bd7e81c2aa2b 100644 > > --- a/Documentation/admin-guide/cgroup-v2.rst > > +++ b/Documentation/admin-guide/cgroup-v2.rst > > @@ -1646,6 +1646,11 @@ The following nested keys are defined. > > pgdemote_khugepaged > > Number of pages demoted by khugepaged. > > > > + hugetlb > > + Amount of memory used by hugetlb pages. This metric only = shows > > + up if hugetlb usage is accounted for in memory.current (i= .e. > > + cgroup is mounted with the memory_hugetlb_accounting opti= on). > > + > > memory.numa_stat > > A read-only nested-keyed file which exists on non-root cgroups. > > > > Definitely makes sense to include this. > > Any reason to not account different hugetlb page sizes separately in this > stat, however? IOW, should there be separate hugetlb_2048kB and > hugetlb_1048576kB stats on x86? Hello David, Thank you for reviewing my patch! The reason that I opted not to include a breakdown of each hugetlb size in memory.stat is only because I wanted to keep the addition that this patch makes as minimal as possible, while still addressing the goal of bridging the gap between memory.stat and memory.current. Users who are curious about this breakdown can see how much memory is used by each hugetlb size by enabling the hugetlb controller as well. It's true that this is the case as well for total hugeltb usage, but I felt that not including hugetlb memory usage in memory.stat when it is accounted by memory.current would cause confusion for the users not being able to see that memory.current =3D sum of memory.stat. On the other hand, seeing the breakdown of how much each hugetlb size felt more like an optimization, and not a solution that bridges a confusion. I have not had a scenario where I had to look at the breakdown of the hugetlb sizes (without the hugetlb controller), or a scenario where not knowing this causes some sort of confusion. If others have had this problem, I would love to hear about it, and perhaps work on a solution that can address this point as well! I hope you have a great day! Joshua