From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77257D5E36B for ; Sat, 9 Nov 2024 18:41:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C51B6B0089; Sat, 9 Nov 2024 13:41:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0765C6B008A; Sat, 9 Nov 2024 13:41:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7EB26B008C; Sat, 9 Nov 2024 13:41:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CBAE16B0089 for ; Sat, 9 Nov 2024 13:41:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5A6861C6EED for ; Sat, 9 Nov 2024 18:41:46 +0000 (UTC) X-FDA: 82767422724.17.8EB02D1 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 5014480004 for ; Sat, 9 Nov 2024 18:40:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PNiTg6eF; spf=pass (imf30.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731177652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KNlXSM/mRvwEpqZlLvbPIkMJUyRK/yTk4ej4kNdJ7Cc=; b=agPsnxQF0MSqMHLGaqASyLzlhoQNXFAVRxpJ7YknW1Nncb7AlbTAarXKZanYyUOOZmhx0Y cCjsjZhU0uOGQarvKaneTieNH04v5npnSEU4wu+gmScgYGDJgsvj6jLlHAsIOLvPycMwH6 VxElRn5uaJniiEU4K7zQfTYkTfGSPFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731177652; a=rsa-sha256; cv=none; b=rcN50A79x+93vX2Xu07mvncwDQF2LbiFVSRrXKIKwDmArKJK9fiaPNVSaMnHe9gBb4RAlJ /hcw91eXnhx4TlvoYyrVipm0/ccKOWdkIQuPauAKDxwQvAjYZ2nWAXs8CWCr6aTquyRjft 8Kdbvu612Qbcz1P0FDQJLPfCgS3nJvA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PNiTg6eF; spf=pass (imf30.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5cefa22e9d5so3607671a12.3 for ; Sat, 09 Nov 2024 10:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731177703; x=1731782503; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KNlXSM/mRvwEpqZlLvbPIkMJUyRK/yTk4ej4kNdJ7Cc=; b=PNiTg6eFf+P7339Rn9rqrUEyAztE5UnyNlmdxVpAilPlYlKp8f6zFz3bGMn14Oc5PL 9PIc80RrCD6Ufl1DOGyC0J8c3m8wRJ6vhwd208KF/GM7sSwVRGLYqV8wjbEVZnBBDd0r qAu6OEqGZNobNVTDEp43CBMKeF6J8Bavzmj602MED8q3uw8JgBnxpZXKjU9rTvYMFCHa FzgPS4o4vqCRvEORNQCIG8YkRHWCyhHOSFo/Pn6HuP/hOMXBgu1W7LYEW4gfTYn2yhmY PqNcO5fM0TRLywLlFj6NfFO3HJuiXlEzXZ0Twcdwf5mq6SLP8K+a1pIM6z91B0AdOP+S RhPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731177703; x=1731782503; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KNlXSM/mRvwEpqZlLvbPIkMJUyRK/yTk4ej4kNdJ7Cc=; b=DJkNvrZnL28vxM/uT1qjWR0E5G9YdT0WZ6py7vLTcV9mj1ylxQT5K1deu5/bo00uEr IVeHL4efE6Pvfrhl9BI43kElhxHLcc7mxCzTnHztlFzWAhHiP5NlTS4iGuxswVabbXLK ylzsPYQ7tlk2ospemx+5FAMq9UufYoiAWCOheEen+WglJMRTMEKxa0xtqi6RZstg2nLa yuMOs15a6/2MLDI5LYjCeXwqB/mlVld87Q9cA+rml+36z+nqWVGd68jh2Ht7Fqp2/DJi 77kZ9kJuN6qjs7wRNoOmKBEBsp+ZMSw8lal9TkSJvNhFFCpIDMaws4k9d60pIX+qyK7B 4JlQ== X-Forwarded-Encrypted: i=1; AJvYcCVg/h+rMQp4ij6QqSWZ08eyn9LcbUeMul2Y9piryVO0u+nvVtuSBIjglsMNUPZ5t0S5j4kZ+K0Nnw==@kvack.org X-Gm-Message-State: AOJu0YzzwEy2OpKYiT5MuDPQoXCpWdpbnElSf2mMvmIom/cTLVx2ppVz k+GRqT3JlsxP4S/5TjQmHmsAESMn1OOqxu7L5trr4VrY8kLDc/y4iNHELNV2UrkwNAiDKcnGn8J 6wqOSTRtjVspywdpjAWRCiCSJZUU= X-Google-Smtp-Source: AGHT+IGUPPpq4g+KUdJ23PuFE9NGdwVNeGGNVd8Dky9lJQwYQN1flJ5XUVtiBdxwY5t0Y/KgdMBfHn7l62BjSzzhGSk= X-Received: by 2002:a05:6402:1ed1:b0:5ce:b9f9:f5c5 with SMTP id 4fb4d7f45d1cf-5cf0a4417fcmr6325621a12.25.1731177702793; Sat, 09 Nov 2024 10:41:42 -0800 (PST) MIME-Version: 1.0 References: <20241108212946.2642085-3-joshua.hahnjy@gmail.com> <20241109010307.74840-1-sj@kernel.org> In-Reply-To: <20241109010307.74840-1-sj@kernel.org> From: Joshua Hahn Date: Sat, 9 Nov 2024 13:41:31 -0500 Message-ID: Subject: Re: [PATCH 2/3] memcg/hugetlb: Introduce mem_cgroup_charge_hugetlb To: SeongJae Park Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: g4eagajxre9y1fbuihygjeadcsu9en64 X-Rspam-User: X-Rspamd-Queue-Id: 5014480004 X-Rspamd-Server: rspam02 X-HE-Tag: 1731177632-891944 X-HE-Meta: U2FsdGVkX1/laRCieY5U8++ZmvfOGXoTHp1tK4k4nviAwSrOqz5V+rjOukJm7NmX9MSzVWI3V66lYUjoH5IV1ZqrBfkNmrQeJGV74r2cTqdfMDXzhFDGMF/v+JYoxJabOc/Go9wUeWwPZz9UlIFlQtUEHsNyFoGAkzow/lE286G9/XjJ1uCQs6T58BK2kVwAbK05FtlidQc5qY9OJ/HiN/WQgKwbRzjMA7WP4rTGQ4MYgBkuyC8+6dLAxRjoqyNxypSgZ/Fe1y+PVrzmNE9UWpRQ0wGP9UgvaAw0B8cO1+Fk2CZYjCwVpGVP3Pg9ePS1AdrSdd1xPstK9dDd07TB1NeEzLaZO9E33ziTA7wY/5wM5L7MwakzukztuiRcjcobv7VCQVH+pVqVM+M8ubEPKZ7XTozmnSTR2+3RJaJWvV/9sSoQ06IXWzm3j07SKYBO4/Q3T9RsyXX96Da/fDe0IsAM+eOfb4JwShFPR5gW0TJzmUEvFbkvv0YM9wTCMSmbPDVgCZSusEVtDobIMYYcyXga7lJzyEfrGjAhcJR8+bBw8h+ZU1h8EGmXjIgN5aWeAbnHXK9I+YLbMSIlkr1PHZ81fOTQgQmn5cLgL1QNLVeYgK1xpIuy17Lt10PKA5Znej8UHmgfcaeLA653a7WUqB54IjGZBd33S1THqI514QsDi013SbWqfFYea/cJlY73hQKCVKC/GSuqIziznd5Yn3bNdqCPKyPs0sDnohyxhv4/nBSdBPJgBlTM5E2tK0v+arI+f0n8VxhPvcFsJtyDXHkPyPEFOyG1b90ctky3uC5gm7seQfUG1vxezoBLDf7t1cpLwMBoFVw3UR4UWy5cJ8WvAsPBRA24uoAbqiYvGcKqew05b8JcHB7gRxGX/u7e+WDVpIJ02V9F81vTPhMAb38tSVWmOXLVW64G3A9YoDRkPlLZRbwNQDJuQ98QjL0/Odzq4lCFBiTVrNnoC5S KPx1OULU SI5VlbR1HcWa3BxVK7Auzm8YIdxENw1OjbfiXpY1piEQE/RIz/BfoLlnxU7WWCOg+UWuOPLIOlNdPaTCHgBpiY5qTfJPQwsKiaFYLPC3e33nFuNxdkE/z0KcGNPWmceXLqaOJiCjD+PGGEsTJZ+m6LlIsPTkmSCCZnQqsslIBdkVpWMuWKgV2QmcRyBUczUa8mpDwgVFTMKWaVWnr+PkXB+bL0V/vGdGc6EkPUTsI2NYywGYzB+LUaF9ieaE0Y50rjoPpBfI6xuO6qbV1WmYUmdir7rL7Q3QIKsaZimAlrVI9TvBO0pIKmM+1Nh04XLzFMRNKAo5GiQ7Ng+FtLKsa0iGxQkxZNgNsZTEONHbGpFEe7bSYJ1r3ex1XMV2SGcoSus4Bev2Rg7sFAa2PxZWnW/phifnxSKIgTSyyXjm8+8RjVEe6U5iIw7fgwQAU+qsaltNbywo1bAnq3RrBS5Aml91by4nHJ7bBoChU X-Bogosity: Ham, tests=bogofilter, spamicity=0.173882, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello SJ, thank you for reviewing my patch! On Fri, Nov 8, 2024 at 8:03=E2=80=AFPM SeongJae Park wrote: > > Hi Joshua, > > On Fri, 8 Nov 2024 13:29:45 -0800 Joshua Hahn w= rote: > > > This patch introduces mem_cgroup_charge_hugetlb, which combines the > > logic of mem_cgroup{try,commit}_hugetlb. This reduces the footprint of > > Nit. Seems the regular expression is not technically correct? I see, I will change it expand it out to include both. What I meant to say is that it combines the functionality of both the functions, but I think there was a typo there. I will just expand it out so that it is more clear to readers! > > +int mem_cgroup_charge_hugetlb(struct folio *folio, gfp_t gfp) > > Can we add a kernel-doc comment for this function? Maybe that for > mem_cgroup_hugetlb_try_charge() can be stolen with only small updates? Yes, I can definitely add a kernel-doc for this function. Would you mind expanding on the "stolen only with small updates" part? Do you mean that instead of writing a completely new section in the kernel-doc, I can just change the name of the section and modify small parts of the description? > Thanks, > SJ Thank you for your time! I hope you have a good weekend! Joshua