From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F69D5D683 for ; Thu, 7 Nov 2024 19:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 178EF6B00A2; Thu, 7 Nov 2024 14:28:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 129356B00A3; Thu, 7 Nov 2024 14:28:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F32EA6B00A4; Thu, 7 Nov 2024 14:28:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D3C476B00A2 for ; Thu, 7 Nov 2024 14:28:42 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4EE95A0B94 for ; Thu, 7 Nov 2024 19:28:42 +0000 (UTC) X-FDA: 82760283606.17.287A946 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 75ECB100021 for ; Thu, 7 Nov 2024 19:28:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d30epdYL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731007635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bqzsUCGDO+jg/s9B70UzanNwP0hhELN8h8dHEbpK3IA=; b=MVmYdPFZV1vtUUfvcZjFNEEzGImZ34eKP0XPdcnc90YCjkXpwyw1ko9QqlpyPPAag9XkoJ 9Hme3Dmi816Kk+lB18t3jWPYTYDp4DVLwaH+b5/k2s260v2CwAqSCPgxRf+tDpNzH4wz5t Jf8vWjzVC+riCcT8d2qTRwynYRBGqPw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d30epdYL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731007635; a=rsa-sha256; cv=none; b=jLzBWEM/c0xkdSDcP1O3U51+KSKoreuVjvl6oRS345yRjzLfyPb9G9DvqmKvcsx9/SGVYX 4q8ZXePoFusLQ4zBklTe+EsS8SfHP1Olv7UYctGvWUexe71mZGkk4GuU5azCmy/4KnnIcU sPz8RxH8dt6F52HVUCzyhEa7GZf7eqo= Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-37d51055097so880575f8f.3 for ; Thu, 07 Nov 2024 11:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731007719; x=1731612519; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bqzsUCGDO+jg/s9B70UzanNwP0hhELN8h8dHEbpK3IA=; b=d30epdYL9tWHs8/K1JyXhGPV6XJy43l+gioOaV5BKd+5NNYrlm9AEzoM9wu1oL+Yio TsOEo1P63T17uT3kQBSCh75VLfe4X4Ykm7HUSRtkzZ7H5aCXWdOxWM2qVl4lsJMBf8b/ DNcFpyXz6vn1oeaiUV6tBqzEK1IT2u3JJMkDDQn+X4U5cynCSv/ay5oMr7s5KxU4+Qpa at/Hj+HQSkiH/VHfGAHdQq0AijohgRf2EkZpBTssRKZXZvX4YjUg5dA173LLmGLRxL3e QUrie2hRoxCFE3dnwQJCYamaV6gqYj3mn/8XJ+Ao82OCIyghl9J3LtyxVFjmlBm3SzzG Kc0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731007719; x=1731612519; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bqzsUCGDO+jg/s9B70UzanNwP0hhELN8h8dHEbpK3IA=; b=wVm/4P2gedU85QsAtCt+vh1kGTlPy+iX0Zjbs3tCKEtuJDqAmiUGi1KApKUHF7Tm3Q Pm/hPzy8tPO0WBDgvbLg/GjIDH/+qd6HH00/JYYbV4htwdDGM3RcKE1haPr5xqqDp8gX iA9Z/g3zHCrm3BvvTlmp6WWLERIndVaf4N/E9FoFtkjDfd+ijd0X/zhMDXO22Jn2iE3y MgQLAOlYQQtEyF7Aq1jjkx4JQCCL2MTAH6DU62DTvdk/spMKxNnMKuOVa5Pdtj/4XtYQ B+am7kaIR60K0PZP02C5g+/2q4dFSthfeFjDDr+wieZnvHR8oG2dpiKmmhAK1snEQJBF LriQ== X-Forwarded-Encrypted: i=1; AJvYcCV70vAP6kd3qVBOaykfHxKCvMYgURynOUDK5tskuCvWIBKeR+aAlc6mht0h2I7J2XmonkEwq/vxNQ==@kvack.org X-Gm-Message-State: AOJu0Yw86ucWcP7FeAftKXBjehBL3IhSoNOntLeBRbNmFeE05uaQFo23 kmdMPGiM2Hz5ZGtI7G9MR09RFLcZyToHDsTVM5OUJ19Wu5YcAGhuwV9ncNMUTTWUHgu5P4j8A76 9HPptIHR4xX7NEfDYpogE9BsxOQ8= X-Google-Smtp-Source: AGHT+IHvz4PUBjFI5RZsML4byKhmEa850ScdyNzRykPiHerz1pgz+in3a3wL6okFWf/GX+CWkoHGsVw9VWhRO8oHDcc= X-Received: by 2002:a5d:64c5:0:b0:37d:3650:fae5 with SMTP id ffacd0b85a97d-381f1885e0cmr206174f8f.52.1731007718522; Thu, 07 Nov 2024 11:28:38 -0800 (PST) MIME-Version: 1.0 References: <20241106221434.2029328-1-joshua.hahnjy@gmail.com> <20241106221434.2029328-3-joshua.hahnjy@gmail.com> In-Reply-To: From: Joshua Hahn Date: Thu, 7 Nov 2024 14:28:27 -0500 Message-ID: Subject: Re: [PATCH 2/2] memcg/hugetlb: Deprecate hugetlb memcg try-commit-cancel charging To: Shakeel Butt Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 75ECB100021 X-Stat-Signature: iq19sqxtk7uyf44s66atfyidnfbt1oux X-HE-Tag: 1731007680-751552 X-HE-Meta: U2FsdGVkX1/PflUkAwKCRlpIkqkPQLWjkiF3lqgWxg6Apjz7Mm5CYUcA8v7/i68wMcfBAEZ3WPYxWYo+1OjSIxrKomjVZb6AqDipCMLTFI8jZuCvN5vty5bJbad/3+qHZg1cZd3YbSqRYvfEELaDcR/KfRoN7lP4womxAB6kvnFGDHZQE+jRUKp0ismIWzo8AjZ+csvRcQwbk/iG3u0uDwBBFkYTRWRh9HH/BjFsFM0Rp9XL3Xj/iA/JIvpHmJX/Wd7oZ4YzVYHncYJcUNQV8QobbzRLnZQTmJpgRYCPrxVoEfz8rBaCvhgafjqY8PrxzR44EUu34dRED8xCR8HPb0nPRXdQ7z03gL4VBTd2WZ/AaHKnNl1L4Od7xP4Y3wMA+MhVrYadfSHPSZD8yIviz1GcZPT7RfP4T3x22Y43gX0OiAel0l+yAOBvBKNNsXCSDyQ0tHugocFvINjMNWYUV+GdBERdZL5zpp/Fc3B5u3kb7JuWixSQRoTqC6PWjdPtFNn1Z/lW1SK9tPumi5+Vg5p0mu/66XI0VPQPkBfIyGsjVmC83YGmyYPRyuYea0bItiXuT2YVJNXOwcAi9iqBx8+zXb8NPeBfaK8Q0PMPCXVtDpz3lWoSaDd3VDkTq3U6ZP43GWX+8L3A/aFLLaNuWT8pICrIDDQW3Zaq55DQ7Qn+X1B39D5Cj3mubiRd41cUVuAftZF/6usLJ9hAXk1YF49cdEABm2zANg5+VuFGmWIh/huMqnYHFRMItIofCKPnutm5iNdW3FoQtZg2TMD+cfz75Q3X8YaAhjtCFj5q68IwK+Bjn6PuGB7l1n26TF4EVmuPRHZGGev3ICteIbbQweizQp0CQ0idNmRLty5QvmvR9FjsKuUCxI0xg+Qeb9X7Vz1T0fe+AYrMdpC5JYMUadHtHnq/QTcY/AC/yBamHbNYSr9+i12CNoIV8EwdvDB5t9TP3kCPYnCmu57TFI4 DL9pW7E/ VK6oDdUFaAjE6fby9ZmV8fFdBHMdzWZcbTlmUnF5V9cS/X0wNrkOhvKvkQIc2LMBvaVSNoFqEM/kQ875UaGeic/afIjvjpv/FL1KiqriJa7lbsOQymEZh1nNLnXiUJCizNdXFj1ZhJdyARs+vRhxNUhg0RHRstIZGf60nhpu/B7Cc6yJ350j3dq5UUYTwJKc7+Mw8ngziSMR/qHeFbQjQwDv7sVa8zxYcjYk4FIGkgYolepweWjOa1Y6h4BIri1GIj+WFlPwSB8hgAgsCDRsDh8VoWTjR2myCgRm32mYRf3HxBKB9O8hQjj+mLdZ0g7gLITponghfXflGkA6kG9swbVo699/P3O+fA4wT X-Bogosity: Ham, tests=bogofilter, spamicity=0.319223, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 1:58=E2=80=AFPM Shakeel Butt wrote: > > On Thu, Nov 07, 2024 at 01:27:53PM -0500, Joshua Hahn wrote: > > On Wed, Nov 6, 2024 at 6:50=E2=80=AFPM Shakeel Butt wrote: > > > > > > Please cleanup mem_cgroup_cancel_charge() and mem_cgroup_commit_charg= e() > > > as well as there will be no users after this patch. > > > > > > > Hi Shakeel, > > > > Thank you for your feedback. Unfortunately, it seems like even after th= is > > patch removes the references from hugetlb.c, there are still some > > references from other files. > > > > mem_cgroup_cancel_charge: > > - memcontrol-v1.c~__mem_cgroup_clear_mc(void) > > __mem_cgroup_clear_mc() is gone. No more reference to > mem_cgroup_cancel_charge after your patch. Ah I see, sorry for the confusion. I was looking at 6.12-rc6, but I see now your "fully deprecate charge moving" patch. I'll remove it completely in that case. Thank you for your help! Joshua