From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C94D5E36B for ; Sat, 9 Nov 2024 18:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 293826B0085; Sat, 9 Nov 2024 13:34:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 243106B0088; Sat, 9 Nov 2024 13:34:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10AF46B0089; Sat, 9 Nov 2024 13:34:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9BE86B0085 for ; Sat, 9 Nov 2024 13:34:54 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6CABA1212A2 for ; Sat, 9 Nov 2024 18:34:54 +0000 (UTC) X-FDA: 82767407226.05.BF35D7C Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 13E8A20009 for ; Sat, 9 Nov 2024 18:34:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eq2wHx9P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731177231; a=rsa-sha256; cv=none; b=sWsdye8ieytPDXq0rnR1edHfHKnudkDKzndggm5OevZKxbSjAYvLPldtDbpfHomAQ5oVQz yeBRWfycQ7bV6MexSbFR7gRM46iBdOg/5hpLqctrg1OFLQm5IqWCygbSY3bLlnSbHEoxt9 t6Bx1WGeBUR2c0Rp8qZAYiOtd2MADkE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eq2wHx9P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731177231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y9UwVErHmVJvfwqmBtKpEzqsP0sdSI7VmMWVCV0njN8=; b=7VRMxsWNteBex2ChKfeapJ9DMJPmY/xf92fIh9ryYOg+curollSeUFUodfzU2oTIM3OVWk IuoHgcfp62trinb5LFgv39jYhdiVY/rRLXe2WErDZeRhn1pZ6cFHFdNHKNR32TAoGkfeXa 2gQEpcuzLXSwMm1rsFJuBakUtP+fhlA= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a99eb8b607aso465533766b.2 for ; Sat, 09 Nov 2024 10:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731177291; x=1731782091; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y9UwVErHmVJvfwqmBtKpEzqsP0sdSI7VmMWVCV0njN8=; b=eq2wHx9P1IWCh/DPVCIofy5cFMD9ukf4bnVxlz2ajetCdpVQkkbdCit5V52rjq/mzo IBdSOxOaGtPFFJSzI5+hJjSQz46wIqqGmPCm8LzVzcBjuehH2rRQK2sqbUcU2OmNeQBX dkGMgt4LBmrjGh3bwZN4hF75RAgzQxtO1O5ViJZVVxXsbSVncoDCSGS1eA5J865XqYyy xOaOMihuX9Nc2Ncl8Vx44JCu/R9LAUuLsL5sm5YG4YajoDgpRn9JH+o3N+beYcfmnt4q /Ni/+BcB4wUMEKTn7a6NE2dnEzllHCy62pyWx1aSdf18E8rbq+UYU+qSEqGLv7UQXAEG oCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731177291; x=1731782091; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y9UwVErHmVJvfwqmBtKpEzqsP0sdSI7VmMWVCV0njN8=; b=mJk2upnwnF6WXsE29xI1lYzz1gkmJ7ZopeyeffbcXGtxc2hOyX46azMpgRlojSFEv0 CYT6X58wgBqOq6yVcGD8rwpK3QiKQH/zrduCr/hDl/0nkdFwhxVQcwsj2KbPYysF1fDb Nc4iqKbYHppBk1VGNv8F6DWyCcFTXg/glG/upITBsZeHoRBrAG1jIDQmPteGgYaKdYHH KbQDjsi6SD74A8zlCJqn8TtsPOtX8F13jM0vFDzVAvhTmec5H1CjV6Mi24A/2/kl0P54 hHGT2Ly2TibSVKaMfHwaNVwq7dfjZkpCOTCHrSJ2J7zS8c6djNRwVPZDJikuQioYl+Sq WULw== X-Forwarded-Encrypted: i=1; AJvYcCWg8QcqGtt8j0M0GtRi/QNLigBRuRDkJguQWn6RyeW5gOOHxrP+1z47NYH6kjgKerijtbxtmPL6Kg==@kvack.org X-Gm-Message-State: AOJu0Yxx17aQpaqfqBwKBIjt0M8R3InmiewdxHkeQWNodNVKN75CqfIu DAZhEpoIlEP7Tv8Of+BVwO3tTPzFsam8Em722V0YNGYRyp4cdqLtOqC3U2qs/KhW6RObHef/1OT jFoVYeRmMGMoxlN3iSg804ARQxrY= X-Google-Smtp-Source: AGHT+IHXb1Fi848c0NJ3KrNiUrX9EnIwnwvCobZKUoqzJV31JvxaGAsQV9fqaCb5MlSzG/o/oz2VVcvFt5pYuFzZvnU= X-Received: by 2002:a17:907:26c2:b0:a9e:c442:2c15 with SMTP id a640c23a62f3a-a9eefff1869mr760216366b.38.1731177290630; Sat, 09 Nov 2024 10:34:50 -0800 (PST) MIME-Version: 1.0 References: <20241108212946.2642085-1-joshua.hahnjy@gmail.com> <20241108212946.2642085-4-joshua.hahnjy@gmail.com> In-Reply-To: From: Joshua Hahn Date: Sat, 9 Nov 2024 13:34:39 -0500 Message-ID: Subject: Re: [PATCH 3/3] memcg/hugetlb: Deprecate memcg hugetlb try-commit-cancel protocol To: Yosry Ahmed Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 13E8A20009 X-Rspamd-Server: rspam01 X-Stat-Signature: uzokxk9ajse977xwf9hq7ir57ebmkjrq X-HE-Tag: 1731177252-533480 X-HE-Meta: U2FsdGVkX1/Hpfrd6eVXm4rC22Zc/o8hJnipzVO3gmvFIp/h7vgZ6dhju4Mr15sd5AhuPlnQ10seVuXWSSFNDEWh3UoBo4z8SGvgNi2W3T/34REwox4eJg+fn9t4ziscoKoqJLHJ3TMMswsXL3Yj9/cwEKRo+dpKxdORryAEeuIgwLPsGdUONvqjDStF8TyDvCN+c05E3hUV9edOf1qQQirfFGRZLORsTEaNsF/AToTvY0hNboHkGXj42sVjUvSUX8+kfzE69Lfc9U2zFPH8m9LwGUCbalWxPeMeKZ4/fArI9dyc24RuOGZMJ5YEl8q7PbCCBuP8oaT2d70jIVXVUbl3wo6Hp1oZG8RyoeBAd64Uytb3CfGkhLjMvxk5vkbBpE11947RQ/hK70Gj7QDH3gq442S9ObSYdNCA9UknzhEyu1i3rliH9WHmjbMlSYB/23a07X6sJ0qefK6BEXytM5aknqTRfENVzmEvFw5iX4idPkdCTFQuzy4Cma5G7vQRGmxB5rAsNPxVfzBfK4osarc/RYznDqzb8q9Vibpu0kZANGeqDNjeeNqdY949D2TpHKeERZ7PH85yAwzhttRCrLRKG6u25+dg56TJRj67FlO4WWg0AEA2PkXapX6f+zMe/MSFLXBE/twCvPdBPhRAJ5xuCr/qvUOencIO0dB8/ITBHw4zFBh3npDFap7k5swyZUEQXkoYTQ2ka28XEptDn13MQ/Y0tlJ5NAR3sR4DfXd0UC9OFnm+QqYJ2B+JNmPyHq6MzFvoYWJC8xtgPCrv1ngGhtajLcLtFHuMIkSWPwdALjwdGBCFSkKxcmhUIiFGDZYulYTlSAgFYZp+QlK2NUwVdDikcDMWZAXRWpiiTD7siliuDDJI+/uOStO355qJQlR7KGJEt+0xDpygtWhs35bb/iBnMY7Zuxf01Ave+isAVg5fdq0JWUjfvNOGLc8S26mdw1/I31/lj5bjZls 89fDczTB iOgqwtCYy5P0LdKLY9lgcsnvxwsAgMnF81LLYr5w/1wjF8rvYQlFZmjtgdxb+2uoaG60rlXTzrdvH3urWJWRRfSwf6agkl6VSeTMNQd74Zwr+F5ZQ1xLvI0nRw+o9wtrSyNGSeDm+unHP8iNfL238sTBPquValpDQKQhTjK4oy4H3SWtMBxo4kWzCv9F8YQXPKm6Q7sXDGe1eaOgFo2vjMzfSioEoe28RsPFCvZru+kKoOd5zDr1JqdVQR71sXPmR6brVwQW2YvKxQM22ked0HlC/dUDJbojhfC1HfoeepZ3GvI4gn1chezST+jimv+U0aWaqkmZawVmctLwgeND2e3ZoKdRb4Dut1dWN+s1K4q4QQ7ujF2kpBE1hxd9grunAJI7U1VWvuk5DFUF4d3knudPotd2ERLI2LMWN7kqjlT4lFII= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003194, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 8, 2024 at 6:08=E2=80=AFPM Yosry Ahmed = wrote: > > On Fri, Nov 8, 2024 at 1:30=E2=80=AFPM Joshua Hahn wrote: > > > > This patch fully deprecates the mem_cgroup_{try, commit, cancel} charge > > functions, as well as their hugetlb variants. Please note that this > > patch relies on [1], which removes the last references (from memcg-v1) > > to some of these functions. > > Nit: We are not really "deprecating" them, we are removing them. > Deprecation is usually tied to user-visible APIs that we cannot just > remove, at least not right away. Please rephrase the subject and > commit log accordingly. > > > > > Signed-off-by: Joshua Hahn > > > > [1] https://lore.kernel.org/linux-mm/20241025012304.2473312-1-shakeel.b= utt@linux.dev/ Hi Yosry, Thank you for letting me know. To be completely honest, I think I have been misusing the word in that case. You are correct, the goal was to try and not change any functionality from the user perspective, so I think removing is a better word, as you suggested. I will make this change in the v3! Have a great day, Joshua