From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C78D5D682 for ; Thu, 7 Nov 2024 18:28:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49E906B0083; Thu, 7 Nov 2024 13:28:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44EDF6B0085; Thu, 7 Nov 2024 13:28:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3164F6B0088; Thu, 7 Nov 2024 13:28:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 125166B0083 for ; Thu, 7 Nov 2024 13:28:09 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83D5AC0AE7 for ; Thu, 7 Nov 2024 18:28:08 +0000 (UTC) X-FDA: 82760132826.11.445B692 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf01.hostedemail.com (Postfix) with ESMTP id A846540013 for ; Thu, 7 Nov 2024 18:27:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nW6EceZ3; spf=pass (imf01.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731003948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BVfDmuHs5p+fa/eZewzS61BcpvU/96M31o+p3JFZkE4=; b=tHEmH/XQgt/Mr1l0NscxHKq1+oTW34MjHAkMKs28uAEC19917kA4ln5hy1bj6s8USRx0+L NZ2e2cTvHpj6XVyT3Fv6OGwOaCz53b/68Mmd21uncMVTjkeRZtZIEUpcMYhQ64RZQsh7xW IHEM+0BOOpLFNMyrlWFSnyIpA6NrLEQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731003948; a=rsa-sha256; cv=none; b=Sccs38gWzQ+zqgPY1vsnbYu+ZpwbUeGD4BDgFdLoqVh2+K+gDyiTzQiWlrwwKzo7mLMB7t N43wlwSGPyr1/fxtalty9CoBLkAWz3Agm6SXSermmkBbtCdxvKESjoKdPGROZlR7n9Qj5g fH0tB5hsPh8C3w3gEb2M2wwntkQF4fk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nW6EceZ3; spf=pass (imf01.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c9c28c1e63so1551278a12.0 for ; Thu, 07 Nov 2024 10:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731004085; x=1731608885; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BVfDmuHs5p+fa/eZewzS61BcpvU/96M31o+p3JFZkE4=; b=nW6EceZ37NNf3jUfMcfCXPR6QC0UabdcI/A6TEte0vyZpGfL3bxHdGFh6MYBiId1Rt aYq25767LKmIJFzNQli7U/33c30aplhol9x8QKS+rhD1UNIOZXtW3pNoSi4B25G9a7tV meXuukMcgaJ62uMHItVlxnHsOFiJ7FYdSfBKYimQYVYSgkUO7biCw5BfmNF4/p1Hv6Fy ASCa1Y5/aeExqvl5B17QVUHZoYcb4Ib5kJI57u4AElsEJmqS2Tb9QyPXnFWe9H1A0k91 PqCQ7acSyYh9aJiNVZK/nv5zFeeT8FikPJ2Dj5GLeQaQpsj6VXDY95SADTRZ2iLl34Ib w4LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731004085; x=1731608885; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BVfDmuHs5p+fa/eZewzS61BcpvU/96M31o+p3JFZkE4=; b=G2FPAWotPwt5qloV17O9UuETCIb8Rem+3pNQ1vIaLwIX5yOfxu7fDowG04sbqTJkNW KPqKXgW2bjiwnBtIEvYp7+z46nwF+tA7TtCU1JI0jczAT3q5XiH+nou0yrK8xmbbD2zD 8bb7YUXEZfhbu1Y6uwHaRmb+XCWb32Muigz7aATM0iPLeZeZFlO9BGrlynQBQkVoMUu+ 0OU8vahrAxCazxYqE4W/jsXWHoaN6wVbie+XRR/ZCrr+JOk7g7dGZzOG8P10pwkBX1bz VLdH6vMI2rieGq7mnNoqmCx+aNpxf7X0poSTQmoVFEUJEkXah5C/5KEFsTuaOivfbJqk zjRw== X-Forwarded-Encrypted: i=1; AJvYcCVqKtqRLbr/Ybk23rmHAqUhD9+MGKSmhgoYkxppxbnUWAPNxe1X0kW91D5OzT28vYU7sLtSl0RwhQ==@kvack.org X-Gm-Message-State: AOJu0Yyfij3SM1/XrKIBMRv0/fJyJU/quioNRCE4TuN1iZ0B0WbL8W1P q96CdaDE5Lu4JeuhGNXkHE6dabto0fY66bs0kbe3N1E6EE9tRXC7lHzWV54nj/MDnMlmoarTUBK nCc4bXZIpG7Y20zhW5A2gl/i/Cbg= X-Google-Smtp-Source: AGHT+IGslwSAq9MKLCz5wDbzj4kAH/gRj6dZGwgC/ErBas1EoEfksgehPaVh61S2Yyo9MRL9FoNIMTkD5gDBNsZaKPA= X-Received: by 2002:a17:907:31c3:b0:a9a:522a:eddd with SMTP id a640c23a62f3a-a9eeae9b963mr113080266b.11.1731004084816; Thu, 07 Nov 2024 10:28:04 -0800 (PST) MIME-Version: 1.0 References: <20241106221434.2029328-1-joshua.hahnjy@gmail.com> <20241106221434.2029328-3-joshua.hahnjy@gmail.com> In-Reply-To: From: Joshua Hahn Date: Thu, 7 Nov 2024 13:27:53 -0500 Message-ID: Subject: Re: [PATCH 2/2] memcg/hugetlb: Deprecate hugetlb memcg try-commit-cancel charging To: Shakeel Butt Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A846540013 X-Stat-Signature: xri9bj7gifskxjnq5phqmqfjgxhmta7t X-HE-Tag: 1731004058-81367 X-HE-Meta: U2FsdGVkX1/JL6BdXGcE2EvZsZ2wit+welybLW4CUkKyQxMzZmL7mbJC+J39pCvd5+cZlPNFiTX0ZCwO6HvqjpIrn5W2+6MdutAyJiBcnbANzE027zL3Ha63RGjkchvyYnO3nOQsun1YI55FFYOC01czife/auWhhob0j3GbmBVP4F2tV3sBeapUkHAMbbGvqt9mDrSlLG4d2od/rF+woEin5sm3SqhIZOUvN1ILn2apvgLUicqhHxcWmGAMeuK6k5HenLk+3csC60zGmI3kRcmcATsLMzoUpF9OXTTIMkrNKNfuvDjF85zkwQiI5iL8qmpMn8Tsq4tv3ZE0flGQqK9HPlOMn/h87tPlRqbro19/0umNJ9Ck69RpSwTxFEYJIC95wY6STHfY+lB1+Z12X7rVdIoZ4GFOCBqXeGPWrMZeL7TAJbM6kBdO/cYXVTemBL8N8ns08ipGsWt3ETYeZpjKuZ91SFFFp2EI43QoAH2Q8rJb6zysnb1LQGMkacyoT+GtXYoxyjvIb6PxJV4HFywOFOhFIGsYnrocXcSonTowhqtZvp5vmyzPT/54/l+ldV2thocsuSemssL5Y/behHtK9Xbo62U4b6QTYj2uCy82lobYJUf5bjdlbR6fglEjvWdvHPXIPU/hM2MeKVEXvujoETUB3FRwhRd/OJpGfOROAorvT1E/tx8Y7h9YT8snjR7jtfKzY2ZrevPcaC3Doporct3OTj8jxFMbNFLrnKEuPYKrblmVkiFGPfvSm7tFQO1I3PS7lS3FWrCwaqquAdtkbX1CSKC3hTi3FTPC8/MQ64WQ7ZsvkUB1ZD8dkyPIwA5ujcgrdsP+FU3RdZx9sux8Y+qhywZ+0PTuvYgDtw6ss2quNrIY9HWR4vAyNazUVQrcyOimKT+ptsVGRknhw+ow5XTQvZWxaB49ieYNfOMqoO6aQKUx1SbEvY7bMwnDUhYMyT2C0cBITAjL9OI mAD4S+mA INWUW6WGURYR/rLR8/3AFOHSVMy5rHaPFGF3Gn83eyCKx6z4+GtKPXE8kx75v89zhlZNsAlXSToeqRAuH7/g5D6YOLbnPtRuXeKULxYG2M6JfeUBNmS7qXozH+aiWaubWg3laM1yYA+5nYEfFExZ/e8LhYtsaXNW7VSdCgEFvjSK5GJk0tGMnGJJPODOgg1tzmx6x5kFBaCECFDF4FX/0oZQChVE7Iyi1Q8GiFIcd8HfOcbIIBFt2nB3SQl2K9u1gfj2fo1FQ9wFvfWnjkz7IwqagHe3b6qiPmaARZIXrtF5SVq14fQXxirlhQhan0SizFeDqL97v+1yzlExdEigu+3O1lk1ytCC0g9f3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.019165, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 6, 2024 at 6:50=E2=80=AFPM Shakeel Butt wrote: > > Please cleanup mem_cgroup_cancel_charge() and mem_cgroup_commit_charge() > as well as there will be no users after this patch. > Hi Shakeel, Thank you for your feedback. Unfortunately, it seems like even after this patch removes the references from hugetlb.c, there are still some references from other files. mem_cgroup_cancel_charge: - memcontrol-v1.c~__mem_cgroup_clear_mc(void) mem_cgroup_commit_charge: - memcontrol.c~charge_memcg(struct folio *folio, struct mem_cgroup...) In fact, in my patch, I add an extra call to charge_memcg. I think for this case, it makes sense to just extract out the functionality from mem_cgroup_commit_charge (3 lines) and expand it out inside charge_memcg, and get rid of mem_cgroup_commit_charge. On the other hand, handling mem_cgroup_cancel_charge seems to be a bit different. Now, all of its references are purely in memcontrol-v1.c. I think in this case, it makes sense to migrate the function declaration & definition into memcontrol-v1.c, and remove it from memcontrol.c. Perhaps at a later date, a cleanup in memcontrol-v1 may find that it makes sense to remove the function, but for now, I think we should just move it. I hope this makes sense. Thank you again for your feedback! Joshua