From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DED5D767F9 for ; Thu, 31 Oct 2024 19:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 993636B0082; Thu, 31 Oct 2024 15:03:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 942356B0083; Thu, 31 Oct 2024 15:03:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830E76B0085; Thu, 31 Oct 2024 15:03:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 64C836B0082 for ; Thu, 31 Oct 2024 15:03:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 19BDCC171B for ; Thu, 31 Oct 2024 19:03:52 +0000 (UTC) X-FDA: 82734820014.17.4C07E8C Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 566371C0009 for ; Thu, 31 Oct 2024 19:03:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EqRfvn16; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730401349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uZESYCwSy02piR+29ifqwWC+ET5V5TOOXfN7NXL/460=; b=fz23/wuzQk9eIVod297t4IAamk8AzLuPvb3HIywYSJvIrrTkhZQUG3j+42YKj+t5ipM9SQ g4u9V9VTJuaCownkJZW3YjD/Ql10+18ja6WJ9bCshfKgoQr8kduN6GHPPALwMy5I7aowlJ iRTY9HHcqn0UOcsyNUKb02Gwf05Asx0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EqRfvn16; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730401349; a=rsa-sha256; cv=none; b=drNygNrO4dzi+ZsmaPujAJhTg+oXkNQTfCIQ3k0ZQ8i2K9V4vF8MF82TvlV8Gm+/d6GswO lB+DgbD5XjRivDKn8HqZuFLjppgY+D1KQyqj7FP83+pvaaFpjJ6XQWo0icT4IQ0Z1odJrW wCds/qJFL3s4pP5B/A7H6oXID+k6EKc= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5c948c41edeso1524571a12.1 for ; Thu, 31 Oct 2024 12:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730401428; x=1731006228; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uZESYCwSy02piR+29ifqwWC+ET5V5TOOXfN7NXL/460=; b=EqRfvn163IYEGYwDBsFtukzC3AS/Ki3j3g8Wz0r+wKwEkPJkcPGrdAfalGTmJcSp+T c0dbFUzjaensnP12XsNNAkwlXJqK6UKXvkt8iohQPIyOYoLqCtSYEzK36US9b21DytME 6kQTSbJVzYEMpYcDnSpqGspnm7wg04uwZ/1UB1r/Lff04Ioq8Nq2X7xiARS+xPEJRrkI yE40i8itpZ3gN1UT2kDkT/2NIGriHTXGml/uB5WlB1HfmhoQ1YhANjdIEWExd8UEyciZ FO3ruQOqkm66G1oxwfaXqkxSeoyPhvH92OEv5D56+oTBkGJy5F3ELsLWSh4b46515bKq z0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730401428; x=1731006228; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uZESYCwSy02piR+29ifqwWC+ET5V5TOOXfN7NXL/460=; b=V/EbkUR13J4PxSnxhga/hSV6NwPvUIDJi2ctkdjb8BwbPyLmaD/6lTslWVVeQqmnOJ 8Wodq+E2jFyp7LnLHu7bPfwbnbPl/XjOwu6q8wtiKFtMFiD0Ir8o1RCCNGVz0CrzQ7UW OlGrE0iWG+GJvTInkGvBnw+vDG3C3grVw6KBR6j3yFE/X85FEZ7MLjPO6SL/gogfRSLk +/Ssn9jYm5fM0zf8kBpStRiOWFoywM6sBYh5ANejartTID0uTLWzqGqNGqUXTgL6+KvQ KFDSHNvNmqj/JBKWWduHYmwjX+smHnEK3d2i2Xmj9nbUYi9IwfCdABGtBKJ4TRKYoxhT /Zzw== X-Forwarded-Encrypted: i=1; AJvYcCUnJthuRtSFC+KKaQPG3hPdRdZ7EacL+TvYsfzsKJqA2wnI9nGtEBMf99JXyx4cg+T+MPnp5wGJlQ==@kvack.org X-Gm-Message-State: AOJu0YzzHPNy8TArZ0ucEQxDC7qpKb7BbM1lAnEOz3+j/dh+dtOY3sq1 RYtgL1Fr92D8ydeXnlNweIN+4q7MVRx8NXmZpvwTPg72uTEqTt8lT/KoCCtDxm4b+GBVM7Nim5Q RACd1fML4Q9doAoZpqiHSzdOiG2o= X-Google-Smtp-Source: AGHT+IFrpwGE0LJQq69tNQQsCndtpIAHUJ6FP3dpoTvWpaJX4mOBqsgxY7fkpk4UaRiczuaoWI/jB/OMed7/7+JLSic= X-Received: by 2002:a05:6402:354f:b0:5c9:4a35:7a20 with SMTP id 4fb4d7f45d1cf-5cea967920amr3734778a12.14.1730401428267; Thu, 31 Oct 2024 12:03:48 -0700 (PDT) MIME-Version: 1.0 References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> <20241030150102.GA706616@cmpxchg.org> <20241030183044.GA706387@cmpxchg.org> In-Reply-To: From: Joshua Hahn Date: Thu, 31 Oct 2024 15:03:34 -0400 Message-ID: Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg To: Michal Hocko Cc: Johannes Weiner , nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 566371C0009 X-Stat-Signature: sc1yfg5mfi714gnkj1yj4ao7gksygwdf X-HE-Tag: 1730401396-891091 X-HE-Meta: U2FsdGVkX1/Xz9sIlg2EZUgr2HoXtiWBSsfUk+rMdsTYbhonoqTA48mnhYrfC6L0moMBugLwH2jjBfQYWl9l2+BQPFFaj2MFCQX6cPHedA+5e5CVuKR1w3YGUUjFzZeQR7JQTi3/EcOd3VHgl0vvtmyvbD4SG+aBBb+QWMA8fXZwIAETilmtIsN1Ad85ymsfLoebGhxPbryN4E8OZ07M0pF9SG/Iz1VdvGDt07gl0bWBCVT6/emWUW6JIUWegSMxcYPR3ZtiygkiruQAkUO8xvms1zgNr5V7hON1rgySbqfxjahJ1l2sbJLg5ebOZFlyKaVnmu9DuztsxPgdsqtspm5k1JBYvaWGFO8L75tUCvD7o093Deg2LlcRiYg1r0/LmCZrtBIOgiMKRNUNg98Elgzhk32A29jr8XSs3bag25MzPQUGSSHHxUuz7FeXyq9uYXsFETxOJEG0dXIMoC9voKMqOruKujDR/igNhEk0EHZz70N6et6+ZVfM+FtYkPsDLnXxr4D/0YGalH3jh4LLtbJ6/6Aw7aBeW6kDabIdrNwtbyq6M7glsnl+zztBgAYZtDgb+riCN+sfMbQFaD2z1keIi6waqcXe5HHxiHApJTxefRLExIu5lNTrJkeAmpZcaipwAGdlA9DGwmztfCKVvz1P28e58KTg8zEWMG659+8C02OkVsCoOsCN491ea97sjf1WAHTPLNh6VVf+0v4J8+ZQbnAfGgRN7j69d9IJfhuaXrbCelSAau4tAXwosEQ+d5UM0/M0w2rHlAcu9JYqNFihsZFbH5HIZyfvCTZBN5WcoP5NnRg0YOchUTiYNHJq9ytuQdt1fZJvsVvQE8VeotPYwsZhH953IJQ+XYcFXDnlzZNbqAcd2SZr9Jo6Yin6986SOAE7jpVnvtndLdLkyjDUY//AI7VudCRKshCreLObQlNZCqip51JewdnwLt3z+kG1IQRLm6sjUpT2E/g a+IYlmIx LaVoDmypCzJtFVnRQAgIPpmxnBWxysureDGLT9OrYCKg1z7ZKKM4LUmY3h3hX5WWzxqQMOikri+Xhnjgp2I432hkm923fDodO+dn0Swr5WUQmx9EflanjrZ5E5Bym32Xy+OY9kEAhbZIWohvbvCJkBEHLPJcu8El9ZaCJew7YMCbHrFgJto4jpevL43a5g7XULW7vtBS9K55KdogvfIv9t3iKoO3VSRVr3lZ7+2O6iAXStr0H3ANJX5p2E+mFXUdfjoNgFQ73NOKw3aI+h1VrO5J2NUciJnuEfl0lixRbBXLs7mpcCbFizDi+BFrpcnrKHmmCaRQ8uVvLgLACl0YnU6/e7mdb95GEdw5az73+sPZYuRmGIHOreathiAQga4yh1hyhQ49DZYZYxVLRh8X46U8oxvmOjr3nVdEp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Michal, On Thu, Oct 31, 2024 at 4:12=E2=80=AFAM Michal Hocko wrot= e: > > I would also add the following > > The global counter is added because vmstats is the preferred framework > for cgroup stats. It makes stat items consistent between global and > cgroup. It provides a per-node breakdown as well which is useful. It > avoids proliferating cgroup-specific hooks in generic MM code. > > Acked-by: Michal Hocko > Thanks! > -- > Michal Hocko > SUSE Labs Thank you for your feedback and review. I think this makes sense, I will add a new paragraph to the implementation details section! Andrew -- I am sorry to ask again, but do you think you can replace the 3rd section in the patch (3. Implementation Details) with the following paragraphs? Thank you so much! In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio regardless of whether memcg accounts hugetlb. mem_cgroup_commit_charge which is called from alloc_hugetlb_folio will set memcg for the folio only if the CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING cgroup mount option is used, so lruvec_stat_mod_folio accounts per-memcg hugetlb counters only if the feature is enabled. Regardless of whether memcg accounts for hugetlb, the newly added global counter is updated and shown in /proc/vmstat. The global counter is added because vmstats is the preferred framework for cgroup stats. It makes stat items consistent between global and cgroups. It also provides a per-node breakdown, which is useful. Because it does not use cgroup-specific hooks, we also keep generic MM code separate from memcg code. Thank you Johannes & Michal for your continued feedback and interest in my work, and thank you Andrew for reviewing and allowing me to fix the patch messages. I hope you all have a great rest of your day! Joshua