From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC38C83F0C for ; Mon, 7 Jul 2025 14:11:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFF6C6B02B6; Mon, 7 Jul 2025 10:11:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAFFC6B02BA; Mon, 7 Jul 2025 10:11:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6856B02BD; Mon, 7 Jul 2025 10:11:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB55B6B02B6 for ; Mon, 7 Jul 2025 10:11:13 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6DCD41A0146 for ; Mon, 7 Jul 2025 14:11:13 +0000 (UTC) X-FDA: 83637655626.26.E1CD84C Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 866AB20012 for ; Mon, 7 Jul 2025 14:11:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GErpcQnT; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751897471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EumfPRZLPRj4W6Rgv8B1SHmvDf7yvxr/YJGquC8BC6Y=; b=qepLtZka3PjGwgOyqHONYE22+sc/Ukb+Eox8ZBUJk5EU/PI51d+ay4+lVg2MkiX5xk8Ck8 9zLRVsi8+HzgXy2EZzwmeiLEnbUvhXkQvylnVtauNOM5FI7UYWb6aoK0/ixyBuTJBVoniZ xs0u3xGkFPQsVK8y7x/XqtHN2b01JAE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GErpcQnT; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751897471; a=rsa-sha256; cv=none; b=TpEVczMzWD/ernrwP+fNS9nI4xpQCiFI5n62gB2oZqDoQsxZNOgY39KpjYc/L42QOhZlY7 WtieRbMEK/ny9gaag4t34oYpwxLAbkjEk3YxwOcbpZsTbNbMq3GTj2J/jRfuO0+S2+UQEE sbACeB1WlzCNs5GeYHv2CRQXJmzJMz0= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-60c79bedc19so5052018a12.3 for ; Mon, 07 Jul 2025 07:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751897470; x=1752502270; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EumfPRZLPRj4W6Rgv8B1SHmvDf7yvxr/YJGquC8BC6Y=; b=GErpcQnTMvnpsEvAA5sJZkzVTG7fpJgEPI+LStv8E4K6TtyhPWWeQonlq2S/P+DwHw Zpcwhn5iBwx05Lo8YW7aC5lphtKyCQDSqNmleelnWunQFz7pRo+ON1R8fyClhC6griAO dTiazhKibo9Vbb2KU7js1hOiBdORrl9Idwkj8liwnO8H0ZsV3gDCrf5aoi96GVZ+cjjU 17WqlwWVWcq4GF5/GDzI8wp8lwYU2VejzZ7OqK/y07+ckRLOgQQ5oywVWvDMNVTEMyH1 ZkYSWjsdgZiEhqF+Xo+PH6vDQxtdfuX8phURCYCjB34eniR+e6RH9dMql3Ylm5wU8f12 1+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751897470; x=1752502270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EumfPRZLPRj4W6Rgv8B1SHmvDf7yvxr/YJGquC8BC6Y=; b=rzwsvGBefnvzslJjFVbLjRQObsV53n/p+7qTmS1VY5CeVKvWcTyVHfiStFIAXFfSBj i+vAog1jQX3KMsD2mw74UZezznD1AIEAt0b+y4wKVPZXhdwI2rK9L3jaK+4yf3aQk4LY kLm+1S/Cwf9z8h5MhybGZ3uv9DBrGfFyEXXoTElhjk53yTbbaXVyuFhIIFdPQEO/+vY4 0qiY/X2fE++gGHMkN0AHUB5GX38sC6bXkLIJU2el2N3FaGI4Wa+0vmUkENARHAC/Eyu1 hn8/mokzS4zUFyqkBvL4Kxl9ZZ9JwXYpL4NY8/Y0qMSFnGTEkZOlk5DY2c4MZ+wrW0EM Zhzg== X-Forwarded-Encrypted: i=1; AJvYcCXRctHo7Ybmb1v7lplcKhduB3LOH19YbpbBEZHxy0wF/ILiQyJsG67vE/aWNpl92+gsVUVVaKqBeA==@kvack.org X-Gm-Message-State: AOJu0YzUXrXg4vZ7cG2vBLjvCTSqpU3x2+ZGSwrvgrWk+gBt99QOwJAc OnZsUc9Ey9sjEqed8PM1CUVyxW6o2L7rxeT4XjeqrJADYGsjLduZpC2LYG4k08c0XruGOYSrGYI wDSckGFaHtsmRv+v4Qg3qLVmJAoln5os= X-Gm-Gg: ASbGncsq9D4EaxW+YtQcRp1tQRb7O9K98w4tei4VUs3EcSDi8ItsQ4hq/w++adaL1SL xjnq3o1eK1Dl/RT9uq+WOUp1x4HTCuTM1guUACaLU+sbAzPIhyBwrPSHUBqfwbNGxsQNuLHhu1O MynSWkefrVTQENp0r4SDfP4r1pwspCcnCwftVtPgCN0XWEmi8BneBTg+qqC62L1vhsvahiBDIPW jflSQ== X-Google-Smtp-Source: AGHT+IHYyQnFOeZ0bkKUpgJHbTY9BDXK4PpmbIrqj1QUMBGcrUO2iso/oAoGSvimcTjIPqKnDJN4gFjGtchnSKVHfmU= X-Received: by 2002:a17:906:6206:b0:ae3:cf41:b93b with SMTP id a640c23a62f3a-ae3fbd50f83mr1217317166b.41.1751897469256; Mon, 07 Jul 2025 07:11:09 -0700 (PDT) MIME-Version: 1.0 References: <20250707065711.18056-1-richard.weiyang@gmail.com> In-Reply-To: <20250707065711.18056-1-richard.weiyang@gmail.com> From: Joshua Hahn Date: Mon, 7 Jul 2025 10:10:58 -0400 X-Gm-Features: Ac12FXxPKGyjvhnQbn7ySFrixwb3Te8dhS_ziZKApu5UOVUDWAao8yqpywyODSo Message-ID: Subject: Re: [PATCH] mm/migrate: remove the -EEXIST conversion for move_pages() To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, John Hubbard , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 866AB20012 X-Stat-Signature: m3pxmkyeoi8ptokbk3x1yi1mu9g46tjh X-Rspam-User: X-HE-Tag: 1751897471-919229 X-HE-Meta: U2FsdGVkX1+aIRvZlLJzHswRGbEdbq+YnHQxPyjzunq+gdW3sV1cD5p4hnEm7SdUBgrqyZP/kuJWE+4prrUXHAROZ+2Ke1bf8rkDL3AwF0sNWXrESb+gVLHj+JnEHjT7H4cuePWt2s/K2CfAwfxadNn8bOnriUip2nzrenSvSnHbsY2bYrJcZ0I4Oujdsz62N0pZqDdqIuWLSrBqoTRGfJbhtWlAspltLIIL7x24VKUKbGSY/KCQotUiB/Zj/7bjqrBhk1AJ710lTaKjrn3TcKfomv+eogcyW5nN0JvVMRe2XiWvsME6cjLZc3MUfFPWcN5kK/IXHhLXBdliF6+noVcNQKWJxOjDhIopwE1fipVX5mDng2WbOPI9/b9MO0+P1FfPDyQRDVX4zNGzeZO0j5pjF35xJCnD1N+sMaTalTmoiAiADcG653OA8MwEr8OdK64PN9GS+zC1VA7JksCPhau+8oZfkz93j8K80LA024vakRaETCrySYPKndqRfF6AUZWBPlUj98wHmM3QJG7f3iMukcQnDtdYP8c+cmWbI0m3Gnvffaa8w4K0xR+olanSQXnhN79BBGqRd6xw51vLBLRKYd8HI6k0d6rYtgumN3oF/sgoB33DZ0fAy8MFAReWrAhTfshXow2NRSKy8eo/TyDK1WuV/GVeyfEwT61imWQJbc+pRpr8aJ/0+oB9nrYVEdbLRDx/+fVq/9eh1jzuw19trZPraZeet5IefMorcYasauxMYk4BxzPQP/mBWwqU3tcidnir1r5F1mDeEf7We0tmvlj4WD1AGuMAd3rN7Gken7Rq0eNfN9DXsuRPnAHOHnqUY5GBxNeSe3yBWD/qbNrZNGiKQnvbDRB6xP2XOTsObq8i0PvJN0EXbVGxYTft4aQse5IPs08t7Nh19Z8zE14z42IqvMB9FhIwpRmCjrajYpRqMGc0uOP2XUNQmJkgd5ASx/yjzo1PsLK7d7H Tgt9xvu9 gAoidnFNaKSRRZdOpMmApRnfp+KADZUL1+g6OwAQEVdhBmNG4ZZUnXhQEd6DfCLjksUtAJtvzg4Qw089tH8DGxB751nIOsxTFqqGgLRTRwTpXgEBP8pmYnD5sAM2SNhfnldFRr6BCiWMFNXZzfT0K38xseW3CZ2WUrVjc112CKu8jvVAC5DJdIbAuTFOTmQwDr/2ZGZQ/ioGqoqxphaQaqSAWxWsVuPU/nuC35rtLa6LKbinS+yj7yA/0sMPj2joZnV+Pa9A0De8MlQv1SMENpM4bbOjvfA5Me6ntpf6vpOul6/tAOvl8JNA7hGseKAwYnm82BJrtOj5aeDWqd4j1uW2D4pBzydu9Jm0xQ291Ih+iUIqL6hEEkSrMSANQ60jlg0TMKy/wdHty6e0qhtxfFJt0IZKhrcr+g4Lp5nyNfaSCnLhpk8SpY6gUiZ2OOHFcAmuYhdOU2XsrI/U06niNPtHOjZRNMh3uDOcOLlNqtte6QXZ24gaKz2g3WZ2BA7t1u3yzDS2ETDwZdMaG6GC45OjWk93Ez29JeHgdPjw846A5EorPGl6GcgN9wUzZnLlt0mayZM6SjK8pipA5WazYcTBrAPlqdp/6UleOenkw5NGqieIzSrTBZlE7cQ3QcxxQR6+dWqBPKNT1+7+dMuETLXD/S39UZMJyj3h6hLutbnqOKGcxVnyGSjTUokot61b8PCd3IZ+RehFSaBSFmYBbdv40OA11oMaxARvbjQh7EghMYm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 7, 2025 at 2:57=E2=80=AFAM Wei Yang = wrote: > > The -EEXIST conversion is introduced in commit 65462462ffb2 ("mm/gup: > follow_pfn_pte(): -EEXIST cleanup"), since follow_page() may call > follow_pfn_pte() which may return -EEXIST. > > But after commit 7dff875c9436 ("mm/migrate: convert > add_page_for_migration() from follow_page() to folio_walk"), it use > folio_walk instead. This limit the error code and won't return -EEXIST. > > Remove the error code conversion here. > > Signed-off-by: Wei Yang > Cc: John Hubbard > Cc: David Hildenbrand > Cc: Zi Yan > Cc: Matthew Brost > Cc: Joshua Hahn > Cc: Rakie Kim > Cc: Byungchul Park > Cc: Gregory Price > Cc: Ying Huang > Cc: Alistair Popple Hello, This makes sense, thank you for spotting this! Reviewed-by: Joshua Hahn Have a great day! Joshua