Re: [PATCH] mm/migrate: remove the -EEXIST conversion for move_pages()

[Joshua Hahn <joshua.hahnjy@gmail.com>]

On Mon, Jul 7, 2025 at 2:57 AM Wei Yang <richard.weiyang@gmail.com> wrote:
>
> The -EEXIST conversion is introduced in commit 65462462ffb2 ("mm/gup:
> follow_pfn_pte(): -EEXIST cleanup"), since follow_page() may call
> follow_pfn_pte() which may return -EEXIST.
>
> But after commit 7dff875c9436 ("mm/migrate: convert
> add_page_for_migration() from follow_page() to folio_walk"), it use
> folio_walk instead. This limit the error code and won't return -EEXIST.
>
> Remove the error code conversion here.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Joshua Hahn <joshua.hahnjy@gmail.com>
> Cc: Rakie Kim <rakie.kim@sk.com>
> Cc: Byungchul Park <byungchul@sk.com>
> Cc: Gregory Price <gourry@gourry.net>
> Cc: Ying Huang <ying.huang@linux.alibaba.com>
> Cc: Alistair Popple <apopple@nvidia.com>

Hello,

This makes sense, thank you for spotting this!
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>

Have a great day!
Joshua