From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838E1D5E36B for ; Sat, 9 Nov 2024 18:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E3326B0082; Sat, 9 Nov 2024 13:31:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 992736B0083; Sat, 9 Nov 2024 13:31:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 881876B0085; Sat, 9 Nov 2024 13:31:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7147D6B0082 for ; Sat, 9 Nov 2024 13:31:22 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E51DDA0334 for ; Sat, 9 Nov 2024 18:31:21 +0000 (UTC) X-FDA: 82767398280.05.7A65DCB Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf03.hostedemail.com (Postfix) with ESMTP id 6BFA62000F for ; Sat, 9 Nov 2024 18:31:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bDf6jKty; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731176890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nfzWuC2VKQci1LCs0LoMNHQCT/EDdpW8OmOePIav1QE=; b=SDtLcIDkHhChjal+kyAmaG1LwCXAD6nfC/NaDF9fVgCPXn4vlgmGzXFjUJDykDG2/deLEF Veb6fs91Nwu5IjOItLEqd1dgp/nZ0Nsvg1I1HmQiMiKg79VG8fRBVh1Wn76SqxT1tMntPD I8K8XxJezrpmHNjhDqMFY9ctp4t6/z0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bDf6jKty; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731176890; a=rsa-sha256; cv=none; b=YXW3fjsFQvWR35LPPOmhDAb8RxH5GnV5/PpNNzxY91PmdRYuq4pUttnjOQX0JpMd9engPv K7jdZ4sRSPcoGE0Lu0/HIH6tHKstSQa4WyVGcYg5IoQ9QQfweD9cdQMclpwslamoZhGDzv MzXgdX0S5GqS2IWJKpknq+Fi5eA49Z4= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5cef772621eso3845435a12.3 for ; Sat, 09 Nov 2024 10:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731177078; x=1731781878; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nfzWuC2VKQci1LCs0LoMNHQCT/EDdpW8OmOePIav1QE=; b=bDf6jKtycpBCra+yk+A21aQXcyBZg2r5ZEVLe4fPJnRfx3Elc+QsDcMX2nM+ui4kzG O+U5CyASScBaEXPYrrD8JV1ZQyfXtleoBUI73dh6pe2ncKxd3SdJgc7Cf9bZhvXXCnEq Rh7ObXgkjlyruuy/s1yMpIjXQVkJrGpZl5bNLUpj+CT5zEHnYKi3KBQ893kWG5H233NO T2vQ19cZIY3STMMt4Y+iHzUEPnQ6kyznly9OfFzZDzJQXgv3bIsBCL5x+7d0vvoLoZsx zPJKTznfPnAVseybESP+a7bT7zhYf9s54MuZYlMn9uKmF49cLgQ+lz7v/Sbhz7qSGtqy qFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731177078; x=1731781878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nfzWuC2VKQci1LCs0LoMNHQCT/EDdpW8OmOePIav1QE=; b=p4lDRZH2812cxmcJBDxKQ/x6H6yyU/JPWY309v7crZSJIvPbHPa0A4o1erujzUPhS4 y0iDm/HYTJ5IWDKE5WP2DJ5rZo16ZO2T03ZzwVTIIies1p9ysdgsBuvjjBSny1qYd2Xd mNLpygAgufl30BWmMOc2cOZCjBrLwfpvcfmzvIOcz4q3PWMgwKKhiQ7aHwqI4xmAGXYq Qp501cBSd9Q8YoKpcUza4ksoPE5kFN+whKsbe4aDOjPitPIPDyC/Qy0FxvY+Qb2m+6sr 7fMm9yfhMsrQjU+8ISDRQeNAKVJ/N4YT/DtjNGlcLWweB4SnTzHO8FcH20V7ykSqdVOF vAIQ== X-Forwarded-Encrypted: i=1; AJvYcCXQjr1tLbeu/mYVS+Iwm9PBb5oqlErrSmxa42ioxjjYAzJ8zehTXikrFBqVaEqOa9zaivJD5smmyQ==@kvack.org X-Gm-Message-State: AOJu0Yw3zTJ+Ef8JLaKir3CJP+tIW2b/OPitLkTgKlzC5l89OyIkRugb /bjl8fNOcd0RzETRJFkryhlUgLTW4umABToJRWmrdvHWVqwVDkmyLIdfExStHT9amn2h9vpcCYh /K24kmTtdFwC1U0iD4mrSsPy3I1o= X-Google-Smtp-Source: AGHT+IF0NLYn7BIi/5HfOrx5IQ1AKJhnHgQtzt5a3COJdCArMWWpavCEutjEHDS7K1qQAzfml+9qN8xV04WAvvqwTsA= X-Received: by 2002:a50:8adc:0:b0:5cf:f20:2b34 with SMTP id 4fb4d7f45d1cf-5cf0f202b52mr4319002a12.17.1731177078136; Sat, 09 Nov 2024 10:31:18 -0800 (PST) MIME-Version: 1.0 References: <20241108212946.2642085-1-joshua.hahnjy@gmail.com> <20241108212946.2642085-2-joshua.hahnjy@gmail.com> In-Reply-To: From: Joshua Hahn Date: Sat, 9 Nov 2024 13:31:07 -0500 Message-ID: Subject: Re: [PATCH 1/3] memcg/hugetlb: Introduce memcg_accounts_hugetlb To: Yosry Ahmed Cc: Shakeel Butt , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6BFA62000F X-Stat-Signature: eipkyyagsib9yjahhk8mxsk36axeybgf X-Rspam-User: X-HE-Tag: 1731177062-925914 X-HE-Meta: U2FsdGVkX18S+I1mkilYEYFKypOhZGFjGG8psUzLQOmWOyaw6ka1metDpWtilOsa0n0F6DuwRrLR7y0MIJEnuZx+S+1BFR7nEBMnbOcoEHtlH9Ca0SEg56TAlRQwWBH9OUIobv9K4L8AZJpKWhWgualrKk0jQIBEEIpURfVS3ZXnaMNiGogEuVnQoQk1WbiEfnNMkQKNFTAj/qte/HEOqBNDb/ZVjvag7+beAxKe7Jk11DL7jcod2BB+kckAtRikwZVsWX1w2SxF81TaJd6dHmlcNyldH9wySUKtuAAHeyomwlvK/Aj7fI3SdKLfbTwI/VfkBpSLfhjzK9HXV2kb88tRpE/Qk/S+eiYqaAVkq9CaQqQmj/8ZAiIljzTs/KayE88VA3kcuDB3AV1TjAG6zBUTO3g/YdNZKB39RoW/f06TOz1+b2AMX7EVwt9wsoVr7PslDVOc+dqaMUoxnajhoO496I1FgGXjhCb5LqC0M4Z49w94CTSVvDjSBjGqe5J+oHN6I60C9ueR57e1Seetd2nJOOH+eRxHamQp7BVsg1UUecNR4R0cfaf3ojr/O21vcuA7SQeW+W7ibQ8cm9RXNbVxAk/eSB0iC9Cq1y466T4Z76LlTr1/E8+NA6ZAUoX1kvcIDVLH0nAh0FbI+2V55DfNkJPByvh07WvhP+Wm0sibaEJeqBk+4FstUJSCoiu9fN1d5gJktQhEHb3IVSh2tTVSUZhn9XnaDUSoVftenNX4Z6itOQ7o3Z9bKRMZ8nBVGlNRcowDTBiZjatGTn47dxk/pGFHPW9rDGeTBeHT2nXtvJSS+eMG0YB2KZ3+ppVDgPJmZPyLxWYdKDz8CdC2TpcF9ADPfyfi5AU/idcxPiSCDEz1rxDSXCHW1fYcMZbgCiVkzJyIiC5bLh35Ba7a37yTXBsQ34XI8U2h52XD7aH+7bwXPhaij6MmqmEu29grrbHlrBwSkhExv2JOvyV ZF48q1rw /w4mfHQ9UGL1VatW/NpUeSpGD3bvb9MOIR4rVBBodEe2zuG4GhblsNBQoD3dUA0nrDSOyt6j++vODz8YrXjXQK8LurIbg9nCdocciuGQoRKBqHNRylmw6TjlFHeLRQ2Osvvfrlb1S0RyMsgHDdmLhOA1yXmGo0vKahyxV7kDSwJVSB3+cWDcjbINroDZBbnpx4UFx/pb4A7MeqCdtSUzzgsCsoLLE7VyTlaCP5OsbHrELg6ct1NgZ0OiUJwVVafghk3AH4mAl7rxZ7H1cxa2Uxsqk/n3Zf9siJzck7sOmPLytkifagxT7+P3AuISBg806l2kPe4CN2vFkuQLIiopAz9KZtBJd5HTJ4aBlhsAxijYk0zkjT/s55eOvUyul8yLUJ1GyxzC6wIiJbFSZbLw0a3Qp+YzX91brBIFs X-Bogosity: Ham, tests=bogofilter, spamicity=0.001221, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 8, 2024 at 6:03=E2=80=AFPM Yosry Ahmed = wrote: > > On Fri, Nov 8, 2024 at 2:21=E2=80=AFPM Shakeel Butt wrote: > > > > On Fri, Nov 08, 2024 at 01:29:44PM -0800, Joshua Hahn wrote: > > > This patch isolates the check for whether memcg accounts hugetlb. > > > This condition can only be true if the memcg mount option > > > memory_hugetlb_accounting is on, which includes hugetlb usage > > > in memory.current. > > > > > > Signed-off-by: Joshua Hahn > > > > > > --- > > > mm/memcontrol.c | 17 ++++++++++++++--- > > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > +/* Forward declaration */ > > > +bool memcg_accounts_hugetlb(void); > > > > No need for forward declaration. Just define it here and make it static= . > > Also please pull the #ifdef outside the function definition, e.g. > > #ifdef CONFIG_HUGETLB_PAGE > static bool memcg_accounts_hugetlb(void) > { > return cgrp_dfl_root.flags & CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING; > } > #else /* CONFIG_HUGETLB_PAGE */ > static bool memcg_accounts_hugetlb(void) { return false; } > { > return false; > } > #endif /* CONFIG_HUGETLB_PAGE */ > Hello Shakeel and Yosry, Thank you for taking the time to review my patch. Yes -- I will just declare the function & make it static. It was my intention to group the new memcg charging functions together, and in that effort I just made a forward declaration above. However, I think that it does make the code look a bit more messy, which is against the spirit of this patch series! And Yosry, thank you for your feedback, I will separate the definitions based on the #ifdef. Thank you both, I hope you have a great day! Joshua