From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09DCD6B6D4 for ; Wed, 30 Oct 2024 20:44:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72E286B00BB; Wed, 30 Oct 2024 16:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DE8D6B00BD; Wed, 30 Oct 2024 16:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57EA86B00BF; Wed, 30 Oct 2024 16:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 38CCC6B00BB for ; Wed, 30 Oct 2024 16:44:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9659580979 for ; Wed, 30 Oct 2024 20:43:59 +0000 (UTC) X-FDA: 82731445146.14.590FF6C Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 56BECC000E for ; Wed, 30 Oct 2024 20:43:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O1vg7FTK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730320982; a=rsa-sha256; cv=none; b=m3/LqEJJEmMT7pCCSqKZ5qI7mFNr4F6Z8LRowPtXTcz5l7xkTFn6rtlxfDEqWsID/CQHRL YwWr2XFhrsT8cavplRa6F/D7SKe1RkjWKHs5opde6aO9PDjDr6KqbpVPNAeCV5wp93Dg/8 6iRh7YRza9FRvj18QHv3QQWPd9uGFxA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O1vg7FTK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730320982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNkFV7cr5Y+37qEIiiM4tOnuD78lQyY8VCgnDaJjAGY=; b=W2fi7rhHwLLFIhFSMpHZEoCJKnOZ32ONZXVIR9Y48012lA+/DJ+NS9K8Fck+3X2XTdXzdG K8EyPQsrqJxCXZDdNbXhMpq2nO2K0eFKxwaMtT18v2+1/WuW2zVZ9YyZCNgwiuY9tGOGlA 8EJBMmDgca8yvpOjiFznyKJfXox73Bw= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2fb4fa17044so2021561fa.3 for ; Wed, 30 Oct 2024 13:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730321036; x=1730925836; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JNkFV7cr5Y+37qEIiiM4tOnuD78lQyY8VCgnDaJjAGY=; b=O1vg7FTKLijIVLNmMiYW6FaKiBJjwrc7w3Ohklfh8H/VhtOHXOyHaa539K4ibpPU9e jiZiusJYIVFSOKFII5opq5GcLKkxlnL/BkGIJgUFAsfynYHUMxASYXxQOfcdBdmqsnQG a+JKEuVjXzYTyX8CWqJ+gSK9rqWPbjWAeGhZvAhrx+zr0akQIFcxsoziHcmzJ6Ij7OyG fmi3oKevolTPbY5mDiP+9wMgAMZxnVcs1AslKnBQIZHDWDP3iFIaruBbdYV1grXTZRL9 0aCgQfMM9mTnO7HBzwkd0B8Ph6AKDdko6y7mphTWngb8THn889CAzq1B/ccA056xl/a6 AVpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730321036; x=1730925836; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JNkFV7cr5Y+37qEIiiM4tOnuD78lQyY8VCgnDaJjAGY=; b=GgLUG4uuI+djAm1Hp/fGvm6HqZSjs0TtpB4fUswBIi9riTSNYj5fm1WWvzBnb8IkZ2 LecPaRFY9ZxA1TCTR3LIMFKVYJRdiAw/M3K9Kas0Fj0m9rDygdfmjkxx2zGHy8EioJek N1JteCwdadMzXS6svI/H58n1ikUzXSnyJzrZIE9DiYCe5AEuIf9mqboa1YHEkwkFZmKh BsQg1jrDmlKm9ifND4sMDKOTANpWO4nEAv+0R/eMaQ84KWUZIvYiurbH4pZ/uCMM2nG3 pg1/yesr7IpVmvnlxnliMyA7z9UcM3ByvhYGGTx8RbdMINgI4Tuz6sZMRnQsEG0JvfyN Gnwg== X-Forwarded-Encrypted: i=1; AJvYcCXtNWtAaIkA8apZ8/cUOS1WgXawamBS4OYU/7l+W7AQBGQ7YsGCxMCkseYBPOAyAkK1JVAQR1W2ZA==@kvack.org X-Gm-Message-State: AOJu0YxsUf/iR3ju3wLsnBnBMpMwuYryMgOMH4zGTl/8hBd09AR/aDa6 TZK5DqZ8hbPs0XQl79PJ0sUI2R9tKcdozax1VUgq9XoyvhizmMl67FSIJxd3Z/0Np672vg8JtbA UwZrL1pDixF/rsV1yJUenrM1Yi+8= X-Google-Smtp-Source: AGHT+IHwIVVPUQ6L4Z9pcPhSrmOucAHyfhtuRc1A2IaalpGTFNzP3GwdIuDPmFnxjOl0uDTjW9q7jnoMgwVaZUIENeM= X-Received: by 2002:a05:6512:b8e:b0:539:8b02:8f1d with SMTP id 2adb3069b0e04-53b348df014mr7797157e87.30.1730321035576; Wed, 30 Oct 2024 13:43:55 -0700 (PDT) MIME-Version: 1.0 References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> <20241030150102.GA706616@cmpxchg.org> <20241030183044.GA706387@cmpxchg.org> In-Reply-To: <20241030183044.GA706387@cmpxchg.org> From: Joshua Hahn Date: Wed, 30 Oct 2024 16:43:42 -0400 Message-ID: Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg To: Johannes Weiner Cc: Michal Hocko , nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 56BECC000E X-Rspamd-Server: rspam01 X-Stat-Signature: ea186cp7rxndmxp59ym4rc1izbp6b9wy X-HE-Tag: 1730321005-1716 X-HE-Meta: U2FsdGVkX19zB3HFYOvmakaVeC8fVdCETPp5B41TM5OiN2icBj3iEHLZEWWneOZx/JoA0M8ko3qsLf3c0j+2MPGiWM8D8sow60ipDqeYw651IPkxM8+I25+BhUQmNgTQMvq6qUixDvoUZ23aGJHgulK6q0wPZNJgbBipH6Ms8FSgq/6RPUjdn7NtuSuqZWxbjCt48a4QE9KQCruT7KLFQmy449o7ZGOoMiqMpRGASZq8W9GtR/MJHLEZ16328KzQdRuhJVvuYzq9BVrObjQRZvobV9FwPaHC289DyByMS8YdGiGwoNztGxGStddtO+dLZR6uPqZw2Bh4iF/bDc3vz4+Ad0tb1o4HHBIegRjixFjq05GdwYxKeImCWePAee3hGe0BVuW3FtaFsBaRbtDdP/5OKnUwTAugLZ68kZ5e0ip9u/dKwXMT2NWgbSjxJETr97f+kG0hN9lJRZsYFU4UkJQk/e0w0qk7eF+tQ8Ff2Z2QR3AP5q1Nzg0H6BiXpWbIHxkymh/oWnV8Mh88+gSitPHvHJJzHbVr7/QugbHYrps3NiPrKFs6iQqBnulJfeMeFL53r5axtHZu8GYhmN0qWGKW12WKi9JL3bsIGBp/2cIFotg9yr8eXaFf8p63LKtFZqkiPMiO7PO0tDXnb2+ChoS+P/ahZIiAMyD4AZGUJijCyuq1Zg2+8tO3/U+QtV30K9TvkY2E+eBghclYhKYl1q3H071/+bvLUCrmQ6b+1DajqRgiO9ya7QKPWmfMiMtXFhUL2PbjUmige5wfiAzpzEM0T9B3re3lZgEEbrrfa+s8qLZrXal1FGQILJDhwZe2FWJnqE8x2Q/nk+ErhBytSKP5OqzbdzIKPZ5/w+2jbqbMo5QkxQbIMpcIksWXAihwzGnClw2QDVz9d35WN6yC041ll5WBVuy/C+NKsSu6do6V8p1/RUpOoAJN5DnBoIZHlZQrvkjcNg2WQ3UPO2c Xn32FZfG FUxs6fqutQdRL6XjHIbGCrgZDY9hh/dzrJuiaXIkfOJGPvo78FfTaDELbPFV/EXeGShwTbZ9WzBDjcNZDYhvJuWaxU9SZu/3KkI4vNy71xlXy0nUOGvbMHh+6i1xlL/nG5CKb5LZ7v+W/vDwQfcCLSYENOdnKuoScCFjnDJaHRXDwSJOUH3qE9UR1aZMEJYltch2gkxSoyv+5xDYAR92R0QTfKnd7kxEK+DIn5tcoDLgkyHV1QxXP17m8hlhH9bq2fp044304XuM5eiqxmZyUOgLX6dKZsb3CR6LP4n1AO8FqvJa0U3ol9goL5e6v3w4fvpinIce0TUo4QhTwJdwxoRooZOK2HUHJonKLDsnoXIfxBhYroYUZWyfZo6k8lYTXmzKEcQKgZ4/NSN1YG5+SNdNknbHnu/hQ4cBHbrrcMJnMQAOVPNwQUiDixe6TCi5RN7l0Uc512gM9AXo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000331, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 2:30=E2=80=AFPM Johannes Weiner wrote: > > Joshua, can you please include something like this at the end: > > lruvec_stat_mod_folio() keys off of folio->memcg linkage, which is > only set up if CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING is switched > on. This ensures that memory.stat::hugetlb is in sync with the hugetlb > share of memory.current. Hello Andrew, I saw that it was merged into mm-unstable earlier yesterday. Would it be possible to add this block of text to the patch description right before the footnot= es? 3. Implementation Details: In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio regardless of whether memcg accounts hugetlb. lruvec_stat_mod_folio keys off of folio->memcg which is only set up if the CGRP_ROOT_MEMORY_HUGETLB_ACCOUTING cgroup mount option is used, so it will not try to accumulate hugetlb unless the flag is set. This also ensures that memory.stat::hugetlb is the same as the share of memory.current that is used by hugetlb pages. And could you also update the list of signatures to reflect the responses on this version? Suggested-by: Nhat Pham Suggested-by: Shakeel Butt Suggested-by: Johannes Weiner Acked-by: Shakeel Butt Acked-by: Johannes Weiner Acked-by: Chris Down Reviewed-by: Roman Gushchin Reviewed-by: Nhat Pham Signed-off-by: Joshua Hahn Thank you so much, I hope you have a great rest of your day. Joshua