From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E4BC43465 for ; Sat, 19 Sep 2020 17:45:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A019207FF for ; Sat, 19 Sep 2020 17:45:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tNG/7qgf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A019207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB9996B0037; Sat, 19 Sep 2020 13:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D68266B0055; Sat, 19 Sep 2020 13:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C08628E0001; Sat, 19 Sep 2020 13:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id A540D6B0037 for ; Sat, 19 Sep 2020 13:45:56 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 74764362C for ; Sat, 19 Sep 2020 17:45:55 +0000 (UTC) X-FDA: 77280539070.27.table92_5e0c07d27135 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 5AB273D663 for ; Sat, 19 Sep 2020 17:45:55 +0000 (UTC) X-HE-Tag: table92_5e0c07d27135 X-Filterd-Recvd-Size: 4794 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 17:45:54 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id d190so10740158iof.3 for ; Sat, 19 Sep 2020 10:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aqIvwdnOSjAHddCU85P/HSWVpvwA3NGs8Q6mRONCYtU=; b=tNG/7qgfSv3KJKzY+MtjBYmgHCdp8UBgqNItDe5F7FDIKPe9kRM9dYX/wgxXsNeKo8 hvT7jE5V1Z2gTTVHOX9IbUL0r3c+bFPouhMS8i0S2Hww2xsCe5QUx8/3hWfvFbLyYkhM Zae2R0aP+aMy8+LWGHImo5PHglLppa7IT4FZbWFEGn/vetxq4vLC8MOPaN8blQqjCBqY urMyvw6jy5CONCdw/aKWal0YXgq0H2g1qUBUo9OLGICTcy7ANwD8JqNteW5w7WKfYARV CS6LRAFQoUr8/66nYQScOHKrJ37vlpX/p5EOjhSTfM2i9DmebqlqqMvFwu8r1y04VDM3 sCpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aqIvwdnOSjAHddCU85P/HSWVpvwA3NGs8Q6mRONCYtU=; b=Oo70pkdw2Hfkdf6+K/gGJAyePBG+ad/3PYcOiz+yZH/ZlyPWYxPHA88eh7jluHnFYY cQrj+KaWhCZpNk9tTPUgN98qGihREiWg2u7kuauDD12WA5nR11E3u0NLEBnMqbYyUhVq 3YDne+wtHMbrkdjIOipWlQxR4VYSXZwY904XLwvJgmqos1dtKW5yY0j8+6Nj6jsTAM1R NvTEYzJnkrhmPAdusNQ7EgnXtcd/YEl0ZU6uQDcT948GHRlbbeFJ4B7PDiuDuwKmiEkv KzKLAXQ9UOF0X4Y2AQsJuf31p6Sn2L4HwlYAq/tdc7hFCxWYw9ejSWRnNa3Rxg8sxVlo EWBA== X-Gm-Message-State: AOAM532uyMUby+QLLd7SuNkxF57ij3D/U/LubLDI6LLYMOvB79v66IV9 C4xsB31q6Vrvzblf+82hdq8awrW77h1y6FpbFw== X-Google-Smtp-Source: ABdhPJy/+swOxx+O/gjUkATrtV+0W+I/532k4HwgKzgpB8LaS3UpaasFbGc1h4Q07NmdRoupikU1hHQEg5Ygt1lOBVI= X-Received: by 2002:a6b:6c0c:: with SMTP id a12mr24437450ioh.40.1600537554347; Sat, 19 Sep 2020 10:45:54 -0700 (PDT) MIME-Version: 1.0 References: <20200918132439.1475479-1-arnd@arndb.de> <20200918132439.1475479-2-arnd@arndb.de> <20200919053514.GI30063@infradead.org> <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> In-Reply-To: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> From: Brian Gerst Date: Sat, 19 Sep 2020 13:45:43 -0400 Message-ID: Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro To: "H. Peter Anvin" Cc: Andy Lutomirski , Christoph Hellwig , Arnd Bergmann , Alexander Viro , Eric Biederman , Andrew Morton , LKML , linux-arm-kernel , linux-arch , Linux-MM , kexec@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: An alternative to the patch I proposed earlier would be to use aliases with the __x32_ prefix for the common syscalls. -- Brian Gerst On Sat, Sep 19, 2020 at 1:14 PM wrote: > > On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski wrote: > >On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig > >wrote: > >> > >> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: > >> > sys_move_pages() is an optional syscall, and once we remove > >> > the compat version of it in favor of the native one with an > >> > in_compat_syscall() check, the x32 syscall table refers to > >> > a __x32_sys_move_pages symbol that may not exist when the > >> > syscall is disabled. > >> > > >> > Change the COND_SYSCALL() definition on x86 to also include > >> > the redirection for x32. > >> > > >> > Signed-off-by: Arnd Bergmann > >> > >> Adding the x86 maintainers and Brian Gerst. Brian proposed another > >> problem to the mess that most of the compat syscall handlers used by > >> x32 here: > >> > >> https://lkml.org/lkml/2020/6/16/664 > >> > >> hpa didn't particularly like it, but with your and my pending series > >> we'll soon use more native than compat syscalls for x32, so something > >> will need to change.. > > > >I'm fine with either solution. > > My main objection was naming. x64 is a widely used synonym for x86-64, and so that is confusing. > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity.