From: Brian Gerst <brgerst@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Theodore Ts'o" <tytso@mit.edu>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Xin Li" <xin@zytor.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ingo Molnar" <mingo@redhat.com>,
"James Morse" <james.morse@arm.com>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Kees Cook" <kees@kernel.org>, "Nam Cao" <namcao@linutronix.de>,
"Oleg Nesterov" <oleg@redhat.com>,
"Perry Yuan" <perry.yuan@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Thomas Huth" <thuth@redhat.com>,
"Uros Bizjak" <ubizjak@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-sgx@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v3 2/9] x86/entry/vdso: refactor the vdso build
Date: Thu, 13 Nov 2025 17:41:50 -0500 [thread overview]
Message-ID: <CAMzpN2gC1NWFu5XG49cCrktTUZbDBbng71RjpALMxzSOmPrQPg@mail.gmail.com> (raw)
In-Reply-To: <1cd27f96-9f29-4607-90d8-c98593eacfbb@zytor.com>
On Thu, Nov 13, 2025 at 4:12 PM H. Peter Anvin <hpa@zytor.com> wrote:
>
> On 2025-11-13 10:38, Brian Gerst wrote:
> >
> > Some of these changes (like moving vdso2c) can be split out into
> > smaller patches.
> >
>
> Sure, but is it worth the extra work?
>
> -hpa
>
The vdso2c move would be a clean patch on its own. The rest would
probably need too many intermediate steps to be worth the effort, but
it does make it harder to compare the new and old code. Not a
dealbreaker though.
next prev parent reply other threads:[~2025-11-13 22:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 20:22 [PATCH v3 0/9] x86/entry/vdso: clean up the vdso build, vdso updates H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 1/9] x86/entry/vdso: rename vdso_image_* to vdso*_image H. Peter Anvin
2025-11-13 19:31 ` Andrew Cooper
2025-11-12 20:22 ` [PATCH v3 2/9] x86/entry/vdso: refactor the vdso build H. Peter Anvin
2025-11-13 18:38 ` Brian Gerst
2025-11-13 21:11 ` H. Peter Anvin
2025-11-13 22:41 ` Brian Gerst [this message]
2025-11-12 20:22 ` [PATCH v3 3/9] x86/entry/vdso32: don't rely on int80_landing_pad for adjusting ip H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 4/9] x86/entry/vdso32: remove SYSCALL_ENTER_KERNEL macro in sigreturn.S H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 5/9] x86/entry/vdso32: remove open-coded DWARF " H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 6/9] x86/entry/vdso: include GNU_PROPERTY and GNU_STACK PHDRs H. Peter Anvin
2025-11-13 19:09 ` Andrew Cooper
2025-11-13 21:13 ` H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 7/9] x86/vdso: abstract out vdso system call internals H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 8/9] x86/cpufeature: replace X86_FEATURE_SYSENTER32 with X86_FEATURE_SYSFAST32 H. Peter Anvin
2025-11-12 20:22 ` [PATCH v3 9/9] x86/entry/vdso32: when using int $0x80, use it directly H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMzpN2gC1NWFu5XG49cCrktTUZbDBbng71RjpALMxzSOmPrQPg@mail.gmail.com \
--to=brgerst@gmail.com \
--cc=Jason@zx2c4.com \
--cc=andrew.cooper3@citrix.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=namcao@linutronix.de \
--cc=oleg@redhat.com \
--cc=perry.yuan@amd.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.weissschuh@linutronix.de \
--cc=thuth@redhat.com \
--cc=tytso@mit.edu \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox