From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFA6C77B7C for ; Thu, 3 Jul 2025 02:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 218466B00F9; Wed, 2 Jul 2025 22:54:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9136B00FA; Wed, 2 Jul 2025 22:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 106D66B00FB; Wed, 2 Jul 2025 22:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 008426B00F9 for ; Wed, 2 Jul 2025 22:54:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 725AF107274 for ; Thu, 3 Jul 2025 02:54:03 +0000 (UTC) X-FDA: 83621433966.07.A8572FF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 3E5F440008 for ; Thu, 3 Jul 2025 02:54:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iyywVqpp; spf=pass (imf01.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751511241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8WjOSSzl9i5hwKcEFLqL2mkoftabsoi7XWLQ81Rdfaw=; b=cmRzUVvth5tzb8ELHLPS7tphdnPDBQot4g75jTZbhmZq4KGqMbI7X9MWC6QojC2KMeErTR 8gszVkJmfd8Sid+AD1EzjrvbYJb+4pu4G8LiTt72VRWao71nNTAsKoMGv0428Kw9gy/SOj FnuPV+KWytVtiM/ohbFoYWwcPx8WCvY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751511241; a=rsa-sha256; cv=none; b=Y4m+lwt5fctNndUQgk5FC5MiJpmzNdVoaIUurtOlSflSo7GYi6dbfLoWzmiq62/PQUOdf+ DiVD+m9A5BDQOK3u2AhTVZYQq0QtC0nSQn6tEh20AWDo6K46khUusuNUuGLxxC6AdyCY3p TLIhvEI3TcJ0KOcRS9lN2D0nGLir5oI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iyywVqpp; spf=pass (imf01.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751511240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WjOSSzl9i5hwKcEFLqL2mkoftabsoi7XWLQ81Rdfaw=; b=iyywVqppRBdQO4Y89CW48ZPJNIQ1XVcC7UgxwHbN3iSJp202DEloniup6ZACSfKlqQVD7+ o0BQyMH2ewtRzzdY3dA7LKpbC0EDdLHDIKxkPBVemyuOzgBpGdhkzYeVJ57FY38Ojba6Tl nRJlWLcUcFqKxoESGGeT0Rf7LT75Gxw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-2ReFWtB-N4eVFo5AfN6iLA-1; Wed, 02 Jul 2025 22:53:57 -0400 X-MC-Unique: 2ReFWtB-N4eVFo5AfN6iLA-1 X-Mimecast-MFC-AGG-ID: 2ReFWtB-N4eVFo5AfN6iLA_1751511236 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-31215090074so8926176a91.0 for ; Wed, 02 Jul 2025 19:53:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751511236; x=1752116036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8WjOSSzl9i5hwKcEFLqL2mkoftabsoi7XWLQ81Rdfaw=; b=pr1G/FKQO9f4m5u8Iht7i7tjshYLkj9lzzmEX2MKWDPnETRBpQ6USMpKs8oizCk5o+ lRfEY9Rt40iV8Vmm5IC5jprcpsv8IYZ/62nqLg6tCYCkwPQ73iJA4N9lEtFePoFJ9phm 4WGT9EMk0QElgSpNairEUXs8KX28vYeWNk+r/J+M66pinniO9EDGIfnoJVq7SAAQ1r75 atu0ngzu90aoAsM2elGVE2ksqPrkAKb64rO2tW2cI1ycQV148U81PEEgXyNjFbHbRSV4 +xF0MUbNqzGZyVf4nnZ+lQ2HiWl/6LgDTzt/BU/aWL/Rz+/ccK0ZdCd4qLpkB6j48ylX X0bQ== X-Forwarded-Encrypted: i=1; AJvYcCVneiyR6nNB16ZdYLl6tTLo2nicDkp8uX23Tkstw1cvX62pYgJoGaY0DW+oURnfh3DG1+JztEZDJQ==@kvack.org X-Gm-Message-State: AOJu0YxqvqVvIReeEx/EbNmp0gISm85jzWuUm5NZmdBLC3P+CNMnY+C/ tAwVLcGv/V0CqinOzNqmQ95WzrFcyuWZw/53RHVl/Jn1fiNi3dnwZdd4UHt8F6rW8LWt/51wJCp UMLgBi1jvWGZMmlL9ZZa3K5yrlRE4wnCMDbxcdHk4O8gLX7u7WfHTCTrVjI0FaCO+uRHaRd8NE6 8j4aFV9YnfBVE4825Bw5N8wg7r7UM= X-Gm-Gg: ASbGncur2D4VGB0NRj+HGLOU31KlMYFacAMz1jyAnEV0MePkkIc3JqC81rt31QdDdgx yfARhzvh5w3Qz0IWhaDWylLRkSMWKFBXKeM+Caxe7WuPd7cX+XqTQdabCsLE2G/j4yLrJJKybhF FULg== X-Received: by 2002:a17:90b:544f:b0:311:a314:c2ca with SMTP id 98e67ed59e1d1-31a90b112eamr6468308a91.6.1751511236052; Wed, 02 Jul 2025 19:53:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQ0Xb9fVsUanKrj9SJ4vz5CwsHLm4J8mEWNpGvRrcL91HtgZSgYiDwJaegQOLaUORsw+a8ntTg9xrcftHWllI= X-Received: by 2002:a17:90b:544f:b0:311:a314:c2ca with SMTP id 98e67ed59e1d1-31a90b112eamr6468284a91.6.1751511235652; Wed, 02 Jul 2025 19:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-18-airlied@gmail.com> In-Reply-To: From: David Airlie Date: Thu, 3 Jul 2025 12:53:44 +1000 X-Gm-Features: Ac12FXzoyceVxp-9CmDA-WGGbRF72A_pItim0nylHqazTjwRzjAE3R0S457FDxU Message-ID: Subject: Re: [PATCH 17/17] amdgpu: add support for memory cgroups To: Shakeel Butt Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig , Dave Chinner , Kairui Song X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: je1dXPF757sXbG-MnAMeBdKHtyZcnChRzfzwlL7oLcg_1751511236 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3E5F440008 X-Stat-Signature: nunwcm93dg3bdcxzc1dwtetto9c4x7q4 X-Rspam-User: X-HE-Tag: 1751511241-625495 X-HE-Meta: U2FsdGVkX19Z4MohqA4Dpw6V5nDarjQONXhMt7Cu5+8aoZZ7ab18FT+vZAaJSlVwheZ9c3QkC+QPp0at2SLL7sl2HSPS7cIqFoGr7h94xuvMHGW8r7FKhLLwbD0F1PZCfDLt6ozXRqffFEpk5gVwtdVLrPGfep14XkAdbW0oOYR3WNIfCyF1cHEftUFlCKlux79zNIkyPfKNcRDiSIdLkDMJPEWad5dkUohvIrBHyZwp5enKi474ryUVX4Slnh2DKa/BEyk2F27ZA4qgq0i6HdSAc22iArYQXeDtnp8AY4zkB7sf2t4cA8PYqIEXMAHCwfnQi4q5i2n7w5BXoXs6DasgvSPkEA7f8im6uR2pF431bkTkrl9njBIuJ++qFB0UrwN0NfB6SmVlDQCZjro6LUBZjipOlRqeIol8zbO/rTurY/nM7sSfVOOrvjm2SAisD4Y1mnyse6AFy4VltbTDvWDG/LwlnJX2eMaSeBKRQMuvIL7vqQzSt8MLgmmEoME8CyXMcfqTTtP0NjvL21x5ZXm783ZCTNuxPsMyP8fpWn8bcBxKIQhJ+83NbXMenjJhp2ExDafe4Wm8nB1/J5jc8xNY1UEr1SsrFKpt60I7qfE0YZd8QcnP+jwqED4s18XaQ3z+UqEFgU1jFAfJG6raLfaV72t2CZ33j3Vy8AEz/Uokw7bSmCEACQ7AfENM+h1eqF4UZbCDKKKX5LCCkNew7JigfRjAdVRGCk6eJ//PXFOdztVwh4xQisq1KJfXJQs8tJYPtB9s4wGrUqeSZt6oD8vRH26rRLBVDeS06PE1HF5YJ0IM3g3Lpt45Vm9RmyZnSF81Fi9RLA2kHw99PCTE9SmZb58DJWOZbP3FM46z8kkwSTevttGTj1cWP4ZxN7ERzYf0ckAeluWWjlv6KIbDsaZSgJSPHJWXjEpQh8RvAouxXyVplj6TdZZ7ycsA76AI3lJByRXwR8OtOTmer0H u184NsBB 8PxOi1J0wkuUSuprKFW4C/I8Iw4CI5I2s4hBfkrwOUUpZZ+U6s5bQXluTZsWhRncCZfGXzSqdaixLbreV+EKutZGrw080mtZfSzWXMcuRO4zf5z95EO0sO0Wf1roj2Hy7aZPtJ+/74oIdOgVZA7mqxsceAi7ZqcSXlUCfbuMtzaUNS4lyt0z8Cj7JssHnwfG+oEPjAGEEE95zXTbG3Ic5c7Kbq6KQsTVXnHKdCUxkrOAQat/IWY3xUgGvmng88PnUs5XO+I333vU+6U7e8CaOPpVH2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 3, 2025 at 2:03=E2=80=AFAM Shakeel Butt wrote: > > On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This adds support for adding a obj cgroup to a buffer object, > > and passing in the placement flags to make sure it's accounted > > properly. > > > > Signed-off-by: Dave Airlie > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 ++ > > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 13 +++++++++---- > > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ > > 4 files changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_gem.c > > index e5e33a68d935..d250183bab03 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > @@ -198,6 +198,7 @@ static void amdgpu_gem_object_free(struct drm_gem_o= bject *gobj) > > struct amdgpu_bo *aobj =3D gem_to_amdgpu_bo(gobj); > > > > amdgpu_hmm_unregister(aobj); > > + obj_cgroup_put(aobj->tbo.objcg); > > ttm_bo_put(&aobj->tbo); > > } > > > > @@ -225,6 +226,7 @@ int amdgpu_gem_object_create(struct amdgpu_device *= adev, unsigned long size, > > bp.domain =3D initial_domain; > > bp.bo_ptr_size =3D sizeof(struct amdgpu_bo); > > bp.xcp_id_plus1 =3D xcp_id_plus1; > > + bp.objcg =3D get_obj_cgroup_from_current(); > > In what context this function is called? Is that the same for > ttm_pool_alloc_page()? Is remote charging happening in > ttm_pool_alloc_page()? > No, this function is called from userspace ioctl paths that allocate GPU objects (GEM objects). The objects are lazily allocated, so this might not trigger any pages being bound to the object, until it is populated, either via mapping + page faults or by being used in a GPU command submission, which is when the ttm_pool_alloc_page happens. Dave.