From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C39C83030 for ; Thu, 3 Jul 2025 21:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0D546B01A3; Thu, 3 Jul 2025 17:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBDBC6B01A5; Thu, 3 Jul 2025 17:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3AA6B01A7; Thu, 3 Jul 2025 17:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9AA186B01A3 for ; Thu, 3 Jul 2025 17:22:37 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0AC24BC02E for ; Thu, 3 Jul 2025 21:22:37 +0000 (UTC) X-FDA: 83624227554.11.46FC553 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id D3EAD20003 for ; Thu, 3 Jul 2025 21:22:34 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sgnq0v8r; spf=pass (imf03.hostedemail.com: domain of airlied@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751577755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hj/RZV132CEm1ornmujQIV2oN5pOhDeHuqZxkw4e3AI=; b=Bwe8P4BV3CDh7NpB6TFHwoFA8vwM3EQjAJPDKjHN3eZ93Tohbk/9FHw5F4CitzXqUA4RvI Xgqj2l9iJ/Pc9LWvF3PkEr1D6HDoZm7+gYqtDAd24CKBl8XvUEmxe4wu0FxolTVoOojywb ZpNDIn/6poY77eIH8tDR5imHFfzh5t0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sgnq0v8r; spf=pass (imf03.hostedemail.com: domain of airlied@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751577755; a=rsa-sha256; cv=none; b=Ts7VeB+6unS17dvf1N1uyC7TESCk7XF8HR3SxSoznfI7nb81jzvxk1FyeHJSqgVcmeQ6MV 050pRsdpVVr64cT+2o2cDfaQVyN3x0M5bxQdJchc6QTqgWEfcT2K/ykpQXZ5SgBGKxcRWw x1cL/tMBRx2njTX7lz6AljLs1LtuTeI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751577754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hj/RZV132CEm1ornmujQIV2oN5pOhDeHuqZxkw4e3AI=; b=Sgnq0v8rOiWiZCBiN7q7uuGcrHhVJ+DMflsznGGAqdPYkfGGdUSU6iUwpzzFI4DE5f/Zeh 9VJ7zomAIQYHW3MrlEYSeiYr5L8L82L8qOEluLK1luyf5jdHikO3S/9UprN/qbgWXrdBFb NbdDGBedrqLXRJpDcEQJvHMv5NxPD48= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-LCjmq76xOiuMnt_1pBPY7A-1; Thu, 03 Jul 2025 17:22:33 -0400 X-MC-Unique: LCjmq76xOiuMnt_1pBPY7A-1 X-Mimecast-MFC-AGG-ID: LCjmq76xOiuMnt_1pBPY7A_1751577752 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3138e671316so210859a91.0 for ; Thu, 03 Jul 2025 14:22:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751577752; x=1752182552; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hj/RZV132CEm1ornmujQIV2oN5pOhDeHuqZxkw4e3AI=; b=cCKF1t8VAgfvNKzDD8YocUNWrBnoCi797RpvE/w2+I4RFuBWVi9OH+foDQQiPmBJTe SIBNJUvHlz71+kdRCgZX53bMNXoaVrBVDkEwCFM0KkFvPWsB9nYCf57xyI07rLe7iNus QZYrRCMFxijwDqsJ+nyOEEWMuywnXzm7ahJtcIi7xK8OuBL3d1Yggn0aeLUaaIPnv4Gi rK4pajl0crBY1KOEzeSYN9S6/tjvGrYXRFt6LbREM4rNFE0a2OruhJjiZyEGSuDW+jD/ 7G6VTTzW1pySVIEkn5BEvJttI6B9OnoSAxugqh3HCrz5c8dLy/fSzyq+kfBDDAK3NkxB kLmw== X-Forwarded-Encrypted: i=1; AJvYcCVwsQP+8jguOa7v1NrnJOzDPJJSdlVuaVux+O8F3ejy6Fkpb5EDjzjuSR/n6C3Sd962BPropmnG6Q==@kvack.org X-Gm-Message-State: AOJu0YzK9K/AjWAF2LUccgnUwWnNrFDsunth47hJOQ+cRELa68hFBTnp fcDfbuMn7Vh/kkNlqdVgF4wSJgS0gEwtyOrgqukb8aT+g4zZrm6VVdGWFzariDTNqh9lGdil48/ mXDbFSgXfBs1MleqclJqMFaT0OZmszE+cvZt5g0FzdFZQ8AHJB4skpAXuXKXjnWt///E4gzwWb4 enLg2EGZ2mEcMjWeyEPLNakVzq+hk= X-Gm-Gg: ASbGnct/4ggbdlwfCJ3acjWpsddbkOZ0D/qsGVyQMFWKFjHWzxes/avdxTxGMB9albb mTHf8NArrBO0hZO/Sn+y9d6Z2f4s2TyhrstKTHIB1h6Oq3uL+NIfyU+BuDGdF1CKfVwTd+xcKN2 o1cw== X-Received: by 2002:a17:90b:288b:b0:313:aefa:b08 with SMTP id 98e67ed59e1d1-31aab8ed31fmr517325a91.16.1751577752277; Thu, 03 Jul 2025 14:22:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfGS4zw2IpBk5STJ0Hm0dnh1KNZ245qqlOIaPU/7TdkTGJTG1oQZNFO9TWe6ekxtILRdjuSItsclw+H7tjcss= X-Received: by 2002:a17:90b:288b:b0:313:aefa:b08 with SMTP id 98e67ed59e1d1-31aab8ed31fmr517305a91.16.1751577751937; Thu, 03 Jul 2025 14:22:31 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-18-airlied@gmail.com> <3b5t4djauhnbvhqjwuktrcphlvahpdyi2b6j3ktoapakxcvpgz@zjpokeykiwy7> <0b887b01-6de3-4633-86f7-20f5b43eeb35@amd.com> In-Reply-To: From: David Airlie Date: Fri, 4 Jul 2025 07:22:20 +1000 X-Gm-Features: Ac12FXwU62okdCrSxmcxw0FH27VG5IbHzWriW3mZObaAGPhhechQmL-w2YyFi20 Message-ID: Subject: Re: [PATCH 17/17] amdgpu: add support for memory cgroups To: Shakeel Butt Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Dave Chinner , Kairui Song X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v4so02SusOMuX7pU_DXTyIQ6HdCUlOiH7MOsAQdEoEE_1751577752 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D3EAD20003 X-Stat-Signature: qcc9uxxfwuw3368gtruwfbjh5g7q1pks X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751577754-125963 X-HE-Meta: U2FsdGVkX18conP9tNo3L4l0WCXFBNOEmk5eyIYay82zh1woQweqs5BcIO8rHLW4hetxJ7xU37m9RhiO3US91GIzqCk5KWdiUoamS2z3FaDS0YQjRCnz46WBjlfIC2CvIVgQEJAMsS5xAvvZ1gd0dRiR8fzUjR9qoQre4uaOl00h05+NrKnjKLBM9GDaRL5UTif1N2OWqY9ssZEoYuT/Rr2k2GQSdu0mUpxIJQlPV096VCTRKGJI5QNfmLTEyZ0FGAyd4JMiC2WNV1gtDYGJCu7BjB573OppemWV8/aXK1iqib4wIiceNllZoGS6yJ+qp6Biak9Dt3ebyKGg5Lc4iEDrlx38tSXIbiP1mi1CS4F7HOZE/8kbbFzrk95eHk0mNVrZ9WXUjLhtaKORcdzl0R3sp5UZAVBxoQp6jnhvh/U/n0BEdLsn//TAyjLSMAWPXwt8dtG+BQTZcWlVr45ovdVZhvN0A/E7qD4RaG04R0HMKFU7KMU7nEZM1KF1XXWQYOMQmLWaMxOfESjPrOgwXSlqyvfGr6N2mWSU2IwghCtUMpKsK5dtVhIbcm1ziD2ypReYG5YPOQNci7D5SV2zZ2CBIeBz0m8R8OwzPTNjQbUQXmDxAmpx2NQAz7zsEp9I60GfrLUbLvV1ssDI2CN+3kcl4qUKkQcFioSNWA1aFmlMnmFNLk8ImAiStV8MtH83eboaUS62Jhb8x/K3JDwpiUpblNPbvDcnIL9ab53zdzc+5/aHZPFtOoQs92gw8aJkKtbZ8ymKfPxlkCSYUw+UjcUTZ/yRGYFAvPYM88KqNyhGUkDnSlvnrdUtbtl4teQ3tRlc8hkz25O931bG/GB2BsPcM65gGOH24PjvGmzcBN5GkuismrnQ8C7avQXA8I41db9pN2EkyLgdKkioD6swy76haHHBHXTTCNol/9WTqy0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > Do you mean a task in cgroup A does amdgpu_gem_object_create() and then > the actual allocation can happen in the task in cgroup B? On android and in some graphics scenarios, this might happen, not sure if it does always though. We have scenarios where a display server allocate a buffer for an application to write into and then it displays it, the ownership of that buffer can be a big rough. But in most scenarios I think it'll be the same cgroup, and I think we generally should account it to the original cgroup unless we explicitly move the object to another one, (which we haven't got any code for yet). > > > > BTW: It might be a good idea to not only limit the amount of memory you actually have allocated, but also how much you wanted to allocate. > > Do you mean accounting and limiting the reservations? Something like > what hugetlb cgroup provides? > I'll let Christian answer that, Dave.