From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8198C83030 for ; Tue, 1 Jul 2025 01:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3840E6B0096; Mon, 30 Jun 2025 21:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 333036B00A1; Mon, 30 Jun 2025 21:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 249506B00A3; Mon, 30 Jun 2025 21:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 186DD6B0096 for ; Mon, 30 Jun 2025 21:41:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9A9591228BE for ; Tue, 1 Jul 2025 01:41:48 +0000 (UTC) X-FDA: 83613994296.01.9C4276C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 6CF4220007 for ; Tue, 1 Jul 2025 01:41:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Veswfly0; spf=pass (imf13.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751334106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vu6I95bDv9BCilBsi7upo1YPF5wPTnjVgc/AYiYqQVs=; b=1ZGYWV6m3zUpnkgf9aiCLRwoHNylBtLbRtmA6p3AACwnp8I3sXQiBZlGppywth1j3Z1U30 fQ2kaRx8L9XlyanrhIIKz8ISHKIuLgFpoQfVHmG3GeSAYU1SIS3rpKIsmeHN4JhCdC5qT1 wbmD4Jpx6+U4PoAo4F5vO3i6WIdF0ps= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Veswfly0; spf=pass (imf13.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751334106; a=rsa-sha256; cv=none; b=Y2K71zRz9ZP5p0HO83ZAsWBaEoPdWcFejILz6Vj7cPdMHHgMUrtMHBQ/TB4bTs77EPPUGB 3B6wzNgSChVxtOamf5wJtaHgbuD+D+/BPu80zeiZucazjWxk4iFePR9tfpKukCBnlclMPz aidVcZX62fPqdq0cveIue4HU1OSQTcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751334105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vu6I95bDv9BCilBsi7upo1YPF5wPTnjVgc/AYiYqQVs=; b=Veswfly0eAZOcTkmKUUh6PMfWy2j5NjRXgMz1desPxo8ePATKBsMXTmc+ynxGiTxaxrUr7 TilZ0If8UUw6ICt460JpKCeOU4fNKWYySos37pQixWm3pcFVg4OWUi1O/rVMIsaFSCUxmL 8EnDoeSXcKKgvbFkP6ygypM377GU4QQ= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-6y2wbV_nNoStdxOf4AOYuQ-1; Mon, 30 Jun 2025 21:41:44 -0400 X-MC-Unique: 6y2wbV_nNoStdxOf4AOYuQ-1 X-Mimecast-MFC-AGG-ID: 6y2wbV_nNoStdxOf4AOYuQ_1751334103 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-23536f7c2d7so44374255ad.2 for ; Mon, 30 Jun 2025 18:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751334103; x=1751938903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vu6I95bDv9BCilBsi7upo1YPF5wPTnjVgc/AYiYqQVs=; b=hSoF+N+cGZ3tkaV2NI1CPBR8W1hdIgfYJKy0qJ3nDs0nqE/SaL89fRZhRl4RQqrR+l AeOHmLEQWX7Zky2+vPw0r2r0PaDPABHxUeRU1X0FX/gFTVOVZfQwfC4q7yWYpxGoUy6u Gu4G6yQAmuUd6XEz+COt5x0lnQmrFSJFyS0wVBLIh5oNMMR3y019zQXyEL00T5Pju8Yb vEe2fm+RgNcITdalPHwWnphSRIH+b9n1jOi0kY3L1BUyMAY3quxJdu+DVbegMwP7OkQV 5oYNxYOqljA8iCwrQ9qEP+lOoVp/MCNwIwclp3K+6GLMs1uiDh4l4nK64/rb2S84hRNU olrw== X-Forwarded-Encrypted: i=1; AJvYcCWS5OplaGZ4eXmf4v5IAznFDYvntVFM7qZbs3WKUuqClEhBz9MjqJeo9dUh9Tys+yTEcWlrcTVC6g==@kvack.org X-Gm-Message-State: AOJu0YwxAuQGE2CdlPlIAzvj3AGcbpr30Uek2YVpl3KBWXt6BlFA4sBc 38XqhzScWqmfRCx4SHO3s1l5j7xNt0uoe9RY8ikfzTI/+do7WBbBVqMRESd3s/3pineV+HFKFep T9tyUZWq5oH3OQ/0MpykaKkr/U0xCW341KjFx/1GgrE/edLjNAVj5OaBvHQJL29dcZZEj1s98oz Xat3N/PdsgzuerRjnWKygc+sfywb0= X-Gm-Gg: ASbGncvK8wGWa5faiPTvVoIZgVjGVEL1tPmmTHHOr52H99ZfbWcbdX3wQ9N72/OLvJU H1ZhljJIyWqLUUtbzoisdFddTXVJ1qfleQTcl7oGcT5fgFkzlyuoMHAhr+aWZNpaccJyPHcGWJY R7Ww== X-Received: by 2002:a17:902:f64f:b0:223:619e:71da with SMTP id d9443c01a7336-23ac4880725mr231075675ad.49.1751334103079; Mon, 30 Jun 2025 18:41:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHpiYoYmCF3g4/jZkavSu3oI/vXqiEC6JONrXqQDvn2Z3VSdMjSQ0/GNzktPRuoIB3Qc7785LONR9oI41koPY= X-Received: by 2002:a17:902:f64f:b0:223:619e:71da with SMTP id d9443c01a7336-23ac4880725mr231075265ad.49.1751334102731; Mon, 30 Jun 2025 18:41:42 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-3-airlied@gmail.com> In-Reply-To: From: David Airlie Date: Tue, 1 Jul 2025 11:41:31 +1000 X-Gm-Features: Ac12FXwDIE0DgaWq_oO1vTg-VN1NqguDBh-Sgj4-otBxOsOamP_bUScH2BnLAss Message-ID: Subject: Re: [PATCH 02/17] drm/ttm: use gpu mm stats to track gpu memory allocations. (v2) To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Dave Chinner , Kairui Song , Matthew Brost , Andrew Morton X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MrnATB4Fo5cn1_tp4PAGH4yUSIsvVUF_QofVhVLdwqc_1751334103 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6CF4220007 X-Stat-Signature: hoojedjs58kws68aprux1qhtaehigpxo X-HE-Tag: 1751334106-365737 X-HE-Meta: U2FsdGVkX1/MRJUNpOZeCrwwCeo3jSPNiG5yydzaioBlwIqGgblQJ78e9aJ2lfWI2i6kjqqAKgVW9aG8zpiBAwzVWMj1fEYpqA4V/11Tk5uRO/PwwMyPaqHUB+ipOgh15Ra8VUIVCSajy6xYNlq8wHU7oIYuWPrfyU+gs9HcilOxv48m6i2sSfpSxOzuv7XvWBu1VU2vAR8KqLprhlRFlxdnzC3GTwt7Ld5vj1vo3xt4K7V/QH9ye9XBtU+D9IMOhjE0hXUJYyYrpGQ41A9+sp9kLT28ocnwg/WmkGZKWBTBfjRYHdkZWOo5R+WsG231PfOIoM4uheAzM+VrGjTM3xJTHNZ507VGOaUQlAXcC53D1HzP8zTgEdExYZX2/M7Gg85frM8SdlDEj0G85fZwT+w94lgbJOccrMrYn/45vNSTSrjfovw0b88E0+00bMbFZ5dZ2KR/E9jrxhHO5rm8A+WZx/RwV8LfFKcNJ2yHxDeTi/EGkyhfZMw8W7Z58/XA5RQwOS3PANvTY0nCxZXWoDug+lcsfkh0wXXCxr8wVO5AAhLFN/+Lcrgcp7EvodrZDi32RHI+ilJBmgyYvzZeE0SeCaj13vhlnZpNLmptTjXz4KXZtEnuRzQ8PiLVXGGT6MgLdOdccOjhmzIqZR1e+qMw56kEjev2Kbk5FbVl6uLJSK6AvFrgIlPKXPLp3MfDbpMEDADEvGtElDY5LBT3xCx/fs1lTFbBmY6zim0a2/iNNit9pZjeGQPNWtZkNcDS/lugrbHysg90iQ72+AtgVUaygAlO1DOrmlFzhpCfPFAIDhphah8iJJfKoM32SXJ2ywkc6Lfbn624J6ZJLAdjCKrps2+/PTHF/rdrC1L9PBM2/47RAmzEJmV6My30bHDgk4bUZK8VqVMrA5h/IdEioXfGMHu8LS4As4504RXJH30cQetikg7WLaLeAcu0J6frCkfQm813neij341QEni TH+i6AsD uP+JLG6H3UxHvOG1KIbsQcWix6Nm+odlerOFQ5PBkRSbvTmhzbhTugF+xg6MpZdhQJvM7YhKeN3wQ2nsE6PMOqEY/wn0rtnl+Rc/fw21LGM592suAPoHjvqkHBvSSQngR842dT1c4UTiXX3W7EnWISt5GJi2vzaqjHXocrqOAeXmZ6WLEkShnjCuc3NcYPqh41jImPrmDf3C5hwDfYVROB05GgWBCRXAOwygoBMw55vIEA9XfOM/7bG1iZ1g71jE1k9PhSDTV6iXqJROmOi8Tu3tVGDhMUeUZK1LfnE0NTQY5SgCanwu+CWxOG9Z2gCBZIszHA+4sAhx5veTYMbnMQK/pcub9/QQKC5uxgG6as2+WE1meJZPiT3MtKvElJAVgnTev2fnOVhhgBOegL8SzsKPmlSAbJmlJ8LdIqeUEsyt+3WlsY9xBOMeOSMWHLqSOZN6APSey1FVP8qF6tdGCmeY6HcvzwyB7bL4qXjOBl7rZcshsKTqjCp2uaTRQGhSBf5yy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 8:04=E2=80=AFPM Christian K=C3=B6nig wrote: > > On 30.06.25 06:49, Dave Airlie wrote: > > From: Dave Airlie > > > > This uses the newly introduced per-node gpu tracking stats, > > to track GPU memory allocated via TTM and reclaimable memory in > > the TTM page pools. > > > > These stats will be useful later for system information and > > later when mem cgroups are integrated. > > > > Cc: Christian Koenig > > Cc: Matthew Brost > > Cc: Johannes Weiner > > Cc: linux-mm@kvack.org > > Cc: Andrew Morton > > Signed-off-by: Dave Airlie > > > > --- > > v2: add reclaim parameters and adjust the right counters. > > --- > > drivers/gpu/drm/ttm/ttm_pool.c | 34 ++++++++++++++++++++++++++++------ > > 1 file changed, 28 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_p= ool.c > > index baf27c70a419..11a5777b4a85 100644 > > --- a/drivers/gpu/drm/ttm/ttm_pool.c > > +++ b/drivers/gpu/drm/ttm/ttm_pool.c > > @@ -131,6 +131,16 @@ static struct list_head shrinker_list; > > static struct shrinker *mm_shrinker; > > static DECLARE_RWSEM(pool_shrink_rwsem); > > > > +/* helper to get a current valid node id from a pool */ > > +static int ttm_pool_nid(struct ttm_pool *pool) { > > + int nid =3D NUMA_NO_NODE; > > + if (pool) > > + nid =3D pool->nid; > > + if (nid =3D=3D NUMA_NO_NODE) > > + nid =3D numa_node_id(); > > That isn't correct. > > The NUMA node in the pool is just a hint where to allocate from, but the = memory can come from somewhere else as well. > > You need to look at the allocated page to figure out to which NUMA node t= hat belongs. Indeed, I've killed this from here, using page_to_nid is correct. This helper is needed later to figure out what nid to ask the list_lru for pages from, but I've move it forward into that patch locally. Dave.