From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381D1C8302F for ; Mon, 30 Jun 2025 21:33:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFB996B00AC; Mon, 30 Jun 2025 17:33:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CABD96B00AD; Mon, 30 Jun 2025 17:33:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9AB56B00B0; Mon, 30 Jun 2025 17:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A6C856B00AC for ; Mon, 30 Jun 2025 17:33:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3B2E51D0117 for ; Mon, 30 Jun 2025 21:33:31 +0000 (UTC) X-FDA: 83613368622.13.6717A7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 078DB1C0003 for ; Mon, 30 Jun 2025 21:33:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcAxkr2V; spf=pass (imf21.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751319209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uRipfUvynsYJW+L/c2yDmraeLEE+XADK7p9pX6mD7Z0=; b=ddFIyTyFXieAZJgq9ftK2PKxw5ouwODV56Vb8wFC58ngA/XzTJjWafKkO5wyoz22y9Jz7j Xk76edT3Z3uvE71jPxagYcujaPWGNuZJY+qVXfwUUfbfuQXnLWut06FsK3SfsxQVCmTdkn zchBEg2QGDhDQB1PjYrFxFutYqvzru4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcAxkr2V; spf=pass (imf21.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751319209; a=rsa-sha256; cv=none; b=lLDCWOaHvQm4jml7wHercLBx4nuhElmLotSQNmBruu5/GXtU+4tR5goC3vG721aoUnclQL yuHgpmTwPSxlxyBAwSrSr42ulCmy7jCMhHP3ccrM0Yx6h1j3DIEJ2yTd9YzULQK29P15nY J8LIvs6ygB26tjJN3ZRIoeKjSnp4NcU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751319206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uRipfUvynsYJW+L/c2yDmraeLEE+XADK7p9pX6mD7Z0=; b=BcAxkr2VFu2/niquzeGs7FS176v9bXyYTQeTwXbOIGWPbuEJMCk6YWh5K0F13LSTNZ97Td THni193VsA/kTDmPaipNDs6RSJy2zxFOq90Nw0FMqCxB3XUBwqaK3O10AXiDiOxQ8NycWv ytP1R4Gr45xk7/IYqfBmbiEKnl5FtYc= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-t63SrMekOkeYEKn47q5PUw-1; Mon, 30 Jun 2025 17:33:24 -0400 X-MC-Unique: t63SrMekOkeYEKn47q5PUw-1 X-Mimecast-MFC-AGG-ID: t63SrMekOkeYEKn47q5PUw_1751319203 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-313f8835f29so3260080a91.3 for ; Mon, 30 Jun 2025 14:33:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751319203; x=1751924003; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uRipfUvynsYJW+L/c2yDmraeLEE+XADK7p9pX6mD7Z0=; b=JELt/oVfxBkanbFU/wakO5X1icw56PaLFmzhhRrxvYJzgeVFnIU7w1a11iXZGVG6wk x/YcL3C3olMsbkhB+ms+JbfoyZnFO6qw+cAzKoq+s34FXXetyxNAznVOSEZTH9YoXknk w2JRvAZiIOD43VMTk0Ybs5uX4dsSBxCTWZVJf3hjuB1uoDMju8zt7NA4gBmtkyn6/hB1 JtldIVD9tT/XCOHBwDzd+fOrPy5p5Ny8wWj3hFXPV5zIIvGKQ/Yym/kmO1JZXfRnW3Yd QqlGnRPOx7XrJfLsRQxA2v7S1FQh5Ow0UGvEEkWdFejL65n6r7fYn7fW+Fy424iAUWpF OBBw== X-Forwarded-Encrypted: i=1; AJvYcCWOMUlYbQblyleAkemenoVk3+ekTe+h1B7ufbwP2ZbVg3cKFwkj4bP6D5S+6hfEVg0J7QGJMbb5NA==@kvack.org X-Gm-Message-State: AOJu0YzPKO9sO0cipDkkJIlz1XnFtI0PJB7acXOG/vNKze9gRkaKAJra XOGy4TqHSzXC22D39KhWnjwUwnUcFihiPZ2CPSRcg7chA6xM/5avQYIIkWYp6WjmjzsHM9B8jgN UIp2KdSAfRB2I/FON43Ir/oBHer2NFtpurVH/fk2PTG8v5svAdZJVQur+f5iKzlKlli4lueKN/U 3LZqw/t6ddaTIj+55gLtHb1kwfEJ8= X-Gm-Gg: ASbGncvpbu/uyVYhsKn/uTKTkBOHqmzSmcW7ez87PT6tQczofULuco5Pu0jS2RDaA/l rxrJnlVmGB+ZkHexsTZb4qYQqKGdn5fqk9FdIiLODOgPW79VYn9p2vELiqlW32ZqKnylatDnJaU 1OGA== X-Received: by 2002:a17:90b:3fce:b0:312:1d2d:18df with SMTP id 98e67ed59e1d1-318c9264529mr17622130a91.23.1751319203454; Mon, 30 Jun 2025 14:33:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqg2o51zhq56WLv69kYGV3nNVs9+TdNBjRo711c3QDSRCQaV4A3ogK5nXmt2zDPVPgcWOZOtQQmh0PYqdHM6A= X-Received: by 2002:a17:90b:3fce:b0:312:1d2d:18df with SMTP id 98e67ed59e1d1-318c9264529mr17622104a91.23.1751319203070; Mon, 30 Jun 2025 14:33:23 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-13-airlied@gmail.com> <20a90668-3ddf-4153-9953-a2df9179a1b1@amd.com> In-Reply-To: <20a90668-3ddf-4153-9953-a2df9179a1b1@amd.com> From: David Airlie Date: Tue, 1 Jul 2025 07:33:11 +1000 X-Gm-Features: Ac12FXxt4yS2fvwtwEW5S1tZQdP1QGKqfCcJBug37YhiJtl9z2hpJMi6DWlAL0Q Message-ID: Subject: Re: [PATCH 12/17] ttm: add objcg pointer to bo and tt To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Dave Chinner , Kairui Song X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rggULSSgkWZmA_ZE56qeLmfGyZFa058bnCsXsFdGyWk_1751319203 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 078DB1C0003 X-Stat-Signature: ofiiffqaxyb3tcduacug53ymyceaguob X-HE-Tag: 1751319208-988753 X-HE-Meta: U2FsdGVkX18yhsrssUbZ/G1BCfbUUcFZotRaFAk/m7RlpExTyE+Y/V6GykZNNfMX47iwJHk7ygpV8GhY+AZC4ar0P2lL5QKTMd9khk+JGOBbc59wobD+YKn1xUdaahh8sBWuK+ggfWfIO9TEqu/1M3LTj26Xm5D+TX3fSQFZcQfsEHhZSiJNLa+Uv1MbKNOXiu4eh2nKGI/lzYmKDFxX1Z/blfpH2vOulUs8Jzwe13JDRUM+/5oiscjg5Y1YpRrrgMlM4TMFiw0wwZz9eHs+JmpBEU91f06X74zZe1sCMAUg3ICMio/dxJ2b0nvk94JKLJ4yoxvqomR2vNwH4CGp2DOT0Kn+wYDpqovJAuXfa+pxn1wfcewmQogj7sdPgFzN2Q94dPeiHupZgW5dxmEmFZOi9Xi/nFDZJAhFgg/sPiJi5+CP/zLSdAL1QCLCmZOA5CLBZMTX6HMf8KT3A0zJJUkfcYywT/ea8VaVi2eK9blOSbOME8W1ofMWQxhUJC5J/crTsR2y7eR6dqKsmknvOqX7YIbnSNne64UIgdpFovdi25FGMnEX3/d7fJMahP6VcXwyI0wDttI6Gk8Jtybl8oPTK/JSQhuJPZZsduatp/iIoEVJ6Nhl3iH83VFrf4SdE367JYC4uZkC1GxkyqkS1lWFYOQioHdlJZ3uC4RrEqnr/BDpKcPbdkJHT/6MpnbivNQnOJNbqjShmF9IUqqfzEGTY4YyA6lYft60j1xtnxkQeLhikKUGJfipsL3Ah53Zgiy3DKpaDFDQzpAk/UIbA6amoszEQ/jDCxsY0a5lmgIMVDaRR5PmSt44SPeaMFCtBvdfSN80zzzszAki7pMZih7B1aQ58RGom6d7KQaDuyj53Typ9nE2zAXTyBFXefQ8EiC3gTGOduc6UOn4hzAgL/ua0HuYs7qMvGJzutUWWFivtr90M6Yil4KZtMULljMqlP3HsPrRlUQA85N/iM7 z1yiDpfx aOt/N+qQH7vaMCjYVScM5TKTmE+6MsQkdgw+o4wTgwB0ZGepZTVh8jg+UKntz8CfC89+6dV484W4k/uNS+i6twGbGFdzpINqRqftLDPiBRzlWdyCGxe66u59nd2BlUwE92DWeRbstKQh9DcZBp5zhzl8jc2JDAXAT2MlB/+dniL9B1levPcM7iwOxdymUdSrWfZywBVywbDouDOPM+WihCV7tf1EX9+xsc0FF8zgQV1HTkL9U8GPMT8j5MiVElMW6SPnF5OO4u4rZDi8WKKKN03+eQBjS2JG07lujlYsKNwVcN5c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 8:24=E2=80=AFPM Christian K=C3=B6nig wrote: > > On 30.06.25 06:49, Dave Airlie wrote: > > From: Dave Airlie > > > > This just adds the obj cgroup pointer to the bo and tt structs, > > and sets it between them. > > > > Signed-off-by: Dave Airlie > > --- > > drivers/gpu/drm/ttm/ttm_tt.c | 1 + > > include/drm/ttm/ttm_bo.h | 6 ++++++ > > include/drm/ttm/ttm_tt.h | 2 ++ > > 3 files changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.= c > > index 8f38de3b2f1c..0c54d5e2bfdd 100644 > > --- a/drivers/gpu/drm/ttm/ttm_tt.c > > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > > @@ -162,6 +162,7 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, > > ttm->caching =3D caching; > > ttm->restore =3D NULL; > > ttm->backup =3D NULL; > > + ttm->objcg =3D bo->objcg; > > } > > > > int ttm_tt_init(struct ttm_tt *ttm, struct ttm_buffer_object *bo, > > diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h > > index 099dc2604baa..f26ec0a0273f 100644 > > --- a/include/drm/ttm/ttm_bo.h > > +++ b/include/drm/ttm/ttm_bo.h > > @@ -135,6 +135,12 @@ struct ttm_buffer_object { > > * reservation lock. > > */ > > struct sg_table *sg; > > + > > + /** > > + * @objcg: object cgroup to charge this to if it ends up using sy= stem memory. > > + * NULL means don't charge. > > + */ > > + struct obj_cgroup *objcg; > > }; > > > > #define TTM_BO_MAP_IOMEM_MASK 0x80 > > diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h > > index 15d4019685f6..c13fea4c2915 100644 > > --- a/include/drm/ttm/ttm_tt.h > > +++ b/include/drm/ttm/ttm_tt.h > > @@ -126,6 +126,8 @@ struct ttm_tt { > > enum ttm_caching caching; > > /** @restore: Partial restoration from backup state. TTM private = */ > > struct ttm_pool_tt_restore *restore; > > + /** @objcg: Object cgroup for this TT allocation */ > > + struct obj_cgroup *objcg; > > }; > > We should probably keep that out of the pool and account the memory to th= e BO instead. > I tried that like 2-3 patch posting iterations ago, you suggested it then, it didn't work. It has to be done at the pool level, I think it was due to swap handling. Dave.