From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C785AC8302F for ; Mon, 30 Jun 2025 21:23:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19E506B00A6; Mon, 30 Jun 2025 17:23:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 176066B00A9; Mon, 30 Jun 2025 17:23:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B33F6B00AA; Mon, 30 Jun 2025 17:23:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F0DD26B00A6 for ; Mon, 30 Jun 2025 17:23:54 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5A34AC0174 for ; Mon, 30 Jun 2025 21:23:54 +0000 (UTC) X-FDA: 83613344388.26.A4C89BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3EDDB160006 for ; Mon, 30 Jun 2025 21:23:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eBxRS/vy"; spf=pass (imf08.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751318632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QIlAVk2ZbX8me9bLr75zHJQl1+T5+qFsLqwij11xprw=; b=pnSnUNNKfhVhbdGbkKsQNlzxOB49yJ3PqEtU+KNJ9pMye2kWWY5iIvPyEoKJpsUcEpcPlV 4EretSlzw9tbhMEVOoc8jwztTXq6sUsfAGupdoMTB3IjuDIshburFUQ79JALy7PWuwHEek b7h/yAyDln5V0gwBe+HasfUe8omYHfg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eBxRS/vy"; spf=pass (imf08.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751318632; a=rsa-sha256; cv=none; b=3bYEfidZqTNPbrC7wtT0Lu3JNBZLN2wbnFiDL/acM3DJkq0qVQoxkHEOKA8hgJx7xmDo35 9qXG79ftoz8EMsggbhpaZQWi8F2XdaZ9cih6+d7+2T9IxqezCPvDv0InFqlpgAdC1kL4lu XLobHEw4MNyaKpLWtoBsHoxsIMBK4LY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751318631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QIlAVk2ZbX8me9bLr75zHJQl1+T5+qFsLqwij11xprw=; b=eBxRS/vy9Luz7L1ad6Aj/2IUMrntbR5RL39uwNkTU6DJ/ETU9Wue1Ii+TgorLMd/JgcNt3 xzNU/5VD6ewGndxoZ09kx4mmEpUVGxi3gVMtkPjbuIGwj0hicKj9EEQKSi3J1UaicKzaeW 4U3XibDj/p2pT8hnCf6jDvjlVbd05I8= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589--P9e65_6MnOgT1De_c0NrA-1; Mon, 30 Jun 2025 17:23:50 -0400 X-MC-Unique: -P9e65_6MnOgT1De_c0NrA-1 X-Mimecast-MFC-AGG-ID: -P9e65_6MnOgT1De_c0NrA_1751318629 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3132e7266d3so2581239a91.2 for ; Mon, 30 Jun 2025 14:23:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751318629; x=1751923429; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QIlAVk2ZbX8me9bLr75zHJQl1+T5+qFsLqwij11xprw=; b=h000bfz86rxp/fL5GSvD6LO38nFYMDGI28bESPnZ5MBXmtbrSVwtoBfR3cO9+inu11 /ivRvHsG/ONcB49PV2Eb98mbgQnlHCdtk+zeSSMB38IUhfE9SbEVs8bBuPrABqMLOlQB jDxegdjneo+qZUZOo3SEwoTlPMs63aaURqN4m0DJ2AvnekkjyqWBpszBbjm86eYGIsql dgVBQaYbP8bj2Kb80lu04b7BTrUWGWsGU4COogP6QdFoBMyp23b7c9zC/EKqPzTysYE3 GfloGTwB02Fm0kCcjoj83n3XwxVgY8H+93PF06QvZp8Nuo+MFLRKKAWziJBi8cIe7anj cvug== X-Forwarded-Encrypted: i=1; AJvYcCWjDyb7/MU6XA0J/BqzaPr+bQJnqAieF91zIxxxVpmXl+p1+cAbieeGpllSA6Cafrb1cvujSHhw0g==@kvack.org X-Gm-Message-State: AOJu0Yy6qisdKUOBtOaRrq0/LqmtDIFk+bege5ZeP2ml7fK8aHfyD03j rIRm+lydwgS9hmd9Nd7LON3GKbRasF2TZ1ejOnwP7poIu3ZP3FxM/2k0CV+arY4E7jPLnnbbPq5 iLSuhn4QzJo8XboJuNQEHi/RC3Qkc4pEs7fK4RugNrEoF/lOEAhOg6aBbMRpfRdt9BoYEvDBsAh uQDXE0gPv3nisTqm9AeFJsCowYr7g= X-Gm-Gg: ASbGnctMEkl/gs7Qc23dRdvA8Fv8tggwIh+2v6tM+NToLEJFsjq7TEUCSqP+1xv/FZf PQnhEK60SBeSs9eqP+79hLvDUDaizeGWyEsr5JWktVfUGs86reDqQK8R7URRmTDqeA4XsGMbQlC u3ig== X-Received: by 2002:a17:90b:17c6:b0:311:fc8b:31b5 with SMTP id 98e67ed59e1d1-318c9225e5dmr24950149a91.14.1751318629128; Mon, 30 Jun 2025 14:23:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcSVGR5/6EewdJ0742GvcFHSpEOt4dnLCd4+olvboeyqLSgVN+Bt0wqrQ8im5iVf1LuZbfyWrhHtraLgdKLvk= X-Received: by 2002:a17:90b:17c6:b0:311:fc8b:31b5 with SMTP id 98e67ed59e1d1-318c9225e5dmr24950111a91.14.1751318628774; Mon, 30 Jun 2025 14:23:48 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-14-airlied@gmail.com> <3a5bf0b0-7d45-445f-b9aa-d1a884634275@amd.com> In-Reply-To: <3a5bf0b0-7d45-445f-b9aa-d1a884634275@amd.com> From: David Airlie Date: Tue, 1 Jul 2025 07:23:37 +1000 X-Gm-Features: Ac12FXzrssT7zZ7b2lMjd_goCz2aoyCNvkUuWlLwQHST8htW_hkgnqGzudTaDrU Message-ID: Subject: Re: [PATCH 13/17] ttm/pool: enable memcg tracking and shrinker. To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Dave Chinner , Kairui Song X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Y9IZWI5PDpSxSLw5-2OOWdmIgq0Jj8X0lcn8-owFQ9Q_1751318629 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3EDDB160006 X-Stat-Signature: 1qemeh3k99awdzs946kaqqtdk67s1wu6 X-HE-Tag: 1751318632-741540 X-HE-Meta: U2FsdGVkX1+8+pnSN1PDIDHp2vkmpmm/jEhDu3eaxVYhp/BguCYyV3Pgt1WmgebeZRrN7gyS8ohpnlIu+YVSd2EH+dlAUaI/ysZqbGrE9KxjEbBWmQIZJK1f9ck2ZlM9+bzzlwn2V5Nn61oiggc/pXG2A5HLtlgGpOFeput1ZCe/DW4LIJ9nuFEBF92JhC5FW9lkIjTkvQdkXg07SQrqXHdC3/17ufBkbIZ88nmj3c4Rw+9NUKDSAta6XaYXm9yoh0XxWzpfP2kjVtXYlg3lYDCJch0gtseYhyOZ8Ytjwd77Z/AjI1HZB73TiTXvDXMpbRtlzF39HKKU+p/5sdF/Y/xhBE0Ws8BXCEI8ar17Mkdt0gLy7dg1SZqHRDxSsp2dGmhEtbxFi3ZgDj20zsAtCuGJj2owsUBHRXX+1N6OOLA2eXyJ/OIN1n/eMkW8elXY2zZyyc/9T0V1NojO4yorQBJyUHni3IAOhK41/GnY3bLGwqwMcv52mPk31pUfQoUvgrJvzFz1pYKDCY6tuoEU21tqHOn+Ipjla9Yez7+YdDDknoTUbtb6HzrTPhHaGnKmJous9Hkyjyjioj4duQ/QLxD0lvumq7bWlyPTydXB11Qeie9scLgXGVtV0875uyDOQjLehyUrb36ABve70Bu9giVNTWOruF69MQRU5N24qk6QURbN/sSZ/QjsmTX5KtsbgJVMZJh3VQB0z8nR1q8hlpZsjYc0q1GPXO0tldAKFt0dItxTn1It7/E5fqKSpJaHpleTsE4NdL424Aw0RZvK4/nMwG3dgUEH/TBuGcaiAxaFIHau1GJKIs18OP00HlOrkq8s20qfNQINfC2M8SCGvHCz4obat98q0q6bSXFwF+jDaxV4Dhl1yX24F/LeWARZkf2lOevVz4Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 8:23=E2=80=AFPM Christian K=C3=B6nig wrote: > > On 30.06.25 06:49, Dave Airlie wrote: > > From: Dave Airlie > > > > This enables all the backend code to use the list lru in memcg mode, > > and set the shrinker to be memcg aware. > > > > It adds the loop case for when pooled pages end up being reparented > > to a higher memcg group, that newer memcg can search for them there > > and take them back. > > Again, this makes no sense at all and will break existing use cases. > This is the use case you raised as needing to work before: Allocate a bunch of uncached pages to a child cgroup, destroying the cgroup makes those uncached pages belong to the parent cgroup. Create another child cgroup, and when it allocates uncached pages they come from the parent cgroup first. What existing use case will this break? Dave.