From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB883C8302F for ; Tue, 1 Jul 2025 01:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 058B66B00A3; Mon, 30 Jun 2025 21:47:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0099E6B00A4; Mon, 30 Jun 2025 21:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3A606B00A6; Mon, 30 Jun 2025 21:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D08D76B00A3 for ; Mon, 30 Jun 2025 21:47:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7897DC023C for ; Tue, 1 Jul 2025 01:47:07 +0000 (UTC) X-FDA: 83614007694.23.88676CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 2905F40002 for ; Tue, 1 Jul 2025 01:47:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gnJm+tiq; spf=pass (imf12.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751334425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mx+fbRinTMuynJD3Fbg1OVPYmDGc6Dy2p+EFhYrKJs4=; b=FIxGRFBZeykMcWg4P6LonUD4942P7ayV2pVXJoHJuoBM7SQuod0RXZsf1mvPLjdvbb/+Z6 7KWqzAJ7Ftbxjocn+uNXLTxpKHnEnS0HFvFbg/eLLFVFjW0YMMzmX2/WxaFBVaSsR98OnS Rk+8EljIJhrdMzGZ648QCqOC8H+B+P0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gnJm+tiq; spf=pass (imf12.hostedemail.com: domain of airlied@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751334425; a=rsa-sha256; cv=none; b=fCrWqEwgKiv7becwq3++DVPKxba3G28WMK4oWppi8hoT8ypYagGwY1S8msvXUmad1UnCb5 X71aRunopnBDc4mmDKCLYdlxZDTqKtoNhI3sc/reiQIk/6/BHTy4HJLaLk5bT7CiG3Q5eY aCMrEvxtjHGkD8XWY6pJHyNHTa5PzAg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751334424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mx+fbRinTMuynJD3Fbg1OVPYmDGc6Dy2p+EFhYrKJs4=; b=gnJm+tiqbUfQHvUddl/p0JuHt5qQeicYWr7NLL74KaSrbGOsicMHuGGoTIynRFLQQoZl4B 6USA6eqWYhRKBddjb5GxBzvXlbWYOKMM0bFZrDDFT1bO+VABOUpQ58jXRtC3bWoktgzvQE wna5NVdOQFxnjmblQnQivtcCMe0EZ4Q= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-mPL66pUgPh6I-yd1gCWJeg-1; Mon, 30 Jun 2025 21:47:02 -0400 X-MC-Unique: mPL66pUgPh6I-yd1gCWJeg-1 X-Mimecast-MFC-AGG-ID: mPL66pUgPh6I-yd1gCWJeg_1751334421 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-313fb0ec33bso4773709a91.2 for ; Mon, 30 Jun 2025 18:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751334421; x=1751939221; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mx+fbRinTMuynJD3Fbg1OVPYmDGc6Dy2p+EFhYrKJs4=; b=qNmiAWaAC+ynWA3aFKiwR3Ff+VbzqlpuH33lY2dA3ISOLmYh5pKaFfgQrzV7Iu72LR +EXQRwcSBinHWF3bVYdBW/sbPaOLxTg5abVV8bMpWGkLyK+kpYRNMXgCTThLryRFDZTj wIFN3h7k78knqIbuqR1oORO5fvdhb/s+g+UxXUPSBUR9TbOAWLeAllMfBsLmPrX+oEgM 720TtPbLSLVSFpgyQhtgrIdJchxXUNweusp44cj2Izg7/O6vGaPJJsPP/hp3j8XKk2D1 NhNSE30Bs8Mbz9fzwhZSjJ8DtMpLnH+RyUo2uKKb9Bsfph3gxg70eOHPp0gfZOlOdoV6 CIWg== X-Forwarded-Encrypted: i=1; AJvYcCVOrke4sZj6rn/3tnX9jGzpZnK7y9rOEdMtcnB3WfGdPJuxli5ED/nD4veEvkTnYRZk2T278s2SOA==@kvack.org X-Gm-Message-State: AOJu0YzzcsBU2Kn5bZxetRZpYQ2wmfBCCw1WSX9mTjXNWf08SaLbzEoi 7Gk0LH1r8g+y5B7kIUflCiViP92is1pXwDkkULkUMMWBBvsnmET4iJC8UUqKUTiUQPJDcIWRn3D X74rnw9PfIANp8mRkafcyGQSGKvGSGyYWqgU1JnJcyjXu8fNiDuFiPuQtp6epB9QRhXyHaarv/f GtIv1fFnJTxVZ8B1w6aDf0i4vcO1Q= X-Gm-Gg: ASbGncsI4+7Unx8rRc4nObKRm+990ZsKONxlu1npI0s1Mg7aa1JjhxLbYuXmmr61J9p D4FdpVdNGOs1625gEvochm2eJj9V/4wOCEp+VGshFC9eC6930ibRjIMWuPgIlMXeLpRRalFZObg iCcQ== X-Received: by 2002:a17:90b:3d05:b0:311:e8cc:4256 with SMTP id 98e67ed59e1d1-318c92a3dbemr17104431a91.22.1751334421432; Mon, 30 Jun 2025 18:47:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlrpj6c4bDiachKhO61td+dxHFiG6TPr6jQRY17LMe42Gje+2uWk9zqkD+CLJtS/E1UDMG4APzV9IOPr6SxG4= X-Received: by 2002:a17:90b:3d05:b0:311:e8cc:4256 with SMTP id 98e67ed59e1d1-318c92a3dbemr17104408a91.22.1751334421030; Mon, 30 Jun 2025 18:47:01 -0700 (PDT) MIME-Version: 1.0 References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-11-airlied@gmail.com> In-Reply-To: From: David Airlie Date: Tue, 1 Jul 2025 11:46:49 +1000 X-Gm-Features: Ac12FXz8Yl3XsxcNjfns2VGpmm_72FeLedIQb5YUSNDP6Bs-0dQvjILAWHhRJ4s Message-ID: Subject: Re: [PATCH 10/17] ttm: add a memcg accounting flag to the alloc/populate APIs To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Dave Chinner , Kairui Song X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FCztM84cYZ5bv3783i8IGK_IEjZe05DfEYmPGg23GzE_1751334421 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1su4hu9fem34ksh9pt415iuhr9j7pc7p X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2905F40002 X-Rspam-User: X-HE-Tag: 1751334424-757063 X-HE-Meta: U2FsdGVkX19uTttbKjXC/XGPXCioC6d5ab81Hd1gFrTPJXMPIw3KzbmEdIYmZW4vAcHd34CeIHV13L4o+rPK6z/tP9uHH6V34QdCuX4J2yHXV73y5WLkCypBECmQKubzq6MCZucA0OWX5g3jtujbGlCBrUUy2kyBTrXfE0TM86XXa3w1zIbiaL6OqinNktdRoxHDErrfaEGoS207tAGebhdgzUzr1IMDv6XeUao/5fDbJk2NjBwzd3YQdlBhBahug++OcOFGCjLZL7XNG9Elck84Wj2O8zr9cZpbQCnJLXLchx8SBvKd+HqKepkvubbmi3zqs8WMWc9LUqwkrkqb6DvZXKf/xDxP0C3C1vkFMlIpsfRXLzVbImx8sDegBpKz+MTxCfaCgcB719ecuX1HRMLXRuSte6+5m044wTJiZIKHfM4+f8xEQN2xre0eYSg2IaQQEvY7+tPcHYgzrxJ63rZPTQZ0FpwrySDbi1snlthqwh2OM3osp7GwjjJCs81t2Y36q73FccmHspQJtrpHI736U16scckxPeb0hqWn3hFW8OwogGiI1pmt0iXWTgRiwLCP3cKbd3c2cu6pA+BvwaE88Ncm2bntMYsWPPX82OQn/zSvNMrbj4mxCpub/UPY6yoadISUqeQlkAdbrVw6XzqI6y19BZCZ/smUfpHF6GnH3y8RIBKluX5uYkO/yUI6BPtwAlinEFnp6ajo5xwNsklHcaE3LaPKFMlq9QUWViShUNz4pA/Kp/u6j67VvRxVEAWxGZhjTdezIzHfSg8tK/d827QdVbWUur2WTAR0yFuswz7TgUO5cjmkgikWBtQE9+CBcbNd33YleRf0sr3hHN+niM30tfiP+7EdlmdbhmSeKn/JqXYvyKOcMt+livFrNHRCqHRZ40Mbvq/HBVhAiR3Kyl+7rf+P8OLrqmoaucGa35rET87eF1TH0syfy8+YStkA1EF00IMIrKZHmva Uf7ED62c wFkEhMGh/HFOYScx+a5kc0ipcCcyTXQWcZNEhXBEPM5n2jLTAOF1CDgA0UJ/o9jYOujqmhC1Pg6yoHu/cbfJPdUjCVbs1ffegtIawichUBpe74nrpUUbw0LxkssXDuk+ck3MK7yHg8lFORZQ2gIFkexBQrAUTqFMA84oDwwC2Oj9Htol3jPfAe4ODS4A8oHzD6lOCsnXfHQILD8LCoLMNPO1SdS6TPVmddeEnIV63pXjTAjhm3jpFRoVjgFypKmg/Dt9E9unvQswTFFg/k4ygDT89c5lAmoOt0tCAfzM8iMdMaUou+Ewu/AHXtmpCuRf5rswZhD/Yj7ZxKignqsBEH4jWdTp7+g+7F/t8dpIlB7NlcbdRWcp3G+czlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 8:20=E2=80=AFPM Christian K=C3=B6nig wrote: > > On 30.06.25 06:49, Dave Airlie wrote: > > From: Dave Airlie > > > > This flag does nothing yet, but this just changes the APIs to accept > > it in the future across all users. > > > > This flag will eventually be filled out with when to account a tt > > populate to a memcg. > > I would keep the pool completely out of memcg accounting and always accou= nt at a higher level. > > Accounting that low just gives a hughe surfurce for driver issues. https://lore.kernel.org/dri-devel/20250512061913.3522902-6-airlied@gmail.co= m/ This is where I already tried it, and had to move it back: "This version moves back from the resource to the tt layer, when accounting at the resource layer, if an object is swapped out there was no way to remove it from the accounting, whereas the tt layer has more info for this." Dave.