From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26248C433FE for ; Wed, 12 Jan 2022 06:07:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 744746B0122; Wed, 12 Jan 2022 01:07:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F3A86B0123; Wed, 12 Jan 2022 01:07:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BB976B0124; Wed, 12 Jan 2022 01:07:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 4BD2E6B0122 for ; Wed, 12 Jan 2022 01:07:32 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0437492EBA for ; Wed, 12 Jan 2022 06:07:31 +0000 (UTC) X-FDA: 79020603144.11.BD7E96D Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf18.hostedemail.com (Postfix) with ESMTP id 84E721C0003 for ; Wed, 12 Jan 2022 06:07:31 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id i5so5474031edf.9 for ; Tue, 11 Jan 2022 22:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=edi.works; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Uim4PQO9GRX6Ml1nDaTb+DvyJmBeJ+eZYwrgMJj3yI=; b=1LNNzA/ve9YQhIzt6mswt+L1KOC7ztP+uZRonN3zpQtMe8zsMGUM76zV3r09+Y4RDv TCs/ixX6b8fHXxQWGqNp1NkolJFZ1dW/YUwuOpBQBnEgl+Mq/UP31vw5LgqtwuygtItT jItgFp2TVagFEfu1tEUBVZMjK2qXEsOyob2zweFygDPXCEnB14Vd3M+QvPy4A2jvHfW0 mghcntQKfhuX8jClj88njP798Shb9uY70Zrz9uZoS9XhStHeqw5E5Vl4+zlbmPiCZuYD 05yGJ+4GOPENbEW3Ma6B4PMLMH0BUoJkXGvqtejqQGkq6/FBQftP3qz+axHBcUCvenL3 uw6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Uim4PQO9GRX6Ml1nDaTb+DvyJmBeJ+eZYwrgMJj3yI=; b=rF5aAc4VdR8GCCLmw+YzyFarFVhDmzbEAgRi85f5eiBRgmsKxc2siO4PIXgzBwKNdS KAWXJpELSMudpK2piMV+OyW/2JVw0YgnjuO9BGY2NNFgZi8sFqgPw8dLOudHzYshFCs3 dEALq0ZHXF5/Kya+SFh5ua7rzJ8EObXd250PwjJpdsyeQ8ymEA2FNalT2WYet95P55Xk 5e8GWmKQ34NQEVnua3Td67CtOUYEhgpZ6kO/okW3T7Llhy1Sdh39Dx7S0BD6ZvjcC1Ku igoOO29SzKo+jM0/rjGs5PHiTzqSFWXekG5iFw3vg6TYiWq7R6QFJrIiKi0lSB53UGFV REYQ== X-Gm-Message-State: AOAM530shGut9fSS9FDkxOIYmiFBRz8QMvMubJ0CKjjN4ze+RK024fsV rM/w+Bn3Mb4WcD6/FziH9gBulYBBEpjnfl7VvzBl7A== X-Google-Smtp-Source: ABdhPJw5cTsO1kWiUiVqpgI3OeCcBg5JTs4BMkeLBxLQDWWc+i6xh5tf47WN9LuD12xfZNO/D9j9J7A3wl/25P/c31s= X-Received: by 2002:aa7:c7cf:: with SMTP id o15mr7598673eds.176.1641967650078; Tue, 11 Jan 2022 22:07:30 -0800 (PST) MIME-Version: 1.0 References: <20220104202227.2903605-1-yuzhao@google.com> In-Reply-To: From: Sofia Trinh Date: Tue, 11 Jan 2022 22:07:19 -0800 Message-ID: Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework To: Yu Zhao Cc: Alexandre Frade , Brian Geffon , Daniel Byrne , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Jan Alexander Steffens , Shuang Zhai , Steven Barrett , Suleiman Souhlal , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 84E721C0003 X-Stat-Signature: oxi4s5jqxzojoxaoeb6npshqykwz5iax Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=edi.works header.s=google header.b="1LNNzA/v"; dmarc=none; spf=pass (imf18.hostedemail.com: domain of sofia.trinh@edi.works designates 209.85.208.43 as permitted sender) smtp.mailfrom=sofia.trinh@edi.works X-Rspamd-Server: rspam06 X-HE-Tag: 1641967651-599430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 12:41 AM Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > Downstream kernel maintainers who have been carrying MGLRU for more than > 3 versions, can you please provide your Acked-by tags? > > Having this patchset in the mainline will make your job easier :) > > Alexandre - the XanMod Kernel maintainer > https://xanmod.org > > Brian - the Chrome OS kernel memory maintainer > https://www.chromium.org > > Jan - the Arch Linux Zen kernel maintainer > https://archlinux.org > > Steven - the Liquorix kernel maintainer > https://liquorix.net > > Suleiman - the ARCVM (Android downstream) kernel memory maintainer > https://chromium.googlesource.com/chromiumos/third_party/kernel > > Also my gratitude to those who have helped test MGLRU: > > Daniel - researcher at Michigan Tech > benchmarked memcached > > Holger - who has been testing/patching/contributing to various > subsystems since ~2008 > > Shuang - researcher at University of Rochester > benchmarked fio and provided a report > > Sofia - EDI https://www.edi.works > benchmarked the top eight memory hogs and provided reports Tested-by: Sofia Trinh