From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB267C47074 for ; Tue, 2 Jan 2024 11:39:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 636D68D0007; Tue, 2 Jan 2024 06:39:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C0618D0006; Tue, 2 Jan 2024 06:39:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461B58D0007; Tue, 2 Jan 2024 06:39:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 334738D0006 for ; Tue, 2 Jan 2024 06:39:39 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 007DE1C0800 for ; Tue, 2 Jan 2024 11:39:38 +0000 (UTC) X-FDA: 81634176036.26.1045978 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf17.hostedemail.com (Postfix) with ESMTP id 0EE3740012 for ; Tue, 2 Jan 2024 11:39:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704195577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFi8eMSPsfOFqOHCg4hwloMdrYmzNBUBfM1xQ0dKIbA=; b=AKNimcedjIdDN4lbTuevfcKorRuv07e3gfo+ru/p8m8KdiD3EHZaQZixdnCCP7Wun6FuyU 05amSXXdHaE5BTgFmCgFnwxr2Ix692jcJ4AdzRMXHwZHE349p7Efd6oX7NtfKxeR7UJZLp QlyviFvRw4W8vvgOMRFiwNZbUaJSUqQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704195577; a=rsa-sha256; cv=none; b=4+Ur9H8poDhgQg9iAMNuqz+J0pzlt98mwNppX2dObH1dJaippGJos9kxMuOOcXotCJGpCS hli6V5c6zVgzimqksSKzVQpTP55HtVlM7wFStajlWjktO16dGmhgvWX4sDd1g779LiyTgz lcoagIZQffQeycXpY97Ya4ro3QWckeM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-db3a09e96daso5813245276.3 for ; Tue, 02 Jan 2024 03:39:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704195576; x=1704800376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uFi8eMSPsfOFqOHCg4hwloMdrYmzNBUBfM1xQ0dKIbA=; b=nn1NH0xWZBs1OVESGi+xiC9PbJTqV2pjsyDSmxKreRdFrir4aOcDTRAj1JMZNXOZ+J kd6JTKqI9KGUPhDe6zrvIWyrCRc9We0YjQNMFIHNlYuztU3D3165Mxq0FX7/BJHRagwY 5/XEyOKUX/NPVJPL9HzXVROICUyqDrQ+C0AipUxAQjgd3FHYayGpjVbEiKBngIGNSAD7 TKQniT4TJ3ATbzWje6DDpbl8m76ulVZ70ZaXsgKpEdijWd0qTk82NCbOYArsb9yOafPU /cAG5wv8rQFzOB4nA+lkwpLrZsUy/r3W6jSDKkLKTRHSCrxiYhVXuDKVG8+P4r/NJ6aN 1lDQ== X-Gm-Message-State: AOJu0YyJPGQVXjfqQ6fLuKt5WyvI64cq9uBbYgWQii59fGAgP5jjShly cKxJmP9zh605jLmJoFVR7m5PiNnPzt76YQ== X-Google-Smtp-Source: AGHT+IH3zuhnYDzvqb9p1UdI5pVlWRf3YWS6GuF1v2jTMc6a9IXo8IsW/+hhrn/fj0E/3d3N24JJow== X-Received: by 2002:a25:d749:0:b0:dbc:9e7a:f1c9 with SMTP id o70-20020a25d749000000b00dbc9e7af1c9mr7587724ybg.38.1704195575761; Tue, 02 Jan 2024 03:39:35 -0800 (PST) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id l10-20020a25bcca000000b00dbd996264d5sm9875631ybm.41.2024.01.02.03.39.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jan 2024 03:39:35 -0800 (PST) Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dbd73620c82so5825688276.2 for ; Tue, 02 Jan 2024 03:39:35 -0800 (PST) X-Received: by 2002:a05:6902:e08:b0:da0:5370:fdce with SMTP id df8-20020a0569020e0800b00da05370fdcemr9471148ybb.19.1704195574941; Tue, 02 Jan 2024 03:39:34 -0800 (PST) MIME-Version: 1.0 References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-7-kent.overstreet@linux.dev> <20231220213957.zbslehrx4zkkbabq@moria.home.lan> In-Reply-To: <20231220213957.zbslehrx4zkkbabq@moria.home.lan> From: Geert Uytterhoeven Date: Tue, 2 Jan 2024 12:39:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 50/50] Kill sched.h dependency on rcupdate.h To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hc75td77pskfa6dgqmoq8hacucmqjopr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0EE3740012 X-Rspam-User: X-HE-Tag: 1704195576-11428 X-HE-Meta: U2FsdGVkX19Lcufd29OYmsSx6NmMmIao0zpsU8To1YIGnNf6afWlu8OcHhfyX6UooLTToB5q4huo9ToDiW6H+ZweP8UsnKfkpPP05yvwgPFs2v7MjiJt+RnSl4P+qYRc3VbB/L86jqoQjAeuZXMJnyI8KsQbv44bXFmXmvByrg7mkdVXLbos3SAuvNSQYfbwxFIm7nkGkCQVhjkqAITKV5r2vK1857GlS16WdHKk44dCF40nV/cMhMoZZSmBG39IiLzCjh7Q7Nwr6YFYiumYVYvhULvmgQNm2oA+WXSajHbP2jCLVtwi8Wx8FWTLM1NQ7VYYxu3eQeGPlswoPxUfB3AwCn80QsUc+ej6aKlS7ecXl3ded4oicPwYyEvaLwI1EZVRaLfxWjb9I4bBi/pTBRi+vxV4BGDvJnc2We567pJLpcRoY39PhtipYO76Ufn1/7WzNCITrzVqBb7OBoTEHe3zPcfVn/Mdq3hLj8N6wo3Ic47AZBeuyaRMrH/dQgAmeaBqDkWuy42coBWxgucOW/1ObRgrCw3PASvYLFwEJ30iVuTZnaNagyNTArNE6NHsyzLRldmTa2DDoAWbBjhLhTNtuLK9nKGFQUUg0Db16AsIls1Y9PFEt+6FANU6kcWGDB+9wfkfQUWuMRI2FLP+bPQZkGaR0hUWfDI8ZzsfHBHwA48k7q118A5+BPFBMnSMBj/4ryxi+bDM4Yi9RPRdy0WAjSNwZx7Yyd9M20dCgHGhawof9Y1U1YNQyCf3qNua2wNCA2xaffeXfD+DbQs4Ko81/Y9Q1Wayme2KgAl+ixrzkUxlkZ2DlqjmNjFTrCe9fgpGgqvTXIjw1kR4Euj8ZDiEqUBXeApULW6uh6T9fu6dPMXRaAkeFbQxIdbfmK+uw1Kn9CgY4G+w9D+T9J2JUZzOiwLo1j9LuWhgicPoKvsT3ZU8a6iN5upMQcFzPYktHm/aCIDJ+dqPv7SYDS7 +GEMDmXD 1Yt0Bs0t51Oj3WW1fHq7fbM+cp86pK9z0bz9v+aV9nupDHP/bf+9NdIknCx9LHriy1jsmg2rYEBolGUB3OTek4EcQ74pNjaEtLOCeI3tt8m4WdTuXhiyWrCtptYMlKIKMM3k6TwxhrBaxGysVDgUw6PcLTBchhfqd9X2FA80atgfE/fXnpgBGDKQVwcdlQpy5nBkfg11hF5AieZBt0nnnAHYsRXcBCP5lVg9Idgy9ZQTfzMGS0JVjkxFBpmLSV1c/YPipoQc5dgn8xjXfdq9kA6EBwGHV87mKpwLIFMGjE0pX9yQjMqYCpOAjtWW+idNtuDt4kvksf9v4lcxbrjhwudaq39+91UM0+r8X6D8bsBW3Vg3kIuiTHY69W6R+WcB5qmlsgtktvNWrUHQfJF5YFeUuYRoWLx8oDVHvrSFiMYbI4XgJxAQLZqIgH9FACDYgbqIRBdCk4t+Z2Lk6P8mfusLmsEjk+9MJiBM6JyE+paz8iHSlKOrxxlU60bvk0glB1FKU/ss3aYkdJsWwCooFSm73TDOYn+KZ3XeP2XRBnKHJqKOGSLlIyGVgQtDN3gHB7FE9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On Wed, Dec 20, 2023 at 10:40=E2=80=AFPM Kent Overstreet wrote: > On Wed, Dec 20, 2023 at 12:59:44PM +0100, Geert Uytterhoeven wrote: > > On Sat, Dec 16, 2023 at 4:39=E2=80=AFAM Kent Overstreet > > wrote: > > > by moving cond_resched_rcu() to rcupdate.h, we can kill another big > > > sched.h dependency. > > > > > > Signed-off-by: Kent Overstreet > > > > Thanks for your patch, which is now commit dc00f26faea81dc0 ("Kill > > sched.h dependency on rcupdate.h") in next-20231220. > > > > Reported-by: noreply@ellerman.id.au > > > > $ make ARCH=3Dm68k defconfig arch/m68k/kernel/asm-offsets.i > > *** Default configuration is based on 'multi_defconfig' > > # > > # No change to .config > > # > > UPD include/config/kernel.release > > UPD include/generated/utsrelease.h > > CC arch/m68k/kernel/asm-offsets.s > > In file included from ./include/asm-generic/bug.h:7, > > from ./arch/m68k/include/asm/bug.h:32, > > from ./include/linux/bug.h:5, > > from ./include/linux/thread_info.h:13, > > from ./arch/m68k/include/asm/processor.h:11, > > from ./include/linux/sched.h:13, > > from arch/m68k/kernel/asm-offsets.c:15: > > ./arch/m68k/include/asm/processor.h: In function =E2=80=98set_fc=E2=80= =99: > > ./arch/m68k/include/asm/processor.h:91:15: error: implicit declaration > > of function =E2=80=98in_interrupt=E2=80=99 [-Werror=3Dimplicit-function= -declaration] > > 91 | WARN_ON_ONCE(in_interrupt()); > > | ^~~~~~~~~~~~ > > ./include/linux/once_lite.h:28:27: note: in definition of macro > > =E2=80=98DO_ONCE_LITE_IF=E2=80=99 > > 28 | bool __ret_do_once =3D !!(condition); \ > > | ^~~~~~~~~ > > ./arch/m68k/include/asm/processor.h:91:2: note: in expansion of macro > > =E2=80=98WARN_ON_ONCE=E2=80=99 > > 91 | WARN_ON_ONCE(in_interrupt()); > > | ^~~~~~~~~~~~ > > cc1: some warnings being treated as errors > > make[3]: *** [scripts/Makefile.build:116: > > arch/m68k/kernel/asm-offsets.s] Error 1 > > make[2]: *** [Makefile:1191: prepare0] Error 2 > > make[1]: *** [Makefile:350: __build_one_by_one] Error 2 > > make: *** [Makefile:234: __sub-make] Error 2 > > Applying this fix: > > commit 0d7bdfe9726b275c7e9398047763a144c790b575 > Author: Kent Overstreet > Date: Wed Dec 20 16:39:21 2023 -0500 > > m68k: Fix missing include > > Signed-off-by: Kent Overstreet LGTM. Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds