From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EBBBC54FCF for ; Mon, 20 Apr 2020 09:28:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B7D921D79 for ; Mon, 20 Apr 2020 09:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B7D921D79 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F1CB88E0005; Mon, 20 Apr 2020 05:28:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6258E0003; Mon, 20 Apr 2020 05:28:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D94828E0005; Mon, 20 Apr 2020 05:28:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id BC9008E0003 for ; Mon, 20 Apr 2020 05:28:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7816C180ACF84 for ; Mon, 20 Apr 2020 09:28:08 +0000 (UTC) X-FDA: 76727707056.28.way50_813dcca304834 X-HE-Tag: way50_813dcca304834 X-Filterd-Recvd-Size: 4538 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 09:28:08 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id z17so7497763oto.4 for ; Mon, 20 Apr 2020 02:28:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XArWxGkJ+VyTPp7Wsn4dbWWlVRq/sh+tie0xFdY8Wzs=; b=DtgHuuARGV8IOD3hsFJ1ufNp7bMt3zoSykIHxIPzeDjprahHMMNpwDMCWOYMnKnAS7 v2GFRbonxnkT4NqmDtTRbiAxcr7cKDGW8muT21RnfftklJMKspo65Z/J2+yRvEmqU1Kv Z1h91JHrnH1HCB/R8FxdwGoWUuDS9wX7uV6Q3XLiTFFBOy3yOZIu6HACZibIh8fkGRSo VtkpoZC5J6uGrEWT0kHCYATQ2bgNPSSXq8ToYnUJgaYo+4LaE+OoFiuDe6LiDevJ7ivQ jIik02hxmFuJLJPC8fXXIuvqkJWPoWVVaI4EvB+hcPITcwfwF36Xxy2rwyTTg3zqCZif M3kA== X-Gm-Message-State: AGi0Pua+M8ss7imuJXV0Bogw9fU5gfLk8UNogKeA3DHDEpN4UeH+MRTa XkW4opxI9NyUfDgG7SAmKaIspYFBEfMM0njThUs= X-Google-Smtp-Source: APiQypKjsC6EXYlE5GmPZ4cHorgIglv7peKg70tltLFRlUNMnXipnoVRB6R66Yu9R4xLAwziPHJaRnQ/4in6/miu0rc= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr5224618ots.250.1587374887535; Mon, 20 Apr 2020 02:28:07 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-25-hch@lst.de> In-Reply-To: <20200414131348.444715-25-hch@lst.de> From: Geert Uytterhoeven Date: Mon, 20 Apr 2020 11:27:56 +0200 Message-ID: Subject: Re: [PATCH 24/29] mm: remove __vmalloc_node_flags_caller To: Christoph Hellwig Cc: Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , "the arch/x86 maintainers" , David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Christophe Leroy , Linux-Arch , linux-hyperv@vger.kernel.org, linux-s390 , Peter Zijlstra , linuxppc-dev , Linux Kernel Mailing List , DRI Development , linaro-mm-sig@lists.linaro.org, Linux MM , Linux IOMMU , bpf , Robin Murphy , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On Tue, Apr 14, 2020 at 3:21 PM Christoph Hellwig wrote: > Just use __vmalloc_node instead which gets and extra argument. To be > able to to use __vmalloc_node in all caller make it available outside > of vmalloc and implement it in nommu.c. > > Signed-off-by: Christoph Hellwig > Acked-by: Peter Zijlstra (Intel) One more nommu failure below... > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,8 +150,8 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > -void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, > - void *caller) > +void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, > + int node, const void *caller) > { > return __vmalloc(size, flags); On Mon, Apr 20, 2020 at 10:39 AM wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:164:25: error: 'flags' undeclared (first use in this function); did you mean 'class'? "return __vmalloc(size, gfp_mask);" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds