From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B09C0015E for ; Thu, 27 Jul 2023 09:25:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E60AC6B0072; Thu, 27 Jul 2023 05:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E10DF8D0001; Thu, 27 Jul 2023 05:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFF886B0075; Thu, 27 Jul 2023 05:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BDDB56B0072 for ; Thu, 27 Jul 2023 05:25:48 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 905CDB2ACC for ; Thu, 27 Jul 2023 09:25:48 +0000 (UTC) X-FDA: 81056859576.24.1994F42 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf24.hostedemail.com (Postfix) with ESMTP id 92A86180015 for ; Thu, 27 Jul 2023 09:25:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FM7dbmsUNQ9ephJiHm7mnMG3bHxM2q6uJO1Stbh0MgY=; b=aWNFdiYowVgJ44Y7q7Ph2uLTb8+8Llfj9/XW/qobSqLttlgP8sHYgYiJl7fcqiUUND6VMZ DiMse+cZ+eGvvt8OaoIM/skYaQI7/fdNemhrTSJXLbDZMledSSBfKSDgdaMsQx0Smeszkr CuZVsfEIoVIATnLH9VGvPw1IwciXFvY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449946; a=rsa-sha256; cv=none; b=OV3PSetHJZA64uGbZ2J9ZMg2VgepAI1s5rwLHcOVqWf46P1txIqfAc5J7CPQ5s2bnS6rhW ixOJlyhyaB61XHPZoOCtibTzyiD6iVpHML3dWZqxc3ST9aPyErLQHJklA26jUXKphOUwFW th90E1m6jneES2RhIbrHjenwfhlWzKg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5774335bb2aso8129567b3.0 for ; Thu, 27 Jul 2023 02:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690449945; x=1691054745; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FM7dbmsUNQ9ephJiHm7mnMG3bHxM2q6uJO1Stbh0MgY=; b=GBMHBh8EEQpR7Z28VYlZSyLurZNGL03fqrfDK2Z8cj1xIPcWoZ3rPnP6jAgzXrKgfh hHp4S+mDEsHsaKycLh/MOA90WWuE3G5DnO9yDgRtC3zjROyqpsvpcfcbYpJQOidHBz/J cMBk1VZFi9/AjN0fEkgRch+jzgxmqdkR1M2ta/36uFTqqb+DK7kHiI/Rx9D3tKq3261A yslCkQdiWxmlfFt1foamYys7fqK2g29OyhH6kUiWKPbX+DtVv8u/TwRWfdTmkMy3pe0S 0xW3daynOqzfRZefitHy3uSHFltrK7xXZSjsTmZchZK28yMTyOqdckZHTiLqCzz5Zt26 HunQ== X-Gm-Message-State: ABy/qLaz8/7TFDaUlQkmPLKT4LBj0yfGfZ+36rADVo6TVRrAm1IzGzT5 gvvwf5GU2L8LYUhBEGy1P/7vKp68Uk5K2Q== X-Google-Smtp-Source: APBJJlFKgPBG/grdpsq00csc0Vg8lo0VXOKT853otu9CXEkhT3lxXX4S27MAjkZ01T8eanRK+jKbmA== X-Received: by 2002:a0d:f786:0:b0:56d:3327:825 with SMTP id h128-20020a0df786000000b0056d33270825mr4233886ywf.48.1690449945260; Thu, 27 Jul 2023 02:25:45 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id h2-20020a81b402000000b005707d7686ddsm299610ywi.76.2023.07.27.02.25.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:25:44 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-d16639e16e6so630974276.3 for ; Thu, 27 Jul 2023 02:25:44 -0700 (PDT) X-Received: by 2002:a25:db04:0:b0:d18:1fbf:c11d with SMTP id g4-20020a25db04000000b00d181fbfc11dmr3898899ybf.47.1690449944618; Thu, 27 Jul 2023 02:25:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Thu, 27 Jul 2023 11:25:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 2742/4710] drivers/clk/clk-versaclock3.c:404:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. (fwd) To: Biju Das Cc: Julia Lawall , Linux Memory Management List , Stephen Boyd , "oe-kbuild-all@lists.linux.dev" , Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: qgzggp1w7mjzyn8sb3tj6fp7fbiq7doq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 92A86180015 X-Rspam-User: X-HE-Tag: 1690449946-317246 X-HE-Meta: U2FsdGVkX18HWVEOGy/S3Mp4uqor/8yjgQ1QMR4URUCgySbJo1Pa6PWJYF4ezhiLdMygnO8yJLvhrtfz69ZtqsGr2Y5lowHSekGqB3wBaw8/ITJ02xqYvc5WJTFcUDdrdw3TGpDJw/cQ5YUIwlbKpoh265IP02Opngw+YoG5DVdN6iVCfyHY5Dy/R0GTO35E85gc7wv4Kl7ZDhEBNAqB4tm54toFvI8kxkSBjMXAvyzAWAA83oP5XyyefUp/ArnZm5B4RwcX5YJ2LSyxlbB/nzSmgR5wpuB7Yk10X1E2sngEdoujyvoX8YTnjWa+J0+VqtGMTV+Z98Ad1l4r8sVqSUSlszwZxiQRqyqWBQ6lCANXINVgCOnYIphRKkdpaQrIqK5T9NK7uYm/7MJXZ8CeTWoVeLtcSIpjasNVPEro7w+Cyj9CGip4Z9rr0/RMBTG656kzfUN08v036F+HsPoHl6+Sai+XPs9skmnEwvCS/duamsDJobdXmroxCBez6OjIn9gTPoYbe+GGSRTJV0oUfrE/1sMO77OGsEWVau1HTMMWJ5IdRl0tJHe3RjxDqpb89MAh78IDWIVvMFatWSfTlpcGfEFLs2uTaMH3am0m3rkvRsjFvzTZYceplELSFCNHkfwbowq7/zhNjsgoWKQ6R0+eob5Yf9GKRvu+Hy8RbpefOsv3ImfX8KlaUfLDftG4hJ8kk4TeTk5iGTpPiFyAvPB20YtcQYSgSOTSDHDn+TEqfCUU44+Ggg0g2LYeh7raiH6CUtLJGy5EMcWnNK7xetbBFAJ0EyFWd1jfXNy6yEPUj75Uq7TrJ/evbzWPhwhQT44K0ppsv0YNoJEFMrv2QZQDMc1Tb5MbU0sIQTz4O06GEoXyYCWR86anZ1+dCZYSUNCIiiLTZaFjvuY5RD2OyVzBtnm3vkazQO5ISl8Ocad1gZvkage3/EQm5ckQvaxEY/UmaqECJj2VsNuJFq/ LL6y5W7m nW6d24db1gA4ImjwN3z+sWETgNd/nX1SfqkdmY3ps0rCg0wl1d2iOYfBXAoylcfnoIaZ7Mn7FqIhqcvVNLb6iv56psHL8Qvx6umd0HNA/2HAVQixAOLs3NzUXyu5r50kElak61fRDFJp7R70LJa9ULi1eLGDLS9FitjGWQDEYDPWvHz5u72l36XC+ykz/u9ZALzmLS6PpSsmBY1sz1t6UVswEXNyNhUMnGxQf7Vs8nUXr75g3/LZ5+AFwUg/5K0lrAllAAgav3Ou/HyDrhz32Rnzy9l+rzftBp0EtURaNEjA3Voem0riEuc/XwU9344kxiJFZC2by/jF1Z74wLzOXMxAt4kfZQ4A9/j+fmVOBMpFARtF8Z4TKfqm/Es8AwhFl0EVb1ZZMBN8P5yPLxXkAN1hJUwTvtAXCNXAqd8jHJWP+sa357YdA1xp/hthbc2TW9PZae13NfPPfa7LitLRjc8MhriF3w0GsByJS7PQP/G0l9cEgC2jR8V1YTd65EEX4A8FFP4mLHCsaC223ViFH+WjsgK9lF9CJp32y2lXcUkSze7PPtDhV/Xai1RYdVSE+XurN7jzUUswvTe2zZ5WJWHqOh1OiinMFQ7c/R/LKuewvu43SjClMCIvRLLwUNDlzRWsowMkx/kvmJLSCuE7x5iCA5NxGM/YA1R1tTsU0DJTOX4nME0ZmG3hodq2YT4VfURr31C4m13Pq5zjvQChgtctLPVgLGhp4T+N+OU5K44IGRlw75i/AdH7OUDqu0kxrNILFXqcd1pFySTsbUX365PbTcUG5yOof5lHd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Biju, On Thu, Jul 27, 2023 at 11:19=E2=80=AFAM Biju Das wrote: > > versaclock3.c:404:2-8: WARNING: do_div() does a 64-by-32 division, plea= se > > consider using div64_ul instead. (fwd) > > > > On Thu, 27 Jul 2023, Biju Das wrote: > > > The reproduce link is not working for me. > > > > > > Can you please provide instruction to reproduce this issue? > > > > I don't think it's intended to be reproduced. The issue is just that a > > long value is being passed to an integer that is 32 bit. If the long > > value will never be very big, then you can just ignore the warning. > > The rate values are well below max 32 bit, 4294967296. So I guess, it is = ok. The type of the parent_rate in/output parameter of clk_ops.round_rate() is unsigned long. Hence you should use div64_ul(). > > > > versaclock3.c:404:2-8: WARNING: do_div() does a 64-by-32 division, > > > > please consider using div64_ul instead. (fwd) > > > > > > > > > > > > > > > > ---------- Forwarded message ---------- > > > > Date: Thu, 27 Jul 2023 08:50:37 +0800 > > > > From: kernel test robot > > > > To: oe-kbuild@lists.linux.dev > > > > Cc: lkp@intel.com, Julia Lawall > > > > Subject: [linux-next:master 2742/4710] drivers/clk/clk- > > > > versaclock3.c:404:2-8: > > > > WARNING: do_div() does a 64-by-32 division, > > > > please consider using div64_ul instead. > > > > > > > > BCC: lkp@intel.com > > > > CC: oe-kbuild-all@lists.linux.dev > > > > CC: Linux Memory Management List > > > > TO: Biju Das > > > > CC: Stephen Boyd > > > > > > > > tree: > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a ne= w > > > > version of the same patch/commit), kindly add following tags > > > > | Reported-by: kernel test robot > > > > | Reported-by: Julia Lawall > > > > | Closes: > > > %2BsY49B78%3D&reserved=3D0 > > > > > > > > cocci warnings: (new ones prefixed by >>) > > > > >> drivers/clk/clk-versaclock3.c:404:2-8: WARNING: do_div() does a > > > > >> 64- > > > > by-32 division, please consider using div64_ul instead. > > > > > > > > vim +404 drivers/clk/clk-versaclock3.c > > > > > > > > 6e9aff555db7b6 Biju Das 2023-07-05 382 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 383 static long > > > > vc3_pll_round_rate(struct clk_hw *hw, unsigned long rate, > > > > 6e9aff555db7b6 Biju Das 2023-07-05 384 > > unsigned > > > > long *parent_rate) > > > > 6e9aff555db7b6 Biju Das 2023-07-05 385 { > > > > 6e9aff555db7b6 Biju Das 2023-07-05 386 struct vc3_hw_data *vc3 = =3D > > > > container_of(hw, struct vc3_hw_data, hw); > > > > 6e9aff555db7b6 Biju Das 2023-07-05 387 const struct vc3_pll_data > > *pll > > > > =3D vc3->data; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 388 u64 div_frc; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 389 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 390 if (rate < pll->vco_min) > > > > 6e9aff555db7b6 Biju Das 2023-07-05 391 rate =3D pll->vco= _min; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 392 if (rate > pll->vco_max) > > > > 6e9aff555db7b6 Biju Das 2023-07-05 393 rate =3D pll->vco= _max; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 394 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 395 vc3->div_int =3D rate / > > > > *parent_rate; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 396 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 397 if (pll->num =3D=3D VC3_P= LL2) > > { > > > > 6e9aff555db7b6 Biju Das 2023-07-05 398 if (vc3->div_int = > > > 0x7ff) > > > > 6e9aff555db7b6 Biju Das 2023-07-05 399 rate =3D > > *parent_rate > > > > * 0x7ff; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 400 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 401 /* Determine best > > > > fractional part, which is 16 bit wide */ > > > > 6e9aff555db7b6 Biju Das 2023-07-05 402 div_frc =3D rate = % > > > > *parent_rate; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 403 div_frc *=3D BIT(= 16) - > > 1; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 @404 do_div(div_frc, > > > > *parent_rate); > > > > 6e9aff555db7b6 Biju Das 2023-07-05 405 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 406 vc3->div_frc =3D > > > > (u32)div_frc; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 407 rate =3D (*parent= _rate > > * > > > > 6e9aff555db7b6 Biju Das 2023-07-05 408 (vc3->div= _int > > * > > > > VC3_2_POW_16 + div_frc) / VC3_2_POW_16); > > > > 6e9aff555db7b6 Biju Das 2023-07-05 409 } else { > > > > 6e9aff555db7b6 Biju Das 2023-07-05 410 rate =3D *parent_= rate > > * > > > > vc3->div_int; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 411 } > > > > 6e9aff555db7b6 Biju Das 2023-07-05 412 > > > > 6e9aff555db7b6 Biju Das 2023-07-05 413 return rate; > > > > 6e9aff555db7b6 Biju Das 2023-07-05 414 } > > > > 6e9aff555db7b6 Biju Das 2023-07-05 415 > > > > > > > > -- > > > > 0-DAY CI Kernel Test Service > > > --=20 Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds