From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C39EDC43331 for ; Sat, 9 Nov 2019 14:26:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D40220869 for ; Sat, 9 Nov 2019 14:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D40220869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0A8D6B0003; Sat, 9 Nov 2019 09:26:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBBC56B0006; Sat, 9 Nov 2019 09:26:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AABED6B0007; Sat, 9 Nov 2019 09:26:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 93F976B0003 for ; Sat, 9 Nov 2019 09:26:42 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 294EA180AD806 for ; Sat, 9 Nov 2019 14:26:42 +0000 (UTC) X-FDA: 76136965044.26.wave57_5790c8b33761d X-HE-Tag: wave57_5790c8b33761d X-Filterd-Recvd-Size: 4661 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Sat, 9 Nov 2019 14:26:41 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id z6so7719996otb.2 for ; Sat, 09 Nov 2019 06:26:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fkse6mn+BlbyKaVzVIbzg4CVFkjF596d7A0VyrrgtRU=; b=dtillIU18QyRR0Sizu4XPquIdJQCYl3+L6amsPThH0BM+F/qeFH5uBS9rX6gtuvIhi Qme1/TszQ0vkoYvZqSmMNOyz3Vemb3wX97qoByoj3dGZjzO7fmfyusbPiC5Xqrd4pXHQ DQISvVe7daUwmN7DrxIX3qty2UB6PctmmIFEed+41fgf6shHBkaEKU7uxQgIl8SHR543 9AQa8Qzg4byM4X2dJAULay7WfNvMqhYF0vTY40YOOAbJJMl+SJ3x+/zW1EmofH3PeoQ4 EKSImdyLxbkxm63ST4xOR2Zs6ACNDiQGTeaTiNNmJg95lQCzG+aqOLqrNuIm4hE1hxJk 4Z+Q== X-Gm-Message-State: APjAAAU8lRDwuWsTLgYiQ4cGCz1c23mxZQ3pVFMMDlPGWCMds3y3Iy6U TsP3MGYgY9/Zhr7/+3g1Iqb0HeHS+fn436Ddy0I= X-Google-Smtp-Source: APXvYqwpjgCj+NHQWmmo7wlASzZaObwnisMuzQQ68HgJW5L0F4ZE2XkJ/WLy2vxRTaOAABifbqXLM9wt0RfHZ30Isk4= X-Received: by 2002:a9d:422:: with SMTP id 31mr13203157otc.107.1573309600743; Sat, 09 Nov 2019 06:26:40 -0800 (PST) MIME-Version: 1.0 References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-6-git-send-email-rppt@kernel.org> <20191108113917.a9c6ebb8373cc95fd684b734@linux-foundation.org> In-Reply-To: <20191108113917.a9c6ebb8373cc95fd684b734@linux-foundation.org> From: Geert Uytterhoeven Date: Sat, 9 Nov 2019 15:26:29 +0100 Message-ID: Subject: Re: [PATCH v4 05/13] m68k: mm: use pgtable-nopXd instead of 4level-fixup To: Andrew Morton Cc: Mike Rapoport , Linux MM , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , alpha , Linux-Arch , Linux ARM , linux-c6x-dev@linux-c6x.org, Linux Kernel Mailing List , "Linux/m68k" , Parisc List , linux-um@lists.infradead.org, sparclinux , Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On Fri, Nov 8, 2019 at 8:39 PM Andrew Morton wrote: > On Tue, 5 Nov 2019 09:15:27 +0200 Mike Rapoport wrote: > > m68k has two or three levels of page tables and can use appropriate > > pgtable-nopXd and folding of the upper layers. > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > include/asm-generic/pgtable-nopmd.h for two-level configurations and with > > include/asm-generic/pgtable-nopud.h for three-lelve configurations and > > adjust page table manipulation macros and functions accordingly. > > This one was messed up by linux-next changes in arch/m68k/mm/kmap.c. > Can you please take a look? You mean due to the rename and move of __iounmap() to __free_io_area() in commit aa3a1664285d0bec ("m68k: rename __iounmap and mark it static")? Commit 42d6c83d6180f800 ("m68k: mm: use pgtable-nopXd instead of 4level-fixup") in next-20191108 looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds