From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDBB1C6FD19 for ; Thu, 16 Mar 2023 16:32:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E2E900003; Thu, 16 Mar 2023 12:32:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81DAE900002; Thu, 16 Mar 2023 12:32:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70C67900003; Thu, 16 Mar 2023 12:32:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 63485900002 for ; Thu, 16 Mar 2023 12:32:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 28EAAC1419 for ; Thu, 16 Mar 2023 16:32:36 +0000 (UTC) X-FDA: 80575304712.06.09BF506 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 2A78CC001D for ; Thu, 16 Mar 2023 16:32:33 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678984354; a=rsa-sha256; cv=none; b=7n65FpOukhSqvhWTNmNpZ3S1vgebRjxEJd2HRYF8EB6AP/MdlfXFgV//ghEhxOqNfpcceK 2RCIpd+qngDtjmsCsLOfCH0Orru1kOlhOVzbH2fKT3iuWsgcXmeJ+Pj00kwH/BNXEbVNr1 CFelmj+k2d4eImCJfy/R9YDlmKNgMOI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678984354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgcdy0Q2UM92NkuqSo6yI/I4/kIvBnyOPq4TXfCrfno=; b=J01ZbeaMQ7Z820WPdVOWV/fXJB2aRipOBRkWwfzpPqlZIkBPd6qj/VKnKeIO8va/HYq22r TnduxUGU3wyP+xfNjQF4ICy9fyoDn6st0RbwJuzaCHzzFsX1r/H/xo5Ls0EbyI8R2BZkJD j0OoAQrgXo/PMniIZjr+nmARhBtOc2k= Received: by mail-qt1-f182.google.com with SMTP id h19so2362070qtn.1 for ; Thu, 16 Mar 2023 09:32:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678984353; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jgcdy0Q2UM92NkuqSo6yI/I4/kIvBnyOPq4TXfCrfno=; b=JWWpI9A/+hbXccCXWb1KE9+nB8q5whpqLqz2whdMPROKJaVfhve1JHz/SxRnA0f6qn DvxF1r2Bv2mZyLn4Dgli+NGgpEr33Y2fxa+JM6wEu/TQVIIewiggOUxvs5TUZbX/yFO0 yd1fvlWKIkrHICM89slCFZWB+YWUBMnd2CL1acOufZX/hKZd2TdlSe/W3rNmKhQVODJz MqF11GmbTsTpkPCT18h0s0ss98UtXMUClDkHsikkN+D2+8V2fyLLGG7yJ3ATJk+pRsA+ ovm5KGwo1Nm//dab3vSaYnHQ+qjmDLadvzF3OlQYv9W4ifnpxoDkD+ItvUo9jaI6Y6c5 uqgg== X-Gm-Message-State: AO0yUKW8ce9weyA3n1hhlhwETC3sJL0uG+XfSMwUlvdXueQiVTZ8EzgN k5t8O5u6vTa+SQpEXCHdydd7mJNryCSugw== X-Google-Smtp-Source: AK7set+OszpCiVIoo7mAOG1yj01i2gv38kkgqT5wYchC6HAw+rtU0xW1ffzubFHzdMuJZe5iarwkMA== X-Received: by 2002:a05:622a:85:b0:3bf:b70b:7804 with SMTP id o5-20020a05622a008500b003bfb70b7804mr7333550qtw.25.1678984352942; Thu, 16 Mar 2023 09:32:32 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id g126-20020a37b684000000b00742a23cada8sm6087898qkf.131.2023.03.16.09.32.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 09:32:32 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-541a05e4124so42863007b3.1 for ; Thu, 16 Mar 2023 09:32:32 -0700 (PDT) X-Received: by 2002:a81:ae5e:0:b0:541:a17f:c779 with SMTP id g30-20020a81ae5e000000b00541a17fc779mr2625005ywk.4.1678984352328; Thu, 16 Mar 2023 09:32:32 -0700 (PDT) MIME-Version: 1.0 References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-15-willy@infradead.org> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 16 Mar 2023 17:32:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 14/36] m68k: Implement the new page table range API To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2A78CC001D X-Rspamd-Server: rspam01 X-Stat-Signature: k7o41c96qn9rgy5qe846onnh4t6nadnj X-HE-Tag: 1678984353-746642 X-HE-Meta: U2FsdGVkX1+kWzgzh7BH59WFSWQsr1+FgRzKRhSXbIm+E3337YRA01neXtWdlEf+QtqOOdZ1XVl72rk9bvCWsQhlAWNh9bzByaNkf62MO9zjLi7Sh+catltYsZDis63fL6FOWgc7SyoXj6N2F/C3GRGB58WCYRpQH8V/j66Jmz7Vaiq007kPVeUvzeo8WJ34uIDutvjRIRmY9gx98Tei4doaGfOp2utTQXR/8D1uSyAXnYPHkgBqaPCJ7/0JVTp5W3Plrpw/cqMjcaQ0c2gtjzK45Z4cqr7sJ6Ny7DtYS27MmqA72JgPjfPpg7rwsZloujXTA/uPjMGcyiDoLjZ3kdqt25iok9qTqyNW1mQ1MPv5+JzAwZHz6OLxfCF5xN2FweQa4YPr0tAh8kRZXNSyms/ad7/IbGkMB5p0BDglO6L0Lf1tI26ekVxjntAJRAj8XuBu6UuPljrvmy2E2S/4Bh8TOEohxfyn0iuF671BLpeEm0KO2lvt/uY+ZqyTnzii/Giq9uSvhqu96XLEEQJSRz1PaoFf2fLDDXVnN6eL4Q7EqrzfOKcvy+CI9N39NM+AkHuRZPYTtPsFytdZYvkq+RaJ0omHbNk4pAt1PpQSE6WKyer1crVnZnxPVvbAR1DdXrBavI91eKS8585aI1tr1CEFwnLDEz77nYJF4L3WTdfRbApNFH0lqDFMsczZT5aOskbiHXiAW43y1HfkWJAw+0fSu+hr4PnEUOr1kwXMuGUrZe6ON6J6RliTaCFTz7CnyVz7anaFvTbRUmkVXS7RACmaL0BK4BMa5O/h5SQuRdQDVdIwQEGUQNq3OmtDpub1Y4jMW5FhSLOWEaj1jypJKjwmNVjRCmVTjiC3wLtO1dDIyTbCNpuzZ3OSfJJ6ffij49iWIjQrXQu/MV0Ac36k0qDGYUZqlq71v7OwsLTjdB1x1VkKfnUwTZQH+xZiBrzrx3s/+Z1RbLqwRinAmBd iZgua9YF ZdWtkMdobiLpqFXajIeqFNdtDz1zYTcR8H7dNLwqeUSyS1FzFRFzZeBn6x1zuDm3wsWx5mnCwytAOXn1537k5Jx/DDWJjZk+Qm8seBYUzko5ImAA5DV8JFJ3Parn0lG98QZ/+JBM2DEl/5UUfyVA/lTvY51jt8lioWzQ431JROaQL/i9TpCVSxYnRsJPrMlZi+VHrYLlWTGJGJRzQUTirOJ88Xdk2/2HaYiKGZLyTl6yi8CrlflXJtKHMXrgWq3wl/iVUyQjX+2JNkBcnic6SD8nG6EoigPv3xHNISUBimTpCJSmZ2bJMhNnd4F4xxvjMLoPgs8zsGhnf/6ixIpjjhmzUpxbahg9KVdnDk7HyXM2hD7xOGxNFLd0yI25q/jAaRizSwtNztvcWsEm4djP+7Q4+QpvhA3H8g90wdSxkeqk8ypeigf93eXAz5ckZVIIZ3ONmUvxNfkDnye39Ul9NQWQ5eZL4MWZsEKyGQTb576XpGmFojkIS8k158bI6+B+MbNm42O8+xTM2S2uU5e939PdbOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 8:43=E2=80=AFAM Geert Uytterhoeven wrote: > On Wed, Mar 15, 2023 at 6:14=E2=80=AFAM Matthew Wilcox (Oracle) > wrote: > > Add PFN_PTE_SHIFT, update_mmu_cache_range(), flush_icache_pages() and > > flush_dcache_folio(). > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Thanks for your patch! > > > --- a/arch/m68k/include/asm/cacheflush_mm.h > > +++ b/arch/m68k/include/asm/cacheflush_mm.h > > @@ -220,24 +220,29 @@ static inline void flush_cache_page(struct vm_are= a_struct *vma, unsigned long vm > > > > /* Push the page at kernel virtual address and clear the icache */ > > /* RZ: use cpush %bc instead of cpush %dc, cinv %ic */ > > -static inline void __flush_page_to_ram(void *vaddr) > > +static inline void __flush_pages_to_ram(void *vaddr, unsigned int nr) > > { > > if (CPU_IS_COLDFIRE) { > > unsigned long addr, start, end; > > addr =3D ((unsigned long) vaddr) & ~(PAGE_SIZE - 1); > > start =3D addr & ICACHE_SET_MASK; > > - end =3D (addr + PAGE_SIZE - 1) & ICACHE_SET_MASK; > > + end =3D (addr + nr * PAGE_SIZE - 1) & ICACHE_SET_MASK; > > if (start > end) { > > flush_cf_bcache(0, end); > > end =3D ICACHE_MAX_ADDR; > > } > > flush_cf_bcache(start, end); > > } else if (CPU_IS_040_OR_060) { > > - __asm__ __volatile__("nop\n\t" > > - ".chip 68040\n\t" > > - "cpushp %%bc,(%0)\n\t" > > - ".chip 68k" > > - : : "a" (__pa(vaddr))); > > + unsigned long paddr =3D __pa(vaddr); > > + > > + do { > > + __asm__ __volatile__("nop\n\t" > > + ".chip 68040\n\t" > > + "cpushp %%bc,(%0)\n\t" > > + ".chip 68k" > > + : : "a" (paddr)); > > + paddr +=3D PAGE_SIZE; > > + } while (--nr); > > Please use "while (nr--) { ... }", to protect against anyone ever > calling this with nr =3D=3D 0. > > The rest LGTM, I'll give it a try shortly... Still working fine on ARAnyM, so Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds