From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC8C4CCA47C for ; Wed, 6 Jul 2022 10:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC296B0071; Wed, 6 Jul 2022 06:03:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48B9C6B0073; Wed, 6 Jul 2022 06:03:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A22E6B0074; Wed, 6 Jul 2022 06:03:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2BE576B0071 for ; Wed, 6 Jul 2022 06:03:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ECDF121536 for ; Wed, 6 Jul 2022 10:03:51 +0000 (UTC) X-FDA: 79656238662.18.6C53CFD Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf10.hostedemail.com (Postfix) with ESMTP id 99EF9C0017 for ; Wed, 6 Jul 2022 10:03:51 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id g1so10631942qkl.9 for ; Wed, 06 Jul 2022 03:03:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=moQR5LBdu+yLzctPNV/vOqPzvGKHHurzxQlNOu9l9Us=; b=ltDZxgYgb9F4zmZIZq9p5QlnnOfYC9qyx0kT09u3bEvup0V1cmOdhOae9/5DIkfKlp p1ZUC7UbUABPu7e1QzdID4E8hWc1OTjZ35c3iAtehcVrtiTE5FB+qhIgbpwlkCPksFI5 gwSD3yerPCqOChOCZpOHf4mndttjfrFsE1y1tY6UquCNT18xsWhsfWG8JXdTRh81LNBI VOBafHr3R9DhDiODo85Jir5EUz7JCAfTkXrKGntlGpCsP9ArY/nhuGUQF/sE+6BpKrui kwjQpIVzjUQdeS1Tw36QKFiRqZB9PgmUbddNDEuW1Y3oRdY9SvaYeSQvTjrvW4YBApiT q90w== X-Gm-Message-State: AJIora88PhyDzc554vGhXl4o+a2MG6jpSD1/YjZowxn5CwdpZ/rldMJD wka6ApIK938EnZWT8Ot/79BJjewJoYDYoT96 X-Google-Smtp-Source: AGRyM1vZhex7Kok6accOIXFZhQTSTg1lb7KdVOt90oi8MoQ9QS31xEWyj2+Q/PQkQLI7B8Mqi4rQHA== X-Received: by 2002:a37:a17:0:b0:6af:a57:25c4 with SMTP id 23-20020a370a17000000b006af0a5725c4mr26174977qkk.168.1657101830765; Wed, 06 Jul 2022 03:03:50 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id fb10-20020a05622a480a00b00304e2e4bf1esm24378647qtb.88.2022.07.06.03.03.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 03:03:49 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-31c86fe1dddso87116607b3.1 for ; Wed, 06 Jul 2022 03:03:49 -0700 (PDT) X-Received: by 2002:a0d:c787:0:b0:31b:a963:e1de with SMTP id j129-20020a0dc787000000b0031ba963e1demr44581975ywd.283.1657101828958; Wed, 06 Jul 2022 03:03:48 -0700 (PDT) MIME-Version: 1.0 References: <20220630051630.1718927-1-anshuman.khandual@arm.com> <20220630051630.1718927-22-anshuman.khandual@arm.com> In-Reply-To: <20220630051630.1718927-22-anshuman.khandual@arm.com> From: Geert Uytterhoeven Date: Wed, 6 Jul 2022 12:03:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V6 21/26] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT To: Anshuman Khandual Cc: Linux MM , Andrew Morton , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , linux-csky@vger.kernel.org, sparclinux , linux-riscv , linux-s390 , "open list:QUALCOMM HEXAGON..." , "the arch/x86 maintainers" , Christophe Leroy , Christoph Hellwig , arcml , "open list:TENSILICA XTENSA PORT (xtensa)" , linux-um , linux-m68k , Openrisc , Linux ARM , Thomas Bogendoerfer , Parisc List , "open list:BROADCOM NVRAM DRIVER" , alpha , linuxppc-dev Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657101831; a=rsa-sha256; cv=none; b=DcNtHH0/ua/9eZ46gyWvC6W1st/1XpnByYeVEdad58q4GEi480RCffDcxJxmq9epmhBZM1 inM3FcC6BBKXSvfj/KUz1JyKIYPZ+yNcecHnvVEmtpMaXkyqBEm97hym0m0PmZ2NGqgkKU xNes00ME/2Z8ZGNPeB6dvFrAzR+sKBA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657101831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moQR5LBdu+yLzctPNV/vOqPzvGKHHurzxQlNOu9l9Us=; b=ZCfsGsohdsUPYfaU8Q10ST+4bwbJUqKGA+Imx9U1TO9mA7d2Chka1Pcqo6rzleH1f+cuqM q/e3/Y0l/cLint1mYTXvvzyw4IuZNZvoCJAuOPC6oUmqzkcLIW1fdFdlZdik1OvjvZ9O+m 63ove+FCsbY8NYaiMh8+UmteXEf2+XI= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 99EF9C0017 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-Stat-Signature: m9pkaandhzdt5tc5ajo86n5zchik6ya3 X-HE-Tag: 1657101831-308138 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On Thu, Jun 30, 2022 at 7:19 AM Anshuman Khandual wrote: > This enables ARCH_HAS_VM_GET_PAGE_PROT on the platform and exports standard > vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, which looks > up a private and static protection_map[] array. Subsequently all __SXXX and > __PXXX macros can be dropped which are no longer needed. > > Cc: Thomas Bogendoerfer > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Thanks for your patch! > --- a/arch/m68k/include/asm/mcf_pgtable.h > +++ b/arch/m68k/include/asm/mcf_pgtable.h > @@ -91,60 +91,6 @@ > * for use. In general, the bit positions are xwr, and P-items are > * private, the S-items are shared. > */ The comment above should be removed, too. > -#define __P000 PAGE_NONE > -#define __P001 __pgprot(CF_PAGE_VALID \ > - | CF_PAGE_ACCESSED \ > - | CF_PAGE_READABLE) > --- a/arch/m68k/include/asm/motorola_pgtable.h > +++ b/arch/m68k/include/asm/motorola_pgtable.h > @@ -83,28 +83,6 @@ extern unsigned long mm_cachebits; > #define PAGE_COPY_C __pgprot(_PAGE_PRESENT | _PAGE_RONLY | _PAGE_ACCESSED) > #define PAGE_READONLY_C __pgprot(_PAGE_PRESENT | _PAGE_RONLY | _PAGE_ACCESSED) You might move the *_C definitions above into arch/m68k/mm/motorola.c as well, as they are only used in the latter. > > -/* > - * The m68k can't do page protection for execute, and considers that the same are read. > - * Also, write permissions imply read permissions. This is the closest we can get.. > - */ > -#define __P000 PAGE_NONE_C > -#define __P001 PAGE_READONLY_C > -#define __P010 PAGE_COPY_C > -#define __P011 PAGE_COPY_C > -#define __P100 PAGE_READONLY_C > -#define __P101 PAGE_READONLY_C > -#define __P110 PAGE_COPY_C > -#define __P111 PAGE_COPY_C > - > -#define __S000 PAGE_NONE_C > -#define __S001 PAGE_READONLY_C > -#define __S010 PAGE_SHARED_C > -#define __S011 PAGE_SHARED_C > -#define __S100 PAGE_READONLY_C > -#define __S101 PAGE_READONLY_C > -#define __S110 PAGE_SHARED_C > -#define __S111 PAGE_SHARED_C > - > #define pmd_pgtable(pmd) ((pgtable_t)pmd_page_vaddr(pmd)) > > /* > diff --git a/arch/m68k/include/asm/sun3_pgtable.h b/arch/m68k/include/asm/sun3_pgtable.h > index 5e4e753f0d24..9d919491765b 100644 > --- a/arch/m68k/include/asm/sun3_pgtable.h > +++ b/arch/m68k/include/asm/sun3_pgtable.h > @@ -71,23 +71,6 @@ > * protection settings, valid (implying read and execute) and writeable. These > * are as close as we can get... > */ The comment above should be removed, too. > -#define __P000 PAGE_NONE > -#define __P001 PAGE_READONLY With the above fixed: Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds