From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA859C433EF for ; Mon, 25 Apr 2022 08:24:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C1998D001D; Mon, 25 Apr 2022 04:24:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 472438D0006; Mon, 25 Apr 2022 04:24:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339028D001D; Mon, 25 Apr 2022 04:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 23C498D0006 for ; Mon, 25 Apr 2022 04:24:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id EA4AF82930 for ; Mon, 25 Apr 2022 08:24:46 +0000 (UTC) X-FDA: 79394715372.09.55800E2 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf08.hostedemail.com (Postfix) with ESMTP id AAA7C160002 for ; Mon, 25 Apr 2022 08:24:41 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id v2so3137951qto.6 for ; Mon, 25 Apr 2022 01:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/re6+Ak0/fc+uJjRwCS2l54bhVpG5GK4J73hEmUsv20=; b=uvZiwlOFkWWpZmv9euneDaXnP+xRj2HKMIthEYHDDVBXiRGPrCFm4jBfjWTEYmSx2L kd7xtmhTpFC6M7hi7NUptGTns7xQIbVSr7qcASlB9A8yQ0rsDOoc2Dqv7XOGymdKdHup wWv4noMIrKWBurSbegInGuMfUR5czsaKzW4j+Bb75NdG4jPzK8HdIhtxlDiGVoHuYQxY YV3fbI9IpSOOr3kqsvERV2YuTocNqV01JOTjyfGLICuUuMmHVa2rMXVHFZAPrgrtCunW h7r/omLmLnKznCuShb7WF64DSmQk3SWaFLD7LYHAdCZCgQ31Fj5d8rMfx1oWa78/avZs 4SRA== X-Gm-Message-State: AOAM531Aa+yEVgeKMLD7uHDoAGw16WM0Pj5F63/O8Vbae4ynI+H/OpjE /mZE3hIjjHlsGtUw8cPDSs4/axURQXtOpg== X-Google-Smtp-Source: ABdhPJzuZYD1GVgmRkidh+lNnyKUKCtXHqioZ/f/Vokek8OwG0bAY64BhTIavOeUJJJE/D9Bj+yQsw== X-Received: by 2002:a05:622a:1106:b0:2f3:479c:54ea with SMTP id e6-20020a05622a110600b002f3479c54eamr11218970qty.158.1650875085108; Mon, 25 Apr 2022 01:24:45 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id d65-20020a37b444000000b0069e9f79795fsm4678252qkf.67.2022.04.25.01.24.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 01:24:44 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2f7c57ee6feso45326527b3.2 for ; Mon, 25 Apr 2022 01:24:44 -0700 (PDT) X-Received: by 2002:a81:c703:0:b0:2d0:cc6b:3092 with SMTP id m3-20020a81c703000000b002d0cc6b3092mr15284248ywi.449.1650875084343; Mon, 25 Apr 2022 01:24:44 -0700 (PDT) MIME-Version: 1.0 References: <20220415164413.2727220-1-song@kernel.org> <20220415164413.2727220-3-song@kernel.org> <5e5e4759efef83250f9511d4ab0e1ba34f987ce5.camel@fb.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 25 Apr 2022 10:24:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 bpf 2/4] page_alloc: use vmalloc_huge for large system hash To: Linus Torvalds Cc: "song@kernel.org" , "linux-mm@kvack.org" , Rik van Riel , "linux-kernel@vger.kernel.org" , "bpf@vger.kernel.org" , "rick.p.edgecombe@intel.com" , "hch@lst.de" , "akpm@linux-foundation.org" , "daniel@iogearbox.net" , "hch@infradead.org" , "mcgrof@kernel.org" , "ast@kernel.org" , Kernel Team , "imbrenda@linux.ibm.com" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AAA7C160002 X-Stat-Signature: ycemc6k5u1ggmprm6rxbq3m58c5ff6iq X-HE-Tag: 1650875081-749300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Linus, On Mon, Apr 25, 2022 at 10:18 AM Linus Torvalds wrote: > On Mon, Apr 25, 2022 at 12:07 AM Geert Uytterhoeven > wrote: > > vmalloc_huge() is provided by mm/vmalloc.c, which is not > > compiled if CONFIG_MMU=n. > > Well, that's annoying. > > Does this trivial patch fix it for you? Thanks, yes it does. (at least it fixes the m5272c3_defconfig build, no hardware to test). > I get this feeling that this could be done better with a weak alias to > __vmalloc(), and that could take care of the "arch doesn't support > VMAP_HUGE" case too, but the attached is the stupid and > straightforward version. Sounds reasonable. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds