From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F784E64002 for ; Thu, 21 Nov 2024 18:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE7026B0082; Thu, 21 Nov 2024 13:50:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6F7F6B0083; Thu, 21 Nov 2024 13:50:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E98A6B0085; Thu, 21 Nov 2024 13:50:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80B746B0082 for ; Thu, 21 Nov 2024 13:50:51 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3FA9D1C80AD for ; Thu, 21 Nov 2024 18:50:51 +0000 (UTC) X-FDA: 82810991172.03.6BBB243 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf30.hostedemail.com (Postfix) with ESMTP id C383B80012 for ; Thu, 21 Nov 2024 18:49:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732214981; a=rsa-sha256; cv=none; b=avI7ficlnhEfk3p7l0UcN2wIVRqRUnCkIYiZnZ774NH8ERrKtrjJyyVt+wRyJ58a7knTgU sB42dm6oye26jrapAxomVLeu++Thhbm/TEJd89WJBpxRQi1RRnT0ywXdxyWXKdF42IoEm2 tiA/hANM6auLbpAgOz8+dnLH4S82Zdk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732214981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1SoflphJdSTWjWlYBW10VBQhVvyygIYFn3eyN0CY8E=; b=CtZLZsZUX+vYBQbPYv6l/ANMy6FraCNnzuwFSZ0S5GurIrIRmpH2g6kfjHoVWLL6XJGq+0 6QTKcuadzSbqih8ViVRoeaOKlxHG2XCfQcdlBxjyRcQc22Dz7l39Ob66J2FMrURWpzdwC4 eCiZ2LAzuW3b2ia9gFoIplobbna5OdU= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-6ee8e894deeso12474767b3.0 for ; Thu, 21 Nov 2024 10:50:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732215047; x=1732819847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N1SoflphJdSTWjWlYBW10VBQhVvyygIYFn3eyN0CY8E=; b=T4DFXaN8aOgH/w7hINO0vMHHM9HVXP1zw41SctduxAPIix5o5xWwR+0gqDxUFmxKhH 0ep7ZUGNK3nh5KFjNh0ElSBdWzep1fHQ7LE04UO3btqWwGn8aGyVyOBjWPS2Ip91ePO7 1WrCclOk4KARJ/llzn9J9xYa83LQuwQRGG6kfPgz2YhyNKea68S1k9COl1H3m5RlWa9x q4gqzTFgXWKcqD0I9CYiFqKEED+TjwYI5oQcMfEk/5lWrQdY+7AJc6ovQGd/9Tii1+I5 PMi7QY41HJomPc71CFlyC11EfXSDqxODif6f173og/YoRboEtAk8cF+nCOHPNRWnUFMt LuBg== X-Forwarded-Encrypted: i=1; AJvYcCUWiy3N2dYpyTkSOy3cXUchApoC9wyzB3v/c17KKNxVNL7azpvrb+ga2HKDCLU6502tD7Cv8UvH/Q==@kvack.org X-Gm-Message-State: AOJu0YzS0sGd8XjKuvodZZQoQGDP46lYrLwglwq4qDahoVZ5Ov+U05cZ dV+c/9URPNbsegPYu7lVZJSC0TNyD39lz53LBk1j4+o964TFbAHBDrNsYjL3 X-Gm-Gg: ASbGncvfgdtZphI81Tzfh17j+GNaTGzntT2G0K94tpFa7gTEkUGKrkKTph55DqzvM3R JBTuUMHqKGs/lOknmoHROF8sUJxT083GGltpNPXLgXDLYcD+dWBEecbq1Q/pJAaYrE897njY8Cn 8AxCVkXt7nTit3PEOxcmMSba9Vpn7f4Barv4ZZCdfJNqlLO8/wVkGNRHOi9x+h/x/gkXsANaioi /6TjzVPNcJLMGQZDmF6T26e5yEH5z0dcd+FSsDGf7/ktmjp3V/YFhovgTwdKbRNkLZ1NXXRluBb 4tAHwhPMvwkMRVBG X-Google-Smtp-Source: AGHT+IEG3jiHXuKS0gD5wcjBllJ4j0srQ8eVAAK66PoiDvrzv27f/RoBfVlEiE7b7asSO8rEu5Uavw== X-Received: by 2002:a05:690c:9b13:b0:6ee:6e71:e6cf with SMTP id 00721157ae682-6eee0a5b66dmr3759527b3.29.1732215047116; Thu, 21 Nov 2024 10:50:47 -0800 (PST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com. [209.85.128.169]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6eedfe2a24bsm721757b3.35.2024.11.21.10.50.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 10:50:45 -0800 (PST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6ee6a2ae6ecso12193027b3.3 for ; Thu, 21 Nov 2024 10:50:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXfe4dd/zG9Osin6fOmSxPLLB9Nw7CzEQPga4eWjXnO9PaaKnBTC7RVxYf93sPLGGrDLRwvMfpWtw==@kvack.org X-Received: by 2002:a05:690c:6a01:b0:6ee:86da:3a49 with SMTP id 00721157ae682-6eee08aba14mr4213967b3.8.1732215045390; Thu, 21 Nov 2024 10:50:45 -0800 (PST) MIME-Version: 1.0 References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> <693a6243-b2bd-7f2b-2b69-c7e2308d0f58@gentwo.org> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 21 Nov 2024 19:50:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() To: Guenter Roeck Cc: "Christoph Lameter (Ampere)" , Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike Rapoport , Christian Brauner , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: C383B80012 X-Rspamd-Server: rspam11 X-Stat-Signature: 8jnq7mw4si3t3sdt1thsgrfn81hxc4om X-HE-Tag: 1732214948-601896 X-HE-Meta: U2FsdGVkX1/T/z3Wu8DikpX/4xus1vFhwToKMyOhKUm/7YqZElmX7XgfAyTERJY3T2CNqkgSWof/OWQKlhCOWdO8jPcY1rQFL/ytu35vgXBJgqCBzhT/Xyb1HTBLHNU3Q3Nb6LA0NHcj3KVb5dbP75zXfW+mliKh44RSfP5TZ4HH+ox720XyMBoQGwAjhQSh+gr+Jb4PnRHEoib2OzBi/SYhlZfGC98W/wploKXMFU6WRqsmjxid7lK+QAZYMFKe5JhlX5/XqCCnbSJfTri1YS0dKDg4KQOjWtqzUh82PA4/eL+QY8j+S56vlOxefWPplhEkqKm6WchOlBHHQnwPgad4uNO8ABIX+bK7h+cJ1KnDUnqqYJGrwdc9Yw1oaPe4sRSfzEkTufovsHFvFMw18hTwhUjOqgB7WXf4aDXDQlq67s/nxKhqtQV1TVvOJNMrUiT1/wMXBoP0O3l3VVSL166F77FIM4+zMpiTsEOfRaTtqYzbAsMaH556vB+FhlOygaObEqEGylMGesOm86Zge6+3c0kHVMK/eygk0noGb7YJQIF9uGZVOk7OCKq9N/P+N8ZXEZX4KdLPyMPd7llUuuThprTDFT0IhJlNdWzeavPsE0k3pFCHVqryoj1q4JCNXzkaWatbDSSN8KwIchUX7GgTTMSrx/cw/02c07rmilYoYHn1Xof4zYpxOlWTEJbLbeHQibHMKqTPW5nN1ttgLZvA2lzH90KeXGSPfs/Lp8yVJtCKfFjkYKBG7IL9WiIORq1GvjewiQOHy8MGVFsBPrL1SwlQhHp1pvNZQ6fpkhr5DELvwJDrjO92ZqtLxWFHZGtFg1twwq1iXKu/j8LR29yipsYYtiFprWR1kC3QqVs+/RNX0W/kwotnvZ0tjkl8T/HaEHfADqB5+Ol3b4BBrY26+lT2xcZVJMEqYE9MrVT7A8z6+M0CR/RIMVxdH2B9QySbAbJSq8lJ6uilJLE ZocSh5rp D9gtf95Le3Uz7jrrEWn7xSCdCFZ36DOxlOAOgHV/itLP1hmOPoWPgFNuOMbkhbnp7Yvsmcb/bkfeBTZHtzhOuZZBKyIh+cZ4owmUP/+xXi60Aw8HBltpsw589n9vfUNqHqqQlIrjnnNL77G7CYAFV0W2UciLWXwgKHoJbSs1rlonURpcGuvfU/1cEAkR+bQ9ROx+SDPZdPUXcvZPDVJMO5lB2RLgUNOUrdigEErHNYIFp1UWAkmqi9Y4nFLrsWpNIKzk6Dn+9DFQ4bMDm2HaHoQhL5Jr42qJLTbtX4TwK59/P64kRx4REqJEw0oZhwVaXE2My3nXpJYNqZfYoNF8Nw/AyiBdeZl0KO4uunyyaPrSzJWZ0CKNUA3GpdJqCd85T7InBQ1tswPGenEL/VbLo/0hvUdybNClWt1OWQLbCFz8sqDyD4lP/Fey34TqFQrNfUP74e3Sd1vUo8SB3z9XyNsXzOqfG3ABEbVUUyMhnqKEz2yslDesHj2jw7O/29Spp7fAKsv5KhmX/ZLxejCnBd6OQWHoef5SvbpFKK/rBJA9RSOSnkZwx7NwkeZR4AlKeEhOx84zSFHG4NSM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 7:30=E2=80=AFPM Guenter Roeck = wrote: > On Thu, Nov 21, 2024 at 09:23:28AM -0800, Christoph Lameter (Ampere) wrot= e: > > On Thu, 21 Nov 2024, Geert Uytterhoeven wrote: > > > Linux has supported m68k since last century. > > > > Yeah I fondly remember the 80s where 68K systems were always out of rea= ch > > for me to have. The dream system that I never could get my hands on. Th= e > > creme de la creme du jour. I just had to be content with the 6800 and > > 6502 processors. Then IBM started the sick road down the 8088, 8086 > > that led from crap to more crap. Sigh. > > > > > Any new such assumptions are fixed quickly (at least in the kernel). > > > If you need a specific alignment, make sure to use __aligned and/or > > > appropriate padding in structures. > > > And yes, the compiler knows, and provides __alignof__. > > > > > > > How do you deal with torn reads/writes in such a scenario? Is this = UP > > > > only? > > > > > > Linux does not support (rate) SMP m68k machines. s/rate/rare/ > > Ah. Ok that explains it. > > > > Do we really need to maintain support for a platform that has been > > obsolete for decade and does not even support SMP? > > Since this keeps coming up, I think there is a much more important > question to ask: > > Do we really need to continue supporting nommu machines ? Is anyone > but me even boot testing those ? Not all m68k platform are nommu. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds