From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B4DD41C13 for ; Wed, 13 Nov 2024 08:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2CF6B00BD; Wed, 13 Nov 2024 03:19:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B63716B00C5; Wed, 13 Nov 2024 03:19:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6A26B00C4; Wed, 13 Nov 2024 03:19:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7BC186B0089 for ; Wed, 13 Nov 2024 03:19:58 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DB9F91C5007 for ; Wed, 13 Nov 2024 08:19:57 +0000 (UTC) X-FDA: 82780372374.23.84EA272 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 97A941C000A for ; Wed, 13 Nov 2024 08:19:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731485819; a=rsa-sha256; cv=none; b=plYD67TI2NMN4YLU8ZAjqLkOKnRlKNySQmPmrmq33egfEk1nVM8YEgQ7e9qtHuEW7L+Ddg yLf6ESS17nrY1F1PVwa4uw+F8Tj2gQArhlswXZzZuO3+XikbfnhSwNDYQ+Quk7+Jw1y/YV 8QpzPHfBNuU5h4o8dNj5z8I/0mHv0b0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731485819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A//o7AUbFlR1hR/WSlBOYJvvqpE2fTFXB/MVLNsxfNA=; b=B7ioVQBRY0cNTX7aTEa8pbsTPl1udnt7WCT6BRqCw3HwKPKG5EXOaeo9XGwtZXl2UM4IG4 X477bRuqV1iPmCJzavLxsJdrjavF7Hz4bdLYVEWP9GzvSB+NG4ZlWAjN3EqeBrOouMFqnL NT6xIEcolrSQS6AfMVO41wPVWne01GQ= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6e5e5c43497so52105367b3.3 for ; Wed, 13 Nov 2024 00:19:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731485993; x=1732090793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A//o7AUbFlR1hR/WSlBOYJvvqpE2fTFXB/MVLNsxfNA=; b=BEUXCTyLFnQ1bBrLjx5NMopzkrweGGkzdL7wY+RDckDRwkmHDvdZllKRLEkmHh3gn6 B/gfl/uKawZLmkJtZW1h4a2E2AtVRCi7vrclvkU7qYjgd/n5Hq/vVS0JUJE65IdvMCgn JJM0queAJG66zg8xacQAxXu8ibj5s5vEXAWKsZk6nWnBKEYD32hkO0YG9RUOCJSrSiNc omCEJPklKY+m6apQbUbNx+BVlE25HIsragl4Vz8/b9Ht0JJUsuxPtHNqAt9+T/1jDKEI U95MzajTaFBFlppf6JkDapSgOfnhGl0n/ewonmbBGpnyKMqCCW4lKibwwvyhztFDySDC oZBA== X-Forwarded-Encrypted: i=1; AJvYcCXuCaiEkjc5U/MHTyYU2To/CvKgfqXWJv0anLrVCCT8DgI3t1rFpb03hWcvkGw+t5Wz4s4HHhj76A==@kvack.org X-Gm-Message-State: AOJu0Yx88Ef4ViVTRD4j/hz+3C2Du5lHRgXIq5sO2fkhM4noDKfSdXuu Yl2EPb7xXq90D9dHeg0CdfiPIYGGeDObU7qiIqw5vHR37qFy50Q8fefrYqNy X-Google-Smtp-Source: AGHT+IHpgTELSlhaoKFSFb5668IZm7slfjGU6CNGccr26WSeW+ZVSreKdK2lNzMTlx82LlXSovFR5w== X-Received: by 2002:a05:690c:4b8f:b0:6e5:b6a7:1640 with SMTP id 00721157ae682-6ecb3484800mr21492307b3.42.1731485993161; Wed, 13 Nov 2024 00:19:53 -0800 (PST) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com. [209.85.128.176]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6eaceb09375sm30482267b3.60.2024.11.13.00.19.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 00:19:51 -0800 (PST) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-6ea339a41f1so56669187b3.2 for ; Wed, 13 Nov 2024 00:19:51 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUgBhu2llEPgISGtI5XEGiAEtzvITUGF3jYfSZLwb7/uFV1VUAHDECG+gtufhWjOJIIzDocu9vJkw==@kvack.org X-Received: by 2002:a05:690c:3582:b0:6e3:116c:ebf3 with SMTP id 00721157ae682-6ecb345f3e4mr26763207b3.28.1731485991068; Wed, 13 Nov 2024 00:19:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Wed, 13 Nov 2024 09:19:39 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 02/13] x86/um: nommu: elf loader for fdpic To: Hajime Tazaki Cc: linux-um@lists.infradead.org, ricarkol@google.com, Liam.Howlett@oracle.com, ebiederm@xmission.com, kees@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 51csxoy3qzuq6cwkee6qe4xn4wuyk1oo X-Rspamd-Queue-Id: 97A941C000A X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731485942-711502 X-HE-Meta: U2FsdGVkX1/hcH8GTtoqApRINxRv2CnOS/BhrB3wlTV7ln6GZ1/9964H6ROYHQLGarwvSJq9/8+0yB1QwN9J/33vNQckrialxwJaR1mroisE0lFsZc29upPTnLH0uz2BiwcRNoTBdM/FiLvgcEGOBE9o0LbpbDhyuZrbccwndPWORZKuE4sphnLxq/OzhqQofuWoHTn+wRS+1oMnGAaFElx4z1CYO4EVPnvR1zn/RiOVZ2MMoBquasGyB14wTPGbM2ebEelElu1XA7kuiMvDnskiD4y6zqDf0hR5JGKybtBaW23/d6O4eUHs8UNwBxpjeo6uaH0JJQtNMc7xhxp0ovBkaRWsTg5/7uwZVZr2IeZ1Pr3wSP/JZ0Td0xFZggn3k9pwGnqfNUCQl4PbsSXw5ZxccyhHR8kN2HzM7DsF+j3SiPDBUdHOO9wrWTyaCfvUZxBMYs9Wo0l4QFUzYTo+Rf3U4tjP4nIGGpqBkJC/8RVA151Dm5krI7NLa8x3LICRqeUpdFMo6kCFp1Iw4m0Td3AC9lgduY5Y95GXOi43sawhCTSEHDCe62PhhQkhTht5LbZRHsp1heHDQLJtdvv7V4zV1bYkzDTr4t10S4Y3K9ORZp3kZqRJnOGusAdlFlbpBzbXaYsNSHX3m+TjxfDRVp+/lyG0dYpyMJAGlP+8ITD2ANiHwAqk8GH05X/M1tvlodbEgvHXllg3HbGTW9f/Hg4n6XZG967x6xbEcGRyqV98M0mbTf5DRlRCSWuDg9FGa1GISb/NzaMvmlknuH1Qo+0LGQ0nVNyNwVsH2a6TBujnhX0hlouKOjXun/PJpmyxjG0VI7YCfTgG7f7zceGeYVZLXsx69bczhOII16uKC+xP5CeDf35ZmTlvF92Sulqmh3cKn9y1NM2EjdbFfGbkupdE+u5U4mZjl6UcnEMOoitGiotjLgvI3v6ZBXJW9mEA7bzKax9eO5gydb5DRZj G16l7m+3 4fdB7it26eg5HbFEPfJnKJuLFYkjRjxUoWsCs3uyfQTT92UrhkFJMw3sKWFz3+ysxEInteBSqDltJdGmly0X/UBzACkEJ9KKerVmjQ4uNN6b8ah9BGVm3f/Zhha36juMy6wGAAD8FIOO+RhCfN0+9a0lpwQ/hPoSGQGmOHBiCD/zTKcBwij5BPwpxO2IHva9KIdPmGBxU+u7TN/+I57UTFGWji4hW4OuRFgu6m+VqUsnTaMxqqXWSxPnKN01QgxNDK84xv6PJPaGIJgXaDR+ClpzOEjCPWHGyqqx6lXkvOJpcTGakt5sJzq140pBvWqdYORkYY6TLwNWtS1xKGi7UBewZhdhwwSiwKvmrJrB4gjclwow3dubdwJ2agiaQ7FXB5KHWpWvt/jL5zgImFeWa8QT46CYvwIVzRot3HWvfiEcZKQAn8EgQEeaVCwZuOxQcr3N7FYjkd9o/BIvqQ9Rq1PebVsapYZCumZsP9kpR5ytPN5NP9NJ1v5uX543c17kj0UygzNH3dtB+MtFOTNbiN3BeaPtVWIESomLZbXFpe6jS8jBikrIPhmDz2/tyTMHS/ylp3w7zC8ItSqrTMW0DA0OafjO2E8nOm0CmDMIXpwOGgPU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Tazaki-san, On Tue, Nov 12, 2024 at 11:07=E2=80=AFPM Hajime Tazaki wrote: > On Tue, 12 Nov 2024 21:48:28 +0900, > > On Mon, Nov 11, 2024 at 7:28=E2=80=AFAM Hajime Tazaki wrote: > > > As UML supports CONFIG_MMU=3Dn case, it has to use an alternate ELF > > > loader, FDPIC ELF loader. In this commit, we added necessary > > > definitions in the arch, as UML has not been used so far. It also > > > updates Kconfig file to use BINFMT_ELF_FDPIC under !MMU environment. > > > > > > Cc: Eric Biederman > > > Cc: Kees Cook > > > Cc: Alexander Viro > > > Cc: Christian Brauner > > > Cc: Jan Kara > > > Cc: linux-mm@kvack.org > > > Cc: linux-fsdevel@vger.kernel.org > > > Signed-off-by: Hajime Tazaki > > > Signed-off-by: Ricardo Koller > > > > Thanks for your patch! > > > > > --- a/fs/Kconfig.binfmt > > > +++ b/fs/Kconfig.binfmt > > > @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY > > > config BINFMT_ELF_FDPIC > > > bool "Kernel support for FDPIC ELF binaries" > > > default y if !BINFMT_ELF > > > - depends on ARM || ((M68K || RISCV || SUPERH || XTENSA) && !MM= U) > > > + depends on ARM || ((M68K || RISCV || SUPERH || UML || XTENSA)= && !MMU) > > > > s/UML/X86/? > > I guess the fdpic loader can be used to X86, but this patchset only > adds UML to be able to select it. I intended to add UML into nommu > family. While currently x86-nommu is supported for UML only, this is really x86-specific. I still hope UML will get support for other architectures one day, at which point a dependency on UML here will become wrong... Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds