From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9791CFA74C for ; Fri, 4 Oct 2024 09:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F8B26B00CB; Fri, 4 Oct 2024 05:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7CD6B00D0; Fri, 4 Oct 2024 05:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1705E6B00D1; Fri, 4 Oct 2024 05:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EEAE86B00CB for ; Fri, 4 Oct 2024 05:07:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 675B0ABF7D for ; Fri, 4 Oct 2024 09:07:40 +0000 (UTC) X-FDA: 82635341880.25.26BF4B0 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 827CFA0005 for ; Fri, 4 Oct 2024 09:07:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728032761; a=rsa-sha256; cv=none; b=ndl/801OSmUc53HOAtNMFiH7BfWXVWWvSIcRYewb7B6j9dZWTilKimPa6B9Wr9CXQr9cP7 7J3fdaP/xFhITs0uSFVZI/AlkavlwSn7Q00d28GKiU+P4pJAjoSBAA6R1bRna9I218vD4L 4QvyY/fkbllWqcbY2OaK4tITK1HT0zA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728032761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6chgMlM/7sl+CMw3ASA+dhKJBOdZlXw4dSmmetI2ODY=; b=HrCXmEzz+8xStfCuYbDymEtLIUZR9VCSbZSzlTd5mOUzNi2IiLh4qSbuVZfwkKDsn32awV Mf/5z91juNSnsUNFvjFa5gTJfLkOYfUeo9OTlxhJbRxYutpfX/7PVaF9pbtlIumP8166ez +vRYYQpJ32MZ4dCZZUJFLYj0tD7vO0w= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6e23aa29408so27263977b3.0 for ; Fri, 04 Oct 2024 02:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728032856; x=1728637656; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6chgMlM/7sl+CMw3ASA+dhKJBOdZlXw4dSmmetI2ODY=; b=CIKLdHSHNYumQy2QxUCpGnfmROFH0O3bKyBTsKtQ2mbjZI7lUwlIqHv0HjKa8GfhAJ /P9ubEwnoaC3Pf9VRzD+e3P7t0W1epffjjR0s/prm4OZUPHJvnc8yN0Y8UO6ZPgi5O63 a6CzoExU9XF7ZU65Tr/KJwWrb/utPF/tVxFV45pxpAIYgMAsVD8Sl1P5yN/YJKmaoXDc JLwDwx0y6s2/SBw+3mbSqZnjRbgxxZYs8w3OipIBEJpJoIh9mozSg7TAg8nHE3DWiCKh +xaWMpJ6GQoWXEGS1PMBORsNoYzGduDOGxEtynq6QNZsQlNtQMjatqG+TXwgebFoRnmT MzOg== X-Forwarded-Encrypted: i=1; AJvYcCVBGT33q22FMl2HxlVAgYbfNJdmyG0B9j3jqzqgxgWgBNWdNni0g85zo8qOkfWJYSURphkaQPcZQQ==@kvack.org X-Gm-Message-State: AOJu0YzvABSwaRhNDOWZPQivpMoEGs4jRbHqBMwcdVvFbgSy1/qMvS/5 eLYjqiqFxKbVZwA379i3YIAsOaxsNo+8TjvXIen+RwY4zUPz7nlKUrppFM0f X-Google-Smtp-Source: AGHT+IGe25EvapF42jO8icdI1CQGk0fky8mz7vbjWvV+qXIOs4DbGJ5wLl9NYvSWvVqodWV6D/piCw== X-Received: by 2002:a05:690c:63c2:b0:6db:d02f:b2c4 with SMTP id 00721157ae682-6e2b534c570mr50250857b3.7.1728032856568; Fri, 04 Oct 2024 02:07:36 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e2bbea9a4csm5753137b3.46.2024.10.04.02.07.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 02:07:36 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-6e255b5e0deso15476447b3.0 for ; Fri, 04 Oct 2024 02:07:36 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVp77BKOredJYJfjR+ZylRpmwSDtL9y5aO1FM6z3xc9Avo7fixPjeqwlhvtk2ebz+hk02JqHwTJtQ==@kvack.org X-Received: by 2002:a05:690c:6185:b0:6e2:2684:7f62 with SMTP id 00721157ae682-6e2b534de12mr42115587b3.8.1728032856220; Fri, 04 Oct 2024 02:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> In-Reply-To: <20241003152910.3287259-3-vincenzo.frascino@arm.com> From: Geert Uytterhoeven Date: Fri, 4 Oct 2024 11:07:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Vincenzo Frascino Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , "Theodore Ts'o" , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 827CFA0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 391m4kkai4w38xmjau9bgp4a3z7mxrqx X-HE-Tag: 1728032857-306934 X-HE-Meta: U2FsdGVkX18gsl+Cf93nbRli3SGFNuTBi2ZxauM3OLgDvC0TSPg1OIgtSVPe6CxsU5zPtiMBKtqBzxnbS/9mV7oKq2de5p9ZDLkTnUKmqB0PKeyAR3VLn/MzkwcAybCIbLMoCoo4W+k1UTeaAxWKd6hHS8nV5lJ/O8KPJWBkcms7OLjngsY3TOPcdjNs+LYGkelvs3ZoH6D9TGljTnbYoZUzeQtHOA+t2aeZ2qGNnGOWkes4hpIt3M+YC01+vo3iRszpT/I+Vg+DKtb5VRUi/Amue0f2W0xexEV9ue2E/qLkjHG7n8rDvR1Vot3YHmOS5M8Kkd7ynNs4/6Ry2tpIX4hnQn4ZZ7bWCYt7SOqO9q0qC8WH+cGU9xTdW5HT9LIFaluDdwDyRjUXdVCvuTbhCT9FKDUis8gcQrowK+qK7QHRcAOW8lGFjgIHhN9NLi+l483/VXV1WaYYVc89ZRYXJPfsg5JihVOh7ILxcKdbew5ysGzYTiLSjnruNndXi8wMKl8i9xEXmcRbkrDOzDwhHjM3Qhw1zVQszJE0gL7CIArj3OADsF5kRUV7qasGwoEFHB5+NlFtbAagKwiar3y7Kh6skTwal8mZTO66kslUl2xVhVVzO5OlWTJcYmx8rkPcS7fDOuebdAAqxwhIr6D8CZzcW4/jUZ5l7Tn0lSQF+vu136gmnIoJCbH4TwT0ugk0pByAKG+m1qANnuDuYlM7WOwC74P5uiy4LsVPmS8IaLYsumJ42jw/1U/QtRnOynWZjMt+w/8j/xR71Mr2El2VkmGOggKFYSGh22pyY0R14/Uvu4wYSjSpNijhbGeCcB1a3G9ymqJ+8scIL26nyQryf+du0OoEschtNWNmiVRasRO+imo8R2DKA0zBUw5Xq46Yx+DmIIi+EwRRBTty0NWEQ/4y8ohMQZyBNSslb2i0PDbBKKBrcJV3vWkKP5kTjjMqAJgX7KtI+g92Ny5c4JH QtMa0NrH ycIeYi2OqOLcTMiwlzTZ67dytyhNErhN3gHRELgVTHTMy+Yf5LtkRh433Gx7AA3ClADXNqRiUhkZVFv1qu4AxkWm8MGvxQ/HJk2chuVFebm6d0dmhekMrrHfnVwbaM33V7rnoFUvzsbzib1I43BbDEhpcOQ/A5P+Ph2L3jDdmQlStVAwXWReKRfJTGUSEa3zeCHVZMYoJyLq44yY9S29AgHgivmnc9fMpjMelEytpJ6WbbFo7WRsO+d2alm74krfDDH+dFK311KdbF6w8TcXUJKDKWf4tml/PKEtlYIj1MtKu0JP98VZGAu6+Mzpm84mkQ+UoaDD/metUYTKr7T+XyEWaUNSR19MpADDFQ0lQKrvVSEHnBToHDyLXOBVoBk1N2TISjKOz0Qf+E4mUfz3yo42exGd/gfl2eJNaBtb2ZHfAMVlfVekKp5AYmDdAf9PYKiwRzH+cPciTotUoxwRKXmr9r6tBkkqMPZyxvSg6FBM0OA3BnvoIVcXSKr4VyQhP5ThaPRef3LfrY4vZL+s/u441y7y5n40nor3ClHaVJPdGfPM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 3, 2024 at 5:30=E2=80=AFPM Vincenzo Frascino wrote: > The VDSO implementation includes headers from outside of the > vdso/ namespace. > > Introduce vdso/page.h to make sure that the generic library > uses only the allowed namespace. > > Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when > it supports 64-bit phys_addr_t we might end up in situation in which the > top 32 bit are cleared. To prevent this issue this patch provides > separate macros for PAGE_MASK. > > Cc: Arnd Bergmann > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Jason A. Donenfeld > Signed-off-by: Vincenzo Frascino Thanks for your patch! > arch/m68k/include/asm/page.h | 6 ++---- Acked-by: Geert Uytterhoeven # m68k > --- /dev/null > +++ b/include/vdso/page.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __VDSO_PAGE_H > +#define __VDSO_PAGE_H > + > +#include > + > +/* > + * PAGE_SHIFT determines the page size. > + * > + * Note: This definition is required because PAGE_SHIFT is used > + * in several places throuout the codebase. throughout Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds