From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13223C64ED8 for ; Mon, 27 Feb 2023 19:46:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E5596B0071; Mon, 27 Feb 2023 14:46:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 497186B0072; Mon, 27 Feb 2023 14:46:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35EC36B0073; Mon, 27 Feb 2023 14:46:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 24AC96B0071 for ; Mon, 27 Feb 2023 14:46:51 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E717FC083C for ; Mon, 27 Feb 2023 19:46:50 +0000 (UTC) X-FDA: 80514104580.04.34A82A6 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf13.hostedemail.com (Postfix) with ESMTP id E3AD82001E for ; Mon, 27 Feb 2023 19:46:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677527208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zgbfP6t1iEXlYeQDHgpgkGKrmlu/wPbkfmiZJDZsq5c=; b=DhvWw86YJJfjCuR5psYj21qOvqphZcPOXGGJXSM3mSXVQ333TnLxCoW/ec035KIjjPximH Hp2u+JopBt7uvK7E5jBKDLVgPiSoFTm8LQ6s22WZ4Px5/qXqeJ2XDR9df7TLM+NYsYMJGq q8WqFks8EtZiaXKbtfWEe/iv02/tC5Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677527208; a=rsa-sha256; cv=none; b=ytdUO6uPqOFGTNfmFLclHxKTUxS3YE/aUAxwbYe481hLfm1TvrMNlEIf0UK8fBbnmHhyi/ MOo0KtqBuiujBupYkikR9ImVfpPSS/ZhDHAyZKQCOYjbbJzyG7Hcz4maqeAP9RV9EuAvlh NtbqlWFAkVmAReTdSAOQMY8FpL80Nrg= Received: by mail-qt1-f172.google.com with SMTP id l18so6943620qtp.1 for ; Mon, 27 Feb 2023 11:46:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zgbfP6t1iEXlYeQDHgpgkGKrmlu/wPbkfmiZJDZsq5c=; b=mLjM4A/ahWp3GhK1c5ogsHVbNEzi7APtMHQ5uyNmQkr3yuwq7mu3hqARQ/fSbG+DlS OAuNNtEXW6K6WneHU+50sCnlvbaM8GGHWyfucnbkJt0vlZ6U0r/34DhNtSUOF2vdFGia m8jUvSRtnOcF9QMHwybTel1vfgzn6tVpvRW3N16tgHQabUwiSAL5T1XTTGcw0iUCCrlu 19B+sL+y4RuPWxwcy6SC5fuH6aOGzAP+jamP+cI7j9SCMFqJfFsBAOnQTB2LB9mp3Xaq 8C1uF9nK16/YebhqnTxRxeY+5Wsh2r7Et9HcpF82L+Bm4pnsJl363jGjrhJdV51Zb16N UFaA== X-Gm-Message-State: AO0yUKXQf+H/w4rJPIkmLD++5sz5h986O4QWggjk54VZOPg6cHMxmHrk ByVlu2swJf4w2VlY5OXpCsrD1Z5S25kmfQ== X-Google-Smtp-Source: AK7set8ZRS+FCxhoI3iDOt2dFhQSRnzYPFWBhEY1ZoP/Q0x4XN/JICyj4kXXD06q9IEgbLDQVOKd1g== X-Received: by 2002:ac8:7f42:0:b0:3b3:7707:9b92 with SMTP id g2-20020ac87f42000000b003b377079b92mr833458qtk.15.1677527206243; Mon, 27 Feb 2023 11:46:46 -0800 (PST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id g1-20020a37b601000000b006f9ddaaf01esm5402058qkf.102.2023.02.27.11.46.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 11:46:45 -0800 (PST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-53916ab0c6bso207286807b3.7 for ; Mon, 27 Feb 2023 11:46:45 -0800 (PST) X-Received: by 2002:a5b:d4e:0:b0:967:f8b2:7a42 with SMTP id f14-20020a5b0d4e000000b00967f8b27a42mr7816406ybr.7.1677527205039; Mon, 27 Feb 2023 11:46:45 -0800 (PST) MIME-Version: 1.0 References: <20230113171026.582290-1-david@redhat.com> <20230113171026.582290-12-david@redhat.com> <9ed766a6-cf06-535d-3337-ea6ff25c2362@redhat.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 27 Feb 2023 20:46:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH mm-unstable v1 11/26] microblaze/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , John Hubbard , Jason Gunthorpe , Mike Rapoport , Yang Shi , Vlastimil Babka , Nadav Amit , Andrea Arcangeli , Peter Xu , linux-mm@kvack.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, Michal Simek Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E3AD82001E X-Stat-Signature: ztkr8hqqu4zrsogz4rpnprqo9e5qwyit X-HE-Tag: 1677527207-944791 X-HE-Meta: U2FsdGVkX191ARmZZSgtdSxhFcvC+8eUB1SGZCX7ROuA6OstNPR5o9r61nLDvNAK+/Xoism2KyDB/OAuVpNEhqzy99VYk9GEw3k5F5oKZ1YovKUEYJDtI1811sOwya/3pbm/5beOKWnotFYUxMNpkjxrDgcOwua2SToxOzvMw3MxBI2LAhRapBDxOL3JXd9rWs4LYs9ednIq8NKOrmBPGGmeQ/JC3lyovtx43s8HzgOLeND55Bbl9zEClxp4JERg54bo/EKZi3Tp9s2k5+vB1hTbMaivrqpPKvzp9QTLm8okzQKeAV6RI7KWVo0XQDaACupl1ytVd9iz1EcPhEilIi5xyHjHFS+AjgEktkwhgFSVWgxsmdQgeKFV2sH1Cnqssc/ZBmn11ycLt/YbaAh2H8xW/kuvopl4kf3olvtjji6Ngmwmrn1c8iq5818TLdaZ16k4ButqFA6lMfKl+8L/HGhHusFVn3i8GSx4DEHUScUgNXQWei+0TlkFxxYo05fR1ZXU2jee2TVPPoIb4Kjmm9wSOxt+aHnLYmWWKBvj1KKudJSJnPxOfuq1hsEMOPTr4PA6Ddz0oCeliUiAO84cRK0RQMdO3iMJLMYFmd0nfRV+vjaMHcUK+N5KGeUB12JkqGeA+rAi1gCu3uNa9oT6wtCSTZKZ8Czuz7hwowXwxr0oh9gJK270jqhe82csIvfrbazXisISWn0Uv7aE7xLDszcibn2OOOYCqJq11QI/5G4wC1TqWRDt5XmdOHQWN69QBW2iEhvxs1t31z5xeO9MJGenNAGBkmrqTuFRKNucWrXXMkAManeM238DDQ+mYmAvxij9BXchaL/k5xuo82WLg4wJaw8ahe2uNL47sjbMJanZ04N+aKyd0JILTXt4GIaZF0V//Zct8GngxU8M8TboCLDqmRnPUuS5NLamoA15hpA0cRkCgL7Al5oeQdC7+AhCsmOtEhCmZ5RTAi9slFe b6LwG/KR 198PCEMbCCcOlidSYWvyFZ9Cei92HkOqDfggo4NedElU858qymHjIVmvk1Y0K/c7sRMeq5/bRtFzbkeJYODnZlyxOdUm/k4FF3Nps+vrNLzb480x12dlnZK7s4+H9bAZWO88Mc3kx+MMnRZyVMVV36At8ZrqdiAc/clA3LwdBYyZqDVqdX7UnqrpZkZ5trBnZZ9qNa/dEqRnAOzKcxS6UZm6HlCWjL4snDHdbWPYNZzR5ftYJ1DaGb7Wm4F+CSF3dhJi8AhYWYJCulibIfo4cL+hWV/I1BjplLVxwl5TMtMrMKUg9fZkRz44/gGq/Y1FDWY82Pkh8eka3fNaMzYCTsTBfZ4CJUNwy8vprnPrsiUl9MLSN2Rl36uR+oAsI0WqeA+tVl6fUpf54Tts4LZGTk0wGthixsK5O5o/lo3yQYumx54rdmF268h2DcTTquLDhguDhxrGqIlVlS7HpfneeWt6bvLUwXQSduVbjBKg2hXSuk45QzaytGBlwdm5KVWdAeBxuZdrhJYVtBobDKug6g/wT+QxMkkmfO3KyrhSDTi2LqqFy0n4qK79pSnO++POIqjH1Hvzm/oACuGyYQRYJ1MShXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David, On Mon, Feb 27, 2023 at 6:01 PM David Hildenbrand wrote: > >>>> /* > >>>> * Externally used page protection values. > >>>> diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h > >>>> index 42f5988e998b..7e3de54bf426 100644 > >>>> --- a/arch/microblaze/include/asm/pgtable.h > >>>> +++ b/arch/microblaze/include/asm/pgtable.h > >>>> * - All other bits of the PTE are loaded into TLBLO without > >>>> * * modification, leaving us only the bits 20, 21, 24, 25, 26, 30 for > >>>> * software PTE bits. We actually use bits 21, 24, 25, and > >>>> @@ -155,6 +155,9 @@ extern pte_t *va_to_pte(unsigned long address); > >>>> #define _PAGE_ACCESSED 0x400 /* software: R: page referenced */ > >>>> #define _PMD_PRESENT PAGE_MASK > >>>> > >>>> +/* We borrow bit 24 to store the exclusive marker in swap PTEs. */ > >>>> +#define _PAGE_SWP_EXCLUSIVE _PAGE_DIRTY > >>> > >>> _PAGE_DIRTY is 0x80, so this is also bit 7, thus the new comment is > >>> wrong? > >> > >> In the example, I use MSB-0 bit numbering (which I determined to be > >> correct in microblaze context eventually, but I got confused a couple a > >> times because it's very inconsistent). That should be MSB-0 bit 24. > > > > Thanks, TIL microblaze uses IBM bit numbering... > > I assume IBM bit numbering corresponds to MSB-0 bit numbering, correct? Correct, as seen in s370 and PowerPC manuals... > I recall that I used the comment above "/* Definitions for MicroBlaze. > */" as an orientation. > > 0 1 2 3 4 ... 18 19 20 21 22 23 24 25 26 27 28 29 30 31 > RPN..................... 0 0 EX WR ZSEL....... W I M G Indeed, that's where I noticed the "unconventional" numbering... > So ... either we adjust both or we leave it as is. (again, depends on > what the right thing to to is -- which I don't know :) ) It depends whether you want to match the hardware documentation, or the Linux BIT() macro and friends... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds