From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890A3C433E4 for ; Thu, 27 Aug 2020 09:33:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20F6820738 for ; Thu, 27 Aug 2020 09:33:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20F6820738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7415D6B0006; Thu, 27 Aug 2020 05:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F1B96B0007; Thu, 27 Aug 2020 05:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 608216B0008; Thu, 27 Aug 2020 05:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 4AB6B6B0006 for ; Thu, 27 Aug 2020 05:33:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 07B76180AD815 for ; Thu, 27 Aug 2020 09:33:53 +0000 (UTC) X-FDA: 77195836746.06.humor47_17185932706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id D1CA6100672C2 for ; Thu, 27 Aug 2020 09:33:52 +0000 (UTC) X-HE-Tag: humor47_17185932706c X-Filterd-Recvd-Size: 3433 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 09:33:52 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id e23so3094641otk.7 for ; Thu, 27 Aug 2020 02:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=erOE8TrBl8kvb1HNiu2tPG2od/TXcbDQmkj/FRCOogE=; b=jCCulNkRbPIv0uikI/fyRFfO6fFpe+4asFsvFN6MShkYVeAvkqxqic4e+d4ql2dX5a 7xqFUi2+9zw5IlbDoPSxfYn26tu1PCdhKo3WVDUIvXrvMq4x5wIoCuYxAsJUyZBoynem iUktB4IZT9hMFxd2p4eNWK5WM8IziTMdkm/Q6nKIrooR7q1JumCoyciHWblcVJVL4gUy NFSKjIlY3NZprxgH+BSf28xvWhTsbZn0hzGdxAV0J+ulCnKAEAua2ifgPX4yC6NgJoRX 5eWRVmEKRkSWjCrjynRQEXtKFyrGSNAY64QAcBNRuV6Ti6LJPwPCWR+lDUNgjJEmvGvf S1Xg== X-Gm-Message-State: AOAM532uxZ9OJu0lGz8LhQV18ZG8J0yZI1WGT1Wm+QPMgm6DI0ib9elo aWwkib1xg+rxT6hZyfDeZYgZTi/nTMo4u0QCVxE= X-Google-Smtp-Source: ABdhPJzf5Rkx0MMkmy1DhlPa7m6zteOCzt6mslUfJ+2pjnLB14NhM0Z4C9ViJf9/MwLtHCDrl20l9yZOG5kwebfd3OE= X-Received: by 2002:a9d:32e5:: with SMTP id u92mr11767634otb.107.1598520831934; Thu, 27 Aug 2020 02:33:51 -0700 (PDT) MIME-Version: 1.0 References: <20200826145249.745432-1-npiggin@gmail.com> <20200826145249.745432-10-npiggin@gmail.com> In-Reply-To: <20200826145249.745432-10-npiggin@gmail.com> From: Geert Uytterhoeven Date: Thu, 27 Aug 2020 11:33:40 +0200 Message-ID: Subject: Re: [PATCH v2 09/23] m68k: use asm-generic/mmu_context.h for no-op implementations To: Nicholas Piggin Cc: Linux-Arch , Linux Kernel Mailing List , Linux MM , Arnd Bergmann , linux-m68k Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D1CA6100672C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 26, 2020 at 4:53 PM Nicholas Piggin wrote: > Cc: Geert Uytterhoeven > Cc: linux-m68k@lists.linux-m68k.org > Signed-off-by: Nicholas Piggin With the below fixed: Acked-by: Geert Uytterhoeven > --- a/arch/m68k/include/asm/mmu_context.h > +++ b/arch/m68k/include/asm/mmu_context.h > @@ -79,19 +76,6 @@ static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next, > set_context(tsk->mm->context, next->pgd); > } > > -/* > - * After we have set current->mm to a new value, this activates > - * the context for the new mm so we see the new mappings. > - */ > -static inline void activate_mm(struct mm_struct *active_mm, > - struct mm_struct *mm) > -{ > - get_mmu_context(mm); > - set_context(mm->context, mm->pgd); > -} Assumed switch_mm() in [PATCH v2 01/23] is revived with the above body. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds