From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC10E65D2F for ; Fri, 22 Nov 2024 07:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CE766B0096; Fri, 22 Nov 2024 02:55:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72F0D6B00A2; Fri, 22 Nov 2024 02:55:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A9546B00A4; Fri, 22 Nov 2024 02:55:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3754C6B0096 for ; Fri, 22 Nov 2024 02:55:57 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ED73512175E for ; Fri, 22 Nov 2024 07:55:56 +0000 (UTC) X-FDA: 82812969582.13.88FAD34 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 5378480003 for ; Fri, 22 Nov 2024 07:54:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732261968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EVhLm7NWxBppx3IfHYH1TmEaGrU/HiyCgYSRO2+1hPA=; b=UwU9nXZ2ArPPXNdzORzSWU3MKQYSTE5Oa6cv/w+c7ulRM2DjCxCabsBLx6m1eQAoLzXYSA MD61lMTyMYNdhIr1R0iBMCFmo0rUQ+C43e8o1HMjOIjLxj6qx/unfCNxyhLKv6t5gRlrk8 OVmUeki6XFBlhxY4C2ESvYn6YQMR0PY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732261968; a=rsa-sha256; cv=none; b=TC+BOMuSFiT0HSom4o60u+73q2F8nmYhkFOKUzurp2mTyNAOkbQI+CAyw2oZkRXVWJ+z7L ZT/wSdArPB+ih32QddIUNfZcZyuGhdWAoXsAc2zDbgvTaiSOC02SNzAUXdV8IVWEdAEb17 jAeU1LiExPthsCbv4eTbE5zWjvGtVeo= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-6ea0b25695dso15855317b3.2 for ; Thu, 21 Nov 2024 23:55:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732262153; x=1732866953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EVhLm7NWxBppx3IfHYH1TmEaGrU/HiyCgYSRO2+1hPA=; b=qlx5/DMsWyWARY1zbvdt0zbPg3akUzkOUBs2Anq/auQ/6NqjkxM6PyMp31rcFjrq5u peZSsSQiuzgHt0CJjzgIySL+G1kiMG/RcGYE+q9vgQBbEHsi1/t4megbEUiUQz2SjPw6 1RKONRAuJj8lu2eBwDXW99NYuk4jqCO1ge4bk0MOvpQCG+yAXlr+KH2UwVFQOGG5qH25 2mjSHuzUVc0N/RnUhjPy/1UjEr3mR1Nnv95Kq9w3TOsCRofpVRblNTf4Fwpa8Lic8h+8 GPr4x8p4mdJBbNNeYTVsMZPIp8OGYNdEDhoW/esZQtYsRqSgQ1H/0RCGeF+Ol6Y5yiqj WzHw== X-Forwarded-Encrypted: i=1; AJvYcCWMtdhTmfIMW2QO1zAzex0vdczYZQSYSOV9Z4dIKd2BUzN3kif9vTi8rRwhfYrSuB7FeQbG6vvZ0Q==@kvack.org X-Gm-Message-State: AOJu0YxZPW6JpIeUDvvSRk+eari/o5SJArHzVbOJJTjX6zKGccRamjBV jHShfOA0R7HISJFVSyKdhcSGwQpoMyVRBQs9Tshl0mkFptCpOnIP5y9tcXY9 X-Gm-Gg: ASbGncvfmLOWeCyVjIQCf0l+rw/+k/MWhnUysHokdfkQt5/CUExUKvPn9jny4gLJG+3 Dah4ZwH9Wh1YavrdlV+Ouwk1IIcTb/V2DK0vUNP6q4aVwO7W3r0x9kthsUeAoFSpHzTqSPWjEUC Vpuz4q5q0XxObHhnQHxpgRTb7IKmxf5sKKeUgwZJlNyAMOyrVSdUK3EFZzxyTEB/sF1WUyodJbl Xb/FOZBuFFTJwnKEDwtwLHjcS/xfCwy61CQpZvIYJ6dKE3c8ned3yslIPrCm4QNnQ2K98zhoNzV yT7d7hoO9fKGqAJu X-Google-Smtp-Source: AGHT+IHiq9SdA2yL8+ElzBhx8Zr7lK2JkK6v4kCjoQdsL/OnNrZYn1F0I2Cze6X+CYQBk/nkoROUkA== X-Received: by 2002:a05:690c:6710:b0:6ec:b108:e5ce with SMTP id 00721157ae682-6eee0a1288bmr26480457b3.28.1732262153491; Thu, 21 Nov 2024 23:55:53 -0800 (PST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6eedfe2bf77sm3509187b3.42.2024.11.21.23.55.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 23:55:50 -0800 (PST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6e34339d41bso15995817b3.0 for ; Thu, 21 Nov 2024 23:55:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXCMm/MNH1QK7zZ1hbazVQBnFAbdSgI9bgti/DOg7rGEAJjMpjosPbWPy9uyne61cH45EHWaQpAKA==@kvack.org X-Received: by 2002:a0d:c2c1:0:b0:6ee:9052:8e18 with SMTP id 00721157ae682-6eee087b79amr17540997b3.6.1732262149807; Thu, 21 Nov 2024 23:55:49 -0800 (PST) MIME-Version: 1.0 References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 22 Nov 2024 08:55:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() To: Finn Thain Cc: John Paul Adrian Glaubitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike@rox.of.borg, Rapoport@rox.of.borg, Christian Brauner , Guenter Roeck , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5378480003 X-Stat-Signature: uawg55pxb73ftcxx7ykkd34mrr9qnowb X-Rspam-User: X-HE-Tag: 1732262053-18244 X-HE-Meta: U2FsdGVkX1919OH5D/oObEKHjMkeDFViIPFNbA63Jt4SUQYYAtdnPvzputiet7AtEuwEPU/eKvQ+jNKGV9kEkAk/YVHwPNrvYnZBwzRPg4PePBjnJeBsFKNrw/i+uhwIk0GIiVeaF9yZDiNEFbFkR8pV/5Jo5jRVK7xE24U6LHHuMs4YZXzs1Rzs6DX+jgJ5RBSCR1hjZnLcetVpPw459NukmLrbsxn4WReQf9zPB+mvOZdKPI9wRNZ0wnyEPOiXeCGD2FWsML3RXTP/UEoWyQUL6uC0EuVUAZrpheihIswjZSuQCJGp3LEBM7VHXgelhvTPagSIaVo2jnWZMMIoxuadM46lgHS6XIFxtYP5fqC76FfL5D6AbHyaHjc+CEezwuucHu/YrT+zE6ukyvFemnv9QcDZWlFozvPRlLSPeY/umxOXR0ik1qLQ2t4RC++eaqM+VloGxZW8YMwVPzRz/PgfsQyLWIVxxNDb/TwE218M6l6dEcKahBtv3xs5zLH7W581kYPUqzjBFtXXUDVuJw5vei4mjHW7ou8/f7/yPJIqHRg0/OuB1tEfoavhdxkR9BVkmo0kLoAeJ4JK0j3tNHLM66t1XaP9ujAVPQgs53IBvq/SwmqFJWyi/jECco2Zrsbk/I2gIIJEJ1xXXdIZG5PYC8rFdjGn7rIzxqtbHjE/ho0W8yCUN7mwm866ghHXkJFuAWI96IWhHLAcpzL4Jsoi8EEp2jp6yWxyj2TWRNLxbTAzdX6uURuLmOAvVX0tB8k4pdZlTVSBI4F+ISonMjST3KB1eZHxfguMifXsotISon8FePLq2frg9FJnGY+vX8x37cS1bhdEuoVUuCXEfwY7fOLGwsUO8g7jGpgjwhHT7zvIdr5+dvPEqBtEbjB/Eagq/AMk8VC8YIDoWPsdETPPYWMNmfGEFuTs08UB0LQM8LEnlK/JoTq04zFggtORRiePteoLtdnYzHxs9gq eWy3KkG9 PtIcexMWYaV50ULOuJujJUYnqLa3NhXqYGdsHS4T+jY8MF+5bCvpi7Wq43bdD7nUI8DkCE3spJYzejJ6ROOdwOWl0AlcyXDbiFS+BydHt0m+LYfTuYC/6jnobIgNvJAEFOEMVkQlOzx6KDZRua/1i9tZP9jPKh0qv/xRHOQSOaYwz4DWPdRouby9Lit9SXGEdOog/scZe7EoQQ2nwfQ/9YqVKQBPHHAk8TBpbEPJceVb1pUP4ZUDC2zJ/i3o+ygDBZ1Ku4zIPem5MSXqTMn58cpX7tbzR8YuvhqIQtiYF+SPTMVPITjMKkMzPQYv5JiH3sv9wJfdQJezkqiBZTtx1m7NCdMIUHpx61RawRkF7h+yAEqya4TNVsC4mQQKGfhEJW5PPk57dRgLP2Y36PzOwwvR0Go+PVRhF2KzXuUDlNFgABZpWw+lw8Pz2teb1EIsO/zRAtbetuuGKPYP1jMPJkKxu99HTjVDCAd4BF39kQ2yBgTqWmG195Tcnl6ZBujfEGmwaZ4bCYeI+U0P4Fje3OoefHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 22, 2024 at 3:11=E2=80=AFAM Finn Thain = wrote: > On Thu, 21 Nov 2024, John Paul Adrian Glaubitz wrote: > > On Wed, 2024-11-20 at 13:46 +0100, Geert Uytterhoeven wrote: > > > On m68k, where the minimum alignment of unsigned long is 2 bytes: > > > > Well, well, well, my old friend strikes again ;-). > > > > These will always come up until we fix the alignment issue on m68k. > > Hmmm. That patch you're replying too. Does it make the kernel source code > better or worse? Touch=C3=A9 ;-) The same can be said about commit d811ac148f0afd2f ("virtchnl: fix m68k build."): if you rely on a specific alignment, make sure to use __aligned__ and/or struct padding. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds