From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 075F5C46CD2 for ; Tue, 2 Jan 2024 08:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0118D0005; Tue, 2 Jan 2024 03:48:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 736C08D0002; Tue, 2 Jan 2024 03:48:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D7D38D0005; Tue, 2 Jan 2024 03:48:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4A9048D0002 for ; Tue, 2 Jan 2024 03:48:07 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0D02CA05B5 for ; Tue, 2 Jan 2024 08:48:07 +0000 (UTC) X-FDA: 81633743814.15.BD073B6 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf15.hostedemail.com (Postfix) with ESMTP id 0830EA001D for ; Tue, 2 Jan 2024 08:48:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704185285; a=rsa-sha256; cv=none; b=RryHsCzgVMb6xB6GG4MwVXpCsyLKUdOnvfggwAacAzNpu2a7U1d9kpJWis8EUDFQX9ic2Q WCSVyiOMOJD/0O7hA9DEAr+vMNBGdYEsIwzGiX8vsnZqfNDq8pv4zHwq0GrE0Pg1NbxxJd yZXVM81ibacHT49LMP56edIX2xMD/sI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704185285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fznygzUD7eBbAPtHsNQrcNeZZd6ceLfwc79V8Fm28m4=; b=HlRXZwhNw/hv+iAduAZmG9WFSAFwkg/vynb3K1Xo2l2OSqAYMfFNCs5h9lzhHTX4jIm1hk UImA9jxyk61oqS44AyW4MSo0bjQ/kmfRuXk0tjKOZj8n7wavU9h3DN8re2uXevCeaM91tB uM3Z8EGA26+wyhK0FG8xw7/w0Rw8Soo= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5ebca94cf74so50326237b3.0 for ; Tue, 02 Jan 2024 00:48:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704185284; x=1704790084; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fznygzUD7eBbAPtHsNQrcNeZZd6ceLfwc79V8Fm28m4=; b=IX7BF6u2ZCmh01yorIyGrzWIGeUv8sH1dFtuGJ72RqaU2se0P2h1AEPqL9JKqmMwkX lDASVv7Bn6uW5bVgognAsHzfedGcDCYqTszsOXp8roWdmHBHAMMaPgWu6aqPL22Gjqrn 2Z00hvo7gVfdtsrJQ1fGgVKBgzRA8x1oP19nx3qwxMzamQ3z9noqB0HXOYW87LK0iJp4 PqrPMlpumJGrth9CEkl5n8kfM+w0UjA6VTzfDlqQcg4oZFQuQsmOKS6m4b4iX6Q2ZtFD IpGm7xFWdm1yUYu1jkVVGrKizZnRJSrLN/VJOCgbU5KWEUMfReQ7OXHcA/5q643ecskL joEg== X-Gm-Message-State: AOJu0YwLqI7zJ327wmuJRvM9HeNi1Jp5n05yZZF2uc2hsI+bJpjyhV7c 09KJqBazsYDRp7/aZRNUWvpzkhkakr1MlA== X-Google-Smtp-Source: AGHT+IEvKxAD4ReF4tHh/gTozCDFAuhpe6VHwPbp9+zmFPVxbFYiiuNw7zckFGxFPVuSdf133TyUtQ== X-Received: by 2002:a0d:e28b:0:b0:5df:5d59:7939 with SMTP id l133-20020a0de28b000000b005df5d597939mr9856254ywe.12.1704185283872; Tue, 02 Jan 2024 00:48:03 -0800 (PST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id bz9-20020a05690c084900b005ecd8995666sm7638550ywb.59.2024.01.02.00.48.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jan 2024 00:48:03 -0800 (PST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5f15a1052b3so14859757b3.1 for ; Tue, 02 Jan 2024 00:48:03 -0800 (PST) X-Received: by 2002:a81:5b46:0:b0:5d8:d93:f02f with SMTP id p67-20020a815b46000000b005d80d93f02fmr10057429ywb.87.1704185282827; Tue, 02 Jan 2024 00:48:02 -0800 (PST) MIME-Version: 1.0 References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033300.3553457-1-kent.overstreet@linux.dev> <20231216033300.3553457-10-kent.overstreet@linux.dev> <20231220213913.gptbcbpwb4q3prtf@moria.home.lan> In-Reply-To: <20231220213913.gptbcbpwb4q3prtf@moria.home.lan> From: Geert Uytterhoeven Date: Tue, 2 Jan 2024 09:47:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 42/50] sem: Split out sem_types.h To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0830EA001D X-Stat-Signature: x73y31hf136bbqk76pbfusgr5r4qip4w X-HE-Tag: 1704185284-985731 X-HE-Meta: U2FsdGVkX1/ZHeK7fQmSAcxKAybfAGkaY08UcRv1Fa9Q/iynOQEbe9e+nISUxOLYYKBM5NGR7aDxat9JpiFIziDyriqcd0Ji0WRdn1A4fAASSyGsfppH0APw56sQbDKQ816FhQlK+ZQ99F349Q7ckukBE/hO5Q3ZQa8gsUaXu3UERke+pnN01KTvp2xlqQKCvHuxfE5q8cgkokpkiF9slLt0Q3yOlQAlM9ug/VXoGQlHOB0uj3buZ9rjspbNSZ0AeSIK12pmJe5GG92MP2D4MB5lm75oox+ZsUPOdd8LqhqcQJ5JgbtV4CJcAZzr8Xjf+5D2iqln52FZNr609Rd34psBJZJWtm/pxPLFe3J8A9/ytJGV4v7nsfjzKDeDiBE4o9Y2gxMxtk8R+EhCmg5LWrc5DARIw+YWYkoPUbpo2EiHEZEjPWhJpQketlhqGe4IurUtPNFs1t96x3keJC70uyYihVQsq3GBzfBO5qbd99t6RMjk+U7UOZq9yffV+uoydidJPL+gcMDm6icWjkH0TUE1vdn4vrH1Q+Kjiv2KDhlFUcQg56uXTTu6efi/su1lftTId+6HwoOk5f1iIPLqXN/3DwWguby4JryCBtrljGizbHnwDEZj9uUiQyC/mppfrN/IPLuLJGe0tFU/XKLvY9OXq0kQT2D/OUGdIaKhXoGraKtry6EDWI9PF9Y8l86z7CfU+D9XHzdKQ103L4dFCqT16HxSCb0MIKaOKtNUEhaF3EiXA40WZn9r2sCIg+lX7DwG/Hf7nAuDDltivNH23pkhi7y62iDj+XvzdeBWR4kVo5msd2LnULG6hw7kTKX44e2OEm34Uqr3rr6xylZW7AdSNtK9UQQhJC1JLLkJ8plNM0hE/ANm3flvWFJh/CinXIf3IMTtzP6DD6IX96BPpcJjX2enrGV72XjHvs8YQzH/cmQ4u6+KVdVTGiHzY85QKVtCPPtolONXKArn7wd ebikkpmj 5Cfn7fa3E0yg2mb+GhjXFzlKNU9XGdafRnDn+7TZ8SCouRQD5dZ+c6EMkoCa5aSwGeZqrKl+0lSx8iLYrqUekdRGrLOrLkkYw8LNRgAhwgPisxnF9fsFfocHm/vJNGndczNqqOhVHW+rR7/uOX6JeN7TDjNEN4nTMJ5PQ8vQQfKJLQ5sOpbn2OV8dhk49ZkJ3uk+gHYCmJ3GWlGufdwjhCOTo0OnQA4KlKYq0H2/11UrzE8ydoOh19VimRCrZozjDAjvGSum72lsgzKXOEzoxHrXuJDJtseF+c7w2B+rXvv/HAsOv6ZZoxgd6LvgcgF5uT9Ko+6Mvrkai+9+9rQ2lFerYZCRZUUWdswWIgxVC8Wkauf5iWfig6ugLTxTanpZEt0DSeBbFJ39h/Ux4FdOuQa4/mwkny+Y+GnZR/oxLisdEGafWEL1pFtw9dJj4oiln9rLj30GkQ8yq2tYJ/HbgSzSBqlH4voy22yDQPjf1fDo3UTS0ZRWvXv4chaHZ0GQz9MpmPnFknLxSb4pkvkIRfBCkvyH240z8+pJFQgliQ/lAY7HPXYIXrrLDmmvdSNPIw5Dki5EPzJlztQHlX8SKJ7BIBFnuBKN8sskSQKL2CLwbFN4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On Wed, Dec 20, 2023 at 10:39=E2=80=AFPM Kent Overstreet wrote: > On Wed, Dec 20, 2023 at 12:53:46PM +0100, Geert Uytterhoeven wrote: > > On Sat, Dec 16, 2023 at 4:37=E2=80=AFAM Kent Overstreet > > wrote: > > > More sched.h dependency pruning. > > > > > > Signed-off-by: Kent Overstreet > > > > Thanks for your patch, which is now commit eb72d60ccaed883a ("sem: > > Split out sem_types.h") in next-20231220. > > > > $ make ARCH=3Dm68k defconfig arch/m68k/kernel/asm-offsets.i > > *** Default configuration is based on 'multi_defconfig' > > # > > # No change to .config > > # > > UPD include/config/kernel.release > > UPD include/generated/utsrelease.h > > CC arch/m68k/kernel/asm-offsets.s > > In file included from arch/m68k/kernel/asm-offsets.c:15: > > ./include/linux/sched.h:551:3: error: conflicting types for > > =E2=80=98____cacheline_aligned=E2=80=99 > > 551 | } ____cacheline_aligned; > > | ^~~~~~~~~~~~~~~~~~~~~ > > ./include/linux/sched.h:509:3: note: previous declaration of > > =E2=80=98____cacheline_aligned=E2=80=99 was here > > 509 | } ____cacheline_aligned; > > | ^~~~~~~~~~~~~~~~~~~~~ > > make[3]: *** [scripts/Makefile.build:116: > > arch/m68k/kernel/asm-offsets.s] Error 1 > > make[2]: *** [Makefile:1191: prepare0] Error 2 > > make[1]: *** [Makefile:350: __build_one_by_one] Error 2 > > make: *** [Makefile:234: __sub-make] Error 2 > > Is this a build failure on linux-next, or that specific commit? On this specific commit. > It looks like this should be fixed in a later commit that includes > cache.h in sched.h; I'll move that include back to this patch. Indeed. The robots reported a build failure, and bisection arrived at this (different) build failure first. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds