From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56BE1C4167D for ; Tue, 14 Nov 2023 16:21:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB7FA6B02E1; Tue, 14 Nov 2023 11:21:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C41716B02E3; Tue, 14 Nov 2023 11:21:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABC4D6B02E5; Tue, 14 Nov 2023 11:21:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 93B4D6B02E1 for ; Tue, 14 Nov 2023 11:21:34 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 63868140B18 for ; Tue, 14 Nov 2023 16:21:34 +0000 (UTC) X-FDA: 81457075308.04.193FC9B Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by imf09.hostedemail.com (Postfix) with ESMTP id 2A6F6140017 for ; Tue, 14 Nov 2023 16:21:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.161.47 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699978892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DuNuFoZ4uO4dR0HE9qyyNud2qzT4ASdzzadzSQPKUKc=; b=nGkSVrfyXs7PvAfMX5V6ExbNTHznD3eZFGvrqm2JTAGc4K01jITrtiYle8s7EP24xaNMEm XW+oMp6udnlAJi85zDQf+gd/1d2LWPPUIQYKmp2yA1kZS0qnK1rtJwMlVN50nmI2HAA2ti aCsieJ+YKjM10Bah+qjNa4hX/jnSqyQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.161.47 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699978892; a=rsa-sha256; cv=none; b=lBzhLRwJ/yXP7REef4HDV6IaoSzRbLA5tFZ1yEh5paT3J823vwczlpgybKMhoffmmg1EBH Mdmlcn5I084pbDukMvXWWzeQxpMnzS3k6NPr+BA22TT3JpVrkOscLcfevUvl0stvzlViw6 N9za6oHdX2DVDHHFQD9q0UN0wCoaEFQ= Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5875c300becso3479163eaf.0 for ; Tue, 14 Nov 2023 08:21:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699978891; x=1700583691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DuNuFoZ4uO4dR0HE9qyyNud2qzT4ASdzzadzSQPKUKc=; b=YTpEs11j9y9BU5jfM4UgDncQYDHYv/gZvF6C4Wmc5JzQAK0wnn5+2/UEz9hODAi68t P1C9fuMK9F6hoXgKSVAqNGT0rKbZdKBBWT7ps9I2r8LG4WNwXfx6hzhTaljTgHRNnBHk XCw62VDMkeEHiqOXq/SPh0nJyq2YwA+kn/2WPMEWlXRJAgMdcZPTtb25YfxcZ2+4Nt4M V6OfVkOFSYt+oU377nPkmpg4FgULD74BruvzkeMy++3eNTEe+TlfeJ575YefHM+uNATr enB1Sy4SH0qAFHE2ubxiXgfJ+cJwUaUYx3vJTDSq30I3g3BEjPJQaScQd5Fb7vEJYArM OXKg== X-Gm-Message-State: AOJu0YwRag9C3aT9pcLRZIhoXGwUJquRNKNH+GEG9rWS5LGSyLH2JCt9 HFVjJLyIVKQcYBCkKh84sMieYCJ2e9BWMw== X-Google-Smtp-Source: AGHT+IHNVyR2JCFS8Zda72KlHPAcWOtCeSCq1nFIqW6MyitpCfbxbtpmUcQhKfHHEzMu2DnrQ6HOfQ== X-Received: by 2002:a4a:7657:0:b0:581:e303:807c with SMTP id w23-20020a4a7657000000b00581e303807cmr10126089ooe.5.1699978891152; Tue, 14 Nov 2023 08:21:31 -0800 (PST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com. [209.85.210.47]) by smtp.gmail.com with ESMTPSA id o5-20020a4aabc5000000b0057e66fa004dsm287853oon.47.2023.11.14.08.21.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 08:21:30 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6ce2988d62eso3421391a34.1 for ; Tue, 14 Nov 2023 08:21:30 -0800 (PST) X-Received: by 2002:a05:6358:7246:b0:169:a9d4:3faf with SMTP id i6-20020a056358724600b00169a9d43fafmr3969586rwa.11.1699978890353; Tue, 14 Nov 2023 08:21:30 -0800 (PST) MIME-Version: 1.0 References: <20231023025125.90972-1-liushixin2@huawei.com> In-Reply-To: <20231023025125.90972-1-liushixin2@huawei.com> From: Geert Uytterhoeven Date: Tue, 14 Nov 2023 17:21:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object To: Liu Shixin Cc: Catalin Marinas , Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linux-Renesas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2A6F6140017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: utczrry7inkai4smndnxp6mts5msfo4r X-HE-Tag: 1699978891-802384 X-HE-Meta: U2FsdGVkX18r3A7tkB9XXtYWyVpX0pNkBe+WmH/bfyFzvCipNN8cnaBqpR84v/Fwa8vC63HrVzjF6HF0nyRPoC4UUso4QuvMzz/KpMTE641FWpUpxi/zwChvI4FzLsUfLV1pN8Hk082oe+9TCSsmo+hlZLVfgRAv4dv+8Cgr6gf92iRGIcd2hpJXy6V6cbkNZBRZtqS/2u/yveaQum3xm3qcTvOU8Ynlz6omEU2WNwJOGj5yaPhb8+b2L1oHNbszhqRc/kdgto4ow9qZ5q2U+75sr/K2z/7SRjr9QoSZh0xZFoMpLz1St6DJHHdx7f8sGeLlO0fB9sKKV/rnYfsVaEWMei9bv2akPlkyUYPmo3K7872hr40M50f5DEYFJOBw6vc2tR5a+N3dSpXe9fiPFN0ytVSwIZUGLo0BkS8fVWHN4hjgjiKGh+6QWrp7fJ0oCZ0nOF9FnxD7yM3HOhlKDpmS0xEx96e6vrtkQhJ//AxTdNNknM3Ck3+ETTwLFPG/20SCqREjQ0LCtJ8GlA7KzJDQ6Y7JHsrIAdokzt9ET0d03jKRkyUYbkce8+mD5pGU9ytEqC8mi1k0ajaRmohRe9etDnq/MywfMo63oXHMnTXnlwctM1n16t4he6L/SxewpcqnMMfuuY3t8QpVyAsAoapPHVyj9sFk3DCGMJTblwanACMKTOzw9StErNzL+kwUgVbcOG283rW2wFfySjOS9Zbjr/lZtutjkLa9iGAUlRuKmskMx7D36VpFbhR83VwcH2zwrUc23gOQCxNekexvBIQGIsriUhNrWm2ZX9RE5QtZHPYoOK+uvMn+WNAuSFUDonk5NqmEnvtWvUvIGoQ/dLeTTzza0TB4+z09jLjvchiH5BvMEtarG6X4m8ayVFqjdK2bgKoGA4u6GKFHV5rWQl4rgWwPVWO7oUdZKHK5b4ys17mV1ZHzGCmM9gvugkeQ1GEAADOvjMtOzaXaRIK 6sUgSrbZ mX2NfA+bu56e+b7lN2K0IjAxuB5w2WkacixYawKQiqDAHeB4rqaUtfV8SX3TROq6DGrYMY2TGVjrkltQCYYKGBPBKwN2TuQUsXAkukGqvP6TJLC860awRv/j2JaQtfnGdHWV+9jGq3000w52KQvk7KnDDzUL/4l/WQ8TrDkpbLUkF+dUOu4MoPq95dvxY5QB04/dxtJwDlq6uWTgQmfbMkT5U89SRInv1kZCs9kpr6dEm5JEuLUTf+e7C3If3c9qgZ2WFVbEfedDCBeCeUPKPqBAWkVVGQA3VPCeWYJUyo/4z6UyNwJd07kz3iyz7UcyGPsWzftmj97RR04t2VfGr0P+Vhc4XDUXLYm3Pn4Gu3DvHIpXL6tGp4eafwmKjk39kdkOUVEvDbp+8ZNjI3E0/FjPDTGNyvPkPrQe6/xVYp/4lWnihnNH6dwKnc7prxPoAo61D46qAn91XU3CbgzvFL3ueGD0yq/qVDeJoVaI9Z2nT2cwXd725V6lBtclHx5mDf0uuUmzp1OnyFSmV1AIp+B/AnGffsBps3RBv9bNm6HzNjlGFzKRWRf1fdHbEWXxElLAylZkoaF03aVcIutSTd1mI7c+5pkuHlFWu0bOFghM/n4tiDeZ6fhjelK49yr40ruBR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liu, On Mon, Oct 23, 2023 at 3:52=E2=80=AFAM Liu Shixin = wrote: > Leave __alloc_object() just do the actual allocation and __link_object() > do the full initialisation. > > Suggested-by: Catalin Marinas > Signed-off-by: Liu Shixin Thanks for your patch, which is now commit 245245c2fffd0050 ("mm/kmemleak: move the initialisation of object to __link_object") in v6.7-rc1. I have bisected to this commit the BUG splat below (seen on various platforms). Reverting this commit fixes the issue. Memory: 7923468K/8257536K available (9024K kernel code, 5144K rwdata, 4088K rodata, 3072K init, 18331K bss, 268532K reserved, 65536K cma-reserved) SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs=3D4, Nodes=3D1 + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D +[ BUG: Invalid wait context ] +6.6.0-rc4-white-hawk-00387-g245245c2fffd #192 Not tainted +----------------------------- +swapper/0 is trying to lock: +ffffffc0814bbed8 (&zone->lock){....}-{3:3}, at: __rmqueue_pcplist+0x4ac/0x= 53c +other info that might help us debug this: +context-{5:5} +3 locks held by swapper/0: + #0: ffffffc0813cd720 (slab_mutex){....}-{4:4}, at: kmem_cache_create_usercopy+0xac/0x2e0 + #1: ffffffc0813d93e8 (kmemleak_lock){....}-{2:2}, at: __create_object+0x48/0x98 + #2: ffffff86bef6cc98 (&pcp->lock){....}-{3:3}, at: get_page_from_freelist+0x184/0x7c0 +stack backtrace: +CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc4-white-hawk-00387-g245245c2fffd #192 +Hardware name: Renesas White Hawk CPU and Breakout boards based on r8a779g0 (DT) +Call trace: + dump_backtrace+0xac/0xe4 + show_stack+0x14/0x20 + dump_stack_lvl+0x68/0x94 + dump_stack+0x14/0x1c + __lock_acquire+0x390/0xffc + lock_acquire+0x230/0x28c + _raw_spin_lock_irqsave+0x54/0x70 + __rmqueue_pcplist+0x4ac/0x53c + get_page_from_freelist+0x2a8/0x7c0 + __alloc_pages+0xf4/0x9f8 + __stack_depot_save+0x178/0x3c8 + stack_depot_save+0x10/0x18 + set_track_prepare+0x44/0x70 + __link_object+0xd0/0x220 + __create_object+0x64/0x98 + kmemleak_alloc+0x28/0x34 + slab_post_alloc_hook.constprop.0+0xbc/0xc4 + kmem_cache_alloc+0xd4/0x158 + kmem_cache_create_usercopy+0x1c8/0x2e0 + kmem_cache_create+0x18/0x20 + kmemleak_init+0x74/0xfc + mm_core_init+0x214/0x250 + start_kernel+0x2cc/0x4ec + __primary_switched+0xb4/0xbc trace event string verifier disabled Running RCU self tests Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds