From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3ECC433E2 for ; Tue, 1 Sep 2020 07:04:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88B2B2071B for ; Tue, 1 Sep 2020 07:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88B2B2071B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AD156B0055; Tue, 1 Sep 2020 03:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 237046B005A; Tue, 1 Sep 2020 03:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D80F6B005C; Tue, 1 Sep 2020 03:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id D20776B0055 for ; Tue, 1 Sep 2020 03:04:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 887BD180AD807 for ; Tue, 1 Sep 2020 07:04:00 +0000 (UTC) X-FDA: 77213603040.12.toe86_300321b27096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 5761D1800860B for ; Tue, 1 Sep 2020 07:04:00 +0000 (UTC) X-HE-Tag: toe86_300321b27096 X-Filterd-Recvd-Size: 4332 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 07:03:59 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id t7so316557otp.0 for ; Tue, 01 Sep 2020 00:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v+UCqMpoxNkc8HR8b48PCCPouXs4GQ+iFq6WKu3/gPA=; b=lJs15tOWm3OWaTgKaG92z5BB0jXMlimMkDWYqnZVlQrSqJLzmkaiQG+TdcP1OQOOTf wzNFLXXSBkQoyuXaWktPwtoMtGYMeFoxlO5cBprE8cp+i1pj7jrRsKUj/yoQ84wZm+KY MMRndA4mHrArwc970CQxNj2MHmQo9Cepf10MVfXxU5cUjwVOJrXykHIosY4vCF1xb1GG Fra8Sh9IRiMajx9EplZBicPieeUqmKcRLb3VzvsOcXr8hxAMB9qhDA0Dtl87Ud9qaJQo 6lKSwgNuDLuDFoPzIUkD82ic5abW4paJUvZA2z4s/pVVXNedKrt7/JIhkouqS2seU4pL x4tQ== X-Gm-Message-State: AOAM5336PyLMHFdCcselkH3NwZSNqZ/ceREn2Za1X8TEY7D2z9gyzGzS rmmfLrgJ+bQ/M5PA9uR21ii7ShQcJxrt5GNuwOE= X-Google-Smtp-Source: ABdhPJw+W75f7LvhKPJmBkANHigTowv41ATseQQVo1zrxnPwXtFSjat/hlrHbRc7rhVmMPWs0LwXP4Ln8wspP9PRVow= X-Received: by 2002:a9d:32e5:: with SMTP id u92mr373423otb.107.1598943839340; Tue, 01 Sep 2020 00:03:59 -0700 (PDT) MIME-Version: 1.0 References: <20200826145249.745432-1-npiggin@gmail.com> <20200826145249.745432-10-npiggin@gmail.com> <1598941313.t5y1w43jgl.astroid@bobo.none> In-Reply-To: <1598941313.t5y1w43jgl.astroid@bobo.none> From: Geert Uytterhoeven Date: Tue, 1 Sep 2020 09:03:48 +0200 Message-ID: Subject: Re: [PATCH v2 09/23] m68k: use asm-generic/mmu_context.h for no-op implementations To: Nicholas Piggin Cc: Arnd Bergmann , Linux-Arch , Linux Kernel Mailing List , linux-m68k , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5761D1800860B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nick, On Tue, Sep 1, 2020 at 8:23 AM Nicholas Piggin wrote: > Excerpts from Geert Uytterhoeven's message of August 27, 2020 7:33 pm: > > On Wed, Aug 26, 2020 at 4:53 PM Nicholas Piggin wrote: > >> Cc: Geert Uytterhoeven > >> Cc: linux-m68k@lists.linux-m68k.org > >> Signed-off-by: Nicholas Piggin > > > > With the below fixed: > > Acked-by: Geert Uytterhoeven > > > >> --- a/arch/m68k/include/asm/mmu_context.h > >> +++ b/arch/m68k/include/asm/mmu_context.h > >> @@ -79,19 +76,6 @@ static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next, > >> set_context(tsk->mm->context, next->pgd); > >> } > >> > >> -/* > >> - * After we have set current->mm to a new value, this activates > >> - * the context for the new mm so we see the new mappings. > >> - */ > >> -static inline void activate_mm(struct mm_struct *active_mm, > >> - struct mm_struct *mm) > >> -{ > >> - get_mmu_context(mm); > >> - set_context(mm->context, mm->pgd); > >> -} > > > > Assumed switch_mm() in [PATCH v2 01/23] is revived with the above body. > > I'm not sure what you mean here. We can remove this because it's a copy > of switch_mm above, and that's what the new header defaults to if you > don't provide an active_mm. IC. I thought it started relying on for this, where you removed switch_mm(). Seems I missed the definition above. > Patch 1 should not have changed that, it should only affect the nommu > architectures (and actually didn't touch m68k because it was not using > the asm-generic/mmu_context.h header). OK. Sorry for the noise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds