From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A869EB64DC for ; Sun, 25 Jun 2023 15:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D06A6B0072; Sun, 25 Jun 2023 11:34:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2581A6B0074; Sun, 25 Jun 2023 11:34:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F8BC6B0075; Sun, 25 Jun 2023 11:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F21536B0072 for ; Sun, 25 Jun 2023 11:34:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CCB49A047B for ; Sun, 25 Jun 2023 15:34:20 +0000 (UTC) X-FDA: 80941666680.04.FC6012E Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf26.hostedemail.com (Postfix) with ESMTP id E2F55140011 for ; Sun, 25 Jun 2023 15:34:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687707258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Em86VtDkd1foZmdIW9TVdQbVnG2xtBG9ePF3h2l9uqI=; b=mRlj2UpKZhY7MNtD0xv/RCTuLKJ6hFVxmT64fQH/5SagWbgrpesO71iFQEhw0rymZMa8pQ ID0jUWKLOSl4NVAg39yGs8Q5b8UB4RK5h92Eg7YKwb7Dbj6wFyFjx+/A1DOAra4v2ymFyP Qn/sV4C+dxjEcYsz7qpn3HebCJWge5o= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687707258; a=rsa-sha256; cv=none; b=R/dUcZteLjRfrkqsXRTK2AH0U4OKKCoDj2oXo+5+yNgtYqVTUNHDnKhy+qCWVWA8D0vwuZ 9gVvSfxR8LtPe1xct16HGYVvaiMc9ap+qGkiusMfQZyOpmiRZM36k/3CLUeIka9OD2TtjX TWoj0SrMrcleNheNpMifbzgd96002QE= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-c15a5ed884dso1153872276.2 for ; Sun, 25 Jun 2023 08:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687707257; x=1690299257; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Em86VtDkd1foZmdIW9TVdQbVnG2xtBG9ePF3h2l9uqI=; b=hy2xNTiPc4HlYCZ5y8+m817SVokuYjnk+j81BkRwUocDF1k2IujI/qDqhGhRScQOpS vbmsEToZ7AZT0ZHiZS2YCgNRwoHx8CgGHkZm4RK6UysHS7nddWKO+uVcl2oexh7ddvHI aPtNgYZMzb0r/C7ZWtW8vAF50zD75M7F4aJX0AlebG5aG4aTGj+l+wuh0g41eGuJ0x/4 EH6/0SPsHTKbsxUlxaxRXeNfR4pwmfVy8MCZraueiHxxP8mPDlUcq0TWDAQ4E7CwYOxZ wOF4KVHZabNilWZ6PAltJjPa06oS3EHVB/BuWY9bgbOBbrc+1SHWzEMyb2gn1gsy6UZ+ xyTw== X-Gm-Message-State: AC+VfDwpAgvdDgIhW2JfLa2AhRLygGHRF7kFCaBSf7lWCp2tVUPtMapw zz2Xr6VWbXgUV6tfuBWu4K7gMzOwFptYlw== X-Google-Smtp-Source: ACHHUZ6wbyFayXpYGKub9genCiivelEFi8FYUoRaBe7oXFiW4X0ZKFUE+FhS0gNtPrrkvsHe3MTwFw== X-Received: by 2002:a0d:f147:0:b0:576:93f1:d118 with SMTP id a68-20020a0df147000000b0057693f1d118mr4073693ywf.2.1687707256880; Sun, 25 Jun 2023 08:34:16 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id w192-20020a8149c9000000b00573a75cd331sm834525ywa.143.2023.06.25.08.34.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jun 2023 08:34:15 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-bd744ffc263so2425322276.3 for ; Sun, 25 Jun 2023 08:34:14 -0700 (PDT) X-Received: by 2002:a81:7c41:0:b0:576:777f:28bc with SMTP id x62-20020a817c41000000b00576777f28bcmr7920762ywc.21.1687707254518; Sun, 25 Jun 2023 08:34:14 -0700 (PDT) MIME-Version: 1.0 References: <6c7a89ba-1253-41e0-82d0-74a67a2e414e@kili.mountain> <1059342c-f45a-4065-b088-f7a61833096e@kili.mountain> <206F3FDB-59BE-4386-82D2-6FF3CD16D053@oracle.com> In-Reply-To: <206F3FDB-59BE-4386-82D2-6FF3CD16D053@oracle.com> From: Geert Uytterhoeven Date: Sun, 25 Jun 2023 17:34:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: next: WARNING: CPU: 0 PID: 1200 at mm/page_alloc.c:4744 __alloc_pages+0x2e8/0x3a0 To: Chuck Lever III Cc: Dan Carpenter , Naresh Kamboju , open list , linux-mm , kasan-dev , "kunit-dev@googlegroups.com" , "lkft-triage@lists.linaro.org" , Marco Elver , Andrew Morton , Mel Gorman , Andrey Ryabinin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E2F55140011 X-Stat-Signature: oja9sso68xjqz8mdqfwrgi8ue1t6ff6g X-Rspam-User: X-HE-Tag: 1687707257-2538 X-HE-Meta: U2FsdGVkX18GOP7lrg+m64xUjGecsBaHh1TmiOh2K53UPPXjDShTho+leKYXQI0ETTF/d4viaSu1ZXUNZ72oImO8d49e/YFn3WVIEfdJD2qkeougppMjEwFmji7/gZ3xqz/CtDM2Jzl4wAfZwHLwsvdEp5BKoKqehbJmZf3ypldzlRA/b3TyZHv8FVX6NuXfbRVvdM7un9xDbG0myPgkOU127AtlBewhhRJVTnOA72ETccjlm9rUu35DLOmaA8nhHsTsYzAXNn+It58nEggVV6NcHUy1T5knZQ5Ok/cvp6hBlclXFHkpMLmJCJO8fkZaMaucNNFvnt57jJsjo1IB+/4yoQ1Bqzm2GBbWuD2yGLyvi37s5RE4Uk+ujT7PQGoAY9H8ELk3pj+tiIfujMBn+k4gJ9w9XM4Q91lhwek4YmkNihL2a+rAmddFOTCvwJfefuX13UGxEqIkEhWnQHVos4Lf8Vlf6zF0dgwRHAmXVoW/UOQEW2xwS0RS3wRCqOZ179yxwPxU9oVFDHgy+LVQ6n2z4jWO6hQMx0Do0i7FWgU98EiFsNWUYzg5wU5tWKqh1MIpMyKYegsJDXv3ZBxQZOWX2sk8waeLEjzwsJ4UDrRXNaKJfEFOay+VcANXfHua5l2U9nNcZ7sLPhB7Apz1sAReO4/QDbLLRdNWY8F4SB4IBWSL/bu+dXcf4+sje632KfFgI2Q8pzB44uxkmXN75ZlbpwgPwxNWwrsaKm0lf9IMlEEWr2Plnr6a/Rx63NLl+fuVXb4rGoSzD+x4qBFN5sR+qhwDcb1gwPOnn4F0XODm/+vNNpfn9vFrMK9LXE77SB4VzP652DsQ9oAgw40dJf+TGhH4lwXeT1DVvYH7nXbkIXOCzxx1Vg2vs8cEBKFM1bvqHx5mmWJ5Qh9OKnfW6wd6Q/nqOK6GhxEhY9C12QL3/2LzrYmmv4GWQ7ZkwB+DmuFWX31RVEz13Zozm3A l0qgXvoJ IVYc9zbJF9vP9iLZ5VAAhi9PwujlNXSwpdoxCV/ygdjcMa5cJ1HU7R5/keUEEs52tNGr3sr41tV2qoit/qdq3UGw5iVkneLK971te8t7YEiI0tM0B3AcVsJD8cClHK5BC7UdDG3Nhco1DgAPaI7N3Kh1qs87DSS+K5shk+49ErV1nexRizhG25XYFKX5gw8n23mx6N6NTnE/M8es1jii8lIEwWCY6XUPDJENdA8T0d41PePSGliGuYnboKrSxILdPEKJdwrUGQBWQ5TfxWihRAaTzbdOGbfhzIy9BOperzi8ayoY8GNjKq/3OLXxOIomaUhKBqSx7oorxvE2QqCp0i5aadlaHeht/WAoEM0HcCBRbl1c8kLkLE+lobczHzNrR0h4iXR9ewdg5xquH/727o5lH7eD54TMy/3Bkkxs5zSIZpJ8+4eMHnJVumEBjM4O5eEGsM0GRIFl+Kg8yGDx2cUhF5tqiolkdf4uBh8ooi+kDPWLnWdiw0AHILoBg+7b2DTwlmK5yYckZu72lRIK0Lb5Cs3EwZVSipkpPXEx8gfWgpQfdgOsp1ubHueDUK/LBL1Fpcog3CjyfRmh49XhhpYo3I6HQofq3BlQ24jskJ4pZyVDG9BFnN7/R6dyXL0oHbyiFJfVpoDy1LD1O8pP6IdwlQnVKh74nhJW9BisMP/ANH4ylXT0dNxjVJVq/CCSmsr3R9xYE0AD7b8DbdsIhXSDORTWMbf5y+kO9KXoipeCfLtH27rY9GK5wng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Chuck, On Sun, Jun 25, 2023 at 5:17=E2=80=AFPM Chuck Lever III wrote: > > On Jun 25, 2023, at 4:46 AM, Geert Uytterhoeven = wrote: > > On Sat, May 13, 2023 at 10:54=E2=80=AFAM Dan Carpenter wrote: > >> On Fri, May 12, 2023 at 01:56:30PM +0000, Chuck Lever III wrote: > >>>> On May 12, 2023, at 6:32 AM, Dan Carpenter wrote: > >>>> I'm pretty sure Chuck Lever did this intentionally, but he's not on = the > >>>> CC list. Let's add him. > >>>> > >>>> regards, > >>>> dan carpenter > >>>> > >>>> On Fri, May 12, 2023 at 06:15:04PM +0530, Naresh Kamboju wrote: > >>>>> Following kernel warning has been noticed on qemu-arm64 while runni= ng kunit > >>>>> tests while booting Linux 6.4.0-rc1-next-20230512 and It was starte= d from > >>>>> 6.3.0-rc7-next-20230420. > >>>>> > >>>>> Reported-by: Linux Kernel Functional Testing > >>>>> > >>>>> This is always reproducible on qemu-arm64, qemu-arm, qemu-x86 and q= emu-i386. > >>>>> Is this expected warning as a part of kunit tests ? > >>> > >>> Dan's correct, this Kunit test is supposed to check the > >>> behavior of the API when a too-large privsize is specified. > >>> > >>> I'm not sure how to make this work without the superfluous > >>> warning. Would adding GFP_NOWARN to the allocation help? > >> > >> That would silence the splat, yes. > > > > But introduce a build failure, as GFP_NOWARN does not exist. > > This is the fix that went in: > > commit b21c7ba6d9a5532add3827a3b49f49cbc0cb9779 > Author: Chuck Lever > AuthorDate: Fri May 19 13:12:50 2023 -0400 > Commit: Jakub Kicinski > CommitDate: Mon May 22 19:24:52 2023 -0700 > > net/handshake: Squelch allocation warning during Kunit test > > The "handshake_req_alloc excessive privsize" kunit test is intended > to check what happens when the maximum privsize is exceeded. The > WARN_ON_ONCE_GFP at mm/page_alloc.c:4744 can be disabled safely for > this test. > > Reported-by: Linux Kernel Functional Testing > Fixes: 88232ec1ec5e ("net/handshake: Add Kunit tests for the handshak= e consumer API") > Signed-off-by: Chuck Lever > Link: https://lore.kernel.org/r/168451636052.47152.960044332657045794= 7.stgit@oracle-102.nfsv4bat.org > Signed-off-by: Jakub Kicinski > > diff --git a/net/handshake/handshake-test.c b/net/handshake/handshake-tes= t.c > index e6adc5dec11a..6193e46ee6d9 100644 > --- a/net/handshake/handshake-test.c > +++ b/net/handshake/handshake-test.c > @@ -102,7 +102,7 @@ struct handshake_req_alloc_test_param handshake_req_a= lloc_params[] =3D { > { > .desc =3D "handshake_req_alloc excessiv= e privsize", > .proto =3D &handshake_req_alloc_proto_6, > - .gfp =3D GFP_KERNEL, > + .gfp =3D GFP_KERNEL | __GFP_NOWARN, > .expect_success =3D false, > }, > { > > Is there a platform where __GPF_NOWARN is not defined? "git grep" says all of them, as you misspelled it in your question ;-) "__GFP_NOWARN" is defined in include/linux/gfp_types.h, so it should be available everywhere. Note the use of "__GFP_NOWARN" instead of "GFP_NOWARN". Once in a while, people do submit patches using "GFP_NOWARN"... Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds