From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38994C83F32 for ; Thu, 31 Aug 2023 12:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 726B9900002; Thu, 31 Aug 2023 08:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D6A38D0001; Thu, 31 Aug 2023 08:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C6A5900002; Thu, 31 Aug 2023 08:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4DCB18D0001 for ; Thu, 31 Aug 2023 08:01:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C19CB4026A for ; Thu, 31 Aug 2023 12:01:34 +0000 (UTC) X-FDA: 81184260108.16.51CDBF9 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 0C1D18004A for ; Thu, 31 Aug 2023 12:01:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693483288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J9bc6fKng+UnSmfH+niYbTUHXqxhmRFh+l6XH8C7zl4=; b=oIzrp7LTH0zlPOCvEcyR6v0Q/ZxZ0fELTbXld94jHETINmXy+1hO38RR/13lLpjuJFvq8j 2qhCxmpN6cCynpzg4rNnIZiVZu+9H9zJuVZRw5RE5+kgvIK7PA8p1b8Q4K/sbgP8aQ8WRB xIsRwET8da8YXNe4HIvEUST37r45PsY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693483288; a=rsa-sha256; cv=none; b=fXBeyuX1DVrEt55fTVo7xCJuZ4xB4hrL6NjzJOHwWHm87zeW3l9sES8FolC5j4f6+eaJwO o6VIfAAwmT/Fibz0B/Adv4Jki7QRYlKvjKFaS/a/Ui0y6E3FFJNbLPOlfR3fMBZGtvqeod eWy1Tyxa0HI8qRuSFkwp+nL1UxxqtbQ= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-58df8cab1f2so8830237b3.3 for ; Thu, 31 Aug 2023 05:01:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693483287; x=1694088087; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J9bc6fKng+UnSmfH+niYbTUHXqxhmRFh+l6XH8C7zl4=; b=APrcF3+KIpEtnZZMeTvAXWFmkbMnOtLtT+Xd/y55W1y7aHOp5c1ZV5EYvEgRx1kaSY 5P6w0ZXiEMgPPzoau56Hom8iDq0OKJhQQ/cFckdxCG0amiZLQlQe9lpZsx+jVIi5NzLq d/6PSBBVGRmT0SzP2cIc/343i7KkPxeSPBCLEgOdguvtJ7OU40sCn2cysLQhZPQlZy4p loHYMJNEI8KiFykYzl2nVE8F6aDqZ11nbaXT08pLWWEM7p5+6qfI1YWJDpno/fTqfAQv J5awxDfL0X7MPMC9gGWRvAdhUYY60GqWL9Khm2ZtVuHW55NiVNJMaLWEUTXtH63XwjKH f0FA== X-Gm-Message-State: AOJu0YxZoUUKUbaibcRX80jC2tLgCIapTW/ClGQq6Uxc+wXkbJpkY68D UGGJiRGWjGM1MJq3BvX0ox6AWdkhZCxbGg== X-Google-Smtp-Source: AGHT+IFuHXbdEP4M7SUcbCvpoPEFL4XDZpl7wdlZKS152BMVPa1gM2fezRHnNiD9p68Xoe4xvFRhVw== X-Received: by 2002:a81:8315:0:b0:576:7dfc:e73e with SMTP id t21-20020a818315000000b005767dfce73emr5205159ywf.32.1693483286741; Thu, 31 Aug 2023 05:01:26 -0700 (PDT) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id p189-20020a815bc6000000b0054bfc94a10dsm361050ywb.47.2023.08.31.05.01.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 05:01:26 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-d7ba4c5f581so502998276.0 for ; Thu, 31 Aug 2023 05:01:26 -0700 (PDT) X-Received: by 2002:a25:6c55:0:b0:d78:2967:93ea with SMTP id h82-20020a256c55000000b00d78296793eamr4324533ybc.1.1693483285941; Thu, 31 Aug 2023 05:01:25 -0700 (PDT) MIME-Version: 1.0 References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> <20230831-imperial-surviving-afdf6d275388@wendy> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 31 Aug 2023 14:01:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known To: "Lad, Prabhakar" Cc: Conor Dooley , kernel test robot , Lad Prabhakar , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: i9y3pppbqs1bdsfonesbgyr564ig38zx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0C1D18004A X-HE-Tag: 1693483287-280240 X-HE-Meta: U2FsdGVkX1+KcPx8zk9y1+stcyWqy22hwRcpHzKOaQJx8rom6EilOW4pAYxL5Z2cuHHqwxUDUQsAV1576x2WO2LQgHlFnv6T2lNJPmnXvRd2dO3SI9w7WV0HJUgv6X9BUac253Ce0eeOylbnl1Od1N0S58bZfj7uPtBWx8OxM6ThS118JtZ2NXT9NEkWlSLzP2F8rRexyDg8Oxk+StfdmKg2D/52WRNJd45RAxqX72Exhhb+C1iKM6j/EA/O3KJM6YTxAnz5Oxawa29Gzj6xKMgUnSYmqViHsi+bNxaC9cGC6KgswQjkNjaSYFv6fHGwwHt0nJv9yRFVkPLZF7FXp6q6KZro9UYr7I0DjLOFatU9z6uKmm8oXUwAvcbiO+CfjdiTNRGN4TkeSDwtO89rmjexIYLUQLm2S4bWavI3tlUe54ZH+azhg39qEhL4VLiOHtNzlAu5sPnLOWT6RDej8V5gzDZ4z2qtYjLpnVM+MgnGTU0LXK5Kqt7y9K2453/+tPhcGo+vK9+Ed6XlJRvf4edmV+OEmDqnKgcsFnaJfnQpZEDYlv6jzlvcbuYAoq5SNkjEUM9Sm0Yp2Sexa8+imIDxzmoei2myEK1c7N+4QdZDNd+QZ0FTsWaru37Z5ewv/puu77oZ/Z1G/gg/is0AE6//6/2lRGYRFtBNEVT2y+wsiZQjPYIlyqSv8XtgapRIj65M0t555vr36VmkBine58fjhXEpTe1rx2YT+tDjtFrBVe+XrGKWLIX8t/HRmJpgBXOTiSTrazsE01ti8IVJ3gEm1W2rWjLH6uhD7qlTDCEiOjU6HOn3yFlJ9WC6J7VYIRX27qrBpKRlmWjjilxM94VvzqJNtTGXk3sLPYP3nqZzt6eMqbXACARmeIVHKmgp1hYvQ3o1OyJ3FJqpdkEJwp7WIK8aCbTEXhhxCHKDs/X+93cJ+gtA/x+BQZKR5E2Ydt58wlTW0eqr1Qfg/+D He3GS7RT ASyXW5Nges6XARKkhwUYHEE0uQzswyYffLvRu/897zLMaVb4iPqNn2j7yDp4gJVH3ju/QHc1vJ1FdNfEtfd1AH4nm/KcDjFt3likhkFDpvoZNht2Y7E2dOScU9Kngtpo3RdFQeswcDdzXOFXY41bUjiPHjTTwoSpoIx8NFhS7fHI7LV05QJkQV4t7RMpQY0aQbe9hwbsXKHyd0TTDKYLCjrGQb/i9N0fOeFU1jWOqLSg6Rzk3l4SOhktK/fvXRiMp03aSgO4HOpqliyObcM7Nu7lMMV7n+ut0gLDwWoOtOlnvLFw9H6+HBAn6aWmOnmckQgMLrEYtJ533zD5L94kDo/0zFq8cjK7sClhve4EDjWSZoFt9vOjcHbntTOukvuszj/TI5NHzAVX+kz1iLmKV+qTSquDZQJRSECouDijVKp/FczGL5ttSI32ZIhpXCQ9/eJxxfPzPfkofDGyzQDLCnMl4EAqYVmgQ2CkIKq2CDl/RHQOLwpCK9h9mxd2emDFRxglYXB8Hav5tADi1uv+LJfh2dXT8TvTIH3BW65rTxnF+iT8FiPquyx57ej3azIHMkprp2tNCSxTQauhBpny/nvwN62msFZjhOklEvxm5FGP8AE8OpoLu3KlKCEqfs2ampwyareLm0YLM8Vd8w6FZz5IlrcLpNsrRrIavdu2AGI+wwlcgr1eCt/aEOUZRHRW9AG0wyQB6TDa/Uc1NvKKWt9k2xqOU1CKQosWdPcMeLxd/rykAktiDGruAGUjTIMr2fIgIDRKfgrS+ISlN5oGqRYcPAlDXaaI+znO6l0LREGa9hsM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Prabhakar, On Thu, Aug 31, 2023 at 1:54=E2=80=AFPM Lad, Prabhakar wrote: > On Thu, Aug 31, 2023 at 12:34=E2=80=AFPM Conor Dooley > wrote: > > On Thu, Aug 31, 2023 at 12:22:50PM +0100, Lad, Prabhakar wrote: > > > On Thu, Aug 31, 2023 at 10:44=E2=80=AFAM Conor Dooley > > > wrote: > > > > > > > > On Thu, Aug 31, 2023 at 04:52:00PM +0800, kernel test robot wrote: > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linu= x-next.git master > > > > > head: a47fc304d2b678db1a5d760a7d644dac9b067752 > > > > > commit: f2863f30d1b05e5ecf61c063609cb974954d47f8 [13230/13643] ri= scv: errata: Add Andes alternative ports > > > > > config: riscv-randconfig-001-20230831 (https://download.01.org/0d= ay-ci/archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/config) > > > > > compiler: riscv64-linux-gcc (GCC) 13.2.0 > > > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-= ci/archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/reproduce) > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a = new version of > > > > > the same patch/commit), kindly add following tags > > > > > | Reported-by: kernel test robot > > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6b= m2G8-lkp@intel.com/ > > > > > > > > > > All error/warnings (new ones prefixed by >>): > > > > > > > > > > arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_= workaround': > > > > > >> arch/riscv/errata/andes/errata.c:29:23: error: storage size of= 'ret' isn't known > > > > > 29 | struct sbiret ret; > > > > > | ^~~ > > > > > >> arch/riscv/errata/andes/errata.c:35:15: error: implicit declar= ation of function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] > > > > > 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, AND= ES_SBI_EXT_IOCP_SW_WORKAROUND, > > > > > | ^~~~~~~~~ > > > > > >> arch/riscv/errata/andes/errata.c:29:23: warning: unused variab= le 'ret' [-Wunused-variable] > > > > > 29 | struct sbiret ret; > > > > > | ^~~ > > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > > > > vim +29 arch/riscv/errata/andes/errata.c > > > > > > > > > > 26 > > > > > 27 static long ax45mp_iocp_sw_workaround(void) > > > > > 28 { > > > > > > 29 struct sbiret ret; > > > > > 30 > > > > > 31 /* > > > > > 32 * ANDES_SBI_EXT_IOCP_SW_WORKAROUND SBI EXT= checks if the IOCP is missing and > > > > > 33 * cache is controllable only then CMO will= be applied to the platform. > > > > > 34 */ > > > > > > 35 ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, = ANDES_SBI_EXT_IOCP_SW_WORKAROUND, > > > > > 36 0, 0, 0, 0, 0, 0); > > > > > 37 > > > > > 38 return ret.error ? 0 : ret.value; > > > > > 39 } > > > > > 40 > > > > > > > > Looks like the config doesn't enable SBI, so ERRATA_ANDES_CMO will = need > > > > to grow a dependency on RISCV_SBI. > > > I think adding dependency for RISCV_SBI on ERRATA_ANDES would be a go= od idea. > > > > > > While at it I am seeing below warnings with this randconfig: > > > WARNING: unmet direct dependencies detected for ERRATA_ANDES_CMO > > > Depends on [n]: ERRATA_ANDES [=3Dy] && MMU [=3Dn] && ARCH_R9A07G043= [=3Dy] So the issue is that CONFIG_MMU=3Dn. > --- a/arch/riscv/Kconfig.errata > +++ b/arch/riscv/Kconfig.errata > @@ -3,6 +3,7 @@ menu "CPU errata selection" > config ERRATA_ANDES > bool "Andes AX45MP errata" > depends on RISCV_ALTERNATIVE > + depends on RISCV_SBI > help > All Andes errata Kconfig depend on this Kconfig. Disabling > this Kconfig will disable all Andes errata. Please say "Y" > @@ -12,7 +13,7 @@ config ERRATA_ANDES > > config ERRATA_ANDES_CMO > bool "Apply Andes cache management errata" > - depends on ERRATA_ANDES && MMU && ARCH_R9A07G043 Why does this depend on MMU? > + depends on ERRATA_ANDES && MMU > select RISCV_DMA_NONCOHERENT > default y > help > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -333,11 +333,9 @@ if RISCV > > config ARCH_R9A07G043 > bool "RISC-V Platform support for RZ/Five" > + depends on AX45MP_L2_CACHE This looks backwards to me... > select ARCH_RZG2L > - select AX45MP_L2_CACHE > select DMA_GLOBAL_POOL > - select ERRATA_ANDES > - select ERRATA_ANDES_CMO > help > This enables support for the Renesas RZ/Five SoC. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds