From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E810C77B78 for ; Thu, 4 May 2023 17:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B0BD6B0078; Thu, 4 May 2023 13:26:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 360B46B0080; Thu, 4 May 2023 13:26:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2507D6B0081; Thu, 4 May 2023 13:26:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by kanga.kvack.org (Postfix) with ESMTP id F2CEB6B0078 for ; Thu, 4 May 2023 13:26:25 -0400 (EDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-55a2691637bso10701687b3.0 for ; Thu, 04 May 2023 10:26:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683221185; x=1685813185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3rnIRd9cvXtgtMC0ZOKTG1aj8pR1h+8CjVNfvekskoI=; b=j9NR85HoRcK6wKfyzlCs+u3+4M3mc1e8ez1QhOQ/B1YIG9JFThNWKI/FFse+mvZkqi OZITB5a7h1pIdRbIuoC30aGxqu7J3HKh2amCT0KGUMyDG/XA3XdNfnxbfqQI/lLqfw3q YzxW6N3XPSXCCYHQT4qTBvUkqc/RtzmTJdY7o7Zta6P4B2tS8WEMV6tbVYpKFA5qi9di i050wZ+SPkukf39V4AdeValBSJDAijsNCpPsGVEKWxUrzn57b6eZORIAXuXZ4HJc3+qW DBP/A46nvM0mqRK+SzKeNXeAYsnRAk8dwUgeuciIwX8qHAp9W8bwg+zjfS5asSLg38w8 NLBw== X-Gm-Message-State: AC+VfDzexnFEIdrwTo0STd2zs8DozEKKSw0SnNs9+r0h9xDMxIAIUJXC t2kLSyysr29DziseibUdmhoNk8odcB4hGg== X-Google-Smtp-Source: ACHHUZ50E7hTAhTIJxia8aqwJp0KstVxJbpeSyOLuUvY/sIY2jnvarVjaUMrV4gqdUx3RVsp9F27eA== X-Received: by 2002:a0d:d846:0:b0:559:fb89:e2c4 with SMTP id a67-20020a0dd846000000b00559fb89e2c4mr3255595ywe.22.1683221185264; Thu, 04 May 2023 10:26:25 -0700 (PDT) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id b124-20020a0dd982000000b0055a8e67d55dsm1845250ywe.23.2023.05.04.10.26.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 10:26:24 -0700 (PDT) Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-b9e2f227640so1031182276.3 for ; Thu, 04 May 2023 10:26:23 -0700 (PDT) X-Received: by 2002:a25:dd07:0:b0:b8f:227a:b080 with SMTP id u7-20020a25dd07000000b00b8f227ab080mr724998ybg.18.1683221183312; Thu, 04 May 2023 10:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20230503013608.2431726-1-nphamcs@gmail.com> <20230503013608.2431726-3-nphamcs@gmail.com> In-Reply-To: <20230503013608.2431726-3-nphamcs@gmail.com> From: Geert Uytterhoeven Date: Thu, 4 May 2023 19:26:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 2/3] cachestat: implement cachestat syscall To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, linux-api@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nhat, On Wed, May 3, 2023 at 3:38=E2=80=AFAM Nhat Pham wrote: > There is currently no good way to query the page cache state of large > file sets and directory trees. There is mincore(), but it scales poorly: > the kernel writes out a lot of bitmap data that userspace has to > aggregate, when the user really doesn not care about per-page > information in that case. The user also needs to mmap and unmap each > file as it goes along, which can be quite slow as well. > > Some use cases where this information could come in handy: > * Allowing database to decide whether to perform an index scan or > direct table queries based on the in-memory cache state of the > index. > * Visibility into the writeback algorithm, for performance issues > diagnostic. > * Workload-aware writeback pacing: estimating IO fulfilled by page > cache (and IO to be done) within a range of a file, allowing for > more frequent syncing when and where there is IO capacity, and > batching when there is not. > * Computing memory usage of large files/directory trees, analogous to > the du tool for disk usage. > > More information about these use cases could be found in the following > thread: > > https://lore.kernel.org/lkml/20230315170934.GA97793@cmpxchg.org/ > > This patch implements a new syscall that queries cache state of a file > and summarizes the number of cached pages, number of dirty pages, number > of pages marked for writeback, number of (recently) evicted pages, etc. > in a given range. Currently, the syscall is only wired in for x86 > architecture. > > NAME > cachestat - query the page cache statistics of a file. > > SYNOPSIS > #include > > struct cachestat_range { > __u64 off; > __u64 len; > }; > > struct cachestat { > __u64 nr_cache; > __u64 nr_dirty; > __u64 nr_writeback; > __u64 nr_evicted; > __u64 nr_recently_evicted; > }; > > int cachestat(unsigned int fd, struct cachestat_range *cstat_range, > struct cachestat *cstat, unsigned int flags); > > DESCRIPTION > cachestat() queries the number of cached pages, number of dirty > pages, number of pages marked for writeback, number of evicted > pages, number of recently evicted pages, in the bytes range given by > `off` and `len`. > > An evicted page is a page that is previously in the page cache but > has been evicted since. A page is recently evicted if its last > eviction was recent enough that its reentry to the cache would > indicate that it is actively being used by the system, and that > there is memory pressure on the system. > > These values are returned in a cachestat struct, whose address is > given by the `cstat` argument. > > The `off` and `len` arguments must be non-negative integers. If > `len` > 0, the queried range is [`off`, `off` + `len`]. If `len` =3D= =3D > 0, we will query in the range from `off` to the end of the file. > > The `flags` argument is unused for now, but is included for future > extensibility. User should pass 0 (i.e no flag specified). > > Currently, hugetlbfs is not supported. > > Because the status of a page can change after cachestat() checks it > but before it returns to the application, the returned values may > contain stale information. > > RETURN VALUE > On success, cachestat returns 0. On error, -1 is returned, and errno > is set to indicate the error. > > ERRORS > EFAULT cstat or cstat_args points to an invalid address. > > EINVAL invalid flags. > > EBADF invalid file descriptor. > > EOPNOTSUPP file descriptor is of a hugetlbfs file > > Signed-off-by: Nhat Pham > --- > arch/x86/entry/syscalls/syscall_32.tbl | 1 + > arch/x86/entry/syscalls/syscall_64.tbl | 1 + This should be wired up on each and every architecture. Currently we're getting :1567:2: warning: #warning syscall cachestat not implemented [-W= cpp] in linux-next for all the missing architectures. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds