From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD88C4332F for ; Wed, 13 Dec 2023 08:36:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F446B045F; Wed, 13 Dec 2023 03:36:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50EEB6B0460; Wed, 13 Dec 2023 03:36:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AFB26B0462; Wed, 13 Dec 2023 03:36:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C62C6B045F for ; Wed, 13 Dec 2023 03:36:31 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E9C69C04D3 for ; Wed, 13 Dec 2023 08:36:30 +0000 (UTC) X-FDA: 81561138540.25.46D89FB Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf19.hostedemail.com (Postfix) with ESMTP id EDC631A0010 for ; Wed, 13 Dec 2023 08:36:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702456589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6anvPPkB7zC5RyRZfp8ATi41Ad4dEiA0WoUIsmcFlew=; b=SynTBMntnPqdWDDZNpfqZ1YF1b5t3U4NwJnAB+khXP+Vntscfv9q9Is9KDDCD6Qbba1LF2 Vnu6jKOlW4sx1ip2Cu+rvrs/rR9ovsHVBo6SxC06iMvzOyYDifb5Ha//CzHrEFJLJS3uGT I9GR0tPRM3oLeDRqU5OreACBEJBBIRA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702456589; a=rsa-sha256; cv=none; b=4FNlZDZ1BuG2mIgi1AhNpvzxSim0mPd2o/jdpJTY2+JlYk/+HAhNk2hNwB9vcFKoU+PAM6 Fep1rhi/hXV+wA1uwgQ/DAIEHj5TzHMaYPG+m7zWyGTcsx/LPJLZwZSnz58/8wHUiaijqy wRLBj9IS7ILlLmYomHY0pJ3jJ1y4cfs= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-1efabc436e4so4698153fac.1 for ; Wed, 13 Dec 2023 00:36:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702456588; x=1703061388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6anvPPkB7zC5RyRZfp8ATi41Ad4dEiA0WoUIsmcFlew=; b=STWqIzVM71I+ckzeQ/Vbu9ehXAnpWmtBoW4pNV5AJJmAioxeaaDSx5kbMug3RLk92y JwdF1/WXwp8y1mgukTqfjRhSjgOFHB/UUTMnWNEJmcJEDVpRgJbhuMBgZ6vaLwy0IKdS 7sk+pcQxybQtcf7fbie97s+0Z5zNs1C82Lc13Rq5lsI8QnH7hhC8ZRJ31umAndkk/Clp Nlep2HmT1D9D2a2Z+0WKwlunQL8n3bruF4RNzzSmwypS4Kl18OgH+uA96MOU+1k8JzGo VQZ0E6B/jTAciw9DWsIZGOT+h7N+yv183rHHU0X3SLBM8zlMfpOAX2IAn/dhbneWqwPa oC8g== X-Gm-Message-State: AOJu0Yygr/hzkBpExxOpJAITQhUMbjzv3LJldoWC9quJazXnL9GLDVfV gKytusQhQ0K5vEFayT1g02OszwDeLbu3Jg== X-Google-Smtp-Source: AGHT+IG9kqn50lb0BT8idSi+iKcp2aQj9Byqw5YLfT+b6DU61b9DUjR+cS9ASfd1ezDAWqamF3y1GA== X-Received: by 2002:a05:6870:2108:b0:203:af5:13e8 with SMTP id f8-20020a056870210800b002030af513e8mr1737156oae.47.1702456587797; Wed, 13 Dec 2023 00:36:27 -0800 (PST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id u205-20020a8160d6000000b005d647048e54sm4441028ywb.111.2023.12.13.00.36.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 00:36:27 -0800 (PST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5e2be6dde31so798537b3.3 for ; Wed, 13 Dec 2023 00:36:27 -0800 (PST) X-Received: by 2002:a81:a1ce:0:b0:5e2:2917:273d with SMTP id y197-20020a81a1ce000000b005e22917273dmr1045743ywg.43.1702456586772; Wed, 13 Dec 2023 00:36:26 -0800 (PST) MIME-Version: 1.0 References: <20231212213457.132605-1-alexghiti@rivosinc.com> <20231212213457.132605-2-alexghiti@rivosinc.com> In-Reply-To: <20231212213457.132605-2-alexghiti@rivosinc.com> From: Geert Uytterhoeven Date: Wed, 13 Dec 2023 09:36:15 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] mm: Introduce flush_cache_vmap_early() To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Arnd Bergmann , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EDC631A0010 X-Rspam-User: X-Stat-Signature: gmpjy6oftktx9diuhtbq9fsarruddpiu X-Rspamd-Server: rspam01 X-HE-Tag: 1702456588-210375 X-HE-Meta: U2FsdGVkX19ZWqGU7necBslDxaB/YAbihTigrFl24wtUwhVL4k+ZwOXK0vOKa6pmPbEiWvysRHBKFekksm4x7Lx09EC0SRikGCJjFRVHkZGnU1AZUXWDF7+vcptntlo3Rm9XkHQXOjqlIUPr2KCCerv327CZZk1nmvkPDmAEy6OQ3jORUQZm3ZvvrcsyFFx0aK4gnscNAQGsFycTkSntGO09uGvhclu/bLI83HRpgrVFeEtzHA46OXTtf8D5zqXVIXj3lkT2EH1jNI5P+gd9fSDxxUU09BcClPIU8TA5ltECWBCYRr4siZ6E3fTRyoeK0q8/vDiddn0fTYAmSbp8OAK/n0CPrWos7oxuT97OjWVGq6vaC9KmXS1akcBcgxtF4CFImbUCx+9jTjtFKBYrv23IFawhrb+OR2MQdXUxMtlP04VWfYMwZ+JmHSfoHAhVjkvBqr2mA/Y5d1H+x5enVfgXzxImkC6jcyoy0E2PJT9jR7uNXSQ+PHpbDghG+dFE9UiEN9EToaSBQhZrhJxqOVK/1FD11SzPbhbcLwgyorcpHo09GsMiNaiSSY72S8LIWoHSoQAjINY8ZVm8oxOzbFpGIa77xYnnfxSEW3r73xUT4oXDWmtQuWPoVANCx6N715Q/cTdzwLxiegnpfSko4alfLbM00lPezOxDTPt6rBjZbOeZGLjTZrAuuhcfPZh6CaTsl0fUYCn/dRUr1yz6pmPEZrl5UtYn3buEImAP/uBqvVMi31QRHDE5o5UKBA92v7DUuL/CWh3LkAJz4+8hmxGvtnnWimYEGSkw9zZ7vA+bxweWtNmoIGo1SWwpqtyTpsJvicHJCeKLL40JozfEe9hL5gYkFLqzQpaVIFaLHQA2V5fgRfRG1DE9qQ1iS0iEwngh2lkIfaw6rVNWMlc4jgjDy7xa7JzuE0pq2InzAUc6AWKDjdYcXqMPtNEwsbqtqBeMsyM3r94h8Daubqb tn97KSd7 +PyF3evBlpTX/tryduUxruR+9axyLHovIT+klJyiZfxQmy9x8d6+AFbkRMX2iCCA0V4Cl54b+edhDCY1VWuHufJEe/eWJIuBcFg/BlDmvhwh6TsJrTr0tidnZ6OO08C+mTh9w2/enot7Plktcrqc2U8v6WVVJKfrdHVEyVlWQq3DzJfsLdtnDbWWjwG3rUOnpwdquIFtq4CTwSWsY3P5qt4JzW6TLTWLGoYb+YHC5zIqZ0WOUDbsOoo5uqZeXrtlnN5XyM9KHLHRZkxDcYDRp7zctraPWH62pZyZTpG7svR+s03ylIB0PDZZHJ3sH5Qt9YGKEIv0rBQtExaVm5W4nHQzugcS+GblEtc0Ry4scRpDPd1xKzCVVyjgzw77eYHrvLbxHeW4TmphOlZcmNbQ/KCIBU/YChRu1ti/gAwEeCVwLw9BExp8kJ9Vz4mcCzF8QMv3proFav9C7MjBW5EiBj7qQpcKfC5pwMVp1/G8jtBUCUYb5GFLsfzfhAGX7vQbPTuXvwvUmRRKO7VTomeiuODy1+z4z9IvQ3gR+NngZuqc33qK2ufg5TRf5GiKnAoFB4wkFM12Yjw0INQ4RpJBs4w6HT9rsCsIWLPAGODak3b6PbvQNslsOtuF7Oma2vX75vmIt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 10:36=E2=80=AFPM Alexandre Ghiti wrote: > The pcpu setup when using the page allocator sets up a new vmalloc > mapping very early in the boot process, so early that it cannot use the > flush_cache_vmap() function which may depend on structures not yet > initialized (for example in riscv, we currently send an IPI to flush > other cpus TLB). > > But on some architectures, we must call flush_cache_vmap(): for example, > in riscv, some uarchs can cache invalid TLB entries so we need to flush > the new established mapping to avoid taking an exception. > > So fix this by introducing a new function flush_cache_vmap_early() which > is called right after setting the new page table entry and before > accessing this new mapping. This new function implements a local flush > tlb on riscv and is no-op for other architectures (same as today). > > Signed-off-by: Alexandre Ghiti > arch/m68k/include/asm/cacheflush_mm.h | 1 + Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds