[PATCH] mseal sysmap: add arch-support txt

[PATCH] mseal sysmap: add arch-support txt

[jeffxu]

From: Jeff Xu <jeffxu@chromium.org>

Add Documentation/features/core/mseal_sys_mappings/arch-support.txt

Signed-off-by: Jeff Xu <jeffxu@chromium.org>
---
 .../core/mseal_sys_mappings/arch-support.txt  | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 Documentation/features/core/mseal_sys_mappings/arch-support.txt

diff --git a/Documentation/features/core/mseal_sys_mappings/arch-support.txt b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
new file mode 100644
index 000000000000..8db637254de9
--- /dev/null
+++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
@@ -0,0 +1,30 @@
+#
+# Feature name:          mseal-system-mappings
+#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
+#         description:   arch supports mseal system mappings
+#
+    -----------------------
+    |         arch |status|
+    -----------------------
+    |       alpha: | TODO |
+    |         arc: | TODO |
+    |         arm: |  N/A |
+    |       arm64: |  ok  |
+    |        csky: | TODO |
+    |     hexagon: | TODO |
+    |   loongarch: | TODO |
+    |        m68k: | TODO |
+    |  microblaze: | TODO |
+    |        mips: | TODO |
+    |       nios2: | TODO |
+    |    openrisc: | TODO |
+    |      parisc: | TODO |
+    |     powerpc: | TODO |
+    |       riscv: | TODO |
+    |        s390: |  ok  |
+    |          sh: | TODO |
+    |       sparc: | TODO |
+    |          um: | TODO |
+    |         x86: |  ok  |
+    |      xtensa: | TODO |
+    -----------------------
-- 
2.49.0.rc0.332.g42c0ae87b1-goog

Re: [PATCH] mseal sysmap: add arch-support txt

[Lorenzo Stoakes]

On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@chromium.org>
>
> Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
>
> Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> ---
>  .../core/mseal_sys_mappings/arch-support.txt  | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/features/core/mseal_sys_mappings/arch-support.txt
>
> diff --git a/Documentation/features/core/mseal_sys_mappings/arch-support.txt b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> new file mode 100644
> index 000000000000..8db637254de9
> --- /dev/null
> +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> @@ -0,0 +1,30 @@
> +#
> +# Feature name:          mseal-system-mappings
> +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> +#         description:   arch supports mseal system mappings
> +#
> +    -----------------------
> +    |         arch |status|
> +    -----------------------
> +    |       alpha: | TODO |
> +    |         arc: | TODO |
> +    |         arm: |  N/A |
> +    |       arm64: |  ok  |
> +    |        csky: | TODO |
> +    |     hexagon: | TODO |
> +    |   loongarch: | TODO |
> +    |        m68k: | TODO |
> +    |  microblaze: | TODO |
> +    |        mips: | TODO |
> +    |       nios2: | TODO |
> +    |    openrisc: | TODO |
> +    |      parisc: | TODO |
> +    |     powerpc: | TODO |
> +    |       riscv: | TODO |
> +    |        s390: |  ok  |
> +    |          sh: | TODO |
> +    |       sparc: | TODO |
> +    |          um: | TODO |
> +    |         x86: |  ok  |
> +    |      xtensa: | TODO |
> +    -----------------------
> --
> 2.49.0.rc0.332.g42c0ae87b1-goog
>

I mean fine, but why not in the existing mseal documentation file where you
already document system mappings?

Plus I feel this need expansion a bit 'N/A' is because of being non-64 bit
right?

Actually this will change soon btw, based on Matthew's idea I plan to drop the
32-bit vma flags limit.

Anyway yeah, let's move that over there please.

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
>
> On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > From: Jeff Xu <jeffxu@chromium.org>
> >
> > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> >
> > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > ---
> >  .../core/mseal_sys_mappings/arch-support.txt  | 30 +++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >  create mode 100644 Documentation/features/core/mseal_sys_mappings/arch-support.txt
> >
> > diff --git a/Documentation/features/core/mseal_sys_mappings/arch-support.txt b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > new file mode 100644
> > index 000000000000..8db637254de9
> > --- /dev/null
> > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > @@ -0,0 +1,30 @@
> > +#
> > +# Feature name:          mseal-system-mappings
> > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > +#         description:   arch supports mseal system mappings
> > +#
> > +    -----------------------
> > +    |         arch |status|
> > +    -----------------------
> > +    |       alpha: | TODO |
> > +    |         arc: | TODO |
> > +    |         arm: |  N/A |
> > +    |       arm64: |  ok  |
> > +    |        csky: | TODO |
> > +    |     hexagon: | TODO |
> > +    |   loongarch: | TODO |
> > +    |        m68k: | TODO |
> > +    |  microblaze: | TODO |
> > +    |        mips: | TODO |
> > +    |       nios2: | TODO |
> > +    |    openrisc: | TODO |
> > +    |      parisc: | TODO |
> > +    |     powerpc: | TODO |
> > +    |       riscv: | TODO |
> > +    |        s390: |  ok  |
> > +    |          sh: | TODO |
> > +    |       sparc: | TODO |
> > +    |          um: | TODO |
> > +    |         x86: |  ok  |
> > +    |      xtensa: | TODO |
> > +    -----------------------
> > --
> > 2.49.0.rc0.332.g42c0ae87b1-goog
> >
>
> I mean fine, but why not in the existing mseal documentation file where you
> already document system mappings?
>
you mean adding s390 in the mseal.rst ? I thought Heiko was going to
add that ? [1], maybe not ?

From the example given by Heiko [1] , arch-support.txt is the official
way of documenting arch specific support. But adding these info in
mseal.rst won't hurt.

> Plus I feel this need expansion a bit 'N/A' is because of being non-64 bit
> right?
>
Below is the definition of N/A in Documentation/features/arch-support.txt
   | N/A|  # feature doesn't apply to the architecture

It fits the arm case because mseal is not supported in 32 bit.

> Actually this will change soon btw, based on Matthew's idea I plan to drop the
> 32-bit vma flags limit.
>
Okay, we can update this section to TODO when 32-bit vma flags are
expanded. Based on past comments, I gather we want the document to
reflect the current state of the kernel, not future features.

> Anyway yeah, let's move that over there please.

I'm looking at Heiko's direction first to see if mseal.rst will be
updated as part of the s390 patch, technically that belongs to Heiko's
patch series. I can also add that if Heiko doesn't care :-)

Thanks
-Jeff

[1]https://lore.kernel.org/all/20250312153946.10610B02-hca@linux.ibm.com/

Re: [PATCH] mseal sysmap: add arch-support txt

[Geert Uytterhoeven]

Hi Jeff,

On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > From: Jeff Xu <jeffxu@chromium.org>
> > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > >
> > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>

Thanks for your patch!

> > > --- /dev/null
> > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > @@ -0,0 +1,30 @@
> > > +#
> > > +# Feature name:          mseal-system-mappings
> > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > +#         description:   arch supports mseal system mappings
> > > +#
> > > +    -----------------------
> > > +    |         arch |status|
> > > +    -----------------------
> > > +    |       alpha: | TODO |
> > > +    |         arc: | TODO |
> > > +    |         arm: |  N/A |
> > > +    |       arm64: |  ok  |
> > > +    |        csky: | TODO |
> > > +    |     hexagon: | TODO |
> > > +    |   loongarch: | TODO |
> > > +    |        m68k: | TODO |
> > > +    |  microblaze: | TODO |
> > > +    |        mips: | TODO |
> > > +    |       nios2: | TODO |
> > > +    |    openrisc: | TODO |
> > > +    |      parisc: | TODO |
> > > +    |     powerpc: | TODO |
> > > +    |       riscv: | TODO |
> > > +    |        s390: |  ok  |
> > > +    |          sh: | TODO |
> > > +    |       sparc: | TODO |
> > > +    |          um: | TODO |
> > > +    |         x86: |  ok  |
> > > +    |      xtensa: | TODO |
> > > +    -----------------------

> > Plus I feel this need expansion a bit 'N/A' is because of being non-64 bit
> > right?
> >
> Below is the definition of N/A in Documentation/features/arch-support.txt
>    | N/A|  # feature doesn't apply to the architecture
>
> It fits the arm case because mseal is not supported in 32 bit.

IIUIC, you can already s@TODO@N/A@ for all other 32-bit architectures,
so we don't accidentally spend time on looking into adding the support?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Heiko Carstens]

On Thu, Mar 13, 2025 at 03:25:46PM -0700, Jeff Xu wrote:
> > > diff --git a/Documentation/features/core/mseal_sys_mappings/arch-support.txt b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > new file mode 100644
> > > index 000000000000..8db637254de9
> > > --- /dev/null
> > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > @@ -0,0 +1,30 @@
> > > +#
> > > +# Feature name:          mseal-system-mappings
> > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > +#         description:   arch supports mseal system mappings
> > > +#
...
> > I mean fine, but why not in the existing mseal documentation file where you
> > already document system mappings?
> >
> you mean adding s390 in the mseal.rst ? I thought Heiko was going to
> add that ? [1], maybe not ?
> 
> From the example given by Heiko [1] , arch-support.txt is the official
> way of documenting arch specific support. But adding these info in
> mseal.rst won't hurt.
> 
> > Anyway yeah, let's move that over there please.
> 
> I'm looking at Heiko's direction first to see if mseal.rst will be
> updated as part of the s390 patch, technically that belongs to Heiko's
> patch series. I can also add that if Heiko doesn't care :-)

Just sent a patch which does that. Sorry for the delay - I was offline
for a couple of days.

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Jeff,
>
> On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > <lorenzo.stoakes@oracle.com> wrote:
> > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > >
> > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
>
> Thanks for your patch!
>
> > > > --- /dev/null
> > > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > @@ -0,0 +1,30 @@
> > > > +#
> > > > +# Feature name:          mseal-system-mappings
> > > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > > +#         description:   arch supports mseal system mappings
> > > > +#
> > > > +    -----------------------
> > > > +    |         arch |status|
> > > > +    -----------------------
> > > > +    |       alpha: | TODO |
> > > > +    |         arc: | TODO |
> > > > +    |         arm: |  N/A |
> > > > +    |       arm64: |  ok  |
> > > > +    |        csky: | TODO |
> > > > +    |     hexagon: | TODO |
> > > > +    |   loongarch: | TODO |
> > > > +    |        m68k: | TODO |
> > > > +    |  microblaze: | TODO |
> > > > +    |        mips: | TODO |
> > > > +    |       nios2: | TODO |
> > > > +    |    openrisc: | TODO |
> > > > +    |      parisc: | TODO |
> > > > +    |     powerpc: | TODO |
> > > > +    |       riscv: | TODO |
> > > > +    |        s390: |  ok  |
> > > > +    |          sh: | TODO |
> > > > +    |       sparc: | TODO |
> > > > +    |          um: | TODO |
> > > > +    |         x86: |  ok  |
> > > > +    |      xtensa: | TODO |
> > > > +    -----------------------
>
> > > Plus I feel this need expansion a bit 'N/A' is because of being non-64 bit
> > > right?
> > >
> > Below is the definition of N/A in Documentation/features/arch-support.txt
> >    | N/A|  # feature doesn't apply to the architecture
> >
> > It fits the arm case because mseal is not supported in 32 bit.
>
> IIUIC, you can already s@TODO@N/A@ for all other 32-bit architectures,
> so we don't accidentally spend time on looking into adding the support?
>
Sure, my architecture knowledge is limited.

I just checked this, it seems to me that csky, m68k, nios2, sh, xtensa
doesn't have 64 bits support, the rest have 64 bits. Is this correct ?

Thanks
-Jeff



> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
>
> On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Jeff,
> >
> > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > <lorenzo.stoakes@oracle.com> wrote:
> > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > >
> > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> >
> > Thanks for your patch!
> >

I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
under arch/, and together with internet search/wiki page, and below is
the proposed update.

> > > > > --- /dev/null
> > > > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > @@ -0,0 +1,30 @@
> > > > > +#
> > > > > +# Feature name:          mseal-system-mappings
> > > > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > > > +#         description:   arch supports mseal system mappings
> > > > > +#
> > > > > +    -----------------------
> > > > > +    |         arch |status|
> > > > > +    -----------------------
> > > > > +    |       alpha: | TODO |
No CONFIG_64BIT found under arch/alpha, but search results show alpha
supports 64 bits. Keep as TODO.

> > > > > +    |         arc: | TODO |
> > > > > +    |         arm: |  N/A |
> > > > > +    |       arm64: |  ok  |
> > > > > +    |        csky: | TODO |
(N/A)

> > > > > +    |     hexagon: | TODO |
No CONFIG_64BIT found under arch/hexagon, but search results show
hexagon supports 64 bits. Keep as TODO.

> > > > > +    |   loongarch: | TODO |
> > > > > +    |        m68k: | TODO |
(N/A)

> > > > > +    |  microblaze: | TODO |
No CONFIG_64BIT found under arch/microblaze, but search results show
microblaze supports both 32 and 64 bits. Keep as TODO.

> > > > > +    |        mips: | TODO |
> > > > > +    |       nios2: | TODO |
(N/A)

> > > > > +    |    openrisc: | TODO |
No CONFIG_64BIT found under arch/openrisc, but search results show
microblaze supports both 32 and 64 bits. Keep as TODO.

> > > > > +    |      parisc: | TODO |
> > > > > +    |     powerpc: | TODO |
> > > > > +    |       riscv: | TODO |
> > > > > +    |        s390: |  ok  |
> > > > > +    |          sh: | TODO |
No CONFIG_64BIT found under arch/openrisc, but wikipedia shows sh-5 is
a 64 bit, so Keep as TODO.

> > > > > +    |       sparc: | TODO |
> > > > > +    |          um: | TODO |
> > > > > +    |         x86: |  ok  |
> > > > > +    |      xtensa: | TODO |
N/A

In summary: csky, m68k, nios2, xtensa, arm only have a 32 bit CPU and
will use "N/A".
I will leave it open for a while, If no objection , I will send a new
patch version.

Thanks.
-Jeff

> > > > > +    -----------------------
> >
> > > > Plus I feel this need expansion a bit 'N/A' is because of being non-64 bit
> > > > right?
> > > >
> > > Below is the definition of N/A in Documentation/features/arch-support.txt
> > >    | N/A|  # feature doesn't apply to the architecture
> > >
> > > It fits the arm case because mseal is not supported in 32 bit.
> >
> > IIUIC, you can already s@TODO@N/A@ for all other 32-bit architectures,
> > so we don't accidentally spend time on looking into adding the support?
> >
> Sure, my architecture knowledge is limited.
>
> I just checked this, it seems to me that csky, m68k, nios2, sh, xtensa
> doesn't have 64 bits support, the rest have 64 bits. Is this correct ?
>



> Thanks
> -Jeff
>
>
>
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Geert Uytterhoeven]

Hi Jeff,

On Mon, 17 Mar 2025 at 20:02, Jeff Xu <jeffxu@chromium.org> wrote:
> On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > > <lorenzo.stoakes@oracle.com> wrote:
> > > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > >
> > > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > >
> > > Thanks for your patch!
>
> I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
> under arch/, and together with internet search/wiki page, and below is
> the proposed update.

That way you only find users of the symbol, not where it is defined.

You can use

    git grep -W "config\s*64BIT" -- arch/

to find out which architectures are 32-bit, 64-bit, or support both.

> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > @@ -0,0 +1,30 @@
> > > > > > +#
> > > > > > +# Feature name:          mseal-system-mappings
> > > > > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > > > > +#         description:   arch supports mseal system mappings
> > > > > > +#
> > > > > > +    -----------------------
> > > > > > +    |         arch |status|
> > > > > > +    -----------------------
> > > > > > +    |       alpha: | TODO |
> No CONFIG_64BIT found under arch/alpha, but search results show alpha
> supports 64 bits. Keep as TODO.

Alpha is 64-bit only. So the code under arch/alpha/ does not need to check for
CONFIG_64BIT, hence you didn't find it;-)

> > > > > > +    |         arc: | TODO |
> > > > > > +    |         arm: |  N/A |
> > > > > > +    |       arm64: |  ok  |
> > > > > > +    |        csky: | TODO |
> (N/A)
>
> > > > > > +    |     hexagon: | TODO |
> No CONFIG_64BIT found under arch/hexagon, but search results show
> hexagon supports 64 bits. Keep as TODO.

32-bit only on Linux.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

Hi Geert,

On Mon, Mar 17, 2025 at 12:14 PM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Jeff,
>
> On Mon, 17 Mar 2025 at 20:02, Jeff Xu <jeffxu@chromium.org> wrote:
> > On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > > On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > > > <lorenzo.stoakes@oracle.com> wrote:
> > > > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > >
> > > > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > > >
> > > > Thanks for your patch!
> >
> > I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
> > under arch/, and together with internet search/wiki page, and below is
> > the proposed update.
>
> That way you only find users of the symbol, not where it is defined.
>
> You can use
>
>     git grep -W "config\s*64BIT" -- arch/
>
> to find out which architectures are 32-bit, 64-bit, or support both.
>
Good to know, thanks!

> > > > > > > --- /dev/null
> > > > > > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > > @@ -0,0 +1,30 @@
> > > > > > > +#
> > > > > > > +# Feature name:          mseal-system-mappings
> > > > > > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > > > > > +#         description:   arch supports mseal system mappings
> > > > > > > +#
> > > > > > > +    -----------------------
> > > > > > > +    |         arch |status|
> > > > > > > +    -----------------------
> > > > > > > +    |       alpha: | TODO |
> > No CONFIG_64BIT found under arch/alpha, but search results show alpha
> > supports 64 bits. Keep as TODO.
>
> Alpha is 64-bit only. So the code under arch/alpha/ does not need to check for
> CONFIG_64BIT, hence you didn't find it;-)
>
> > > > > > > +    |         arc: | TODO |
> > > > > > > +    |         arm: |  N/A |
> > > > > > > +    |       arm64: |  ok  |
> > > > > > > +    |        csky: | TODO |
> > (N/A)
> >
> > > > > > > +    |     hexagon: | TODO |
> > No CONFIG_64BIT found under arch/hexagon, but search results show
> > hexagon supports 64 bits. Keep as TODO.
>
> 32-bit only on Linux.
>
Ok. Thank you for correcting this.

Thanks
-Jeff

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

Hi Geert

On Tue, Mar 18, 2025 at 10:21 AM Jeff Xu <jeffxu@chromium.org> wrote:
>
> Hi Geert,
>
> On Mon, Mar 17, 2025 at 12:14 PM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> >
> > Hi Jeff,
> >
> > On Mon, 17 Mar 2025 at 20:02, Jeff Xu <jeffxu@chromium.org> wrote:
> > > On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > > > On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > > > > <lorenzo.stoakes@oracle.com> wrote:
> > > > > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > > >
> > > > > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > > > >
> > > > > Thanks for your patch!
> > >
> > > I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
> > > under arch/, and together with internet search/wiki page, and below is
> > > the proposed update.
> >
> > That way you only find users of the symbol, not where it is defined.
> >
> > You can use
> >
> >     git grep -W "config\s*64BIT" -- arch/
> >
> > to find out which architectures are 32-bit, 64-bit, or support both.
> >
Microblaze, openrisc, sh, hexagon all don't have CONFIG 64BIT defined
in KCONFIG, and are not using CONFIG_64BIT in their arch code.  Is
there something else that makes you point out the hexagon as 32 bit
only (and not other 3) ?

The microblaze/ openrisc/sh are currently listed as TODO in this patch
, and that is because the search results show they have 64 bits CPU.
But I like to double check.

I  included some people who recently merged into those arches in case
anyone is familiar with 32bit/64 bits usage in those architectures.

Thanks
-Jeff

> Good to know, thanks!
>
> > > > > > > > --- /dev/null
> > > > > > > > +++ b/Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > > > @@ -0,0 +1,30 @@
> > > > > > > > +#
> > > > > > > > +# Feature name:          mseal-system-mappings
> > > > > > > > +#         Kconfig:       ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS
> > > > > > > > +#         description:   arch supports mseal system mappings
> > > > > > > > +#
> > > > > > > > +    -----------------------
> > > > > > > > +    |         arch |status|
> > > > > > > > +    -----------------------
> > > > > > > > +    |       alpha: | TODO |
> > > No CONFIG_64BIT found under arch/alpha, but search results show alpha
> > > supports 64 bits. Keep as TODO.
> >
> > Alpha is 64-bit only. So the code under arch/alpha/ does not need to check for
> > CONFIG_64BIT, hence you didn't find it;-)
> >
> > > > > > > > +    |         arc: | TODO |
> > > > > > > > +    |         arm: |  N/A |
> > > > > > > > +    |       arm64: |  ok  |
> > > > > > > > +    |        csky: | TODO |
> > > (N/A)
> > >
> > > > > > > > +    |     hexagon: | TODO |
> > > No CONFIG_64BIT found under arch/hexagon, but search results show
> > > hexagon supports 64 bits. Keep as TODO.
> >
> > 32-bit only on Linux.
> >
> Ok. Thank you for correcting this.
>
> Thanks
> -Jeff
>
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Geert Uytterhoeven]

Hi Jeff,

On Tue, 18 Mar 2025 at 19:39, Jeff Xu <jeffxu@chromium.org> wrote:
> On Tue, Mar 18, 2025 at 10:21 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > On Mon, Mar 17, 2025 at 12:14 PM Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> > > On Mon, 17 Mar 2025 at 20:02, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > > > > > <lorenzo.stoakes@oracle.com> wrote:
> > > > > > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > > > >
> > > > > > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > > > > >
> > > > > > Thanks for your patch!
> > > >
> > > > I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
> > > > under arch/, and together with internet search/wiki page, and below is
> > > > the proposed update.
> > >
> > > That way you only find users of the symbol, not where it is defined.
> > >
> > > You can use
> > >
> > >     git grep -W "config\s*64BIT" -- arch/
> > >
> > > to find out which architectures are 32-bit, 64-bit, or support both.
> > >
> Microblaze, openrisc, sh, hexagon all don't have CONFIG 64BIT defined
> in KCONFIG, and are not using CONFIG_64BIT in their arch code.  Is
> there something else that makes you point out the hexagon as 32 bit
> only (and not other 3) ?

AFAIK Microblaze, openrisc, and hexagon are all 32-bit.
Linux used to support sh64, but that was dropped, as sh64 never went
beyond prototype hardware.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mseal sysmap: add arch-support txt

[Jeff Xu]

Hi Geert

On Wed, Mar 19, 2025 at 1:17 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Jeff,
>
> On Tue, 18 Mar 2025 at 19:39, Jeff Xu <jeffxu@chromium.org> wrote:
> > On Tue, Mar 18, 2025 at 10:21 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > > On Mon, Mar 17, 2025 at 12:14 PM Geert Uytterhoeven
> > > <geert@linux-m68k.org> wrote:
> > > > On Mon, 17 Mar 2025 at 20:02, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > On Mon, Mar 17, 2025 at 11:14 AM Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > > On Fri, Mar 14, 2025 at 3:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > > > On Thu, 13 Mar 2025 at 23:26, Jeff Xu <jeffxu@chromium.org> wrote:
> > > > > > > > On Wed, Mar 12, 2025 at 10:21 PM Lorenzo Stoakes
> > > > > > > > <lorenzo.stoakes@oracle.com> wrote:
> > > > > > > > > On Thu, Mar 13, 2025 at 12:06:23AM +0000, jeffxu@chromium.org wrote:
> > > > > > > > > > From: Jeff Xu <jeffxu@chromium.org>
> > > > > > > > > > Add Documentation/features/core/mseal_sys_mappings/arch-support.txt
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > > > > > >
> > > > > > > Thanks for your patch!
> > > > >
> > > > > I used "find * |xargs grep -i  CONFIG_64BIT" to look for CONFIG_64BIT
> > > > > under arch/, and together with internet search/wiki page, and below is
> > > > > the proposed update.
> > > >
> > > > That way you only find users of the symbol, not where it is defined.
> > > >
> > > > You can use
> > > >
> > > >     git grep -W "config\s*64BIT" -- arch/
> > > >
> > > > to find out which architectures are 32-bit, 64-bit, or support both.
> > > >
> > Microblaze, openrisc, sh, hexagon all don't have CONFIG 64BIT defined
> > in KCONFIG, and are not using CONFIG_64BIT in their arch code.  Is
> > there something else that makes you point out the hexagon as 32 bit
> > only (and not other 3) ?
>
> AFAIK Microblaze, openrisc, and hexagon are all 32-bit.
> Linux used to support sh64, but that was dropped, as sh64 never went
> beyond prototype hardware.
>
Great !  Thanks for the information.
I will update accordingly.

-Jeff


> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds