From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0451DC0218A for ; Thu, 30 Jan 2025 13:26:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C2C3280296; Thu, 30 Jan 2025 08:26:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 872B1280293; Thu, 30 Jan 2025 08:26:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ECB5280296; Thu, 30 Jan 2025 08:26:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4F2E5280293 for ; Thu, 30 Jan 2025 08:26:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 13DCAC0C14 for ; Thu, 30 Jan 2025 13:26:14 +0000 (UTC) X-FDA: 83064191868.12.8DBC87A Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf08.hostedemail.com (Postfix) with ESMTP id E35E916000A for ; Thu, 30 Jan 2025 13:26:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738243572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RcnCdea0Cg2xhZ905GiM0LEi2fn/A0TJy6vLZwAFU5g=; b=dwuOqAYWRuw1Vy2BcHn48IQjs0N635oODRBFAnRpE/SUnZQ+e8B/I0Fvl6PQkE0Zfjjfbj NypXKONrEvCCMk9u45kt2TIzlBkIPyIpxgfX4lz4zfFcM2g35LoJ5YyNdm6v9dAcRVlO4z upy4oT+8uCPWhb4yvqt2EzFZq5k/ymc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738243572; a=rsa-sha256; cv=none; b=C25Ih8YtiQ60/jPdgrUBs5jHgg17sVqly5udqk2KlW2USps+ryGyqyJq9JI2Qep8FH2qFS 3xRmB/MCrSJqBgiWrozHCdeB8R6QA4V9EdR+QFmMheV0FOJCtx4kva6Z6+rnEQ+V3rGBXR VZRyFqtgxhGcYrci2RfrAfsXatzTu1Y= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-4afe70b41a8so259909137.3 for ; Thu, 30 Jan 2025 05:26:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738243570; x=1738848370; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RcnCdea0Cg2xhZ905GiM0LEi2fn/A0TJy6vLZwAFU5g=; b=dpKAH9Xi8BFjpR8YtNAOQxV46Z7qGef7BA4ICc8M8A9XlNwGssg3dE0ZZwSgZSNkzo gqLxPPtQ5VQW9XJOsoaETwnTvkNAAMnP1qYff4btzfXVcf5BDu67kHrY6ZK1XPWMzx0r NmI0mmzGp795x4ILGMMni4C3JQ6lxf6v+K4z8o2kyLVnfGPLUEmrPd5EFukzv9nP3pcp nNXHe+yCJvclK5jk04rKuCW+PQR9KOhzCy1KvDU+Q/D25u1hA8Me62gjQu1eBBZEjzaA hDugTSPWETcRiQJt5X7O8NDo1BftKaKpKVNXrqVMUmpyM2WoCs7tRYkZNej2qNfdifJ7 PaOw== X-Forwarded-Encrypted: i=1; AJvYcCVdMWpIbx2GhZTxyQKxp5ll7729xHjtBLCEP4oZC2aup6XthAW6CtNbizwf9RkL2dBWS36dh6DMHA==@kvack.org X-Gm-Message-State: AOJu0YyfHEyfS6MaZ71NYbJ/DnK/LQGnJW5i2qh6c+z9XykjKPYzSMOq jGAiKdcxvViGEbe72q/d+ewMYe77e4U22eLKPaXa2NBxXPSrV7qAu0k0atPa X-Gm-Gg: ASbGnctaTKb99lQdhTVyFZw3i9b9caNhYyeIT6wSBFJErB7pwpPuUVy7q2BHH0UaU9d dIYWzHVlAO/jREm8i2x1YUerQURohBgCZ68VxUyvtyRV2nqKG7qgxXV8a7VjfJj36LYs+T3Z9xh 3V+eKCBBZceAMjtd0/4RysrHGzrm/ejlClGHeM7slrARmB5K2kqnto+Z/idD+4PBAZ66c94lbv1 2mNgOipR1zxyRzrHUCOFaddStLa03/R0Ig0T4nzjJInAYqAJDL91PuQ58s5VBixnr5RJgbnS4vn M+EzO1bIgqlIsCK2Ti0RRmdWaejd3tHUjpnd2mhXkgoLYEzG4+/zJQ== X-Google-Smtp-Source: AGHT+IFCnkLForTOh3uabvU68giFxNKzOTHV91trxqrrIwyEo2XHSqfn6WniJssmzfL5/KPkmJK0LA== X-Received: by 2002:a05:6102:31aa:b0:4b9:ba6d:8692 with SMTP id ada2fe7eead31-4b9ba6d8a73mr1011554137.20.1738243569938; Thu, 30 Jan 2025 05:26:09 -0800 (PST) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com. [209.85.217.45]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4b9baccd5cbsm225231137.19.2025.01.30.05.26.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 05:26:09 -0800 (PST) Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-4afe70b41a8so259898137.3 for ; Thu, 30 Jan 2025 05:26:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVXsx8p7oWrmj/3CGOa8s47LMMVHXvHZjJbXidA0ofvTPGa7sZEs2uU7gVoAntISF7LooWELEKn+A==@kvack.org X-Received: by 2002:a05:6102:2ad3:b0:4af:bb06:62d with SMTP id ada2fe7eead31-4b9a4f499c9mr6186530137.11.1738243569336; Thu, 30 Jan 2025 05:26:09 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 30 Jan 2025 14:25:57 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZn0su9wB3Rua7xZlN_jsLurJgHhePP-DQxZFLycHjingwrtS3E5xZdT-fo Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: "Liam R. Howlett" Cc: Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, Matthew Wilcox , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E35E916000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: st3qtannhkqzn6g58nmh37f373a4hg76 X-HE-Tag: 1738243571-736214 X-HE-Meta: U2FsdGVkX18ilZN+O3cQ+67oen1ZKZvnPGlN8am7XoS1gIcfxdnYcDaLYDRX2KoFNcGwHsv4Nex2Kxmds/983y7Cfbs9tmyTG/v0JY4d/XTUnuIq4oyGBrqCTxSM1gkW/MRY9dNNE6LI1hn3LNi4x+ZGMIbIK9BQYv7QF1LZnM4wk9b2eXhom4sNZ78hgMjj7Y+shHVr9EdmjN+pc2I6nUqXFHVF0Kj3DLDRQmKxYeKWukekA/tafKdnuIjota17wx6KbPwlnAi4ia1Z5c3ghTVJjK5cQDKlYh6r2UMaolbDyKssGf43JNtKhNFe3LEnum4YJ8RNcnADJBp8PYxPRRl/ZXAXV/kANYlitumknnv7vfSnJK9i18ShQt0grS3AOxn7MKoo4pOqKHV9DCy83zw1LukV3Vr+9oGAxK6x+VNviWx3BWqsrZwqDcwo3PIIq4mUyoq87R9Fj8JYhxdKL2br+XQXoFcN8ht0vwpan6kFgXgTQaas7+uilhfK9pPGeFdEcJBNJDl9SX6B6vKcFiYlesy46lRM+FQ+WF6HN0/Y3Ux0mmnkbyocYsAyHoh0ihK9DpszwMIZ9pumpU/a4hDDmgdq6IXTGdAw9KNkBqbyyRREFSA0ntSL7NbNfPIf0urXela20S4FlcmZMSWPz4yEj8JbxvC7aLVTtNJFJa6xStSPv0KbWLJI6DKWoGFxTbGzjbUmk0+7ciHI4ERkeZIYj0Eu61WAovNQKUE4Q1kh9j+oPHsGp5ckQ4j0piCFdIIpYp2SpG63SiHMsEDyqeRm3bZTCc0hgeQr+r/4C25jxh1Hmp+koLlIADBGNVNK0ceMWDkyXT9JzrEtdzKGRBVPfVah5sFxQ53iG6R9tLws9JOEWUS9rtT51AjWOSXuCWrLCGJnhcEuo5h1e5Z4FLjnkCUU59ntH/DfwiKqQwKy4ULzxako4TUW7nuDNKtnq90gTLUNq30eQBzts9Q v57oMQ/G LsyBSdXKJPcKtPBMJv8XAzXIiG/Fr9QMMOIC056zXn1KQM5X0YWg0cfuUiWsxVx2eT6R6zNXUkHJM0DqjjBikaMTwWl1P60JLXJZFXyKvELXgmLAOLBy+kPkyY1fSUz/FTQ6Hb9WfcNzXba7XoWCc3/DQK0hvTeWaMmzmsDPLTTrrakHiL/OtI/iVkT1HSQ7BgGEUbHKJMSdNpj8INOKVpkZ1MJNCF8naian5woEHWI9+5ImeclVJepNSMvlSmcodcYhdsnaA759vnhG0QiH25WpBqNRoq346kYsQYmukFUjqmK7Xzfu38/l2LsP9CpTL2n2NDHi3LvS4bfjUbjQmWLJ6xdQNRmF6CDYcA4C1x2sXzzFOAsT3DBveOGIfe507UqnjCNzllkYQxcCxK6QUhNgrB/Lp174Y2qSf9d+LYxqep9MA57JOsTUzjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam, On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett wrote: > * Geert Uytterhoeven [250130 03:21]: > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote: > > > I've never used the kunit testing of xarray and have used the userspace > > > testing instead, so I can't speak to the obscure invocation as both > > > commands seem insanely long and obscure to me. > > > > The long and obscure command line is a red herring: a simple > > "modprobe test_xarray" is all it takes... > > That command worked before too... Exactly, great! > > > You should look at the userspace testing (that this broke) as it has > > > been really useful in certain scenarios. > > > > BTW, how do I even build tools/testing/radix-tree? > > "make tools/help" doesn't show the radix-tree test. > > "make tools/all" doesn't seem to try to build it. > > Same for "make kselftest-all". > > make Where? > Or look at the make file and stop guessing. Considering how difficult There is no Makefile referencing tools/testing/radix-tree or the radix-tree subdir. That's why I asked... Oh, I am supposed to run make in tools/testing/radix-tree/? What a surprise! Which is a pain when building in a separate output directory, as you cannot just do "make -C tools/testing/radix-tree" there, but have to type the full "make -C tools/testing/radix-tree O=..." (and optionally ARCH=... and CROSS_COMPILE=...; oh wait, these are ignored :-( in the source directory instead... If these tests are not integrated into the normal build system (see also [1]), I am not so surprised the auto-builders don't build them, and breakages are introduced... > it is to get m68k to build, you should probably know how to read a > makefile. Like all other kernel cross-compilation? Usually you don't even have to know where your cross-compiler is living: make ARCH=m68k > > When trying the above, and ignoring failures due to missing packages > > on my host: > > - there are several weird build errors, > > - this doesn't play well with O=, > > - lots of scary warnings when building for 32-bit, > > - ... > > > > At least the kunit tests build (and run[1] ;-) most of the time... > > Do they? How about you break something in xarray and then try to boot > the kunit, or try to boot to load that module. If you break the kernel beyond the point of booting, you can indeed not run any test modules... Which does _not_ mean the userspace tests are not useful, and that I approve breaking the userspace tests... [1] https://lore.kernel.org/all/CAK7LNASdA+5_pdTjr1dY-cKGSDq804Huc_CX_8-Gg+ypFCmajQ@mail.gmail.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds