From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EDFC6FA8E for ; Sun, 5 Mar 2023 10:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD0596B0073; Sun, 5 Mar 2023 05:16:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58C36B0074; Sun, 5 Mar 2023 05:16:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C219F6B0075; Sun, 5 Mar 2023 05:16:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B452D6B0073 for ; Sun, 5 Mar 2023 05:16:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85FB5120938 for ; Sun, 5 Mar 2023 10:16:28 +0000 (UTC) X-FDA: 80534440056.16.4D8A022 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf01.hostedemail.com (Postfix) with ESMTP id A5FA440010 for ; Sun, 5 Mar 2023 10:16:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678011386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5qRGfTs5+kV00emn3Oo5iN+DSAN1HACfQYEpZctxMY=; b=T4YUh2i+xVDZYjflkhM9L3B/SUL6OsQpE1YPoeqezvDCba4azG3VAz6KPEiPjBTKTdKCA+ cgVcJS3KkIEkWa5+F1ID1Zh42V3cHCbawL1mXV1W0C5/aZ2hdFs+lhi+rsqlSEUqB+qxK1 Hup+Olf/hNPV2cNh+858TylU9PX+pIM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678011386; a=rsa-sha256; cv=none; b=dM7sMYgHEKUqjvmZ1XPcE1JNszr5z/TS1f/GJ8xNvIlBwS5dGvsFwilgzmDLZ+Cvbvh9Jo pISARhFdkfNgNGn5GtvQRd9yWxvvi8cQcFtKTO728p3tImPJv0a+HkaL0gT6Grs4jacczQ 80XiyscGB9pnNz7o4CHtr+T0fEmI0a8= Received: by mail-qt1-f173.google.com with SMTP id s12so7586345qtq.11 for ; Sun, 05 Mar 2023 02:16:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678011385; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5qRGfTs5+kV00emn3Oo5iN+DSAN1HACfQYEpZctxMY=; b=hgGDO7LVvIvtdu9Wr6BSixCUu5PJRryuMXCfUYp3gdlOQR2g9EteGMNlPwSsJC1NYb UyIIKaB/d6EwpyVB1O9IlmiJN8YErlTTU11e8u/NuZJLLv38t993ZdKJ7uRNGqDIACUB FPfNJo0fkdYgXCpohS1+3fvmI80QgAhsjni/kAC3BdquHJvxpYhBeqwl2nkjh13yp/Xn gDeC4bwzD1WAT4esmM8UQKcGqK0QzzjyR7ZCxlFd8zOrq9HhWXdkFKhgimyKfBfvbTY2 XkleTlRK0moYx4znflxXKAa1mSdf1wV9e0qyOt028zUfqqWo5X6Lw/gRhBpdakZJh0AV gPAg== X-Gm-Message-State: AO0yUKVJqeiT6/5L8AXf/z/7bpxanELCErzju2KWicXKCkDLlCPexxVG vcXneiRyrAJW+o1r482qOSY4MoStUuBwVQ== X-Google-Smtp-Source: AK7set/Fz0/CAbtbApA88Ll5qzdSJcoDJU8HGRTvDDkVo4ftqrvhFIZ0StffEWsENQ1cK0gppJIVgA== X-Received: by 2002:a05:622a:5cf:b0:3a7:e619:61a with SMTP id d15-20020a05622a05cf00b003a7e619061amr11609040qtb.37.1678011385618; Sun, 05 Mar 2023 02:16:25 -0800 (PST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id s144-20020a374596000000b0073bb4312842sm5237104qka.128.2023.03.05.02.16.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 02:16:25 -0800 (PST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-536b7ffdd34so129698017b3.6 for ; Sun, 05 Mar 2023 02:16:24 -0800 (PST) X-Received: by 2002:a81:b61d:0:b0:52e:f66d:b70f with SMTP id u29-20020a81b61d000000b0052ef66db70fmr4376324ywh.5.1678011384672; Sun, 05 Mar 2023 02:16:24 -0800 (PST) MIME-Version: 1.0 References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-14-willy@infradead.org> In-Reply-To: <20230228213738.272178-14-willy@infradead.org> From: Geert Uytterhoeven Date: Sun, 5 Mar 2023 11:16:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 13/34] m68k: Implement the new page table range API To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A5FA440010 X-Stat-Signature: uh4qekgrg4ipp88fi1fen6pakcoexbz6 X-Rspam-User: X-HE-Tag: 1678011386-813256 X-HE-Meta: U2FsdGVkX1+jgPOCsUpg7JQ//J2BIMylUu0QLbI2LD3mgZ4ktDRURGap8OYrGGz4C624+9eluV2bguu/Z1TUJ+/Zd/PR3kaP7uZeXYReFPpRPJs4wvOyEG2eZaPYl/NCFRmh2hHpG9XSbFY79aCpNLaMu+ca7mtQC9+73408Lp6oCz846TfFFHsRxmkbo8DHPNVACaJQi2J4923wleARad6Yurqgh5Th/wE0fY7Gjqz8pNw2wJTlXaYq3JRs5PANMAjLYNAb6xBHwJwrSf5DxhFVgnrpIh/Icrr3trGK0oIHb+3LizVTqzk0w/8wTG+2cj/HWscVVtzNzzKDfsmo9R8b0M9Gd2owNSxhbHTBhah5pmDHJA/CyRCPH+TKh6H31EDFP/EJGkbBa6JjUlucM3oSauxswFzI80qRswSHJzubLqVZ6ZLag/sHSXRCJXnhvqB5x1S1v9nU/UStWhzUFUYWaD26SWoJF7XVeDuu8zI7hBLkDD+d3Yu/B3sjr5JhXjHDZFZn9VtX7o4HkpixZzaaIMWDmUihUG3HiAM6v+XkIA5DHYiAFNKZx0IkCt4heiHVtjDuWcwAq45QnE8MrUoQE7Hn+Ied52o5bfBeN2sUZMlhBQIYWI+rLyAkkV6zwwJqgJa4ipa1w3xSZJ4Bdf4xkUKWZq4Ukc5uL1NEZ0jD5Ljc2vbYzNz0NfF5MBGRNEjWao1eW9x+4BuXYAfWJsbhIwDMdHIW5F2rfQg4ZZILR//zeLartAa6w0yU2R/9nMyKjGc0F6hY8hNQHBFks0Gr41rIhvu4VTpFsuMv7VXV6UtyBV25+qTv58fwTikN1KvUEW47PMEqi4lFdLclIZH8RWtsKuFpNrpKVjvpx1FzEtFlHRwwoKYMDrm6XaUCoylGxxHPerCffUecwdTa8/3ADWlkDfMCdEAMPuQ4EPcHbyq1WbuRC5TJbEYyDxLiKgdzc84YTxqcR7Iv9q9 S4soNNSs t/rdAs9zQ+IPFQOQg00j5R1MoC80sWwd0xTz8AlXZzbGAH/eEif1FT3j1JX1UjFmdqrGuzLLIIGh0R3gXK/gKvQr+jZCclw7UbecTzdbirpR0ClE6oH6YIW9uyTtxUofXff3ynp4Kx4Wiz5k9TZf7PBjHhRUGRAF3c9X59bbWq2KiQJRcrJ9+FWxld7rvh2ITlYSyWUcTlf+5AoZtpjBlBeZjs8FmJ+J3XFgrCFyCSuoNFAO9WTHfdZNFt8yvU4XKU6ZyX4mI9McOyKX6gV0gFnjTKXzxoBSkDwjCsisKPBQxyEkVnmx3nxwzAwECh8hcm+yMuwI0oMs9u+9vKhLi8BspDC5yc//dAqKcNxt0DQpdqO0oNXelss0ZbkljKtTLGGRbC2d9HEfcfE7CpJNxIVTn7VeM9l8FCMrRlzyb1OVdcm0MP5uMwv2nw1C5mEwjWtrTEWqPVDg1JAAdwo44acUeENdTNTJ9/KHazzUgAo+fQwp6g/kAqteur7Y3EcwumaecKjf7aehFKgMG6NOFG64hHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Willy, On Tue, Feb 28, 2023 at 10:37=E2=80=AFPM Matthew Wilcox (Oracle) wrote: > Add set_ptes(), update_mmu_cache_range(), flush_icache_pages() and > flush_dcache_folio(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/arch/m68k/include/asm/cacheflush_mm.h > +++ b/arch/m68k/include/asm/cacheflush_mm.h > @@ -220,24 +220,28 @@ static inline void flush_cache_page(struct vm_area_= struct *vma, unsigned long vm > > /* Push the page at kernel virtual address and clear the icache */ > /* RZ: use cpush %bc instead of cpush %dc, cinv %ic */ > -static inline void __flush_page_to_ram(void *vaddr) > +static inline void __flush_pages_to_ram(void *vaddr, unsigned int nr) > { > if (CPU_IS_COLDFIRE) { > unsigned long addr, start, end; > addr =3D ((unsigned long) vaddr) & ~(PAGE_SIZE - 1); > start =3D addr & ICACHE_SET_MASK; > - end =3D (addr + PAGE_SIZE - 1) & ICACHE_SET_MASK; > + end =3D (addr + nr * PAGE_SIZE - 1) & ICACHE_SET_MASK; > if (start > end) { > flush_cf_bcache(0, end); > end =3D ICACHE_MAX_ADDR; > } > flush_cf_bcache(start, end); > } else if (CPU_IS_040_OR_060) { > - __asm__ __volatile__("nop\n\t" > - ".chip 68040\n\t" > - "cpushp %%bc,(%0)\n\t" > - ".chip 68k" > - : : "a" (__pa(vaddr))); > + unsigned long paddr =3D __pa(vaddr); > + > + while (nr--) { > + __asm__ __volatile__("nop\n\t" > + ".chip 68040\n\t" > + "cpushp %%bc,(%0)\n\t" > + ".chip 68k" > + : : "a" (paddr + nr * PAGE_S= IZE)); As gcc (9.5.0) keeps on calculating "paddr + nr * PAGE_SIZE" inside the loop (albeit using a shift instead of a multiplication), please use "paddr" here, followed by "paddr +=3D PAGE_SIZE;". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds