From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1D5C6FD1D for ; Thu, 23 Mar 2023 08:36:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B1236B0075; Thu, 23 Mar 2023 04:36:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 461526B0078; Thu, 23 Mar 2023 04:36:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 329326B007B; Thu, 23 Mar 2023 04:36:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 218E66B0075 for ; Thu, 23 Mar 2023 04:36:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFFC912028D for ; Thu, 23 Mar 2023 08:36:55 +0000 (UTC) X-FDA: 80599507590.21.37FDCE4 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 09AE28000B for ; Thu, 23 Mar 2023 08:36:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679560614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLvOHhjGtQPAGxbfhV5i2RzlDMu0DOqPCzbtGbv4UHg=; b=pDpUiMvx83o46xjuUm8EoshRdzf2WNuLwZJDYH3EsnUl2lN/W3iNCPZpPYBivPde3Lwg9e z++xMxSLLG2mt31GZJpmVhufjjclBF+HtloJz9Nng+OF4NTFm16qTgvJcGklAjIpUZmBx9 bfz/GLdqR64kKPHDlWjjuN4wvAyP9+Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679560614; a=rsa-sha256; cv=none; b=n4oxsCSfu6UFXZm+UTXfSNdIocyEhlbUTBjd1WSJ9PQk7/vUi4yLQngXc8m9lJbQf1/VbS kB1LB83E9cT4FlJjdIassBSU8GpMan0jT7CKW9+Mz4juztBt9X7cwN3tRyoPR7nJYTuccd zcqL2nnUBjWUltcMBJqydH2mduKUzCw= Received: by mail-qt1-f172.google.com with SMTP id ga7so6922747qtb.2 for ; Thu, 23 Mar 2023 01:36:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679560613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DLvOHhjGtQPAGxbfhV5i2RzlDMu0DOqPCzbtGbv4UHg=; b=omw9VJH/57+GXZIhpuj/tIbWxRQVxZkOUsBYiOQ0UAE86VFHzqSHOi70Lk6qHUDdPI KQfm0UklzKT3YvMOZTrC2JpCB5681JqEqtMlCT2yCiE0eaAg39tbHPRE0D1qfjttbYF/ PdJK8rvumQ2uVbgNRwKfE5mlRtVzRl1SQvvLkD/g/D9/zogf9aA2yvQ0P+zOM+DSaq7R JNixO1F4CWpUwCEigpGqbk0BQ6fboIPqdvaAgJPFqgJ5IessFXOt7KfMXpJfQt1D4J+g Va0RcWkM5TYrqQeI1h0RXQn+4RPkGn3QIseOoEsoC7L1M1t03NoJ2+Z8aG8n49onIjDN h90Q== X-Gm-Message-State: AO0yUKVLzwrihc2NS7PT9PtV9knzHMnfZ0SM9mFJsTlf8vQjss1cUe1U i59VLo+zhDg/w76MU9Nq1xnJ2Mu3GV+GIQ== X-Google-Smtp-Source: AK7set8DajV/SXIxwFNFfRnXGhGOvDhASsMB8xpqC6xF9+pdpep8zNnmNpiiVWNak+CwGJrfuXGXkA== X-Received: by 2002:ac8:588c:0:b0:3e3:86d0:4ef8 with SMTP id t12-20020ac8588c000000b003e386d04ef8mr8159472qta.28.1679560613011; Thu, 23 Mar 2023 01:36:53 -0700 (PDT) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com. [209.85.219.172]) by smtp.gmail.com with ESMTPSA id i7-20020a378607000000b007422eee8058sm13020672qkd.125.2023.03.23.01.36.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 01:36:52 -0700 (PDT) Received: by mail-yb1-f172.google.com with SMTP id p203so23839339ybb.13 for ; Thu, 23 Mar 2023 01:36:51 -0700 (PDT) X-Received: by 2002:a25:6b0e:0:b0:a27:3ecc:ffe7 with SMTP id g14-20020a256b0e000000b00a273eccffe7mr1426444ybc.3.1679560611303; Thu, 23 Mar 2023 01:36:51 -0700 (PDT) MIME-Version: 1.0 References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> <6320abf6-0898-361b-d5f6-bcc58306f55c@intel.com> <4cd6f0c8d7603254df9e2eb1e7b80973e75c4e45.camel@physik.fu-berlin.de> In-Reply-To: <4cd6f0c8d7603254df9e2eb1e7b80973e75c4e45.camel@physik.fu-berlin.de> From: Geert Uytterhoeven Date: Thu, 23 Mar 2023 09:36:39 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP To: John Paul Adrian Glaubitz Cc: Matthew Wilcox , Dave Hansen , Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 09AE28000B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tqq8qejwanxuw4qm5r8uyjqnbeubfzwf X-HE-Tag: 1679560613-815596 X-HE-Meta: U2FsdGVkX1/YHkQ7WzFZP3VSvvVSuoDGK2H9l+nCR8AJKH/Jhhou6iuDyp1CKkn2tZk4Nrn90zZh01NINSKNk/afF6JK4+zAXYI0UYtdMHnt4itTc4DBBYWOzyI3diTs6vz538m868SPJt/G7OPBht80Mq00bPNqahvy8WlC95IruDWNCgEPc2kkoOkKhPefjgTEV2209PFebJ8pzB9BRy/XVSLsZtaF64X8/j3Avc32PEx1vETIDgVeMw7dV9OV2w8Iv+QrViv8tFVYyRKUzn2JNiXwyTQ0xHkzjAVaeB38HopaNNnz2wzhXBmjMm0Ys3Nx7iwaATctJ0sIn1uVPkcTm0Dusjb7v8gkj92P9eli1IO1yoDESDWtD4umLPkJjeH0xDaHH5C/m4p25M/okbdLEW7RdU86pVOJdZUQ7NG6sqHsk1aBVOfpasng1lnqFs/VCjjqwufk+px9vdq4iQqSv7XFGrI1avap1C/Enjo01rSxGb7QkaVr/rP1ToZQ3QewZQufzG+oXXOeLfstIVC1CjVxSx93Xm96ZzkTQY/tMB5X0rx5yr5MLrPUdEAVhypLfnpUA/yDk57kno1TFRjmpvVg/x1NSkjMR4byGHgmtqA4vgo7fE/NVlbo+ErmC3wovnSQVUSgOyTuRwb6rO0r1qPQRceijUFRzeweKevzuBFoRq/ReetmiYkdleH+IDJSuevwjHcHhFmFtsXaPFOILF//3ek70ZoP2nc7pHzxvYMxLlTUvj1oPp2JAzlLlJLxAg0N4BB9Nwnw3DQG+8InWb/F+RSCwoQN5zi/7n75Z0y0d7W/IdkurMoOQmpQBVGY4bG+oCQtherUPd6KILmFS1TODOi4szTpS5AxRDIoKtQr9dZRxLNh4lezSI5YXj3lJoS8HRkuoNeMabEqWn/N5dRGBuIUFYJZA2Jh5JrOHl20sTyU+qYKhJdpaTaCjoEnjQf9X6xQCmT7Q3U 7l6iWH9Y LSPEDzNizCQgb0N+zxHO0OF+ZN0h3cKFjq+6mEJJSgapLAzovxC7U7EgPR3qxAc544UC5xaIWatCynJm0KrOQoHAaY6KA1eOc4if4ZcM3/TNI1LKUO9GN7dl8e0E0+KIHJzkXVp87DRxSt2fa+o3qalU6GANwOyCHjqtRy/j0F+ryPFmD4fKtuhOX9VkH5aNnJ4hWqOo9HrAO5vb5r7x4dIEvArgSDszjCmi8Ql0Z4xqbC02Vl0Z2ZA6IlF24ubZHM6hqOUzW8UubSeQzz5iiPjSwjsSYeQvYcGK0jDpm14PaHvxs6jkZcB5Lc4Y9u+yZsRdMTurLzJG7bcIYvCuVMtyF7m48fTw1uJdWGIlWrQUdIJOWGP5T4Pbgho3r05zLIFyTI5ePk5u9un7eLMDagbzl+j559bu0JH4fOsk1MYBBghoqvfj3GSA0FOKTuRgrcs6UfPBHeG4br3AaGJIajedQ279j7G+LG0fgnyzINtoSNK8xWqldrC2AnNhhJYI0w253X/9xM6tcRWCxm35EfalUViIJMRx4uA7ShuLl+FVf8KxbB1BvaLHU1gGE/cOoazSlfEoSKv9SanJZoOxDXHMpp3zbLQBAfKIMc8mc0qhdh3docJU4WqqYSqBNoiV6wGZLelm+g/TDjOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Adrian, On Thu, Mar 23, 2023 at 9:28=E2=80=AFAM John Paul Adrian Glaubitz wrote: > On Thu, 2023-03-23 at 09:25 +0100, Geert Uytterhoeven wrote: > > It's supported. Dave just forgot to update the #ifdef around the > > definition of init_cache_node_node() when updating an #ifdef around > > a code block that contains one of the callers. > > > > P.S. To me, this discussion reminds me of the old discussion about > > discontigmem without NUMA. Yes, not all systems are PCs with > > contiguous memory on a single fast bus ;-) > > I'm wondering: Could the NUMA code be used to work with the different > memory types found on the Amiga, i.e. chip RAM, fast RAM etc? I guess so, but only for 32-bit motherboard RAM on A3000/A4000 vs. RAM on an accelerator card vs. Zorro-III RAM on e.g. BigRamPlus. Chip RAM and Zorro-II RAM do not support RMW-cycles on Zorro-III capable machines. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds