linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Clement Courbet <courbet@google.com>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'?
Date: Wed, 6 Dec 2017 09:42:07 +0100	[thread overview]
Message-ID: <CAMuHMdW4W5T_KX-bm4zD=yOOnHBRn9BiTNg3DN=+izjknVo4uQ@mail.gmail.com> (raw)
In-Reply-To: <20171205160928.8eef0f54c63cb05d67c5c7b9@linux-foundation.org>

Hi Andrew,

On Wed, Dec 6, 2017 at 1:09 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 5 Dec 2017 20:31:28 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   7ceb97a071e80f1b5e4cd5a36de135612a836388
>> commit: e49c614e6b37254b1e7bf55c631ce3cb5e3b6433 [2148/2944] lib: optimize cpumask_next_and()
>> config: m68k-allmodconfig (attached as .config)
>> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout e49c614e6b37254b1e7bf55c631ce3cb5e3b6433
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=m68k
>>
>> All errors (new ones prefixed by >>):
>>
>>    lib/find_bit_benchmark.c: In function 'test_find_next_and_bit':
>> >> lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? [-Werror=implicit-function-declaration]
>>       i = find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
>>           ^~~~~~~~~~~~~~~~~
>>           find_next_bit
>>    cc1: some warnings being treated as errors
>
> For some reason m68k doesn't include asm-generic/bitops/find.h from
> arch/m68k/include/asm/bitops.h.  One for Clement and Geert to puzzle
> out, please.

Oh it does, but only for the CONFIG_CPU_HAS_NO_BITFIELDS=y case.
Which used to be fine, as the code for CONFIG_CPU_HAS_NO_BITFIELDS=n
implemented everything in find.h, until find_next_and_bit() was added.

Thanks, will fix...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2017-12-06  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 12:31 kbuild test robot
2017-12-06  0:09 ` Andrew Morton
2017-12-06  8:42   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdW4W5T_KX-bm4zD=yOOnHBRn9BiTNg3DN=+izjknVo4uQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=courbet@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox