From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DACC3DA6E for ; Wed, 20 Dec 2023 12:00:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A56016B007E; Wed, 20 Dec 2023 07:00:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A06206B0080; Wed, 20 Dec 2023 07:00:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A66D6B0081; Wed, 20 Dec 2023 07:00:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 74D976B007E for ; Wed, 20 Dec 2023 07:00:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 395D6120BB7 for ; Wed, 20 Dec 2023 12:00:03 +0000 (UTC) X-FDA: 81587053086.23.3B8264A Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 4244E40013 for ; Wed, 20 Dec 2023 12:00:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703073601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yNnwzy6tQcqeaUcHOAS+iDzjbl/FPbSmBUr6dHQRpC8=; b=IFhStOe/kzXrnjSRgq2Wayc0cavpAoFNCu1yYTW9t11iBVdUQVbojXtE2gk3Hxqs0vJFCu bMQSIMlqItLnq+G4/W/yuLtfiTls7+/BTKlwYoJMR3SziR7s7n8PYYIfGH7wFsanWm3WrL SLsQEdjue+DqRTGEFK+SD1lJCnwOz4I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703073601; a=rsa-sha256; cv=none; b=rC5wnvfTAfh+OjIdjIJ2Ipmodt6kgOJcLeWgbO7LScnJSjO8GGGDeSh9fUtRBX9I/uhoYA RpZ2z7HGFWN+w0ivDymoKvRDhBRsvuznqVkJ9nFLS77zkoFC2fCirhWAcOQ+XFeGX3NCFM hOgDSBCITCYcZbt4jCoIUfK8RXkIr+I= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5e745891a69so22454917b3.2 for ; Wed, 20 Dec 2023 04:00:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703073600; x=1703678400; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yNnwzy6tQcqeaUcHOAS+iDzjbl/FPbSmBUr6dHQRpC8=; b=ieQWj1Kex4kOoLOsHfa4O49JXGsHh5fqegNR9sRAo30774nwsvasI8yhS12pMTZghf 4m+VLdlE+PfjQB+xYvN1cww7Zg1bAM8D9OVBXtE23qzCytjcWNfuHABHgx5a4vgWGhzS Q6XByjSqVKYGBf4m3SA7lqSUvJELgyF7c1IcOFizanE6dRUOoTV6oOJ5sunb1Y0/yeHb g0etO2v1H1/AtplsDQkfk+ODGKB840/kAu7f1Qa6J+iGbp1YSbn+fZ2oowLdCIUhiHKe R2IYhz+EiA/ptNqhbEE/99h8vYezDX4PN8JFhixOm1YKP6NL88OkCer3YFqwoQcSJJGI Kbag== X-Gm-Message-State: AOJu0YxtJYJfhQ7YasJgrdlVjls39NJ23KZDZa1hT6RxZs9fAJoSWkgz ekMCNapgKUe0rfwsb5YmFGW51Zb65w78dg== X-Google-Smtp-Source: AGHT+IGF5h3Phea6ZkUC8aaSQaPAf+BOttu7zPn47ZZ7KazZWVvKRy59/xgPE0BGXAlHgy2h9oMSQg== X-Received: by 2002:a81:840f:0:b0:5e8:7efe:2368 with SMTP id u15-20020a81840f000000b005e87efe2368mr564923ywf.86.1703073600115; Wed, 20 Dec 2023 04:00:00 -0800 (PST) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id ey9-20020a05690c300900b005e7b1884183sm1339551ywb.21.2023.12.20.03.59.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 03:59:59 -0800 (PST) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5e7d306ee27so13611877b3.3 for ; Wed, 20 Dec 2023 03:59:59 -0800 (PST) X-Received: by 2002:a0d:d845:0:b0:5e7:f47d:7f94 with SMTP id a66-20020a0dd845000000b005e7f47d7f94mr1778813ywe.9.1703073598971; Wed, 20 Dec 2023 03:59:58 -0800 (PST) MIME-Version: 1.0 References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-7-kent.overstreet@linux.dev> In-Reply-To: <20231216033552.3553579-7-kent.overstreet@linux.dev> From: Geert Uytterhoeven Date: Wed, 20 Dec 2023 12:59:44 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 50/50] Kill sched.h dependency on rcupdate.h To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: n4s3wq5ngfuwum9zubat46y3fb8qkmk6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4244E40013 X-HE-Tag: 1703073601-230286 X-HE-Meta: U2FsdGVkX195FFz/CfCX2lHPV9oK0cDrlawVR4cIpcapxnepW3uCUFhZRlOmZ78l1GEiOqAvM9w3CbJVodjlA9fEbReT6q6k3iT8karZGR9h67EEZwXpa7C4J+/tcRzdtH2WcfS6yjqxygngGlVJdBUhR4UhojwJP2iRA89GAiQE02Of40QV8qDg/a4jJjdtwvBJ5wIAZTXfl3zHfeHJZHFPO/+W1fhhrAhjhAjafJD/OqV2WPUhPfv4wH3FzKg300k82eRvHyj7idCntKKFW6XcIypbJlqUh91XZUZTE0osut52N1hLR0XD33iA+vzOd7aRgLAcXuopYJ8ZH2YOd0MFUU+wf5fiMZovpQ9xSMsIk8s3M3skN6/O5SL7WwHsg0IC0EwqoN5wvrdKr8k1Ip5DIlNcJzmpSnk5i0qGu6Z0F7z3ZbkpLeaD8DgaDzRXrkSm1VUCQ3DsZ/nIAR3/NAaN0X/sTuHX6vUQ86DrjUbp+bxfF+EyWbvQLTBXpZcuHEw7L68m+aBYXQkel6H53LQL/RohMXLI39OfJ2zv8qh4GWiLi4GUje1vdCAnooOdN1GiqkBbzeMJGnHKzhK7GDM0okisSj4uYdK42KKbTOLNl/fgNMgupiJoHBCcYIa40FrRn5OjuYIhrlpAwdEgjly2tEFoQksYSWrAtKSD9Dls8gHZ3o3ZhfEG7fgPZ+k3jax6+p0mnv/rrQ29M/OSHR5S1qLGArgUbhIcfI7pjzET1YN7vMWHBWEbA7VkPMqPu7JEYkXuGRm7r3nAWayLD8Jb4R5wz1GFDE6aDcDD1iwt7vmr8HTJT2ngfVyo0zqqrTVEXNRJ96HdG4zzlSYAhEYYt4meytn5Cu7qp7DesKTePLW+b7GfM5y+K4kfTakXOfOVcSIFqeYSwyn4EFoEkPMjhCVwiAnVHb/7Pz02ycfmqymfLmLM4Gu0Ua4GeIYJJMeJWRDptqGWNwzdUBH jTAuKeiH +NXhsus3d3IDsamKpUF0tYX9ZwQCJtGTxrOKn6QM88dWINBNhDCSPjLQR9J8IGL221nUccot9sNuCn/KFpwP5gK21wfKIXWClN/nF00Ca5qzLVX6xh8T49GaNqvaOEVjXEbUTjcBXXFS5BWQ3r+X2IkTfFZ8d2FdUMxifSjpIsQ6MZQ3jwc3EFw8gcNXRy4ZJ2OWCEXjey4Z+xoRttCuCPuZfhsA3YaXlLIewxFThFyh0HG9Pz+/YL4Amu0mvrM9CiIHeOBGl9JGq2HajzQlK/Djt2LmKf3HfqMfkZu2DQ5rtpDwIY0vkohCZI2i7UKGJgc2q+KbICKTk+T70vI6HnEe6F1ASYJ2srgb++QGa5rRIgj+Q4YdtmsuZATNPevmibzJFbYqUW7HNUWShdqhVKptccEvqkQqj50Y62WMEhz3BupyDHlhcjrlK+eXhaRN9e3+DOUHR04A8qLwwnvrWAROxN1NVe85TQbGFzVDfUbpJZZWVydz5bUtqNvk9SqwZRtF3fFHGfZ44GzdS25a1SZnZW0umCfx7eSns X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On Sat, Dec 16, 2023 at 4:39=E2=80=AFAM Kent Overstreet wrote: > by moving cond_resched_rcu() to rcupdate.h, we can kill another big > sched.h dependency. > > Signed-off-by: Kent Overstreet Thanks for your patch, which is now commit dc00f26faea81dc0 ("Kill sched.h dependency on rcupdate.h") in next-20231220. Reported-by: noreply@ellerman.id.au $ make ARCH=3Dm68k defconfig arch/m68k/kernel/asm-offsets.i *** Default configuration is based on 'multi_defconfig' # # No change to .config # UPD include/config/kernel.release UPD include/generated/utsrelease.h CC arch/m68k/kernel/asm-offsets.s In file included from ./include/asm-generic/bug.h:7, from ./arch/m68k/include/asm/bug.h:32, from ./include/linux/bug.h:5, from ./include/linux/thread_info.h:13, from ./arch/m68k/include/asm/processor.h:11, from ./include/linux/sched.h:13, from arch/m68k/kernel/asm-offsets.c:15: ./arch/m68k/include/asm/processor.h: In function =E2=80=98set_fc=E2=80=99: ./arch/m68k/include/asm/processor.h:91:15: error: implicit declaration of function =E2=80=98in_interrupt=E2=80=99 [-Werror=3Dimplicit-function-dec= laration] 91 | WARN_ON_ONCE(in_interrupt()); | ^~~~~~~~~~~~ ./include/linux/once_lite.h:28:27: note: in definition of macro =E2=80=98DO_ONCE_LITE_IF=E2=80=99 28 | bool __ret_do_once =3D !!(condition); \ | ^~~~~~~~~ ./arch/m68k/include/asm/processor.h:91:2: note: in expansion of macro =E2=80=98WARN_ON_ONCE=E2=80=99 91 | WARN_ON_ONCE(in_interrupt()); | ^~~~~~~~~~~~ cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:116: arch/m68k/kernel/asm-offsets.s] Error 1 make[2]: *** [Makefile:1191: prepare0] Error 2 make[1]: *** [Makefile:350: __build_one_by_one] Error 2 make: *** [Makefile:234: __sub-make] Error 2 > --- a/include/linux/rcupdate.h > +++ b/include/linux/rcupdate.h > @@ -1058,4 +1058,15 @@ extern int rcu_normal; > > DEFINE_LOCK_GUARD_0(rcu, rcu_read_lock(), rcu_read_unlock()) > > +#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU) > +#define cond_resched_rcu() \ > +do { \ > + rcu_read_unlock(); \ > + cond_resched(); \ > + rcu_read_lock(); \ > +} while (0) > +#else > +#define cond_resched_rcu() > +#endif > + > #endif /* __LINUX_RCUPDATE_H */ > diff --git a/include/linux/sched.h b/include/linux/sched.h > index d528057c99e4..b781ac7e0a02 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -10,8 +10,11 @@ > #include > > #include > +#include > +#include > > #include > +#include > #include > #include > #include > @@ -22,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -2058,15 +2060,6 @@ extern int __cond_resched_rwlock_write(rwlock_t *l= ock); > __cond_resched_rwlock_write(lock); = \ > }) > > -static inline void cond_resched_rcu(void) > -{ > -#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU) > - rcu_read_unlock(); > - cond_resched(); > - rcu_read_lock(); > -#endif > -} > - > #ifdef CONFIG_PREEMPT_DYNAMIC > > extern bool preempt_model_none(void); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds