From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C9BC47255 for ; Mon, 11 May 2020 15:24:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 400EC207FF for ; Mon, 11 May 2020 15:24:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 400EC207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B0AA90005D; Mon, 11 May 2020 11:24:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96199900036; Mon, 11 May 2020 11:24:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8785590005D; Mon, 11 May 2020 11:24:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 717D1900036 for ; Mon, 11 May 2020 11:24:43 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 37A6945B4 for ; Mon, 11 May 2020 15:24:43 +0000 (UTC) X-FDA: 76804810446.29.fruit54_635dc93898555 X-HE-Tag: fruit54_635dc93898555 X-Filterd-Recvd-Size: 4602 Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 15:24:42 +0000 (UTC) Received: by mail-oo1-f67.google.com with SMTP id z6so1107245ooz.3 for ; Mon, 11 May 2020 08:24:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cFOqYFe+JnxanB4tWXMEfN+/EOvlslN0N0IK+ztKBU4=; b=McOnAcSyCTJKBBJB+WKneQuD5VMtTQ2Z0DpZLXj3eBBm2/tBk0ilJwdR5Z7Mero5Vo gPUd3jcObOaCd3pJU8G2D5RAKKqSR3x/E3VwU+X6+w9jSSWV1rqIEqQpaefEzZEqGh4h thHlaU51fMkzI/bp+g9fFDGYBjxDxwpTIOlsLcqJN7zBgj+FkkBlECMI454vGMJyRJ7I iuaUjp2GlEv5T/jdm8UhjnmiFSupubWFRBNJFOWGYsXSccS3FAo04HEl6xR4YbPQoGdn yviEaPShUEi//SFNPqHJoP+Ba904vE95nN8FjQv7mNYiKKg6/6GGsW2FBsU6h6KdhlOG R56g== X-Gm-Message-State: AGi0PuY+/rCrKeKdouFxt93tvqUqHegyTrp0yBbNVIN4wSklqA9o/kv7 UbQpL0M386Bu2rc5904N3SqE5neaXa3eK+fcKGM= X-Google-Smtp-Source: APiQypJasCN4yl8lWM1FRmzaz39ukL/iWbljLpcbY1TKIvOnIUfi1IKvTWCvzobh4HXgocJWo6GBkm5ORmsQ5s6pFSU= X-Received: by 2002:a4a:d204:: with SMTP id c4mr2380562oos.1.1589210682093; Mon, 11 May 2020 08:24:42 -0700 (PDT) MIME-Version: 1.0 References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-32-hch@lst.de> <20200511151120.GA28634@lst.de> In-Reply-To: <20200511151120.GA28634@lst.de> From: Geert Uytterhoeven Date: Mon, 11 May 2020 17:24:30 +0200 Message-ID: Subject: Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k To: Christoph Hellwig Cc: Andrew Morton , Arnd Bergmann , Roman Zippel , Jessica Yu , Michal Simek , "the arch/x86 maintainers" , alpha , Linux Kernel Mailing List , Linux ARM , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , sparclinux , Linux-Arch , Linux MM , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux FS Devel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On Mon, May 11, 2020 at 5:11 PM Christoph Hellwig wrote: > On Mon, May 11, 2020 at 09:40:39AM +0200, Geert Uytterhoeven wrote: > > On Sun, May 10, 2020 at 9:57 AM Christoph Hellwig wrote: > > > > > > flush_icache_range generally operates on kernel addresses, but for some > > > reason m68k needed a set_fs override. Move that into the m68k code > > > insted of keeping it in the module loader. > > > > > > Signed-off-by: Christoph Hellwig > > > > Reviewed-by: Geert Uytterhoeven > > Acked-by: Geert Uytterhoeven > > Btw, do you know what part of flush_icache_range relied on set_fs? > Do any of the m68k maintainers have an idea how to handle that in > a nicer way when we can split the implementations? arch/m68k/mm/cache.c:virt_to_phys_slow() All instructions that look up addresses in the page tables look at the source/destination function codes (SFC/DFC) to know if they have to use the supervisor or user page tables. So the actual implementation is the same: set_fs() merely configures SFC/DFC, to select the address space to use. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds