From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3F1C5321E for ; Mon, 26 Aug 2024 14:01:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CCD76B0085; Mon, 26 Aug 2024 10:01:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AB5C6B0088; Mon, 26 Aug 2024 10:01:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6921B6B0089; Mon, 26 Aug 2024 10:01:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 488D76B0085 for ; Mon, 26 Aug 2024 10:01:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ED97BC1174 for ; Mon, 26 Aug 2024 14:01:28 +0000 (UTC) X-FDA: 82494559056.24.7D1150E Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B79540032 for ; Mon, 26 Aug 2024 14:01:25 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724680771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3+6+zszjG25uKB5YsPuXSVnLU6Olwn6W73A2LlZ3Hg=; b=F0+huodYFqqqHjYzhh2hWsmtrZmDN7s2aRFD3pww/sz2ErNTcTjp9XpKmNh+hxfNdQkcUz fAa3EsRCfjJyxxPnyCmOQkowa+vjdDvHJk0LAtE59qiEWqSSC7kprDxYjXNJOlEmt6td7O 29YjyKJxVhkDtq+5Cp94I1W/ZpYlKY8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724680771; a=rsa-sha256; cv=none; b=LbMsNB3uv6/lhAizgp5K9cWj2lZKnQzJmnIzgtRoqaIL+vO4bnUoLh1GE/rw6g4bLILDhy V21wcyWuz1UmSdqhsI+2bTozM0JBZuDAhOF/OrHbLHALBamEksOHBpGEuWOYfxmua+B0+9 fJKnDL1n1XNG9dmNGJOuU+bzUz6jkms= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6c0adbbf2eeso35203717b3.0 for ; Mon, 26 Aug 2024 07:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724680884; x=1725285684; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e3+6+zszjG25uKB5YsPuXSVnLU6Olwn6W73A2LlZ3Hg=; b=YqKuayn5vhOzsbmVIZxbydr6th0cK69K6HZ1ZB0yA2FpNfwrllFpWlpye5BwU6Fk9p 6Unh/Llu/6gfue6X8TBCXYo9PUwWv0rWLH1wG8CAJ9DCDl1Vf159mWiWUuOQMmqgzDpA f5wnGhwAT2mETGpSQVgs3iQLshxkGWgKoF+lO712BfREywq7rPnZjgcdiHpoCfJvuK/t oQOw8eedxrjwB+domeaUIC/DX8JgMCI/KsnWK2bsIR5rEm/YAxop7tWx3ny0FQdaouNs WgwSbhCkdMLyFMd0yMRkLVkadJArdgYl6iLyytTrSn80s3TLgmKN57Y7wGm3/bhURFZJ fM4Q== X-Forwarded-Encrypted: i=1; AJvYcCWWNdiNx1cTqlHHNlhiSlS7pqeRJb+cBShpi0c0sE/8PAZTGO5EVlKMhab+qLGvNEv9w4eUoJvCNw==@kvack.org X-Gm-Message-State: AOJu0YzmCWcvft/YrJeebbRL24dZdLYtf0I1Pj/QELnHQzPxFsuUJ7ME FVl/B5NdgHYIalUhFpab/C0OnMwYr77RO99UKhlyYe+mTnaXo6IeYvOhq1zP X-Google-Smtp-Source: AGHT+IH1ZxdMGTcFn9BwlVt7JuWup+5OJQjGOmIfAfMMIitgfFon2GgyoelzbPZL1dpWH3cOnAZDbA== X-Received: by 2002:a05:690c:d0e:b0:6b1:598e:8cf6 with SMTP id 00721157ae682-6c625c3b60emr124282687b3.22.1724680883577; Mon, 26 Aug 2024 07:01:23 -0700 (PDT) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com. [209.85.128.182]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6c39a7530b4sm15351877b3.38.2024.08.26.07.01.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 07:01:23 -0700 (PDT) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6b6b9867faaso38869137b3.2 for ; Mon, 26 Aug 2024 07:01:22 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWZktlcNZBvJY59rG8iAzfJyjp5qaS3ZTihl+H5UFuHF7uiJIeqs7xLA6xgoemra2+0/bVLSkjZvg==@kvack.org X-Received: by 2002:a05:690c:f8c:b0:61a:e4ef:51d with SMTP id 00721157ae682-6c6246037a6mr144593157b3.9.1724680882369; Mon, 26 Aug 2024 07:01:22 -0700 (PDT) MIME-Version: 1.0 References: <20240822192543.3359552-1-Liam.Howlett@oracle.com> <20240822192543.3359552-13-Liam.Howlett@oracle.com> In-Reply-To: <20240822192543.3359552-13-Liam.Howlett@oracle.com> From: Geert Uytterhoeven Date: Mon, 26 Aug 2024 16:01:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 12/21] mm/vma: Track start and end for munmap in vma_munmap_struct To: "Liam R. Howlett" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Lorenzo Stoakes , Matthew Wilcox , Vlastimil Babka , sidhartha.kumar@oracle.com, Bert Karwatzki , Jiri Olsa , Kees Cook , "Paul E . McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5B79540032 X-Stat-Signature: nbfa9y7tg3j3tb4hk119jd7yp9ktag8a X-Rspam-User: X-HE-Tag: 1724680885-59081 X-HE-Meta: U2FsdGVkX1+1KkaF+Nw4A7Fm++kjcPWD0pcx905pU+wrsDDlb74tlG88aSTLoAbmXZMrK5TRTEpac+Bnl3aOvA4qRX0DQU/31BUFHXx+WlzZDeG/C1jOWGITQEJ2eUC7eT/nzfXxP+mPgweaXbEi60tcSieCyratFt20V+a3n7igqQ6T0YYDryYdudEZoQD5ar/gQcxzmxUNhwN9oE4+6rUKDjqUziF0xZJvx8oS1b4Py23q/gNBw+bzHbwVYiJwvHVgGJpPb0takTBSPB8oVH+fpjs4cmAGuk5bzjDbvRE1alsdcm2DibC2nmTI0UgXuwsxqwSrq0gcatWm46C+vcHEk9WY1x4GQjgzuMlglPpEff9QD///N41VkYUB2h71YxxEhXHbBAVVBI8sQiQXCOPxXQ0TXaNKgxeRvwhtl9rzDPqIYeFFyfBfVP5Jw1fwBmeKiDa78J11bQoUyWMBkRw1ZHXkWyfwGiBXd5ah2pSXOfsGLglIiZFIwdzagI+tmn64DTolq6Wh+9+2EBg++hqW6T6QjIZNMLimxouQMUWQKRMIyfZvM24SHC+9u9ukl/lsH6WotXcU0g8pyWXmHaOqwOMntZ05sJunfuLQTDv/PinMpIHBRfQ4lW45JvhvBocRoQOmhiLqdH7uUebbdNJDVIC0+ZN4jvjdg/Z7ZEmqiIOaL+RoiRKmR5aisKTy+GfxeEOY5vLxpuoJjtKL7WbrMssg4CyJqNmtAhOY1rXY6qQf+TsT1ZhkqjAX04jasvhUgm+GkYFjPyGj2hFcPrzzGrc0WObZMxfM9iDGpRZQdTyV4BoQhSJpTFPtG2K5F9mV3kDoHFp2GM9//XoOJGQ7r+Mc2Z2xsBztuGZmRheF9gNoXMdbQtku0AilZkC2pi1+bqX1hTsYKCuMFBFgsd5saMZwRz96KAtrRcw3aOrtyYwtfeozg/JjlNBMSYvz+u0gpyzpUUMWbuCJmV/ rntBQNiy fkZwStqD1Aw6Q4lxiqTXd91O3jbnXNKBFMGhf75SYuJh4XNBMlOExXkRCaJ99vL4Zn/7zp0BGjWQ8oVgNkUIwEhxZsQpqlcW0iIxt875EMdHDRe4AvUwDhVbBQ/tOGVwyPAycga+PIVYslI7tH3i3tYyk7NbgIj51JFZAImP1E4MqHQpGP18uz9fcsT6qgsNOGPj98b7Ss5vGzVwYGg1vsXxcLflZo+ZHcTrNPmsS11WssXlQNu55HLrzAHLi2Wn0jYDOg/lO6Jv/jM0dAp+R096oBW4UUDO/4be894oOUFr0g89i4jdxSNd/XWaOOeP5lmxX98lHvRpB/9FfxXHWCizirE4s3EqRBEp26A9i2Fna1N6ohCEMBefv2oddOwtkBI5CMv31M3Ksh+tP25I3KkavCOFQXvuJSsmTWOBCaVMktkuqlmfnsgCS+Mline/k0dYX5kLCuaKI8xGXKu2GUaZ6HAiyZut3f8bIeaFxXK+wGrm/U1ixXKShb/JPivo38kRsIURYHEKXgQVDv5kJbma00A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam, On Thu, Aug 22, 2024 at 9:27=E2=80=AFPM Liam R. Howlett wrote: > From: "Liam R. Howlett" > > Set the start and end address for munmap when the prev and next are > gathered. This is needed to avoid incorrect addresses being used during > the vms_complete_munmap_vmas() function if the prev/next vma are > expanded. > > Add a new helper vms_complete_pte_clear(), which is needed later and > will avoid growing the argument list to unmap_region() beyond the 9 it > already has. > > Signed-off-by: Liam R. Howlett > Reviewed-by: Lorenzo Stoakes Thanks for your patch, which is now commit ca39aca8db2d78ff ("mm/vma: track start and end for munmap in vma_munmap_struct") in next-20240826. > --- a/mm/vma.h > +++ b/mm/vma.h > @@ -38,6 +38,8 @@ struct vma_munmap_struct { > struct list_head *uf; /* Userfaultfd list_head */ > unsigned long start; /* Aligned start addr (inclusive)= */ > unsigned long end; /* Aligned end addr (exclusive) *= / > + unsigned long unmap_start; /* Unmap PTE start */ > + unsigned long unmap_end; /* Unmap PTE end */ > int vma_count; /* Number of vmas that will be re= moved */ > unsigned long nr_pages; /* Number of pages being removed = */ > unsigned long locked_vm; /* Number of locked pages */ > @@ -108,6 +110,8 @@ static inline void init_vma_munmap(struct vma_munmap_= struct *vms, > vms->vma_count =3D 0; > vms->nr_pages =3D vms->locked_vm =3D vms->nr_accounted =3D 0; > vms->exec_vm =3D vms->stack_vm =3D vms->data_vm =3D 0; > + vms->unmap_start =3D FIRST_USER_ADDRESS; > + vms->unmap_end =3D USER_PGTABLES_CEILING; noreply@ellerman.id.au reported build failures for m5272c3_defconfig http://kisskb.ellerman.id.au/kisskb/buildresult/15224802/ $ make ARCH=3Dm68k m5272c3_defconfig mm/filemap.o In file included from mm/internal.h:22, from mm/filemap.c:52: mm/vma.h: In function =E2=80=98init_vma_munmap=E2=80=99: mm/vma.h:113:21: error: =E2=80=98FIRST_USER_ADDRESS=E2=80=99 undeclared (fi= rst use in this function) 113 | vms->unmap_start =3D FIRST_USER_ADDRESS; | ^~~~~~~~~~~~~~~~~~ mm/vma.h:113:21: note: each undeclared identifier is reported only once for each function it appears in mm/vma.h:114:19: error: =E2=80=98USER_PGTABLES_CEILING=E2=80=99 undeclared = (first use in this function) 114 | vms->unmap_end =3D USER_PGTABLES_CEILING; | ^~~~~~~~~~~~~~~~~~~~~ Both are defined in include/linux/pgtable.h inside #ifdef CONFIG_MMU, so they are not available on nommu. > } > > int vms_gather_munmap_vmas(struct vma_munmap_struct *vms, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds