From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F460C4332F for ; Mon, 13 Nov 2023 09:46:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F029E6B019B; Mon, 13 Nov 2023 04:46:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8C176B019C; Mon, 13 Nov 2023 04:46:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2BA66B01A1; Mon, 13 Nov 2023 04:46:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C09456B019B for ; Mon, 13 Nov 2023 04:46:43 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9835AA02F7 for ; Mon, 13 Nov 2023 09:46:43 +0000 (UTC) X-FDA: 81452451486.24.050AE7C Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 3D09B160002 for ; Mon, 13 Nov 2023 09:46:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699868800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hwzQbtIpe+t3wqED8YWdB5pI957h93jq9NhhCumia7w=; b=nDubESu1Q10qvC05ffFI5bRtEjDwktlRSShgS8ttnAyu5TkjIvqiwSOebp/HrlK5OGMpCi HoQL2xIDzS3mCwXlKHmG5eElVPxTIQ/+Pn/WgVvbZUjIXddraD+CCGaHOpcxighBilBDIT ME/kyEvOZySkmMYVNpG9HAGmmqZS568= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699868800; a=rsa-sha256; cv=none; b=gG1V/iw1urD77OKidx42oeLQ6/gSPJJ/zH4Hxt9Rnuwdh2qFq1hRESWhlWkLlDoxj2nTqc mSImjjtTd1zVRoN0t/EiVmViDiSVPaTgzCe3tuW7NUzLefCg8t+RkOKTpBHbZrLH4R+2y5 czvWJsT6kGG7+DmHUHwXw08VqZ/K8sg= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5afabb23900so49420567b3.2 for ; Mon, 13 Nov 2023 01:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699868799; x=1700473599; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hwzQbtIpe+t3wqED8YWdB5pI957h93jq9NhhCumia7w=; b=UGq+ozSATQ4VVDdwdwREvKzLkkKQRsd6ZuHVPlzGIrTBf6AEHb7BVuwv5mBoyHVikH LxARLVZOGJMxptDkutEW+YGpBwUZ9uQkyBzt9DPB0gPrVHGI8s8Erw3t8dUELvAn0XUh Oq4E0hQO3QV2ySb7DcdHNg70KPerY3MXICANgIEcxhAmlFItmReGQGK7cpi+jpW1d9wk lrZ4AUS5GqoX3bZqJyujz/PPlVLE6GpS4FZZcEjG5l0KNKojQ3oJrC8F2EcxkqJhl5Db Mle7bcbOzlcAt+6Dcg2spcR9DUu0QHBxLibXEniSJDaVdHCYR/oPlRGCxeT/ikht/SgJ uyhw== X-Gm-Message-State: AOJu0YxsOiAQ+7WphvJEx8FWNW+72KoklLxTII04QzhCxm+DWRCPTAjV 15QGGGh539rsSiqFm1uoOjK8yEwtDD1mlQ== X-Google-Smtp-Source: AGHT+IGdDkLjV6VdB72lxc/Eb9EqT4s1jXti0hSLt6OzTnl/YrrchIvJPC7hVkVHF/vQrGGYFQxPCA== X-Received: by 2002:a0d:ca11:0:b0:5a7:aa7b:cb9f with SMTP id m17-20020a0dca11000000b005a7aa7bcb9fmr6888962ywd.14.1699868799360; Mon, 13 Nov 2023 01:46:39 -0800 (PST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com. [209.85.219.181]) by smtp.gmail.com with ESMTPSA id u81-20020a818454000000b005a23ab90366sm1678532ywf.11.2023.11.13.01.46.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 01:46:39 -0800 (PST) Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d9beb865a40so4282789276.1 for ; Mon, 13 Nov 2023 01:46:39 -0800 (PST) X-Received: by 2002:a25:42d2:0:b0:da0:c8d1:5c5 with SMTP id p201-20020a2542d2000000b00da0c8d105c5mr5227362yba.41.1699868799056; Mon, 13 Nov 2023 01:46:39 -0800 (PST) MIME-Version: 1.0 References: <20231108125843.3806765-18-arnd@kernel.org> <202311090843.b8ISrsV1-lkp@intel.com> <87h6lu8ed8.fsf@mail.lhotse> In-Reply-To: <87h6lu8ed8.fsf@mail.lhotse> From: Geert Uytterhoeven Date: Mon, 13 Nov 2023 10:46:26 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype To: Michael Ellerman Cc: kernel test robot , Arnd Bergmann , Andrew Morton , linux-kernel@vger.kernel.org, Masahiro Yamada , linux-kbuild@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Arnd Bergmann , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Guo Ren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Christophe Leroy , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3D09B160002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9h1zsnc1cuxx7ozhu546iskc86iebbse X-HE-Tag: 1699868800-305429 X-HE-Meta: U2FsdGVkX1+Ey0VToU1NpjLzdDlwFAwNBF4C2omWWVkOXUOw0cKsv4nLOkMboHdZ12I8NGDop0pdZFwGNnfc6NEoDtpig0j4u25QMoeB6JymlTEAKxCV3KxNVm5+JeYQc9gR9yzBIpjEVgNVxdzccwyejcuKI1DVmkXV5M1ugnoZVJFPVipDozW1b+7kepnfFDhLH4ipGSobol1UkuDrq3bfpP0xZ4PIGY++MydlXepv/w/Dn142nRc7FplYQRFWKhiClz9v5xXd77X+gfnhAZdDK7VwQu4jDfV//CLfj8AnB57BtfABhYCKePdMgHz4Bo1H/FsoGsxT3xRfHVk6VeSngZxEiCYBQumUOKk/Pk2VdKbrrxcfUedGHQy5VXOgT8h5ZTqn89nP+PcWmT1BOtJBQIeU/MyX7OzkLtl8xmSbaomaANOYJvFEsy5P1c+N56wJ+TOoe0z1Xxtz24Lxb1IW2LkpHBzs2p7X0VQb88zL4O/2LykFFo0wfwPQRQVVoDVdAZZtrgUtGAkaLnqkZNGGvzgBmbHlqSAJNVgnltCo8qnwHoNc7Iq4Pp986vDaZLlpaHQSHStc3rG95qyljQIQaD+nSAp6i9mhKZVghRpe1LJ29RZHGTkNNmzwNBQvuXtoF2qxqxqLkBWxpDEa8Yanj0CjPoxiPrtQ/oZSX3MOyIxTNvVl47xy9PMyncePP28Mb6T/uB1P5VFKklfTTqOdKvXB2s1OBByFnBwPk7kyyzM86bl5xmC8w1yCiupw9GQamhCo60RdqnZThZgLQkbPg7sFxYPmcdbex25Weel8Hkv8gD/UOypZVGHQHxIfC2O+WYCadk1eSK5Ll4gGfUVonzyd/btxUsiUo15z2He9EwjD9eWRbtb3rLN8HM/0uImzZwi/Eg2y6MMLTp9jZqZloNF95FZtCpuXaDXgw+F2RwfB8wl/6fkdQ1majMax+E/M+7Eb/KRG/VB1FfQ Jo9qQepQ Qlvq/KjRM2olVUAgx4uF1eifsspM5xov9aGYEJ24Hy39/y1sMsWj+aLAZvjjxJ980WHLcKEQMGwBgoy154LWRaQ7YXJ6Tm8Is28r8UuU+SHdacX6GHkNFCpMr5EHGSFwYZHUc+IW0B804Cayx5bJzYyznBWgq/h67EKFSV/I/oUznyD4IBW5e8yJsKi+mpaVE7r0Upuf4x10DgJO54zUSPT6WvvVtNn7J4s+9Qpfw0uzPV/TCtKtR241iNzWdJILJ5cyZ/9Vz2/FYhZnje2dP+XY6ouTMJr38JecqgAncgCkU/Z3xOPF/5si0XyBDez2nzXOA5OQHYVcFBDeMMAaXT5xl/hoka0AsZjPpqADwOsEfvMlqbRB3CYTltqaCI17pJSRv9YGAW8f6RcJVxKliyrXl3t8lzjZaRd5p6tidFGXheewqa+TY2FLNan2xDUwGX3qgdmiH7Dsj/cAAbTkxb6ErYZi7Z4EVnFB2dU3QVHm9X4hPU7DScFgAD0zzd/C2Osh6kKHBFWOYaM28/5puLj0uR4vlzI+1AMRpq+JKg7mSAOEDMnjkwnZvPCNtzLpVL+2VXClOQ+G7YjG2CLlYr7Pr5oynX5LgM1fnwBKJecjZEj83yfFvSi5qApHT5XBci4TqcxE5HrN6Rp+O4KaCdijcS9k0ptJ1quNTITP9XsVfv6xKfdDamkfD1oZMK8jGBAeLGRbWPWqiKrrygSWDiVW1RULCeee24uDu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Michael, On Fri, Nov 10, 2023 at 4:42=E2=80=AFAM Michael Ellerman wrote: > kernel test robot writes: > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on next-20231108] > > [cannot apply to v6.6] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/id= a-make-ida_dump-static/20231109-005742 > > base: linus/master > > patch link: https://lore.kernel.org/r/20231108125843.3806765-18-arnd= %40kernel.org > > patch subject: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic = prototype > > config: powerpc64-randconfig-001-20231109 (https://download.01.org/0day= -ci/archive/20231109/202311090843.b8ISrsV1-lkp@intel.com/config) > > compiler: powerpc64-linux-gcc (GCC) 13.2.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20231109/202311090843.b8ISrsV1-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311090843.b8ISrsV1-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > arch/powerpc/platforms/ps3/gelic_udbg.c:59:1: warning: alignment 1 o= f 'struct debug_block' is less than 32 [-Wpacked-not-aligned] > > 59 | } __packed; > > | ^ > >>> arch/powerpc/platforms/ps3/gelic_udbg.c:240:6: error: redefinition of= 'udbg_shutdown_ps3gelic' > > 240 | void udbg_shutdown_ps3gelic(void) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > In file included from arch/powerpc/platforms/ps3/gelic_udbg.c:17: > > arch/powerpc/include/asm/ps3.h:520:20: note: previous definition of = 'udbg_shutdown_ps3gelic' with type 'void(void)' > > 520 | static inline void udbg_shutdown_ps3gelic(void) {} > > | ^~~~~~~~~~~~~~~~~~~~~~ > > As pointed out by Arnd this is due to there being two symbols that > control the gelic_udbg.c code. > > I don't see the need for PS3GELIC_UDBG, without PPC_EARLY_DEBUG_PS3GELIC > it just causes gelic_udbg.c to be built, but never called. My first thought was: PPC_EARLY_DEBUG_PS3GELIC is meant as an early debugging console, while PS3GELIC_UDBG can be used with xmon later, but that does not seem to be the case. > The diff below fixes the error AFAICS. So your changes on top LGTM. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds