From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344BDE7716B for ; Wed, 4 Dec 2024 13:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C16A6B0093; Wed, 4 Dec 2024 08:15:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 949D16B0095; Wed, 4 Dec 2024 08:15:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79C246B0096; Wed, 4 Dec 2024 08:15:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D1F26B0093 for ; Wed, 4 Dec 2024 08:15:24 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E23411C7BFC for ; Wed, 4 Dec 2024 13:15:23 +0000 (UTC) X-FDA: 82857322254.08.71AA5BE Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf01.hostedemail.com (Postfix) with ESMTP id CE6E24000F for ; Wed, 4 Dec 2024 13:15:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733318115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=juKoUY/+GHPAhNw5w6qO+bk4TMamhAcWlpPERhaqdrs=; b=05WcXbFYucQf7dwp5aAcC9tXiu50CHQPppgEidBkWhskCWeD+iCIh4nqVhycyxJMRTXb3S ma73bWMkAndwTz8+3XL/awDLrIiW5Ao8/GBt+qZN3o2RqOPnUopWSYwnKfB/r6sEC4VjRf 3C8VUVQ764Y6xot8jPz8FZz+RfheSWQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733318115; a=rsa-sha256; cv=none; b=EtvHReFeOyw/kZGSJ/UM//Xy7lJnqUrm8rZG6kZQ7PFjJTjknsn8C4CIOn7uqzGrophZ0p S8T0PwIG1M2PhlAfEhfPafpfWMX6N7HLZv/Up327PLmRmaZ5kS3zR+Ouq0RXooNbsjMl4S JmKKa4djhRTFz5oit8yNrEwpES0VZ4g= Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-4afa53874beso371676137.3 for ; Wed, 04 Dec 2024 05:15:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733318120; x=1733922920; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=juKoUY/+GHPAhNw5w6qO+bk4TMamhAcWlpPERhaqdrs=; b=rNVfdr4RkjTkXLY0PmU1K31iKmwwqrZ+1ep/XkWKBriG9sWLTLbdAsaYbR8ku8NnDG PLE8F+bEV/M1cY+JrA6qkePw0hKn0mao0FWFo3S+OEAawA5U4Zet0QbrawwpKTrfrTzA 1qJyR0BsXB4metDSujUdmFhYe/aZtR7/WLT3IEdC8WwfVh+gs6RnIfuZxKQYE68ggMLB duIZEgEtXCnZzvuHZgJJlkLUXdLei0ZI5zNFQa6cXAuLQZnyN0/UokOEOrLj/3GV1jxZ YFMItHcpA84ZtDkP1lBqK67hlpyxOdgPI/5e5XyJ66W0GnlHRFU9Cb35RkUPofcbuGFO OA9A== X-Forwarded-Encrypted: i=1; AJvYcCUJ/yCe+V1uwrAsVJ035JrHApDCuXXXBKoPzpcV8a9peK9nf4miSpMe3ZbZRz3MTNhN/a7Anq7zbg==@kvack.org X-Gm-Message-State: AOJu0YwfnFvOHh2fv9u2y1UuxTqYNRRh9ji5xgSOtCnSKr3Rba9GCnAg 4wO1CXyQs5xMTAoStEER8d7a8yVF99qW0PSgaY/BKGeF4p1KM+0OQ+RUY7PJ X-Gm-Gg: ASbGncsdCAMrzz3wVL/arKPHMRvLtx00EN+P6F0PThdz40iL+bIuVZTimoYBKahGZu4 F0EGHAT5m/v2G8zhVAZktJ0ohX71YYxvC1w/IodQRxC0LuybBj/JMsTGnFxRHsxWCQZrhEFPYzX 3zPwOd8PgEc3p2skGex5xY9S5ePGawuUPj7UM7zFW5DoRs5je6MnLqFdntYhwrfZaFjj5j2wVDz iJueKjckjdyNT67WJca2NpM2mV06onCigIgldcKR9QpIt6Y5rQgLuUT1skXaLdF1UHNImBXIOXl fQObiO+X/gr0 X-Google-Smtp-Source: AGHT+IFDf6a9danGjpHoqAQBZV5CXvRuBQEaYbbPxr7eokBJi97L+Z6mHn9DVQM0k1r6Z1fJcx6jFQ== X-Received: by 2002:a05:6122:2221:b0:50a:b728:5199 with SMTP id 71dfb90a1353d-515bf526dd7mr8543556e0c.7.1733318120165; Wed, 04 Dec 2024 05:15:20 -0800 (PST) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com. [209.85.217.47]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4afb5835678sm31508137.19.2024.12.04.05.15.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 05:15:19 -0800 (PST) Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-4afb1961a35so191703137.1 for ; Wed, 04 Dec 2024 05:15:19 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV/vDoSeBrKZVM+amZhhE1LmubjCDuLnENFWFusN6lU9znUe9jgU9FXQs6hlbbTwykVpQ4GjRbP0Q==@kvack.org X-Received: by 2002:a05:6102:34a:b0:4af:a967:65c5 with SMTP id ada2fe7eead31-4afa9676822mr3387736137.10.1733318119032; Wed, 04 Dec 2024 05:15:19 -0800 (PST) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> In-Reply-To: <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> From: Geert Uytterhoeven Date: Wed, 4 Dec 2024 14:15:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: Arnd Bergmann Cc: Linus Torvalds , David Laight , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes , Biju Das Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CE6E24000F X-Stat-Signature: pnn7wfrhdhm5r38cs193j7m4bdmc5nqb X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733318110-606790 X-HE-Meta: U2FsdGVkX18Hn7bsHLhDDjXSOGBz0eRbJTUtBunESpgdA8NSKW43+RGelOoIniq2VyqzU1FUzBgl0xyogbiFDkf5nHrS9akSP71meI4g2ICrOpslm1vzYB8Pym3gURcnezVej5nwHcu12/4XPMPnm3Iz1VY+lNePOdV8DZ1tb0570ynpdCl48qhIEIi6kwvVnf01JxdibFM3GnAUtbzAe2326Kp4vPAALf68m3oje3LR/+XvW19cl/XXEtOlj9YbWW8ixNi5yPwsEqKup1R+znqPwpxxpamW+ZenFRTVn2EWw0HEDGnvXYA7+mI0UFx3iLvkbwl2OnvavDNe3jSnC7TEnmF1CZ/qedXNs6P4wtIPD6PsuWbtzooCA/itNPcYdihmr+GgdqLndWZUS1T9gc3GoVnbYT18V44FSiwHh4MOI8lmhcrLl70R3eXSoG5Rq4y3gvGbWHVY3GEzHKmIrHomPywkh31xanbpwzAKe1Pt/jnPduzXrf7v4/VVKWyw/aGMzwnocpyydx3r2XYW9Sd5Bu2Y5uBlhgA83CZNxdiMnUBE2OMPvhYPNNiNuKd5bm1R+VlweFmd+tIU7FVI25jHQQV20RzM+TEpe0FsMvUirsaz7DsFDNeTZZ4ZcZuCgS+KLIEUFB+pp8YL5e3VqVRe/7HjF52/b3VxLxE1Rux6AGOQ6oiMIvs9m+V3P3Ogm02ySvWQSMosMMkxrR/PVblvV39Om0AsZRl+jXeCM54lgOIewv35O22P64IW/U6a7n6bGjRHfVZS3+5Tj7zM2MUpVW9DIsWuHuyqr7Nq/M46PIQP71dx7PLosZPsLVhK03lTrxMA4gJuTJEmbMbN/RlPja5DvqExYn1rgaB6hxnxCCBYQ0sFnxL7J+6FiJcAGlVwfBjAz9y+xvG+cc/nXkBNc/Uvsyj+1yLV3OnGAbRJVqv9ql5bweCdieMAlEpV/kEPCp2OJiuY8ffabqr UMjiSqTg SbUlI0LZOEjoFr9QpEDDrxfPK3/OO3w7tI73E39E6zfyz0gU6t3VVrTqiBCTA5YCQGUCRMqYlunsRu6ZhCUGyzXGWbrS/MpU6D/Xlu9GqvU4jJAOUKirc09e4J55O5cq6Y6GaMMY3WfLtWTZp5AqJlG11SfVY0DuM/y76I1/kvLFAIAuKvOxLHzNIHKNVxAmGXaI/9WFTK1+tmcGbxTfXA+EaxqxidYFW+sx5laQPgb9F9F9rRUbeawkFw8fvHtN46/xBO+SavZ+fy7LcGbABp1LD4TBkW9k99uExT/3Oy2Z1EnlKzTvRY+ja+ckHCn1l/vDK7R6OfyYrUHsgQnk9TPN8BZE4qdp2mzhUdOtiZDoOb0F+OUgCIK/RWaQS5fqt0vbz30Agr3QyuhKD2FSR0PRNWPlI1SUKDE4+MvjYjP2YK5pcCHQFLJtk6egoei6CRGFZUr6A82WgyvYLAy7EI1v2+/C7HbXD4x97QxDMtpFg2jQsgBWb58x6ABOLT0H5XqonSkrUjqTgmPRya4YyNwhCvFn7g6jI2AJViKi/4voNlm10PE3k9cO7c1b/0Y5VbnRn6Sh1gsw82uEX4LQYzCcW/zhoZ5sR+NkFnR84sIwnjMeK7IutH4xCiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Arnd et al, People started seeing this in today's linux-next... On Tue, Jul 30, 2024 at 4:15=E2=80=AFPM Arnd Bergmann wro= te: > On Tue, Jul 30, 2024, at 12:10, Arnd Bergmann wrote: > > On Tue, Jul 30, 2024, at 05:59, Linus Torvalds wrote: > >> On Mon, 29 Jul 2024 at 16:21, Linus Torvalds wrote: > > > > I'm giving this a spin on the randconfig test setup now to see > > if there are some other cases like the bcachefs one. So far I've > > seen one failure, but I can't make sense of it yet: > > > > drivers/gpu/drm/i915/display/intel_backlight.c: In function 'scale': > > include/linux/compiler_types.h:510:45: error: call to > > '__compiletime_assert_905' declared with attribute error: clamp() low > > limit source_min greater than high limit source_max > > include/linux/minmax.h:107:9: note: in expansion of macro > > 'BUILD_BUG_ON_MSG' > > 107 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), > > \ > > drivers/gpu/drm/i915/display/intel_backlight.c:47:22: note: in > > expansion of macro 'clamp' > > 47 | source_val =3D clamp(source_val, source_min, source_max= ); > > > > See https://pastebin.com/raw/yLJ5ZqVw for the x86-64 .config > > that triggered this. > > The above seems to happen only with gcc-13 and gcc-14, but not gcc-12 > and earlier, and it's the only one I've seen with a bit of randconfig > testing on that version. > > There is another one that I see with gcc-8 randconfigs (arm64): > > net/netfilter/ipvs/ip_vs_conn.c: In function 'ip_vs_conn_init': > include/linux/compiler_types.h:510:38: error: call to '__compiletime_asse= rt_1040' declared with attribute error: clamp() low limit min greater than = high limit max_avail > 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COU= NTER__) > | ^ > include/linux/minmax.h:182:28: note: in expansion of macro '__careful_cla= mp' > 182 | #define clamp(val, lo, hi) __careful_clamp(val, lo, hi) > | ^~~~~~~~~~~~~~~ > net/netfilter/ipvs/ip_vs_conn.c:1498:8: note: in expansion of macro 'clam= p' > 1498 | max =3D clamp(max, min, max_avail); > > I can reproduce this one with gcc-8/9/10, but not gcc-11 > or higher. > > This may be another case of __builtin_constant_p() being > slightly unreliable when a local variable is constant-folded > based on a condition, or with partial inlining. Or perhaps the argument order is wrong, and it should be max =3D clamp(max_avail, min, max); instead? Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds